24677 2009-03-18 13:17:37 -0700 REGRESSION: Range#surroundContents is inserting empty text nodes into the document 2009-03-20 01:19:00 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED DUPLICATE 24122 http://www.nick-santos.com/tests/webkit_range_test.html Regression P1 Normal --- 1 nicksantos ap ap darin eric jparent oldest_to_newest 114218 0 nicksantos 2009-03-18 13:17:37 -0700 Repro steps: 1) Create a range over the text "---[ANCHOR]Text to <br/> split[FOCUS]---" 2) Call range.surroundContents(someElement) Results: A 0-length text node is inserted after [FOCUS] This is happening in 528 and 530 on Windows. You can visit http://www.nick-santos.com/tests/webkit_range_test.html for a simple test case. I don't make very good cookies, but Julie says that she will award a cookie to the person that fixes this. 114219 1 jparent 2009-03-18 13:20:11 -0700 This is definitely a regression, the test passes fine in Chrome 1.0/WebKit 525. 114349 2 ap 2009-03-19 12:35:06 -0700 Confirmed as a regression. 114363 3 28760 ap 2009-03-19 13:13:32 -0700 Created attachment 28760 further reduced test case This version works in Firefox, too. The problem is actually in Range.insertNode, which surroundContents uses internally. 114365 4 ap 2009-03-19 13:23:57 -0700 Err, not quite - it's the range start that's different after extractContents(). It used to be ([object HTMLDivElement], 1), but now it's ([object Text], 3), so insertNode is arguably correct to split the node. 114401 5 ap 2009-03-19 16:24:39 -0700 I've got a patch that fixes this and bug 24122, which was filed earlier. 114455 6 ap 2009-03-20 01:18:41 -0700 Oops, I meant to resolve as duplicate. 114456 7 ap 2009-03-20 01:19:00 -0700 *** This bug has been marked as a duplicate of 24122 *** 28760 2009-03-19 13:13:32 -0700 2009-03-19 13:13:32 -0700 further reduced test case webkit_range_test.html text/html 737 ap PGh0bWw+CiAgPGhlYWQ+CiAgICA8c2NyaXB0PgoKICAgICAgZnVuY3Rpb24gZG9JdCgpIHsKICAg ICAgICB2YXIgeCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd4Jyk7CiAgICAgICAgdmFyIHJh bmdlID0gZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKTsKICAgICAgICByYW5nZS5zZXRTdGFydCh4LmZp cnN0Q2hpbGQsIDMpOwogICAgICAgIHJhbmdlLnNldEVuZCh4Lmxhc3RDaGlsZCwgMTgpOwovLyAg ICAgICAgcmFuZ2Uuc3Vycm91bmRDb250ZW50cyhkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdiJykp OwogICAgICAgIHJhbmdlLmV4dHJhY3RDb250ZW50cygpOwogICAgICAgIHJhbmdlLmluc2VydE5v ZGUoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYiIpKQogICAgICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdhY3R1YWwnKS5pbm5lckhUTUwgPSAneCBoYXMgJyArIHguY2hpbGROb2Rlcy5sZW5n dGggKyAnIGNoaWxkcmVuJzsKICAgICAgfQogICAgPC9zY3JpcHQ+CiAgPC9oZWFkPgogIDxib2R5 IG9ubG9hZD0iZG9JdCgpIj4KICAgIDxkaXYgaWQ9J3gnPi0tLVRleHQgdGhhdCA8YnIvPndpbGwg YmUgc3Vycm91bmRlZC0tLTwvZGl2PgogICAgPGRpdj5FeHBlY3RlZCBvdXRwdXQ6PC9kaXY+PGRp diBpZD0nZXhwZWN0ZWQnPnggaGFzIDMgY2hpbGRyZW48L2Rpdj4KICAgIDxkaXY+QWN0dWFsIG91 dHB1dDo8L2Rpdj48ZGl2IGlkPSdhY3R1YWwnPjwvZGl2PgogIDwvYm9keT4KPC9odG1sPgo=