<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24675</bug_id>
          
          <creation_ts>2009-03-18 10:24:14 -0700</creation_ts>
          <short_desc>Upstream V8InspectorControllerCustom.cpp</short_desc>
          <delta_ts>2009-03-19 09:31:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Pavel Feldman">pfeldman</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dglazkov</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>114198</commentid>
    <comment_count>0</comment_count>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2009-03-18 10:24:14 -0700</bug_when>
    <thetext>Upstream V8InspectorControllerCustom.cpp that contains custom InspectorController.idl methods implementations for v8.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>114199</commentid>
    <comment_count>1</comment_count>
      <attachid>28724</attachid>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2009-03-18 10:25:38 -0700</bug_when>
    <thetext>Created attachment 28724
V8InspectorControllerCustom.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>114209</commentid>
    <comment_count>2</comment_count>
      <attachid>28724</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-03-18 11:28:57 -0700</bug_when>
    <thetext>Comment on attachment 28724
V8InspectorControllerCustom.cpp

This is just the beginning, not the final impl, so ok.

BTW, always include URL to the bug in ChangeLog. No need to change this patch (I&apos;ll fix and land), but FYI for the future.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>114322</commentid>
    <comment_count>3</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-03-19 09:31:23 -0700</bug_when>
    <thetext>Landed as http://trac.webkit.org/changeset/41836.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28724</attachid>
            <date>2009-03-18 10:25:38 -0700</date>
            <delta_ts>2009-03-18 11:28:57 -0700</delta_ts>
            <desc>V8InspectorControllerCustom.cpp</desc>
            <filename>InspectorControllerCustomPatch.txt</filename>
            <type>text/plain</type>
            <size>3550</size>
            <attacher name="Pavel Feldman">pfeldman</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0MTgwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMDktMDMtMTggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJv
bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgorCisgICAg
ICAgIFVuZm9ya2luZyBmcm9udGVuZDogYWRkIGN1c3RvbSBJbnNwZWN0b3JDb250cm9sbGVyIG1l
dGhvZHMgCisgICAgICAgIGltcGxlbWVudGF0aW9uLgorICAgICAgICAKKyAgICAgICAgTm8gY2hh
bmdlIGluIGJlaGF2aW9yLCBzbyBubyB0ZXN0LgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3Vz
dG9tL1Y4SW5zcGVjdG9yQ29udHJvbGxlckN1c3RvbS5jcHA6IEFkZGVkLgorICAgICAgICAoV2Vi
Q29yZTo6Q0FMTEJBQ0tfRlVOQ19ERUNMKToKKwogMjAwOS0wMy0xOCAgRGlyayBTY2h1bHplICA8
a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEhvbGdlciBGcmV5dGhlci4K
SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5zcGVjdG9yQ29udHJvbGxlckN1
c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJbnNw
ZWN0b3JDb250cm9sbGVyQ3VzdG9tLmNwcAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvYmluZGlu
Z3MvdjgvY3VzdG9tL1Y4SW5zcGVjdG9yQ29udHJvbGxlckN1c3RvbS5jcHAJKHJldmlzaW9uIDAp
CkBAIC0wLDAgKzEsNzUgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMDctMjAwOSBHb29nbGUg
SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug
aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0
aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z
IGFyZQorICogbWV0OgorICoKKyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29k
ZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiBub3RpY2UsIHRoaXMgbGlzdCBv
ZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAgICAgKiBSZWRp
c3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCisgKiBj
b3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2lu
ZyBkaXNjbGFpbWVyCisgKiBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJp
YWxzIHByb3ZpZGVkIHdpdGggdGhlCisgKiBkaXN0cmlidXRpb24uCisgKiAgICAgKiBOZWl0aGVy
IHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCisgKiBjb250cmli
dXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQg
ZnJvbQorICogdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVy
bWlzc2lvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklH
SFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisgKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBP
UiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywg
VEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9S
CisgKiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hB
TEwgVEhFIENPUFlSSUdIVAorICogT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1Ig
QU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisgKiBTUEVDSUFMLCBFWEVNUExBUlks
IE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVE
IFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9G
IFVTRSwKKyAqIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9X
RVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorICogVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJ
TiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdM
SUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisg
KiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9G
IFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJJbnNw
ZWN0b3JDb250cm9sbGVyLmgiCisKKyNpbmNsdWRlICJFeGNlcHRpb25Db2RlLmgiCisKKyNpbmNs
dWRlICJWOEJpbmRpbmcuaCIKKyNpbmNsdWRlICJWOEN1c3RvbUJpbmRpbmcuaCIKKyNpbmNsdWRl
ICJWOFByb3h5LmgiCisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworQ0FMTEJBQ0tfRlVOQ19ERUNM
KEluc3BlY3RvckNvbnRyb2xsZXJEZWJ1Z2dlckVuYWJsZWQpCit7CisgICAgSU5DX1NUQVRTKCJJ
bnNwZWN0b3JDb250cm9sbGVyLmRlYnVnZ2VyRW5hYmxlZCgpIik7CisgICAgcmV0dXJuIHY4OjpG
YWxzZSgpOworfQorCitDQUxMQkFDS19GVU5DX0RFQ0woSW5zcGVjdG9yQ29udHJvbGxlclBhdXNl
T25FeGNlcHRpb25zKQoreworICAgIElOQ19TVEFUUygiSW5zcGVjdG9yQ29udHJvbGxlci5wYXVz
ZU9uRXhjZXB0aW9ucygpIik7CisgICAgcmV0dXJuIHY4OjpGYWxzZSgpOworfQorCitDQUxMQkFD
S19GVU5DX0RFQ0woSW5zcGVjdG9yQ29udHJvbGxlclByb2ZpbGVyRW5hYmxlZCkKK3sKKyAgICBJ
TkNfU1RBVFMoIkluc3BlY3RvckNvbnRyb2xsZXIucHJvZmlsZXJFbmFibGVkKCkiKTsKKyAgICBy
ZXR1cm4gdjg6OkZhbHNlKCk7Cit9CisKKyNpZiBFTkFCTEUoREFUQUJBU0UpCitDQUxMQkFDS19G
VU5DX0RFQ0woSW5zcGVjdG9yQ29udHJvbGxlckRhdGFiYXNlVGFibGVOYW1lcykKK3sKKyAgICBJ
TkNfU1RBVFMoIkluc3BlY3RvckNvbnRyb2xsZXIuZGF0YWJhc2VUYWJsZU5hbWVzKCkiKTsKKyAg
ICB2ODo6TG9jYWw8djg6OkFycmF5PiByZXN1bHQgPSB2ODo6QXJyYXk6Ok5ldygwKTsKKyAgICBy
ZXR1cm4gcmVzdWx0OworfQorI2VuZGlmCisKK0NBTExCQUNLX0ZVTkNfREVDTChJbnNwZWN0b3JD
b250cm9sbGVyV3JhcENhbGxiYWNrKQoreworICAgIElOQ19TVEFUUygiSW5zcGVjdG9yQ29udHJv
bGxlci53cmFwQ2FsbGJhY2soKSIpOworICAgIHJldHVybiBhcmdzWzBdOworfQorCit9IC8vIG5h
bWVzcGFjZSBXZWJDb3JlCg==
</data>
<flag name="review"
          id="14157"
          type_id="1"
          status="+"
          setter="dglazkov"
    />
          </attachment>
      

    </bug>

</bugzilla>