<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>246708</bug_id>
          
          <creation_ts>2022-10-18 13:34:04 -0700</creation_ts>
          <short_desc>[JSC][armv7] Disassembler should use register numbers instead of (inappropriate) names</short_desc>
          <delta_ts>2022-10-28 13:21:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Griego">joseph.j.griego</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1906575</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Griego">joseph.j.griego</who>
    <bug_when>2022-10-18 13:34:04 -0700</bug_when>
    <thetext>As title. The current disassembler uses e.g. &quot;fp&quot; for r11 and &quot;ip&quot; for r12 (this is the &quot;InterProcedural link&quot; register for calls across dsos); neither of which has the corresponding meaning inside of the JIT; (or in Thumb code generally, which uses r7 as the frame pointer)

This is a minor annoyance, but it would be nice to just use the register numbers instead.

Patch forthcoming</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1906576</commentid>
    <comment_count>1</comment_count>
    <who name="Joseph Griego">joseph.j.griego</who>
    <bug_when>2022-10-18 13:36:46 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/5510</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1908213</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-10-25 13:35:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/101559166&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1909066</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-10-28 13:21:56 -0700</bug_when>
    <thetext>Committed 256113@main (51613ad86d58): &lt;https://commits.webkit.org/256113@main&gt;

Reviewed commits have been landed. Closing PR #5510 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>