246692 2022-10-18 09:18:17 -0700 REGRESSION: [bugs.webkit.org] Linkified commit identifiers don't go to specific commit 2022-10-19 08:13:20 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad lingho lingho webkit-bug-importer oldest_to_newest 1906483 0 ryanhaddad 2022-10-18 09:18:17 -0700 Linkified commit identifiers in bugzilla (e.g. 255564@main) don't direct you to a page like https://commits.webkit.org/255564@main, but rather https://github.com/WebKit/WebKit/commits Unsure if this was caused by https://commits.webkit.org/255564@main, it definitely started recently. 1906509 1 webkit-bug-importer 2022-10-18 10:16:03 -0700 <rdar://problem/101297471> 1906511 2 lingho 2022-10-18 10:18:37 -0700 Displayed text link uses matched group 1 while generate link uses matched group 2 due to another regex handing trac.webkit.org link. sub _replace_reference { my $args = shift; my $text = $args->{matches}->[0]; my $reference = $args->{matches}->[1]; return qq{<a href="https://commits.webkit.org/$reference">$text</a>}; }; My last patch left out a parentesis pair causing group 2 to be NULL. 1906515 3 lingho 2022-10-18 10:21:55 -0700 Pull request: https://github.com/WebKit/WebKit/pull/5349 1906521 4 lingho 2022-10-18 10:30:13 -0700 Pull request: https://github.com/WebKit/WebKit/pull/5500 1906767 5 ews-feeder 2022-10-19 08:13:17 -0700 Committed 255732@main (3f0b2fe64691): <https://commits.webkit.org/255732@main> Reviewed commits have been landed. Closing PR #5500 and removing active labels.