24662 2009-03-17 18:33:33 -0700 Chromium build fixes. 2009-03-17 23:02:02 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin dglazkov oldest_to_newest 114154 0 levin 2009-03-17 18:33:33 -0700 These are various fixes that had to happen to make Chromium buildable. 114156 1 28714 levin 2009-03-17 18:39:20 -0700 Created attachment 28714 Proposed fix. 114157 2 levin 2009-03-17 18:40:45 -0700 fyi I noticed a missing space in this line: SkRect topBorder = { rect.fLeft, rect.fTop, rect.width(), 1}; and added it locally. 114162 3 28714 dglazkov 2009-03-17 20:28:33 -0700 Comment on attachment 28714 Proposed fix. r=me. Perhaps modify ChangeLog to have consistent reference to bug url. I like to use this format: URL Description 114166 4 levin 2009-03-17 23:02:02 -0700 Committed as r41805. 28714 2009-03-17 18:39:20 -0700 2009-03-17 20:28:33 -0700 Proposed fix. bug24462.txt text/plain 2834 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjdmMjA2My4uN2M2OTcyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0wMy0xNyAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NDY2Mj4KKyAgICAgICAgQ2hyb21pdW0gYnVpbGQgZml4ZXMuCisgICAgICAgIAorICAgICAgICBC dWcgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NjYzIHRyYWNrcwor ICAgICAgICB0aGUgaW52YWxpZCBpbXBsZW1lbnRhdGlvbiBvZiBTY3JpcHRDYWxsU3RhY2suCisK KyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLCBzbyBubyB0ZXN0LgorCisgICAgICAgICog YmluZGluZ3MvdjgvU2NyaXB0Q2FsbFN0YWNrLmg6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRD YWxsU3RhY2s6OnN0YXRlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRm b3JtQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoUGxhdGZvcm1Db250ZXh0U2tpYTo6ZHJhd1Jl Y3QpOgorCiAyMDA5LTAzLTE3ICBEYXZpZCBDYXJzb24gIDxkYWNhcnNvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgSHlhdHQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NjcmlwdENhbGxTdGFjay5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRD YWxsU3RhY2suaAppbmRleCAxMTNmZjk5Li4zMTIzZThiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NjcmlwdENhbGxTdGFjay5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvU2Ny aXB0Q2FsbFN0YWNrLmgKQEAgLTUwLDYgKzUwLDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAg ICAgICAvLyBGSVhNRTogaW1wbGVtZW50IHJldHJpZXZpbmcgYW5kIHN0b3JpbmcgY2FsbCBzdGFj ayB0cmFjZQogICAgICAgICB1bnNpZ25lZCBzaXplKCkgY29uc3QgeyByZXR1cm4gMTsgfQogCisg ICAgICAgIC8vIEZJWE1FOiBUaGlzIG1ldGhvZCBpcyBvYnZpb3VzbHkgbm90IGltcGxlbWVudGVk LgorICAgICAgICBTY3JpcHRTdGF0ZSogc3RhdGUoKSBjb25zdCB7IHJldHVybiAwOyB9CisKICAg ICBwcml2YXRlOgogICAgICAgICBTY3JpcHRDYWxsRnJhbWUgbV9sYXN0Q2FsbGVyOwogICAgIH07 CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250 ZXh0U2tpYS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250 ZXh0U2tpYS5jcHAKaW5kZXggYjA0Zjc4Ny4uMTFlNmNkMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcApAQCAtMjc3 LDEwICsyNzcsMTQgQEAgdm9pZCBQbGF0Zm9ybUNvbnRleHRTa2lhOjpkcmF3UmVjdChTa1JlY3Qg cmVjdCkKICAgICAgICAgaWYgKG9sZEZpbGxDb2xvciAhPSBtX3N0YXRlLT5tX3N0cm9rZUNvbG9y KQogICAgICAgICAgICAgc2V0RmlsbENvbG9yKG1fc3RhdGUtPm1fc3Ryb2tlQ29sb3IpOwogICAg ICAgICBzZXR1cFBhaW50Rm9yRmlsbGluZygmcGFpbnQpOwotICAgICAgICBjYW52YXMoKS0+ZHJh d1JlY3QoV2ViQ29yZTo6RmxvYXRSZWN0KHJlY3QuZkxlZnQsIHJlY3QuZlRvcCwgcmVjdC53aWR0 aCgpLCAxKSwgcGFpbnQpOwotICAgICAgICBjYW52YXMoKS0+ZHJhd1JlY3QoV2ViQ29yZTo6Rmxv YXRSZWN0KHJlY3QuZkxlZnQsIHJlY3QuZkJvdHRvbSAtIDEsIHJlY3Qud2lkdGgoKSwgMSksIHBh aW50KTsKLSAgICAgICAgY2FudmFzKCktPmRyYXdSZWN0KFdlYkNvcmU6OkZsb2F0UmVjdChyZWN0 LmZMZWZ0LCByZWN0LmZUb3AgKyAxLCAxLCByZWN0LmhlaWdodCgpIC0gMiksIHBhaW50KTsKLSAg ICAgICAgY2FudmFzKCktPmRyYXdSZWN0KFdlYkNvcmU6OkZsb2F0UmVjdChyZWN0LmZSaWdodCAt IDEsIHJlY3QuZlRvcCArIDEsIDEsIHJlY3QuaGVpZ2h0KCkgLSAyKSwgcGFpbnQpOworICAgICAg ICBTa1JlY3QgdG9wQm9yZGVyID0geyByZWN0LmZMZWZ0LCByZWN0LmZUb3AsIHJlY3Qud2lkdGgo KSwgMX07CisgICAgICAgIGNhbnZhcygpLT5kcmF3UmVjdCh0b3BCb3JkZXIsIHBhaW50KTsKKyAg ICAgICAgU2tSZWN0IGJvdHRvbUJvcmRlciA9IHsgcmVjdC5mTGVmdCwgcmVjdC5mQm90dG9tIC0g MSwgcmVjdC53aWR0aCgpLCAxIH07CisgICAgICAgIGNhbnZhcygpLT5kcmF3UmVjdChib3R0b21C b3JkZXIsIHBhaW50KTsKKyAgICAgICAgU2tSZWN0IGxlZnRCb3JkZXIgPSB7IHJlY3QuZkxlZnQs IHJlY3QuZlRvcCArIDEsIDEsIHJlY3QuaGVpZ2h0KCkgLSAyIH07CisgICAgICAgIGNhbnZhcygp LT5kcmF3UmVjdChsZWZ0Qm9yZGVyLCBwYWludCk7CisgICAgICAgIFNrUmVjdCByaWdodEJvcmRl ciA9IHsgcmVjdC5mUmlnaHQgLSAxLCByZWN0LmZUb3AgKyAxLCAxLCByZWN0LmhlaWdodCgpIC0g MiB9OworICAgICAgICBjYW52YXMoKS0+ZHJhd1JlY3QocmlnaHRCb3JkZXIsIHBhaW50KTsKICAg ICAgICAgaWYgKG9sZEZpbGxDb2xvciAhPSBtX3N0YXRlLT5tX3N0cm9rZUNvbG9yKQogICAgICAg ICAgICAgc2V0RmlsbENvbG9yKG9sZEZpbGxDb2xvcik7CiAgICAgfQo=