24657 2009-03-17 16:13:30 -0700 Chromium fails SVG image-small-width-height layout test 2009-03-23 11:54:46 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 glen glen brettw oldest_to_newest 114123 0 glen 2009-03-17 16:13:30 -0700 Skia fails to render the SVG image-small-width-height layout test correctly because we perform an unnecessary IntRect conversion when calling paintSkBitmap in ImageSkia.cpp. 114124 1 28707 glen 2009-03-17 16:16:31 -0700 Created attachment 28707 ImageSkia.cpp change Updates ImageSkia.cpp to stop the unnecessary conversion to IntRect in our calls to paintSkBitmap. 114805 2 fishd 2009-03-23 11:35:15 -0700 Looks good to me, but I'm not expert on this code. It would be good to get a "LGTM" from Brett. 114811 3 28707 fishd 2009-03-23 11:44:49 -0700 Comment on attachment 28707 ImageSkia.cpp change Brett gave verbal LGTM. r=me Next time, please be sure to include a link to this bug in the ChangeLog entry. Thanks! 114816 4 fishd 2009-03-23 11:54:46 -0700 Landed as: http://trac.webkit.org/changeset/41913 28707 2009-03-17 16:16:31 -0700 2009-03-23 11:44:49 -0700 ImageSkia.cpp change ImageSkia.patch text/plain 1504 glen SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gNDE3 OTApCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0w My0xNyAgR2xlbiBNdXJwaHkgIDxnbGVuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggU2tpYSBkcmF3aW5nIG9mIGhpZ2hs eSBzY2FsZWQgYml0bWFwczsgdGhlIGNvbnZlcnNpb24gdG8KKyAgICAgICAgSW50UmVjdCBwcm9k dWNlZCB2aXNpYmxlIGxheW91dCB0ZXN0IGZhaWx1cmVzIGluIGhpZ2hseSBzY2FsZWQgCisgICAg ICAgIGNvb3JkaW5hdGUgc3lzdGVtcy4KKworICAgICAgICAqIFdlYkNvcmVccGxhdGZvcm1cZ3Jh cGhpY3Ncc2tpYVxJbWFnZVNraWEuY3BwOgorICAgICAgICAKIDIwMDktMDMtMTcgIEd1c3Rhdm8g Tm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFy ayBSb3dlLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5j cHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0NCi0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VT a2lhLmNwcAkocmV2aXNpb24gNDE3MzgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Nr aWEvSW1hZ2VTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDI3LDcgKzQyNyw3IEBAIHZvaWQg Qml0bWFwSW1hZ2U6OmRyYXcoR3JhcGhpY3NDb250ZXh0KiAKICAgICBwYWludFNrQml0bWFwKGN0 eHQtPnBsYXRmb3JtQ29udGV4dCgpLAogICAgICAgICAgICAgICAgICAgKmJtLAogICAgICAgICAg ICAgICAgICAgZW5jbG9zaW5nSW50UmVjdChub3JtU3JjUmVjdCksCi0gICAgICAgICAgICAgICAg ICBlbmNsb3NpbmdJbnRSZWN0KG5vcm1Ec3RSZWN0KSwKKyAgICAgICAgICAgICAgICAgIG5vcm1E c3RSZWN0LAogICAgICAgICAgICAgICAgICAgV2ViQ29yZUNvbXBvc2l0ZVRvU2tpYUNvbXBvc2l0 ZShjb21wb3NpdGVPcCkpOwogfQogCkBAIC00NDcsNyArNDQ3LDcgQEAgdm9pZCBCaXRtYXBJbWFn ZVNpbmdsZUZyYW1lU2tpYTo6ZHJhdyhHcgogICAgIHBhaW50U2tCaXRtYXAoY3R4dC0+cGxhdGZv cm1Db250ZXh0KCksCiAgICAgICAgICAgICAgICAgICBtX25hdGl2ZUltYWdlLAogICAgICAgICAg ICAgICAgICAgZW5jbG9zaW5nSW50UmVjdChub3JtU3JjUmVjdCksCi0gICAgICAgICAgICAgICAg ICBlbmNsb3NpbmdJbnRSZWN0KG5vcm1Ec3RSZWN0KSwKKyAgICAgICAgICAgICAgICAgIG5vcm1E c3RSZWN0LAogICAgICAgICAgICAgICAgICAgV2ViQ29yZUNvbXBvc2l0ZVRvU2tpYUNvbXBvc2l0 ZShjb21wb3NpdGVPcCkpOwogfQogCg==