246487 2022-10-13 16:33:06 -0700 Refactor RegisterSet to support 128-bit widths 2022-12-12 10:39:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=246588 InRadar P2 Normal --- 1 justin_michaud mcatanzaro mcatanzaro webkit-bug-importer oldest_to_newest 1905469 0 justin_michaud 2022-10-13 16:33:06 -0700 Refactor RegisterSet to support 128-bit widths 1905471 1 webkit-bug-importer 2022-10-13 16:33:24 -0700 <rdar://problem/101148986> 1905478 2 justin_michaud 2022-10-13 16:43:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/5354 1905871 3 ews-feeder 2022-10-15 10:14:07 -0700 Committed 255583@main (a57d810b085e): <https://commits.webkit.org/255583@main> Reviewed commits have been landed. Closing PR #5354 and removing active labels. 1906012 4 ap 2022-10-16 18:36:56 -0700 This was reverted in bug 246588 / 255596@main because of build breakage. 1906776 5 ews-feeder 2022-10-19 08:54:17 -0700 Committed 255736@main (912bf24408b1): <https://commits.webkit.org/255736@main> Reviewed commits have been landed. Closing PR #5522 and removing active labels. 1906852 6 mcatanzaro 2022-10-19 12:20:41 -0700 This introduced a minor GCC warning spam, one warning for each unified source bundle that includes the header: [783/2475] Building CXX object Source/JavaScriptCore/CMak...vedSources/unified-sources/UnifiedSource-15db4ad9-4.cpp.o In file included from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmFormat.h:39, from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmCallee.h:33, from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmCalleeGroup.h:31, from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmModule.h:30, from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmModule.cpp:27, from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-4.cpp:2: /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/WasmOps.h: In member function ‘JSC::Width JSC::Wasm::Type::width() const’: /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/WasmOps.h:122:5: warning: control reaches end of non-void function [-Wreturn-type] 122 | } I will submit a follow-up. 1906863 7 justin_michaud 2022-10-19 12:58:30 -0700 Oops, sorry! 1906879 8 mcatanzaro 2022-10-19 13:52:45 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/5555 1906919 9 ews-feeder 2022-10-19 16:00:14 -0700 Committed 255764@main (7bb3ebc2f29b): <https://commits.webkit.org/255764@main> Reviewed commits have been landed. Closing PR #5555 and removing active labels. 1918530 10 ews-feeder 2022-12-12 10:39:44 -0800 Committed 257737@main (2d2f8ac6371b): <https://commits.webkit.org/257737@main> Reviewed commits have been landed. Closing PR #7487 and removing active labels.