<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>246478</bug_id>
          
          <creation_ts>2022-10-13 15:50:46 -0700</creation_ts>
          <short_desc>Commit URLs causing 500 Internal Server Error</short_desc>
          <delta_ts>2022-10-14 17:05:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Website</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="lingho@apple.com">lingho</reporter>
          <assigned_to name="lingho@apple.com">lingho</assigned_to>
          <cc>jond</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1905449</commentid>
    <comment_count>0</comment_count>
    <who name="lingho@apple.com">lingho</who>
    <bug_when>2022-10-13 15:50:46 -0700</bug_when>
    <thetext>When a commit range URL in the form of &quot;https://commits.webkit.org/compare/123456@main&lt;ellipsis&gt;234567@main&quot; is entered into a comment, saving the comment, or subsequence comments causes bug page to return 500 Internal Server Error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1905450</commentid>
    <comment_count>1</comment_count>
    <who name="lingho@apple.com">lingho</who>
    <bug_when>2022-10-13 15:51:16 -0700</bug_when>
    <thetext>rdar://98541419</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1905454</commentid>
    <comment_count>2</comment_count>
    <who name="lingho@apple.com">lingho</who>
    <bug_when>2022-10-13 16:02:54 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/5349</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1905456</commentid>
    <comment_count>3</comment_count>
    <who name="lingho@apple.com">lingho</who>
    <bug_when>2022-10-13 16:06:54 -0700</bug_when>
    <thetext>The old regex was matching the 2nd commit ID, causing that part to be replaced with a URL, which in turn causing the 500 error.

The new regex should not match /123456@main and …123456@main and thus leave them alone.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1905497</commentid>
    <comment_count>4</comment_count>
    <who name="lingho@apple.com">lingho</who>
    <bug_when>2022-10-13 17:56:08 -0700</bug_when>
    <thetext>Updated title to cover another issue reported by Fujihori https://webkit.slack.com/archives/CU64U6FDW/p1664478835893709

where url such as this
https://commits.webkit.org/ + 252432.352@safari-7614-branch is causing issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1905782</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-10-14 17:05:45 -0700</bug_when>
    <thetext>Committed 255564@main (f59283656141): &lt;https://commits.webkit.org/255564@main&gt;

Reviewed commits have been landed. Closing PR #5349 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>