24645 2009-03-17 09:04:59 -0700 bisect-builds script doesn't work with Safari 4 Public Beta (version string) 2009-03-17 13:16:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer aroben mitz mrowe oldest_to_newest 114031 0 ddkilzer 2009-03-17 09:04:59 -0700 * SUMMARY The bisect-build script doesn't work with the Safari 4 Public Beta installed because the version string isn't parseable by Perl. * NOTES I have a quick fix, but it's suboptimal. 114070 1 28693 ddkilzer 2009-03-17 11:19:38 -0700 Created attachment 28693 Patch v1 This fixes bisect-builds with Safari 4 Public Beta. The long-term fix is to switch from using "CFBundleShortVersionString" to using "CFBundleVersion" in findSafariVersion(). 114084 2 ddkilzer 2009-03-17 13:14:41 -0700 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bisect-builds Committed r41785 http://trac.webkit.org/changeset/41785 114086 3 ddkilzer 2009-03-17 13:16:18 -0700 (In reply to comment #1) > The long-term fix is to switch from using "CFBundleShortVersionString" to using > "CFBundleVersion" in findSafariVersion(). See Bug 24652. 28693 2009-03-17 11:19:38 -0700 2009-03-17 11:21:12 -0700 Patch v1 bug-24645-fix-bisect-builds-for-Safari-4-Public-Beta.txt text/plain 2305 ddkilzer Y29tbWl0IDM4YmNiZDE1MGMxODZhZDAxY2FlNjRjZmY1NzZkYjBhMDRiYzg3MGUKQXV0aG9yOiBE YXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgTWFyIDE3IDExOjE3 OjEyIDIwMDkgLTA3MDAKCiAgICAgICAgICAgIEJ1ZyAyNDY0NTogYmlzZWN0LWJ1aWxkcyBzY3Jp cHQgZG9lc24ndCB3b3JrIHdpdGggU2FmYXJpIDQgUHVibGljIEJldGEgKHZlcnNpb24gc3RyaW5n KQogICAgCiAgICAgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQ2NDU+CiAgICAKICAgICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAg ICAKICAgICAgICAgICAgKiBTY3JpcHRzL2Jpc2VjdC1idWlsZHM6CiAgICAgICAgICAgIChtYWtl TmlnaHRseUxpc3QpOiBBZGRlZCBjaGVja3MgZm9yIFNhZmFyaSA0IFB1YmxpYyBCZXRhIG9uCiAg ICAgICAgICAgIFRpZ2VyIGFuZCBMZW9wYXJkLgoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0No YW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCBlNThiZmNkLi4yYzE3M2YyIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDMtMTcgIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KKworICAgICAgICBCdWcgMjQ2NDU6IGJpc2VjdC1idWlsZHMgc2NyaXB0IGRv ZXNuJ3Qgd29yayB3aXRoIFNhZmFyaSA0IFB1YmxpYyBCZXRhICh2ZXJzaW9uIHN0cmluZykKKwor ICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NjQ1Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy9iaXNlY3QtYnVpbGRzOgorICAgICAgICAobWFrZU5pZ2h0bHlMaXN0KTogQWRkZWQgY2hlY2tz IGZvciBTYWZhcmkgNCBQdWJsaWMgQmV0YSBvbgorICAgICAgICBUaWdlciBhbmQgTGVvcGFyZC4K KwogMjAwOS0wMy0xNCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz L2Jpc2VjdC1idWlsZHMgYi9XZWJLaXRUb29scy9TY3JpcHRzL2Jpc2VjdC1idWlsZHMKaW5kZXgg YzY5NTI2Yi4uNDVmZGNjNCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9iaXNlY3Qt YnVpbGRzCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcwpAQCAtMzIxLDcg KzMyMSw5IEBAIHN1YiBtYWtlTmlnaHRseUxpc3QoJCQkJCkKICAgICB9CiAKICAgICBpZiAoZXZh bCAidiRtYWNPU1hWZXJzaW9uIiBnZSB2MTAuNSkgewotICAgICAgICBpZiAoZXZhbCAidiRzYWZh cmlWZXJzaW9uIiBnZSB2My4yKSB7CisgICAgICAgIGlmICgkc2FmYXJpVmVyc2lvbiBlcSAiNCBQ dWJsaWMgQmV0YSIpIHsKKyAgICAgICAgICAgIEBmaWxlcyA9IGdyZXAgeyAkXy0+e3Jldn0gPj0g Mzk2ODIgfSBAZmlsZXM7CisgICAgICAgIH0gZWxzaWYgKGV2YWwgInYkc2FmYXJpVmVyc2lvbiIg Z2UgdjMuMikgewogICAgICAgICAgICAgQGZpbGVzID0gZ3JlcCB7ICRfLT57cmV2fSA+PSAzNzM0 OCB9IEBmaWxlczsKICAgICAgICAgfSBlbHNpZiAoZXZhbCAidiRzYWZhcmlWZXJzaW9uIiBnZSB2 My4xKSB7CiAgICAgICAgICAgICBAZmlsZXMgPSBncmVwIHsgJF8tPntyZXZ9ID49IDI5NzExIH0g QGZpbGVzOwpAQCAtMzMzLDcgKzMzNSw5IEBAIHN1YiBtYWtlTmlnaHRseUxpc3QoJCQkJCkKICAg ICAgICAgICAgIGRpZSAiUmVxdWlyZXMgU2FmYXJpIDIuMCBvciBuZXdlciI7CiAgICAgICAgIH0K ICAgICB9IGVsc2lmIChldmFsICJ2JG1hY09TWFZlcnNpb24iIGdlIHYxMC40KSB7Ci0gICAgICAg IGlmIChldmFsICJ2JHNhZmFyaVZlcnNpb24iIGdlIHYzLjIpIHsKKyAgICAgICAgaWYgKCRzYWZh cmlWZXJzaW9uIGVxICI0IFB1YmxpYyBCZXRhIikgeworICAgICAgICAgICAgQGZpbGVzID0gZ3Jl cCB7ICRfLT57cmV2fSA+PSAzOTY4MiB9IEBmaWxlczsKKyAgICAgICAgfSBlbHNpZiAoZXZhbCAi diRzYWZhcmlWZXJzaW9uIiBnZSB2My4yKSB7CiAgICAgICAgICAgICBAZmlsZXMgPSBncmVwIHsg JF8tPntyZXZ9ID49IDM3MzQ4IH0gQGZpbGVzOwogICAgICAgICB9IGVsc2lmIChldmFsICJ2JHNh ZmFyaVZlcnNpb24iIGdlIHYzLjEpIHsKICAgICAgICAgICAgIEBmaWxlcyA9IGdyZXAgeyAkXy0+ e3Jldn0gPj0gMjk3MTEgfSBAZmlsZXM7Cg==