24639 2009-03-16 23:56:42 -0700 [GTK] GStreamer MediaPlayer is unable to correctly querry duration 2009-09-24 03:50:10 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned cascardo commit-queue pnormand oldest_to_newest 113994 0 gustavo 2009-03-16 23:56:42 -0700 When querying time duration of ogg files (which are the only we support for now) gst_element_query_duration currently returns true, and sets the length to 0. We are adding a work-around to our MediaPlayerPrivate class, but this should be fixed in GStreamer. 113999 1 cascardo 2009-03-17 00:10:33 -0700 http://bugzilla.gnome.org/show_bug.cgi?id=575649 149410 2 pnormand 2009-09-23 09:24:28 -0700 Fix in GStreamer has been released. The workaround we have can now be removed maybe? 149532 3 gustavo 2009-09-23 15:50:41 -0700 (In reply to comment #2) > Fix in GStreamer has been released. The workaround we have can now be removed > maybe? With a version check, sure =). Want to write a patch for me to review? 149690 4 40049 pnormand 2009-09-24 00:55:05 -0700 Created attachment 40049 Proposed gst version check 149695 5 40051 pnormand 2009-09-24 01:16:48 -0700 Created attachment 40051 Proposed gst version check (with fixed ChangeLog) 149696 6 40051 xan.lopez 2009-09-24 01:21:12 -0700 Comment on attachment 40051 Proposed gst version check (with fixed ChangeLog) r=me 149714 7 40051 commit-queue 2009-09-24 03:50:06 -0700 Comment on attachment 40051 Proposed gst version check (with fixed ChangeLog) Clearing flags on attachment: 40051 Committed r48713: <http://trac.webkit.org/changeset/48713> 149715 8 commit-queue 2009-09-24 03:50:10 -0700 All reviewed patches have been landed. Closing bug. 40049 2009-09-24 00:55:05 -0700 2009-09-24 01:16:48 -0700 Proposed gst version check 0001-check-duration-returned-by-gst_element_query_duratio.patch text/plain 2324 pnormand RnJvbSAxMDYxZjdkZGYzMzY2ZDgzNmYxNjNjZjE3NzBjY2U3NWViM2E4NjhmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDI0IFNlcCAyMDA5IDA5OjUxOjEyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Y2hlY2sgZHVyYXRpb24gcmV0dXJuZWQgYnkgZ3N0X2VsZW1lbnRfcXVlcnlfZHVyYXRpb24oKSBv bmx5IHdoZW4gdXNpbmcgR1N0cmVhbWVyIDwgMC4xMC4yMwoKLS0tCiBXZWJDb3JlL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrKwogLi4u L2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgfCAgICA5ICsr KysrKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggM2NkYzY4Zi4uMGIyNmM1ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOS0yNCAgUGhpbGlwcGUg Tm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgY2hlY2sgZHVyYXRpb24gcmV0dXJuZWQgYnkgZ3N0X2Vs ZW1lbnRfcXVlcnlfZHVyYXRpb24oKSBvbmx5CisgICAgICAgIHdoZW4gdXNpbmcgR1N0cmVhbWVy IDwgMC4xMC4yMy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2 YXRlOjpkdXJhdGlvbik6CisKIDIwMDktMDktMjMgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lci5jcHAKaW5kZXggMjRhMjdhYi4uMzczNzA1MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwCkBAIC0yMTgsMTIgKzIxOCwxNyBAQCBmbG9hdCBNZWRpYVBsYXllclByaXZhdGU6OmR1 cmF0aW9uKCkgY29uc3QKICAgICBHc3RGb3JtYXQgdGltZUZvcm1hdCA9IEdTVF9GT1JNQVRfVElN RTsKICAgICBnaW50NjQgdGltZUxlbmd0aCA9IDA7CiAKLSAgICAvLyBGSVhNRTogV2UgdHJ5IHRv IGdldCB0aGUgZHVyYXRpb24sIGJ1dCB3ZSBkbyBub3QgdHJ1c3QgdGhlCisjaWYgIUdTVF9DSEVD S19WRVJTSU9OKDAsIDEwLCAyMykKKyAgICAvLyBXZSB0cnkgdG8gZ2V0IHRoZSBkdXJhdGlvbiwg YnV0IHdlIGRvIG5vdCB0cnVzdCB0aGUKICAgICAvLyByZXR1cm4gdmFsdWUgb2YgdGhlIHF1ZXJ5 IGZ1bmN0aW9uIG9ubHk7IHRoZSBwcm9ibGVtIHdlIGFyZQogICAgIC8vIHRyeWluZyB0byB3b3Jr LWFyb3VuZCBoZXJlIGlzIHRoYXQgcGlwZWxpbmVzIGluIHN0cmVhbSBtb2RlIG1heQogICAgIC8v IG5vdCBiZSBhYmxlIHRvIGZpZ3VyZSBvdXQgdGhlIGR1cmF0aW9uLCBidXQgc3RpbGwgcmV0dXJu IHRydWUhCi0gICAgLy8gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNDYzOS4KKyAgICAvLyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI0NjM5IHdoaWNoIGhhcyBiZWVuCisgICAgLy8gZml4ZWQgaW4gZ3N0LXBsdWdpbnMtYmFz ZSAwLjEwLjIzCiAgICAgaWYgKCFnc3RfZWxlbWVudF9xdWVyeV9kdXJhdGlvbihtX3BsYXlCaW4s ICZ0aW1lRm9ybWF0LCAmdGltZUxlbmd0aCkgfHwgdGltZUxlbmd0aCA8PSAwKSB7CisjZWxzZQor ICAgIGlmICghZ3N0X2VsZW1lbnRfcXVlcnlfZHVyYXRpb24obV9wbGF5QmluLCAmdGltZUZvcm1h dCwgJnRpbWVMZW5ndGgpKSB7CisjZW5kaWYKICAgICAgICAgTE9HX1ZFUkJPU0UoTWVkaWEsICJU aW1lIGR1cmF0aW9uIHF1ZXJ5IGZhaWxlZC4iKTsKICAgICAgICAgcmV0dXJuIG51bWVyaWNfbGlt aXRzPGZsb2F0Pjo6aW5maW5pdHkoKTsKICAgICB9Ci0tIAoxLjYuMC40Cgo= 40051 2009-09-24 01:16:48 -0700 2009-09-24 03:50:06 -0700 Proposed gst version check (with fixed ChangeLog) 0001-check-duration-returned-by-gst_element_query_duratio.patch text/plain 2460 pnormand RnJvbSBiOWI3MWZjZTZmMmM0YTc2NGI0Zjk2MmEyYWRkYzI3NjczMjYwN2MxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDI0IFNlcCAyMDA5IDA5OjUxOjEyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Y2hlY2sgZHVyYXRpb24gcmV0dXJuZWQgYnkgZ3N0X2VsZW1lbnRfcXVlcnlfZHVyYXRpb24oKSBv bmx5IHdoZW4gdXNpbmcgR1N0cmVhbWVyIDwgMC4xMC4yMwoKLS0tCiBXZWJDb3JlL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwog Li4uL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgfCAgICA5 ICsrKysrKystLQogMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggZjAyMTFhYS4uNmE5ZTBiMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOS0yNCAgUGhpbGlw cGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gR1N0cmVhbWVyIE1lZGlhUGxheWVyIGlz IHVuYWJsZSB0byBjb3JyZWN0bHkgcXVlcnJ5IGR1cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDYzOQorCisgICAgICAgIGNoZWNrIGR1cmF0 aW9uIHJldHVybmVkIGJ5IGdzdF9lbGVtZW50X3F1ZXJ5X2R1cmF0aW9uKCkgb25seQorICAgICAg ICB3aGVuIHVzaW5nIEdTdHJlYW1lciA8IDAuMTAuMjMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6ZHVyYXRpb24pOgorCiAyMDA5LTA5LTIzICBHZW9m ZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2Ft IFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0 ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDI0YTI3YWIuLjM3MzcwNTMg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMjE4LDEyICsyMTgsMTcgQEAgZmxvYXQg TWVkaWFQbGF5ZXJQcml2YXRlOjpkdXJhdGlvbigpIGNvbnN0CiAgICAgR3N0Rm9ybWF0IHRpbWVG b3JtYXQgPSBHU1RfRk9STUFUX1RJTUU7CiAgICAgZ2ludDY0IHRpbWVMZW5ndGggPSAwOwogCi0g ICAgLy8gRklYTUU6IFdlIHRyeSB0byBnZXQgdGhlIGR1cmF0aW9uLCBidXQgd2UgZG8gbm90IHRy dXN0IHRoZQorI2lmICFHU1RfQ0hFQ0tfVkVSU0lPTigwLCAxMCwgMjMpCisgICAgLy8gV2UgdHJ5 IHRvIGdldCB0aGUgZHVyYXRpb24sIGJ1dCB3ZSBkbyBub3QgdHJ1c3QgdGhlCiAgICAgLy8gcmV0 dXJuIHZhbHVlIG9mIHRoZSBxdWVyeSBmdW5jdGlvbiBvbmx5OyB0aGUgcHJvYmxlbSB3ZSBhcmUK ICAgICAvLyB0cnlpbmcgdG8gd29yay1hcm91bmQgaGVyZSBpcyB0aGF0IHBpcGVsaW5lcyBpbiBz dHJlYW0gbW9kZSBtYXkKICAgICAvLyBub3QgYmUgYWJsZSB0byBmaWd1cmUgb3V0IHRoZSBkdXJh dGlvbiwgYnV0IHN0aWxsIHJldHVybiB0cnVlIQotICAgIC8vIFNlZSBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ2MzkuCisgICAgLy8gU2VlIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDYzOSB3aGljaCBoYXMgYmVlbgorICAgIC8vIGZp eGVkIGluIGdzdC1wbHVnaW5zLWJhc2UgMC4xMC4yMwogICAgIGlmICghZ3N0X2VsZW1lbnRfcXVl cnlfZHVyYXRpb24obV9wbGF5QmluLCAmdGltZUZvcm1hdCwgJnRpbWVMZW5ndGgpIHx8IHRpbWVM ZW5ndGggPD0gMCkgeworI2Vsc2UKKyAgICBpZiAoIWdzdF9lbGVtZW50X3F1ZXJ5X2R1cmF0aW9u KG1fcGxheUJpbiwgJnRpbWVGb3JtYXQsICZ0aW1lTGVuZ3RoKSkgeworI2VuZGlmCiAgICAgICAg IExPR19WRVJCT1NFKE1lZGlhLCAiVGltZSBkdXJhdGlvbiBxdWVyeSBmYWlsZWQuIik7CiAgICAg ICAgIHJldHVybiBudW1lcmljX2xpbWl0czxmbG9hdD46OmluZmluaXR5KCk7CiAgICAgfQotLSAK MS42LjAuNAoK