24638 2009-03-16 21:23:14 -0700 [GTK] HTML5 media tags do not work 2009-09-23 09:50:58 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED http://www.double.co.nz/video_test/ Gtk P2 Normal --- 1 gustavo gustavo baggetun eric.carlson oldest_to_newest 113976 0 gustavo 2009-03-16 21:23:14 -0700 If you visit the URI I added to the bug report you'll notice that the video doesn't play. There are two main problems, really: 1) MediaPlayerPrivate::duration is returning 0 because gst_element_query_duration returns true even though it isn't able to figure out the duration in time format. 2) Nothing calls MediaPlayerPrivate::repaint when the sink draws the frame in the surface, so the video only gets updated when expose events or other conditions force the repaint 113977 1 gustavo 2009-03-16 22:24:59 -0700 3) When buffering the stream is not paused, so the video plays badly 113981 2 28678 gustavo 2009-03-16 22:37:00 -0700 Created attachment 28678 fix for duration 113982 3 28679 gustavo 2009-03-16 22:37:45 -0700 Created attachment 28679 fix repainting 113983 4 28680 gustavo 2009-03-16 22:38:25 -0700 Created attachment 28680 fix buffering 113984 5 28681 gustavo 2009-03-16 22:39:00 -0700 Created attachment 28681 enable passing tests 113985 6 28679 mrowe 2009-03-16 22:43:51 -0700 Comment on attachment 28679 fix repainting > +void mediaPlayerPrivateRepaintCallback(WebKitVideoSink* sink, gpointer data) > +{ > + MediaPlayerPrivate* playerPrivate = static_cast<MediaPlayerPrivate*>(data); > + playerPrivate->repaint(); > +} The function should be declared static, and the name of the first argument omitted since it is unused. You could probably do away with the local variable too without losing any clarity. r=me 113986 7 28680 mrowe 2009-03-16 22:46:33 -0700 Comment on attachment 28680 fix buffering What happens here if I explicitly hit "play" while a large video is buffering? It seems like the video would pause itself until it completes loading, even though it may have buffered sufficiently for it to be watchable. Does that match the spec? What happens if I hit play and then explicitly pause the video while it is still loading? It seems like the video would start itself playing when it finishes loading. Does that match the spec? 113987 8 28678 mrowe 2009-03-16 22:50:17 -0700 Comment on attachment 28678 fix for duration This seems as though it will treat a zero-length video as streaming? Does that behavior match the spec and/or other browsers? 113988 9 28681 mrowe 2009-03-16 22:51:22 -0700 Comment on attachment 28681 enable passing tests It would be preferable for the comment to explain, with reference to a bug, why specific tests are disabled. 113989 10 28678 zecke 2009-03-16 22:56:35 -0700 Comment on attachment 28678 fix for duration sorry, due mark's comments I put it back to review. 113990 11 gustavo 2009-03-16 23:06:30 -0700 (In reply to comment #10) > (From update of attachment 28678 [review]) > sorry, due mark's comments I put it back to review. > I'm setting the review flag for duration to r+ again, after talking to Mark on IRC, and will add a FIXME comment pointing to a bug report in our bugzilla, refering to a bug on the gstreamer bugzilla. 113993 12 gustavo 2009-03-16 23:48:48 -0700 (In reply to comment #7) > (From update of attachment 28680 [review]) > What happens here if I explicitly hit "play" while a large video is buffering? > It seems like the video would pause itself until it completes loading, even > though it may have buffered sufficiently for it to be watchable. Does that > match the spec? > > What happens if I hit play and then explicitly pause the video while it is > still loading? It seems like the video would start itself playing when it > finishes loading. Does that match the spec? I'll have to investigate this more closely. By reading the spec I believe we need to at least set readyState and networkState to specific values, and we need to figure out if we need to check if the user explicitely paused while we were buffering. I'll study some more tomorrow. 113996 13 28678 gustavo 2009-03-17 00:04:16 -0700 Comment on attachment 28678 fix for duration Landed as r41756, with comments addressed. Clearing review flag. 114000 14 28679 gustavo 2009-03-17 00:11:50 -0700 Comment on attachment 28679 fix repainting Landed as r41757. Clearing review flag. 114005 15 28681 gustavo 2009-03-17 00:26:26 -0700 Comment on attachment 28681 enable passing tests Landed as r41758. Clearing review flag. 114768 16 28680 gustavo 2009-03-23 08:07:50 -0700 Comment on attachment 28680 fix buffering Forgot to clear review flag while I stufy html5 media stuff a bit more for this change. 118462 17 gustavo 2009-04-22 19:11:04 -0700 *** Bug 16985 has been marked as a duplicate of this bug. *** 28678 2009-03-16 22:37:00 -0700 2009-04-22 19:10:07 -0700 fix for duration 0001-2009-03-16-Gustavo-Noronha-Silva-gns-gnome.org-and.patch text/plain 3247 gustavo RnJvbSAxNTQwMjI4MDc2YTk1M2ZjOTI0MWVlYzQwNjBlZTE1MTg4NTFiNjFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUdWUsIDE3IE1hciAyMDA5IDAxOjIzOjIyIC0wMzAwClN1YmplY3Q6IFtQQVRDSCAx LzRdIDIwMDktMDMtMTYgR3VzdGF2byBOb3JvbmhhIFNpbHZhIDxnbnNAZ25vbWUub3JnPiBhbmQg VGhhZGV1IExpbWEgZGUgU291emEgQ2FzY2FyZG8gPGNhc2NhcmRvQGhvbG9zY29waW8uY29tPgoK ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NjM4CiAgICAgICAgW0dUS10gSFRNTDUgbWVk aWEgdGFncyBkbyBub3Qgd29yawoKICAgICAgICBXb3JrLWFyb3VuZCB0aGUgZmFjdCB0aGF0IGdz dF9lbGVtZW50X3F1ZXJ5X2R1cmF0aW9uIHJldHVybnMgdHJ1ZSBldmVuCiAgICAgICAgdGhvdWdo IGl0IGlzIHVuYWJsZSB0byBmaWd1cmUgb3V0IHRoZSBkdXJhdGlvbiB3aGVuIGluIHN0cmVhbSAo cHVzaCkKICAgICAgICBtb2RlLgoKICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgogICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXll clByaXZhdGU6OmR1cmF0aW9uKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3Rr L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICB8ICAgMjMgKysrKysrKysrKystLS0t LS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IGE3MjgzNWQuLjY4OWZjYTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDMtMTYgIEd1c3Rhdm8gTm9y b25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+IGFuZCBUaGFkZXUgTGltYSBkZSBTb3V6YSBDYXNj YXJkbyA8Y2FzY2FyZG9AaG9sb3Njb3Bpby5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI0NjM4CisgICAgICAgIFtHVEtdIEhUTUw1IG1lZGlhIHRhZ3MgZG8gbm90IHdvcmsK KworICAgICAgICBXb3JrLWFyb3VuZCB0aGUgZmFjdCB0aGF0IGdzdF9lbGVtZW50X3F1ZXJ5X2R1 cmF0aW9uIHJldHVybnMgdHJ1ZSBldmVuCisgICAgICAgIHRob3VnaCBpdCBpcyB1bmFibGUgdG8g ZmlndXJlIG91dCB0aGUgZHVyYXRpb24gd2hlbiBpbiBzdHJlYW0gKHB1c2gpCisgICAgICAgIG1v ZGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6ZHVy YXRpb24pOgorCiAyMDA5LTAzLTE2ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBLZXZpbiBEZWNrZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw cAppbmRleCA1OWZkZDZmLi44MzFhY2Q3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAg LTE5MSwxOSArMTkxLDIyIEBAIGZsb2F0IE1lZGlhUGxheWVyUHJpdmF0ZTo6ZHVyYXRpb24oKSBj b25zdAogICAgIGlmICghbV9wbGF5QmluKQogICAgICAgICByZXR1cm4gMC4wOwogCi0gICAgR3N0 Rm9ybWF0IGZtdCA9IEdTVF9GT1JNQVRfVElNRTsKLSAgICBnaW50NjQgbGVuID0gMDsKLQotICAg IGlmIChnc3RfZWxlbWVudF9xdWVyeV9kdXJhdGlvbihtX3BsYXlCaW4sICZmbXQsICZsZW4pKQot ICAgICAgICBMT0dfVkVSQk9TRShNZWRpYSwgIkR1cmF0aW9uOiAlIiBHU1RfVElNRV9GT1JNQVQs IEdTVF9USU1FX0FSR1MobGVuKSk7Ci0gICAgZWxzZQotICAgICAgICBMT0dfVkVSQk9TRShNZWRp YSwgIkR1cmF0aW9uIHF1ZXJ5IGZhaWxlZCAiKTsKLQotICAgIGlmICgoR3N0Q2xvY2tUaW1lKWxl biA9PSBHU1RfQ0xPQ0tfVElNRV9OT05FKSB7CisgICAgR3N0Rm9ybWF0IHRpbWVGb3JtYXQgPSBH U1RfRk9STUFUX1RJTUU7CisgICAgZ2ludDY0IHRpbWVMZW5ndGggPSAwOworCisgICAgLy8gV2Ug dHJ5IHRvIGdldCB0aGUgZHVyYXRpb24sIGJ1dCB3ZSBkbyBub3QgdHJ1c3QgdGhlIHJldHVybgor ICAgIC8vIHZhbHVlIG9mIHRoZSBxdWVyeSBmdW5jdGlvbiBvbmx5OyB0aGUgcHJvYmxlbSB3ZSBh cmUgdHJ5aW5nIHRvCisgICAgLy8gd29yay1hcm91bmQgaGVyZSBpcyB0aGF0IHBpcGVsaW5lcyBp biBzdHJlYW0gbW9kZSBtYXkgbm90IGJlCisgICAgLy8gYWJsZSB0byBmaWd1cmUgb3V0IHRoZSBk dXJhdGlvbiwgYnV0IHN0aWxsIHJldHVybiB0cnVlIQorICAgIGlmICghZ3N0X2VsZW1lbnRfcXVl cnlfZHVyYXRpb24obV9wbGF5QmluLCAmdGltZUZvcm1hdCwgJnRpbWVMZW5ndGgpIHx8IHRpbWVM ZW5ndGggPD0gMCkgeworICAgICAgICBMT0dfVkVSQk9TRShNZWRpYSwgIlRpbWUgZHVyYXRpb24g cXVlcnkgZmFpbGVkLiIpOwogICAgICAgICBtX2lzU3RyZWFtaW5nID0gdHJ1ZTsKICAgICAgICAg cmV0dXJuIG51bWVyaWNfbGltaXRzPGZsb2F0Pjo6aW5maW5pdHkoKTsKICAgICB9Ci0gICAgcmV0 dXJuIChmbG9hdCkgKGxlbiAvIDEwMDAwMDAwMDAuMCk7CisKKyAgICBMT0dfVkVSQk9TRShNZWRp YSwgIkR1cmF0aW9uOiAlIiBHU1RfVElNRV9GT1JNQVQsIEdTVF9USU1FX0FSR1ModGltZUxlbmd0 aCkpOworCisgICAgcmV0dXJuIChmbG9hdCkgKHRpbWVMZW5ndGggLyAxMDAwMDAwMDAwLjApOwog ICAgIC8vIEZJWE1FOiBoYW5kbGUgMy4xNC45LjUgcHJvcGVybHkKIH0KIAotLSAKMS42LjIKCg== 28679 2009-03-16 22:37:45 -0700 2009-04-22 19:10:09 -0700 fix repainting 0002-2009-03-16-Gustavo-Noronha-Silva-gns-gnome.org-and.patch text/plain 5868 gustavo RnJvbSAwYzdhYmRmYmMwNGY0MTFmMTAyZGMxY2NiZjA1OGY0YTIxMjcyYzU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUdWUsIDE3IE1hciAyMDA5IDAxOjMxOjQyIC0wMzAwClN1YmplY3Q6IFtQQVRDSCAy LzRdIDIwMDktMDMtMTYgR3VzdGF2byBOb3JvbmhhIFNpbHZhIDxnbnNAZ25vbWUub3JnPiBhbmQg VGhhZGV1IExpbWEgZGUgU291emEgQ2FzY2FyZG8gPGNhc2NhcmRvQGhvbG9zY29waW8uY29tPgoK ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NjM4CiAgICAgICAgW0dUS10gSFRNTDUgbWVk aWEgdGFncyBkbyBub3Qgd29yawoKICAgICAgICBBZGQgYSByZXBhaW50LXJlcXVlc3RlZCBzaWdu YWwgdG8gdGhlIHZpZGVvIHNpbmssIGFuZCB1c2UgaXQgdG8KICAgICAgICBjYWxsIE1lZGlhUGxh eWVyUHJpdmF0ZTo6cmVwYWludCwgc28gdGhhdCB0aGUgdmlkZW8gYWN0dWFsbHkKICAgICAgICBw bGF5cy4KCiAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmNwcDoKICAgICAgICAoV2ViQ29yZTo6bWVkaWFQbGF5ZXJQcml2YXRlUmVwYWlu dENhbGxiYWNrKToKICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpjcmVhdGVH U1RQbGF5QmluKToKICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9WaWRlb1NpbmtHU3Ry ZWFtZXIuY3BwOgogICAgICAgICh3ZWJraXRfdmlkZW9fc2lua19pZGxlX2Z1bmMpOgogICAgICAg ICh3ZWJraXRfdmlkZW9fc2lua19yZW5kZXIpOgogICAgICAgICh3ZWJraXRfdmlkZW9fc2lua19j bGFzc19pbml0KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgMTkgKysrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3RrL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICB8ICAgIDggKysrKysrCiAuLi4vcGxhdGZvcm0v Z3JhcGhpY3MvZ3RrL1ZpZGVvU2lua0dTdHJlYW1lci5jcHAgICB8ICAgMjUgKysrKysrKysrKysr KysrKy0tLQogMyBmaWxlcyBjaGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggNjg5ZmNhNi4uZjQyMzI5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTUsNiArNSwyNSBAQAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ2MzgKICAgICAgICAgW0dUS10gSFRNTDUgbWVk aWEgdGFncyBkbyBub3Qgd29yawogCisgICAgICAgIEFkZCBhIHJlcGFpbnQtcmVxdWVzdGVkIHNp Z25hbCB0byB0aGUgdmlkZW8gc2luaywgYW5kIHVzZSBpdCB0bworICAgICAgICBjYWxsIE1lZGlh UGxheWVyUHJpdmF0ZTo6cmVwYWludCwgc28gdGhhdCB0aGUgdmlkZW8gYWN0dWFsbHkKKyAgICAg ICAgcGxheXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1lZGlhUGxheWVyUHJpdmF0 ZVJlcGFpbnRDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6 OmNyZWF0ZUdTVFBsYXlCaW4pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9WaWRl b1NpbmtHU3RyZWFtZXIuY3BwOgorICAgICAgICAod2Via2l0X3ZpZGVvX3NpbmtfaWRsZV9mdW5j KToKKyAgICAgICAgKHdlYmtpdF92aWRlb19zaW5rX3JlbmRlcik6CisgICAgICAgICh3ZWJraXRf dmlkZW9fc2lua19jbGFzc19pbml0KToKKworMjAwOS0wMy0xNiAgR3VzdGF2byBOb3JvbmhhIFNp bHZhICA8Z25zQGdub21lLm9yZz4gYW5kIFRoYWRldSBMaW1hIGRlIFNvdXphIENhc2NhcmRvIDxj YXNjYXJkb0Bob2xvc2NvcGlvLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjQ2MzgKKyAgICAgICAgW0dUS10gSFRNTDUgbWVkaWEgdGFncyBkbyBub3Qgd29yaworCiAgICAg ICAgIFdvcmstYXJvdW5kIHRoZSBmYWN0IHRoYXQgZ3N0X2VsZW1lbnRfcXVlcnlfZHVyYXRpb24g cmV0dXJucyB0cnVlIGV2ZW4KICAgICAgICAgdGhvdWdoIGl0IGlzIHVuYWJsZSB0byBmaWd1cmUg b3V0IHRoZSBkdXJhdGlvbiB3aGVuIGluIHN0cmVhbSAocHVzaCkKICAgICAgICAgbW9kZS4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDgzMWFjZDcuLjg0Y2U2OTEgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyLmNwcApAQCAtMTAxLDYgKzEwMSwxMiBAQCBnYm9vbGVhbiBtZWRpYVBsYXll clByaXZhdGVCdWZmZXJpbmdDYWxsYmFjayhHc3RCdXMqIGJ1cywgR3N0TWVzc2FnZSogbWVzc2Fn ZSwgZwogICAgIHJldHVybiB0cnVlOwogfQogCit2b2lkIG1lZGlhUGxheWVyUHJpdmF0ZVJlcGFp bnRDYWxsYmFjayhXZWJLaXRWaWRlb1NpbmsqIHNpbmssIGdwb2ludGVyIGRhdGEpCit7CisgICAg TWVkaWFQbGF5ZXJQcml2YXRlKiBwbGF5ZXJQcml2YXRlID0gc3RhdGljX2Nhc3Q8TWVkaWFQbGF5 ZXJQcml2YXRlKj4oZGF0YSk7CisgICAgcGxheWVyUHJpdmF0ZS0+cmVwYWludCgpOworfQorCiBN ZWRpYVBsYXllclByaXZhdGVJbnRlcmZhY2UqIE1lZGlhUGxheWVyUHJpdmF0ZTo6Y3JlYXRlKE1l ZGlhUGxheWVyKiBwbGF5ZXIpIAogeyAKICAgICByZXR1cm4gbmV3IE1lZGlhUGxheWVyUHJpdmF0 ZShwbGF5ZXIpOwpAQCAtNjM0LDYgKzY0MCw4IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpj cmVhdGVHU1RQbGF5QmluKFN0cmluZyB1cmwpCiAgICAgZ19vYmplY3Rfc2V0KG1fcGxheUJpbiwg ImF1ZGlvLXNpbmsiLCBhdWRpb1NpbmssIE5VTEwpOwogICAgIGdfb2JqZWN0X3NldChtX3BsYXlC aW4sICJ2aWRlby1zaW5rIiwgbV92aWRlb1NpbmssIE5VTEwpOwogCisgICAgZ19zaWduYWxfY29u bmVjdChtX3ZpZGVvU2luaywgInJlcGFpbnQtcmVxdWVzdGVkIiwgR19DQUxMQkFDSyhtZWRpYVBs YXllclByaXZhdGVSZXBhaW50Q2FsbGJhY2spLCB0aGlzKTsKKwogICAgIHNldFZvbHVtZShtX3Zv bHVtZSk7CiB9CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL1Zp ZGVvU2lua0dTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9WaWRl b1NpbmtHU3RyZWFtZXIuY3BwCmluZGV4IDA0ZGY3YWMuLjQzNjg0MWMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL1ZpZGVvU2lua0dTdHJlYW1lci5jcHAKKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvVmlkZW9TaW5rR1N0cmVhbWVyLmNwcApAQCAt NDYsMTAgKzQ2LDE3IEBAIHN0YXRpYyBHc3RFbGVtZW50RGV0YWlscyB3ZWJraXRfdmlkZW9fc2lu a19kZXRhaWxzID0KICAgICAgICAgICAgICAgICAgICAgICAoZ2NoYXIqKSAiQWxwIFRva2VyIDxh bHBAYXRva2VyLmNvbT4iKTsKIAogZW51bSB7CisgICAgUkVQQUlOVF9SRVFVRVNURUQsCisgICAg TEFTVF9TSUdOQUwKK307CisKK2VudW0gewogICAgIFBST1BfMCwKICAgICBQUk9QX1NVUkZBQ0UK IH07CiAKK3N0YXRpYyBndWludCB3ZWJraXRfdmlkZW9fc2lua19zaWduYWxzW0xBU1RfU0lHTkFM XSA9IHsgMCwgfTsKKwogc3RydWN0IF9XZWJLaXRWaWRlb1NpbmtQcml2YXRlIHsKICAgICBjYWly b19zdXJmYWNlX3QqIHN1cmZhY2U7CiAgICAgR0FzeW5jUXVldWUqIGFzeW5jX3F1ZXVlOwpAQCAt OTUsMTEgKzEwMiwxMCBAQCB3ZWJraXRfdmlkZW9fc2lua19pbml0KFdlYktpdFZpZGVvU2luayog c2luaywgV2ViS2l0VmlkZW9TaW5rQ2xhc3MqIGtsYXNzKQogc3RhdGljIGdib29sZWFuCiB3ZWJr aXRfdmlkZW9fc2lua19pZGxlX2Z1bmMoZ3BvaW50ZXIgZGF0YSkKIHsKLSAgICBXZWJLaXRWaWRl b1NpbmtQcml2YXRlKiBwcml2OworICAgIFdlYktpdFZpZGVvU2luayogc2luayA9IFdFQktJVF9W SURFT19TSU5LKGRhdGEpOworICAgIFdlYktpdFZpZGVvU2lua1ByaXZhdGUqIHByaXYgPSBzaW5r LT5wcml2OwogICAgIEdzdEJ1ZmZlciogYnVmZmVyOwogCi0gICAgcHJpdiA9IChXZWJLaXRWaWRl b1NpbmtQcml2YXRlKilkYXRhOwotCiAgICAgaWYgKCFwcml2LT5hc3luY19xdWV1ZSkKICAgICAg ICAgcmV0dXJuIEZBTFNFOwogCkBAIC0xMjEsNiArMTI3LDggQEAgd2Via2l0X3ZpZGVvX3Npbmtf aWRsZV9mdW5jKGdwb2ludGVyIGRhdGEpCiAKICAgICBnc3RfYnVmZmVyX3VucmVmKGJ1ZmZlcik7 CiAKKyAgICBnX3NpZ25hbF9lbWl0KHNpbmssIHdlYmtpdF92aWRlb19zaW5rX3NpZ25hbHNbUkVQ QUlOVF9SRVFVRVNURURdLCAwKTsKKwogICAgIHJldHVybiBGQUxTRTsKIH0KIApAQCAtMTMxLDcg KzEzOSw3IEBAIHdlYmtpdF92aWRlb19zaW5rX3JlbmRlcihHc3RCYXNlU2luayogYnNpbmssIEdz dEJ1ZmZlciogYnVmZmVyKQogICAgIFdlYktpdFZpZGVvU2lua1ByaXZhdGUqIHByaXYgPSBzaW5r LT5wcml2OwogCiAgICAgZ19hc3luY19xdWV1ZV9wdXNoKHByaXYtPmFzeW5jX3F1ZXVlLCBnc3Rf YnVmZmVyX3JlZihidWZmZXIpKTsKLSAgICBnX2lkbGVfYWRkX2Z1bGwoR19QUklPUklUWV9ISUdI X0lETEUsIHdlYmtpdF92aWRlb19zaW5rX2lkbGVfZnVuYywgcHJpdiwgTlVMTCk7CisgICAgZ19p ZGxlX2FkZF9mdWxsKEdfUFJJT1JJVFlfSElHSF9JRExFLCB3ZWJraXRfdmlkZW9fc2lua19pZGxl X2Z1bmMsIHNpbmssIE5VTEwpOwogCiAgICAgcmV0dXJuIEdTVF9GTE9XX09LOwogfQpAQCAtMjc5 LDYgKzI4NywxNSBAQCB3ZWJraXRfdmlkZW9fc2lua19jbGFzc19pbml0KFdlYktpdFZpZGVvU2lu a0NsYXNzKiBrbGFzcykKICAgICBnc3RiYXNlX3NpbmtfY2xhc3MtPnN0b3AgPSB3ZWJraXRfdmlk ZW9fc2lua19zdG9wOwogICAgIGdzdGJhc2Vfc2lua19jbGFzcy0+c2V0X2NhcHMgPSB3ZWJraXRf dmlkZW9fc2lua19zZXRfY2FwczsKIAorICAgIHdlYmtpdF92aWRlb19zaW5rX3NpZ25hbHNbUkVQ QUlOVF9SRVFVRVNURURdID0gZ19zaWduYWxfbmV3KCJyZXBhaW50LXJlcXVlc3RlZCIsCisgICAg ICAgICAgICBHX1RZUEVfRlJPTV9DTEFTUyhrbGFzcyksCisgICAgICAgICAgICAoR1NpZ25hbEZs YWdzKShHX1NJR05BTF9SVU5fTEFTVCB8IEdfU0lHTkFMX0FDVElPTiksCisgICAgICAgICAgICAw LAorICAgICAgICAgICAgTlVMTCwKKyAgICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICBnX2Nj bG9zdXJlX21hcnNoYWxfVk9JRF9fVk9JRCwKKyAgICAgICAgICAgIEdfVFlQRV9OT05FLCAwKTsK KwogICAgIGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkoCiAgICAgICAgIGdvYmplY3Rf Y2xhc3MsIFBST1BfU1VSRkFDRSwKICAgICAgICAgZ19wYXJhbV9zcGVjX3BvaW50ZXIoInN1cmZh Y2UiLCAic3VyZmFjZSIsICJUYXJnZXQgY2Fpcm9fc3VyZmFjZV90KiIsCi0tIAoxLjYuMgoK 28680 2009-03-16 22:38:25 -0700 2009-03-23 08:07:50 -0700 fix buffering 0003-2009-03-16-Gustavo-Noronha-Silva-gns-gnome.org.patch text/plain 2320 gustavo RnJvbSBlZTdiMDhiZmYwYTJlN2MyYzczZjNlZDA4ZWM4YTE3ZTgxYjI2MjY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUdWUsIDE3IE1hciAyMDA5IDAyOjE5OjAxIC0wMzAwClN1YmplY3Q6IFtQQVRDSCAz LzRdIDIwMDktMDMtMTYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+Cgog ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ2MzgKICAgICAgICBbR1RLXSBIVE1MNSBtZWRp YSB0YWdzIGRvIG5vdCB3b3JrCgogICAgICAgIFdoZW4gYnVmZmVyaW5nLCBwYXVzZSB0aGUgc3Ry ZWFtLiBTZXQgaXQgdG8gcGxheWluZyBhZ2FpbiBhZnRlcgogICAgICAgIHRoZSBidWZmZXJpbmcg aXMgZG9uZS4KCiAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyLmNwcDoKICAgICAgICAoV2ViQ29yZTo6bWVkaWFQbGF5ZXJQcml2YXRlQnVm ZmVyaW5nQ2FsbGJhY2spOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3RrL01l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICB8ICAgIDcgKysrKysrKwogMiBmaWxlcyBj aGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dl YkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQyMzI5Yi4uODJlMDhi MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMy0xNiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25z QGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ2MzgKKyAgICAg ICAgW0dUS10gSFRNTDUgbWVkaWEgdGFncyBkbyBub3Qgd29yaworCisgICAgICAgIFdoZW4gYnVm ZmVyaW5nLCBwYXVzZSB0aGUgc3RyZWFtLiBTZXQgaXQgdG8gcGxheWluZyBhZ2FpbiBhZnRlcgor ICAgICAgICB0aGUgYnVmZmVyaW5nIGlzIGRvbmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Om1lZGlhUGxheWVyUHJpdmF0ZUJ1ZmZlcmluZ0NhbGxiYWNrKToKKwogMjAwOS0wMy0xNiAg R3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4gYW5kIFRoYWRldSBMaW1hIGRl IFNvdXphIENhc2NhcmRvIDxjYXNjYXJkb0Bob2xvc2NvcGlvLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDg0 Y2U2OTEuLjQ4ODQxYTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3Rr L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtOTcsNiArOTcs MTMgQEAgZ2Jvb2xlYW4gbWVkaWFQbGF5ZXJQcml2YXRlQnVmZmVyaW5nQ2FsbGJhY2soR3N0QnVz KiBidXMsIEdzdE1lc3NhZ2UqIG1lc3NhZ2UsIGcKICAgICAgICAgZ2ludCBwZXJjZW50ID0gMDsK ICAgICAgICAgZ3N0X21lc3NhZ2VfcGFyc2VfYnVmZmVyaW5nKG1lc3NhZ2UsICZwZXJjZW50KTsK ICAgICAgICAgTE9HX1ZFUkJPU0UoTWVkaWEsICJCdWZmZXJpbmcgJWQiLCBwZXJjZW50KTsKKwor ICAgICAgICBNZWRpYVBsYXllclByaXZhdGUqIHBsYXllclByaXZhdGUgPSBzdGF0aWNfY2FzdDxN ZWRpYVBsYXllclByaXZhdGUqPihkYXRhKTsKKworICAgICAgICBpZiAocGVyY2VudCA8IDEwMCAm JiAhcGxheWVyUHJpdmF0ZS0+cGF1c2VkKCkpCisgICAgICAgICAgICBwbGF5ZXJQcml2YXRlLT5w YXVzZSgpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBwbGF5ZXJQcml2YXRlLT5wbGF5KCk7 CiAgICAgfQogICAgIHJldHVybiB0cnVlOwogfQotLSAKMS42LjIKCg== 28681 2009-03-16 22:39:00 -0700 2009-04-22 19:10:19 -0700 enable passing tests 0004-2009-03-16-Gustavo-Noronha-Silva-gns-gnome.org.patch text/plain 2402 gustavo RnJvbSBmN2FkOTAzNWZkZGUxZmM4MjBjNGJhYjNlN2EwYjNkYjM0MWFkYjBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUdWUsIDE3IE1hciAyMDA5IDAyOjMxOjM0IC0wMzAwClN1YmplY3Q6IFtQQVRDSCA0 LzRdIDIwMDktMDMtMTYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+Cgog ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ2MzgKICAgICAgICBbR1RLXSBIVE1MNSBtZWRp YSB0YWdzIGRvIG5vdCB3b3JrCgogICAgICAgIFJlbW92ZSB0aGUgYmxhY2tsaXN0aW5nIG9mIHRo ZSBtZWRpYS8gZGlyZWN0b3J5LCBub3cgdGhhdCB3ZSBoYXZlCiAgICAgICAgYSB3b3JraW5nIE1l ZGlhUGxheWVyOyBza2lwIG9ubHkgdGhlIHRlc3RzIHRoYXQgYXJlIHN0aWxsIGZhaWxpbmcuCgog ICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6Ci0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n ICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1NraXBwZWQgfCAgIDE3ICsrKysrKysrKysrKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDI4IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDA5ODBjODkuLmYxODcxMDcgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wMy0xNiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8 Z25zQGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ2MzgKKyAg ICAgICAgW0dUS10gSFRNTDUgbWVkaWEgdGFncyBkbyBub3Qgd29yaworCisgICAgICAgIFJlbW92 ZSB0aGUgYmxhY2tsaXN0aW5nIG9mIHRoZSBtZWRpYS8gZGlyZWN0b3J5LCBub3cgdGhhdCB3ZSBo YXZlCisgICAgICAgIGEgd29ya2luZyBNZWRpYVBsYXllcjsgc2tpcCBvbmx5IHRoZSB0ZXN0cyB0 aGF0IGFyZSBzdGlsbCBmYWlsaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6 CisKIDIwMDktMDMtMTYgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBS dWJiZXItc3RhbXBlZCBieSBBZGVsZSBQZXRlcnNvbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQK aW5kZXggNmIwYzYwMi4uZDAwNDFlYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTIx MTIsNyArMjExMiw2IEBAIGNzczIuMQogY3NzMwogZWRpdGluZwogZ2VvbG9jYXRpb24KLW1lZGlh CiBwbGF0Zm9ybQogcHJpbnRpbmcKIHNjcm9sbGJhcnMKQEAgLTIxNDksNiArMjE0OCwyMiBAQCBk b20veGh0bWwvbGV2ZWwzL2NvcmUvbm9kZWxvb2t1cHByZWZpeDE5LnhodG1sCiAjIE5lZWRzIHNj aGVkdWxlQXN5bmNocm9ub3VzQ2xpY2sgbWV0aG9kIGZvciBFdmVudFNlbmRlcgogZmFzdC9ldmVu dHMvcG9wdXAtYmxvY2tpbmctY2xpY2staW4taWZyYW1lLmh0bWwKIAorIyBUZXN0cyBpbiBtZWRp YS8gZGlyZWN0b3J5CittZWRpYS9hdWRpby1tcGVnLXN1cHBvcnRlZC5odG1sCittZWRpYS9icm9r ZW4tdmlkZW8uaHRtbAorbWVkaWEvcHJvZ3Jlc3MtZXZlbnQtdG90YWwuaHRtbAorbWVkaWEvdW5z dXBwb3J0ZWQtcnRzcC5odG1sCittZWRpYS92aWRlby1idWZmZXJlZC5odG1sCittZWRpYS92aWRl by1jYW4tcGxheS10eXBlLmh0bWwKK21lZGlhL3ZpZGVvLWNsaWNrLWRibGNraWNrLXN0YW5kYWxv bmUuaHRtbAorbWVkaWEvdmlkZW8tY29udHJvbHMtdHJhbnNmb3JtZWQuaHRtbAorbWVkaWEvdmlk ZW8tZXJyb3ItZG9lcy1ub3QtZXhpc3QuaHRtbAorbWVkaWEvdmlkZW8tbG9vcC5odG1sCittZWRp YS92aWRlby1zZWVrLXBhc3QtZW5kLXBsYXlpbmcuaHRtbAorbWVkaWEvdmlkZW8tc2l6ZS5odG1s CittZWRpYS92aWRlby1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbAorbWVkaWEvdmlkZW8tc291cmNl LXR5cGUuaHRtbAorCiAjIFRlc3RzIGluIHBsdWdpbnMvIGRpcmVjdG9yeQogIyBUZXN0cyB0aGF0 IG5lZWQgT2JqQyBwbHVnaW4KIHBsdWdpbnMvY2FsbC1hcy1mdW5jdGlvbi10ZXN0Lmh0bWwKLS0g CjEuNi4yCgo=