246344 2022-10-11 09:38:50 -0700 Correct autocorrect 2024-08-27 08:46:26 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 151019 1 annevk annevk webkit-bug-importer wenson_hsieh oldest_to_newest 1904799 0 annevk 2022-10-11 09:38:50 -0700 For password/URL/email controls we do the wrong thing per https://github.com/web-platform-tests/wpt/pull/25073 and our proposed specification at https://github.com/whatwg/html/pull/5841. Might want to wait with fixing this until the specification PR has landed. 1904800 1 webkit-bug-importer 2022-10-11 09:39:08 -0700 <rdar://problem/101036922> 2053274 2 annevk 2024-08-16 05:13:57 -0700 Per recent specification discussion we'll also have to change isEmpty() to isNull() here: bool HTMLFormControlElement::shouldAutocorrect() const { const AtomString& autocorrectValue = attributeWithoutSynchronization(autocorrectAttr); if (!autocorrectValue.isEmpty()) return !equalLettersIgnoringASCIICase(autocorrectValue, "off"_s); if (RefPtr<HTMLFormElement> form = this->form()) return form->shouldAutocorrect(); return true; } This causes an additional failure in the tests. 2053730 3 annevk 2024-08-19 09:06:12 -0700 Pull request: https://github.com/WebKit/WebKit/pull/32388 2055659 4 ews-feeder 2024-08-27 08:46:24 -0700 Committed 282792@main (28a8a4b35f33): <https://commits.webkit.org/282792@main> Reviewed commits have been landed. Closing PR #32388 and removing active labels.