24625 2009-03-16 13:07:55 -0700 Accessor to the selected index needed in PopupMenuChromium 2009-03-19 09:30:44 -0700 1 1 1 Unclassified WebKit New Bugs 420+ All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jcampan jcampan dglazkov oldest_to_newest 113913 0 jcampan 2009-03-16 13:07:55 -0700 In order to implement the deletion of autofill items in Chromium, PopupMenuChromium should have a getter to the selected index. 113915 1 28657 jcampan 2009-03-16 13:11:00 -0700 Created attachment 28657 Adds the selectedIndex accessor to PopupMenuChromium 114114 2 28657 dglazkov 2009-03-17 15:38:09 -0700 Comment on attachment 28657 Adds the selectedIndex accessor to PopupMenuChromium > +++ WebCore/platform/chromium/PopupMenuChromium.h (working copy) > @@ -107,6 +107,10 @@ namespace WebCore { > > PopupListBox* listBox() const { return m_listBox.get(); } > > + // Gets the index of the item that the user is currently moused-over or > + // has selected with the keyboard up/down arrows. > + int selectedIndex() const; > + ident fail? :) 114117 3 28706 jcampan 2009-03-17 15:48:29 -0700 Created attachment 28706 Fixed indent. 114119 4 28706 dglazkov 2009-03-17 15:51:30 -0700 Comment on attachment 28706 Fixed indent. r=me. I'll land. 114320 5 dglazkov 2009-03-19 09:30:44 -0700 Landed as http://trac.webkit.org/changeset/41835. 28657 2009-03-16 13:11:00 -0700 2009-03-17 15:48:29 -0700 Adds the selectedIndex accessor to PopupMenuChromium popupmenuchromium.patch text/plain 1864 jcampan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTczNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMTYgIEpheSBDYW1wYW4gIDxqY2FtcGFuQGdvb2dsZS5j b20+CisKKyAgICAgICAgQWRkaW5nIGFuIGFjY2Vzc29yIHRvIHRoZSBjdXJyZW50bHkgc2VsZWN0 ZWQgaW5kZXggaW4gdGhlIFBvcHVwTWVudUNocm9taXVtLgorICAgICAgICBUaGlzIGlzIHJlcXVp cmVkIGZvciBpbXBsZW1lbnRpbmcgdGhlIGRlbGV0aW9uIG9mIGFuIGF1dG9jb21wbGV0ZSBlbnRy eSBpbiBDaHJvbWl1bS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI0NjI1CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJv bWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cENvbnRhaW5lcjo6c2VsZWN0ZWRJbmRl eCk6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uaDoKKwog MjAwOS0wMy0xNiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2aXNpb24gNDE3MzQpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDgwLDYgKzQ4MCwxMSBAQCB2b2lkIFBvcHVwQ29udGFpbmVyOjpyZWZyZXNoKCkK ICAgICBsYXlvdXQoKTsKIH0KIAoraW50IFBvcHVwQ29udGFpbmVyOjpzZWxlY3RlZEluZGV4KCkg Y29uc3QKK3sKKyAgICByZXR1cm4gbV9saXN0Qm94LT5zZWxlY3RlZEluZGV4KCk7Cit9CisKIC8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8KIC8vIFBvcHVwTGlzdEJveCBpbXBsZW1lbnRhdGlvbgogCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5oCShy ZXZpc2lvbiA0MTczNCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hy b21pdW0uaAkod29ya2luZyBjb3B5KQpAQCAtMTA3LDYgKzEwNywxMCBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKICAgICAgICAgUG9wdXBMaXN0Qm94KiBsaXN0Qm94KCkgY29uc3QgeyByZXR1cm4g bV9saXN0Qm94LmdldCgpOyB9CiAKKwkvLyBHZXRzIHRoZSBpbmRleCBvZiB0aGUgaXRlbSB0aGF0 IHRoZSB1c2VyIGlzIGN1cnJlbnRseSBtb3VzZWQtb3ZlciBvcgorCS8vIGhhcyBzZWxlY3RlZCB3 aXRoIHRoZSBrZXlib2FyZCB1cC9kb3duIGFycm93cy4KKwlpbnQgc2VsZWN0ZWRJbmRleCgpIGNv bnN0OworCiAgICAgICAgIC8vIFJlZnJlc2ggdGhlIHBvcHVwIHZhbHVlcyBmcm9tIHRoZSBQb3B1 cE1lbnVDbGllbnQuCiAgICAgICAgIHZvaWQgcmVmcmVzaCgpOwogCg== 28706 2009-03-17 15:48:29 -0700 2009-03-17 15:51:30 -0700 Fixed indent. popupmenuchromium.patch text/plain 1885 jcampan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTczNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMTYgIEpheSBDYW1wYW4gIDxqY2FtcGFuQGdvb2dsZS5j b20+CisKKyAgICAgICAgQWRkaW5nIGFuIGFjY2Vzc29yIHRvIHRoZSBjdXJyZW50bHkgc2VsZWN0 ZWQgaW5kZXggaW4gdGhlIFBvcHVwTWVudUNocm9taXVtLgorICAgICAgICBUaGlzIGlzIHJlcXVp cmVkIGZvciBpbXBsZW1lbnRpbmcgdGhlIGRlbGV0aW9uIG9mIGFuIGF1dG9jb21wbGV0ZSBlbnRy eSBpbiBDaHJvbWl1bS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI0NjI1CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJv bWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cENvbnRhaW5lcjo6c2VsZWN0ZWRJbmRl eCk6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uaDoKKwog MjAwOS0wMy0xNiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2aXNpb24gNDE3MzQpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDgwLDYgKzQ4MCwxMSBAQCB2b2lkIFBvcHVwQ29udGFpbmVyOjpyZWZyZXNoKCkK ICAgICBsYXlvdXQoKTsKIH0KIAoraW50IFBvcHVwQ29udGFpbmVyOjpzZWxlY3RlZEluZGV4KCkg Y29uc3QKK3sKKyAgICByZXR1cm4gbV9saXN0Qm94LT5zZWxlY3RlZEluZGV4KCk7Cit9CisKIC8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8KIC8vIFBvcHVwTGlzdEJveCBpbXBsZW1lbnRhdGlvbgogCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5oCShy ZXZpc2lvbiA0MTczNCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hy b21pdW0uaAkod29ya2luZyBjb3B5KQpAQCAtMTA3LDYgKzEwNywxMCBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKICAgICAgICAgUG9wdXBMaXN0Qm94KiBsaXN0Qm94KCkgY29uc3QgeyByZXR1cm4g bV9saXN0Qm94LmdldCgpOyB9CiAKKyAgICAgICAgLy8gR2V0cyB0aGUgaW5kZXggb2YgdGhlIGl0 ZW0gdGhhdCB0aGUgdXNlciBpcyBjdXJyZW50bHkgbW91c2VkLW92ZXIgb3IKKyAgICAgICAgLy8g aGFzIHNlbGVjdGVkIHdpdGggdGhlIGtleWJvYXJkIHVwL2Rvd24gYXJyb3dzLgorICAgICAgICBp bnQgc2VsZWN0ZWRJbmRleCgpIGNvbnN0OworCiAgICAgICAgIC8vIFJlZnJlc2ggdGhlIHBvcHVw IHZhbHVlcyBmcm9tIHRoZSBQb3B1cE1lbnVDbGllbnQuCiAgICAgICAgIHZvaWQgcmVmcmVzaCgp OwogCg==