24621 2009-03-16 09:08:27 -0700 PositionIterator doesn't iterate "after last child" positions when going backwards 2012-05-29 23:47:19 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All ASSIGNED P2 Normal --- 24576 1 darin darin antaryami.pandia ap enrica eric leviw rniwa oldest_to_newest 113877 0 darin 2009-03-16 09:08:27 -0700 For example, consider a <table> element with these children: text node <tbody> text node The PositionIterator won't iterate to the <table> element position offset 3. This is causing various editing bugs, including problems uncovered by my changes for bug 24576. 113927 1 darin 2009-03-16 14:48:09 -0700 The problem was narrower in scope than I thought, and only affects backwards iteration; without my other changes I couldn’t find any behavior changes. 113929 2 28660 darin 2009-03-16 14:52:27 -0700 Created attachment 28660 patch 115065 3 adele 2009-03-24 15:42:12 -0700 Is it possible to make a layout test for this? 115066 4 darin 2009-03-24 15:59:31 -0700 (In reply to comment #3) > Is it possible to make a layout test for this? No. There’s no direct effect of this change alone. It simply prevents certain other changes from causing bugs. 115694 5 darin 2009-03-28 12:48:00 -0700 This seems like the kind of patch Eric might want to review. 115824 6 28660 eric 2009-03-30 09:12:42 -0700 Comment on attachment 28660 patch Sigh. We really need a way to add c++ unit tests to WebCore. Also, I'm about to re-write increment and decrement as part of bug 24854. Still debugging why my (obsoleted) change on that bug causes regressions. 115825 7 28660 eric 2009-03-30 09:15:16 -0700 Comment on attachment 28660 patch Yup, looks fine. 115826 8 eric 2009-03-30 09:16:37 -0700 Nevermind, the interesting parts of bug 24854 haven't been posted from my git repo yet, even in obsoleted form. 116138 9 darin 2009-03-31 21:42:01 -0700 http://trac.webkit.org/changeset/42147 116142 10 darin 2009-03-31 23:43:54 -0700 Seems to have caused regression test failures. Reopening the bug for now. 116143 11 28660 darin 2009-03-31 23:44:14 -0700 Comment on attachment 28660 patch Clearing the review flag until I find out what's wrong. 116145 12 eric 2009-04-01 00:03:15 -0700 I had the same PositionIterator constructor change in my recent PositionIterator re-write and also saw lots of regressions. I think that might have been the source of the regression. 634879 13 darin 2012-05-27 21:51:25 -0700 Thought the modern day editing experts might be interested in my struggle from three years ago. This was never resolved. 28660 2009-03-16 14:52:27 -0700 2010-06-11 13:35:46 -0700 patch PositionIteratorPatch.txt text/plain 3723 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTc0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDMtMTYgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy NDYyMTogUG9zaXRpb25JdGVyYXRvciBkb2Vzbid0IGl0ZXJhdGUgImFmdGVyIGxhc3QgY2hpbGQi IHBvc2l0aW9ucyB3aGVuIGdvaW5nIGJhY2t3YXJkcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ2MjEKKworICAgICAgICAqIGRvbS9Qb3NpdGlvbkl0 ZXJhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvc2l0aW9uSXRlcmF0b3I6OmRlY3JlbWVu dCk6IE1ha2Ugc3VyZSB0aGF0IHdoZW4gdGhlIHBhcmVudCBoYXMgbm8gY2hpbGRyZW4sIHdlCisg ICAgICAgIGRvbid0IGV2ZXIgdXNlIFBvc2l0aW9uOjp1bmNoZWNrZWRQcmV2aW91c09mZnNldC4g VGhpcyBpcyBjb25zaXN0ZW50IHdpdGggdGhlIGZvcndhcmQKKyAgICAgICAgaXRlcmF0b3IsIGJ1 dCBhbHNvIHNob3VsZCBuZXZlciBhcmlzZSBiZWNhdXNlIG9mIHRoZSBmaXggYmVsb3cuCisgICAg ICAgICogZG9tL1Bvc2l0aW9uSXRlcmF0b3IuaDoKKyAgICAgICAgKFdlYkNvcmU6OlBvc2l0aW9u SXRlcmF0b3I6OlBvc2l0aW9uSXRlcmF0b3IpOiBGaXhlZCBzbyBtX29mZnNldCB3aWxsIGFsd2F5 cyBiZSAwIHdoZW4KKyAgICAgICAgdGhlIHBhc3NlZC1pbiBub2RlIGhhcyBubyBjaGlsZHJlbi4g TGlrZSB0aGUgY2hhbmdlIGFib3ZlLCB0aGlzIGlzIGNvbnNpc3RlbnQgd2l0aCB0aGUgcmVzdAor ICAgICAgICBvZiB0aGUgY2xhc3MsIGFsdGhvdWdoIGluIHRoZSBsb25nIHJ1biBJIHRoaW5rIGl0 J3MgYSBiaXQgc3RyYW5nZSB0byB0cmVhdCBhIDxwPiBlbGVtZW50CisgICAgICAgIHdpdGggbm8g Y2hpbGRyZW4gZGlmZmVyZW50bHkgdGhhbiBhIDxwPiBlbGVtZW50IHdpdGggY2hpbGRyZW4uCisK IDIwMDktMDMtMTIgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEVyaWMgU2VpZGVsCkluZGV4OiBXZWJDb3JlL2RvbS9Qb3NpdGlvbkl0ZXJhdG9y LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Qb3NpdGlvbkl0ZXJhdG9yLmNwcAkocmV2 aXNpb24gNDE3MzUpCisrKyBXZWJDb3JlL2RvbS9Qb3NpdGlvbkl0ZXJhdG9yLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDcsIDIwMDgg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA3LCAy MDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3Ry aWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhv dXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucwpAQCAtNzksMTQgKzc5LDE1IEBAIHZvaWQgUG9zaXRpb25JdGVyYXRv cjo6ZGVjcmVtZW50KCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmIChtX29mZnNl dCkgewotICAgICAgICBtX29mZnNldCA9IFBvc2l0aW9uOjp1bmNoZWNrZWRQcmV2aW91c09mZnNl dChtX3BhcmVudCwgbV9vZmZzZXQpOworICAgIGlmIChtX3BhcmVudC0+aGFzQ2hpbGROb2Rlcygp KSB7CisgICAgICAgIEFTU0VSVCghbV9vZmZzZXQpOworICAgICAgICBtX3BhcmVudCA9IG1fcGFy ZW50LT5sYXN0Q2hpbGQoKTsKKyAgICAgICAgaWYgKCFtX3BhcmVudC0+aGFzQ2hpbGROb2Rlcygp KQorICAgICAgICAgICAgbV9vZmZzZXQgPSBtYXhEZWVwT2Zmc2V0KG1fcGFyZW50KTsKICAgICB9 IGVsc2UgewotICAgICAgICBpZiAobV9wYXJlbnQtPmhhc0NoaWxkTm9kZXMoKSkgewotICAgICAg ICAgICAgbV9wYXJlbnQgPSBtX3BhcmVudC0+bGFzdENoaWxkKCk7Ci0gICAgICAgICAgICBpZiAo IW1fcGFyZW50LT5oYXNDaGlsZE5vZGVzKCkpCi0gICAgICAgICAgICAgICAgbV9vZmZzZXQgPSBt YXhEZWVwT2Zmc2V0KG1fcGFyZW50KTsKLSAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgaWYgKG1f b2Zmc2V0KQorICAgICAgICAgICAgbV9vZmZzZXQgPSBQb3NpdGlvbjo6dW5jaGVja2VkUHJldmlv dXNPZmZzZXQobV9wYXJlbnQsIG1fb2Zmc2V0KTsKKyAgICAgICAgZWxzZSB7CiAgICAgICAgICAg ICBtX2NoaWxkID0gbV9wYXJlbnQ7CiAgICAgICAgICAgICBtX3BhcmVudCA9IG1fcGFyZW50LT5w YXJlbnROb2RlKCk7CiAgICAgICAgIH0KSW5kZXg6IFdlYkNvcmUvZG9tL1Bvc2l0aW9uSXRlcmF0 b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Qb3NpdGlvbkl0ZXJhdG9yLmgJKHJldmlz aW9uIDQxNzM1KQorKysgV2ViQ29yZS9kb20vUG9zaXRpb25JdGVyYXRvci5oCSh3b3JraW5nIGNv cHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwNywgMjAwOCBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDcsIDIwMDgs IDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAog ICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb25kaXRpb25zCkBAIC00MiwxOCArNDIsMTcgQEAgcHVibGljOgogICAgICAgICAsIG1fb2Zm c2V0KDApCiAgICAgewogICAgIH0KLQotICAgIFBvc2l0aW9uSXRlcmF0b3IoY29uc3QgUG9zaXRp b24mIHBvcykKLSAgICAgICAgOiBtX3BhcmVudChwb3Mubm9kZSgpKQotICAgICAgICAsIG1fY2hp bGQobV9wYXJlbnQtPmNoaWxkTm9kZShwb3MubV9vZmZzZXQpKQotICAgICAgICAsIG1fb2Zmc2V0 KG1fY2hpbGQgPyAwIDogcG9zLm1fb2Zmc2V0KQorICAgIFBvc2l0aW9uSXRlcmF0b3IoY29uc3Qg UG9zaXRpb24mIHBvc2l0aW9uKQorICAgICAgICA6IG1fcGFyZW50KHBvc2l0aW9uLm5vZGUoKSkK KyAgICAgICAgLCBtX2NoaWxkKG1fcGFyZW50LT5jaGlsZE5vZGUocG9zaXRpb24ubV9vZmZzZXQp KQorICAgICAgICAsIG1fb2Zmc2V0KG1fcGFyZW50LT5oYXNDaGlsZE5vZGVzKCkgPyAwIDogcG9z aXRpb24ubV9vZmZzZXQpCiAgICAgewogICAgIH0KLSAgICBvcGVyYXRvciBQb3NpdGlvbigpIGNv bnN0OwogCiAgICAgdm9pZCBpbmNyZW1lbnQoKTsKICAgICB2b2lkIGRlY3JlbWVudCgpOwogCisg ICAgb3BlcmF0b3IgUG9zaXRpb24oKSBjb25zdDsKICAgICBOb2RlKiBub2RlKCkgY29uc3QgeyBy ZXR1cm4gbV9wYXJlbnQ7IH0KICAgICBpbnQgb2Zmc2V0SW5MZWFmTm9kZSgpIGNvbnN0IHsgcmV0 dXJuIG1fb2Zmc2V0OyB9CiAK