246207 2022-10-07 03:14:47 -0700 Modules with invalid "type" assertion should throw 2022-10-15 01:26:02 -0700 1 1 1 Unclassified WebKit WebCore JavaScript Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 nribaudo ysuzuki mark.lam webkit-bug-importer ysuzuki oldest_to_newest 1904004 0 nribaudo 2022-10-07 03:14:47 -0700 Consider these two files: // main.js await import("./dep.js", { assert: { type: "<invalid>" } }); // dep.js console.log("Hi from dep!"); Step 6 of https://html.spec.whatwg.org/#fetch-an-import()-module-script-graph stops the import process if "type" is not a supported type assertion, so dep.js shouldn't be fetched and executed. However, WebKit ignores the "type" assertions and loads dep.js as JavaScript. Tested in Epiphani TP 43.0-12. I believe that this bug comes from the .value_or call at https://github.com/WebKit/WebKit/blob/5d0f369579801f91293bcae0845cca26c816ea44/Source/WebCore/bindings/js/ScriptModuleLoader.cpp#L318. 1905574 1 webkit-bug-importer 2022-10-14 03:15:18 -0700 <rdar://problem/101166148> 1905759 2 ysuzuki 2022-10-14 15:35:44 -0700 Pull request: https://github.com/WebKit/WebKit/pull/5399 1905843 3 ews-feeder 2022-10-15 01:26:00 -0700 Committed 255574@main (902de48a7da9): <https://commits.webkit.org/255574@main> Reviewed commits have been landed. Closing PR #5399 and removing active labels.