24619 2009-03-16 09:04:48 -0700 RenderObject::selectionStartEnd does not need to be a virtual function 2009-03-16 15:41:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Enhancement --- 1 darin darin oldest_to_newest 113874 0 darin 2009-03-16 09:04:48 -0700 The base class version of selectionStartEnd would work fine even for the one class, RenderView, that overrides it. It would be a small speedup to make the function non-virtual. 113875 1 28647 darin 2009-03-16 09:06:11 -0700 Created attachment 28647 patch 113939 2 darin 2009-03-16 15:41:36 -0700 trac.webkit.org/changeset/41748 28647 2009-03-16 09:06:11 -0700 2009-03-16 09:55:48 -0700 patch SelectionStartEndPatch.txt text/plain 1742 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTczMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMTYgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy NDYxOTogUmVuZGVyT2JqZWN0OjpzZWxlY3Rpb25TdGFydEVuZCBkb2VzIG5vdCBuZWVkIHRvIGJl IGEgdmlydHVhbCBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjQ2MTkKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuaDog UmVtb3ZlIHZpcnR1YWwga2V5d29yZCBmcm9tIHNlbGVjdGlvblN0YXJ0RW5kIGRlY2xhcmF0aW9u LgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3Lmg6IERpdHRvLgorCiAyMDA5LTAzLTE2 ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCShyZXZpc2lv biA0MTY2NikKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCSh3b3JraW5nIGNv cHkpCkBAIC02NTEsNyArNjUxLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBpbWFnZUNo YW5nZWQoV3JhcHBlZEltYWdlUHRyLCBjb25zdCBJbnRSZWN0KiA9IDApIHsgfQogICAgIHZpcnR1 YWwgYm9vbCB3aWxsUmVuZGVySW1hZ2UoQ2FjaGVkSW1hZ2UqKTsKIAotICAgIHZpcnR1YWwgdm9p ZCBzZWxlY3Rpb25TdGFydEVuZChpbnQmIHNwb3MsIGludCYgZXBvcykgY29uc3Q7CisgICAgdm9p ZCBzZWxlY3Rpb25TdGFydEVuZChpbnQmIHNwb3MsIGludCYgZXBvcykgY29uc3Q7CiAKICAgICBS ZW5kZXJPYmplY3QqIHBhaW50aW5nUm9vdEZvckNoaWxkcmVuKFBhaW50SW5mbyYgcGFpbnRJbmZv KSBjb25zdAogICAgIHsKSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmgJKHJldmlzaW9uIDQxNjY2 KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC05 OSw3ICs5OSw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgSW50UmVjdCB2aWV3UmVjdCgpIGNv bnN0OwogCi0gICAgdmlydHVhbCB2b2lkIHNlbGVjdGlvblN0YXJ0RW5kKGludCYgc3RhcnRQb3Ms IGludCYgZW5kUG9zKSBjb25zdDsKKyAgICB2b2lkIHNlbGVjdGlvblN0YXJ0RW5kKGludCYgc3Rh cnRQb3MsIGludCYgZW5kUG9zKSBjb25zdDsKIAogICAgIEludFJlY3QgcHJpbnRSZWN0KCkgY29u c3QgeyByZXR1cm4gbV9wcmludFJlY3Q7IH0KICAgICB2b2lkIHNldFByaW50UmVjdChjb25zdCBJ bnRSZWN0JiByKSB7IG1fcHJpbnRSZWN0ID0gcjsgfQo=