<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24608</bug_id>
          
          <creation_ts>2009-03-15 09:01:28 -0700</creation_ts>
          <short_desc>Missing include in KURLGoogle.cpp</short_desc>
          <delta_ts>2009-03-20 16:57:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Craig Schlenter">craig.schlenter</reporter>
          <assigned_to name="David Levin">levin</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>113827</commentid>
    <comment_count>0</comment_count>
    <who name="Craig Schlenter">craig.schlenter</who>
    <bug_when>2009-03-15 09:01:28 -0700</bug_when>
    <thetext>KURLGoogle.cpp uses printf when #ifndef NDEBUG is true which in turn means that stdio.h should be included in that situation. Found with gcc 4.4.0

I&apos;ll attach a patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>113828</commentid>
    <comment_count>1</comment_count>
      <attachid>28636</attachid>
    <who name="Craig Schlenter">craig.schlenter</who>
    <bug_when>2009-03-15 09:03:18 -0700</bug_when>
    <thetext>Created attachment 28636
patch to add missing include

Only tested on linux with chromium.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>114554</commentid>
    <comment_count>2</comment_count>
      <attachid>28636</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-03-20 14:26:11 -0700</bug_when>
    <thetext>Comment on attachment 28636
patch to add missing include

Don&apos;t forget to add a link to bug on ChangeLog entry when landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>114576</commentid>
    <comment_count>3</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-03-20 15:54:28 -0700</bug_when>
    <thetext>Please include a link to the bug in the changelog in the future.

Assigned to levin for landing.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>114606</commentid>
    <comment_count>4</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-03-20 16:57:35 -0700</bug_when>
    <thetext>Committed as r41881.

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28636</attachid>
            <date>2009-03-15 09:03:18 -0700</date>
            <delta_ts>2009-03-20 14:26:11 -0700</delta_ts>
            <desc>patch to add missing include</desc>
            <filename>webkit.2.diff</filename>
            <type>text/plain</type>
            <size>862</size>
            <attacher name="Craig Schlenter">craig.schlenter</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0MTcxNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTEgQEAKKzIwMDktMDMtMTUgIENyYWlnIFNjaGxlbnRlciAgPGNyYWlnLnNjaGxl
bnRlckBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgSW5jbHVkZSBzdGRpby5oIG5lZWRlZCBmb3IgcHJpbnRmIG9uIGdjYyA0LjQuMAor
CisgICAgICAgICogcGxhdGZvcm0vS1VSTEdvb2dsZS5jcHA6CisKIDIwMDktMDMtMTUgIEFsZXhl
eSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh
cmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9LVVJMR29vZ2xlLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL0tVUkxHb29nbGUuY3BwCShyZXZpc2lvbiA0MTcxNikK
KysrIFdlYkNvcmUvcGxhdGZvcm0vS1VSTEdvb2dsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMz
LDYgKzMzLDEwIEBACiAjaWYgVVNFKEdPT0dMRVVSTCkKICNpbmNsdWRlICJLVVJMLmgiCiAKKyNp
Zm5kZWYgTkRFQlVHCisjaW5jbHVkZSA8c3RkaW8uaD4KKyNlbmRpZgorCiAjaW5jbHVkZSAiQ1N0
cmluZy5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiVGV4dEVuY29k
aW5nLmgiCg==
</data>
<flag name="review"
          id="14098"
          type_id="1"
          status="+"
          setter="dglazkov"
    />
          </attachment>
      

    </bug>

</bugzilla>