24600 2009-03-14 15:04:52 -0700 [GTK] responses with status code >= 400 should not be given special treatment 2009-03-25 07:50:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk, Soup P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 113781 0 gustavo 2009-03-14 15:04:52 -0700 Current code avoids calling gotHeaders and gotChunk for messages that are not "successful". This makes them skip things such as content sniffing, and would hog the memory for responses with big bodies, were accumulate not disabled =). This last fact is the reason why error pages with content, such as plone.org's 404 pages are not displayed. 113782 1 28630 gustavo 2009-03-14 15:07:26 -0700 Created attachment 28630 proposed fix 114052 2 zecke 2009-03-17 10:26:17 -0700 Okay, any idea about the impact on the http tests? 114075 3 gustavo 2009-03-17 12:31:26 -0700 (In reply to comment #2) > Okay, any idea about the impact on the http tests? > I was getting some tests fixed, and one regression. I have reworked the patch to fix the xmlhttprequest regression, and we are now down to 2 failing tests, and no crash, in my tests. I'm going to upload the patch now. 114076 4 28695 gustavo 2009-03-17 12:33:42 -0700 Created attachment 28695 proposed fix This patch differs from the other in that it also does not give special treatment to 304 regarding gotHeaders and gotChunk, but does avoid trying a content sniff on it. On my local setup, I get the following impact on the http tests: Without the patch: Fails: http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html http/tests/xmlhttprequest/web-apps/013.html Crashes: http/tests/xmlhttprequest/web-apps/002-simple.html With the patch: Fails: http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html 114098 5 28630 gustavo 2009-03-17 14:17:46 -0700 Comment on attachment 28630 proposed fix Forgot to obsolete when uploading the new one. 115114 6 28695 zecke 2009-03-25 00:17:24 -0700 Comment on attachment 28695 proposed fix > + if ((msg->status_code != SOUP_STATUS_NOT_MODIFIED) > + &&!soup_message_headers_get_content_type(msg->response_headers, NULL)) style. put a space in there... 115142 7 gustavo 2009-03-25 07:50:12 -0700 Landed as r41974 with the style fix. 28630 2009-03-14 15:07:26 -0700 2009-03-17 14:17:46 -0700 proposed fix error-responses.patch text/plain 3014 gustavo RnJvbSAxNDU1YzBmMTdmMjJjOTZhOTU2NmQ0NjI1ZDdhYzVlOTQ5MDUzOTAzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBTYXQsIDE0IE1hciAyMDA5IDE4OjEzOjEwIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g RG8gbm90IHNwZWNpYWwgY2FzZSByZXF1ZXN0cyB0aGF0IGhhdmUgSFRUUCByZXNwb25zZXMgPiAy MDAuIFJlZGlyZWN0cwogYXJlIGhhbmRsZWQgYXV0b21hdGljYWxseSBieSBsaWJzb3VwLCBidXQg dGhlIHJlc3Qgb2YgdGhlIHJlc3BvbnNlcwogc2hvdWxkIGJlIHRyZWF0ZWQgbGlrZSBhbnkgb3Ro ZXIuCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv dXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgIDE2ICsrLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNzU0NWE5Li41NTY0MTdj IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDA5LTAzLTE0ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNA Z25vbWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIERvIG5vdCBzcGVjaWFsIGNhc2UgcmVxdWVzdHMgdGhhdCBoYXZlIEhUVFAgcmVzcG9uc2Vz ID49CisgICAgICAgIDQwMC4gUmVkaXJlY3RzIGFyZSBoYW5kbGVkIGF1dG9tYXRpY2FsbHkgYnkg bGlic291cCwgYnV0IHRoZSByZXN0CisgICAgICAgIG9mIHRoZSByZXNwb25zZXMgc2hvdWxkIGJl IHRyZWF0ZWQgbGlrZSBhbnkgb3RoZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oik6CisgICAgICAg IChXZWJDb3JlOjpnb3RIZWFkZXJzQ2FsbGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6Z290Q2h1 bmtDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpmaW5pc2hlZENhbGxiYWNrKToKKwogMjAw OS0wMy0xNCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCAzNGIyZDdmLi4xYzVjZTEzIDEw MDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv dXAuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxl U291cC5jcHAKQEAgLTE5OSw3ICsxOTksNyBAQCBzdGF0aWMgdm9pZCByZXN0YXJ0ZWRDYWxsYmFj ayhTb3VwTWVzc2FnZSogbXNnLCBncG9pbnRlciBkYXRhKQogCiBzdGF0aWMgdm9pZCBnb3RIZWFk ZXJzQ2FsbGJhY2soU291cE1lc3NhZ2UqIG1zZywgZ3BvaW50ZXIgZGF0YSkKIHsKLSAgICBpZiAo IVNPVVBfU1RBVFVTX0lTX1NVQ0NFU1NGVUwobXNnLT5zdGF0dXNfY29kZSkpCisgICAgaWYgKFNP VVBfU1RBVFVTX0lTX1RSQU5TUE9SVF9FUlJPUihtc2ctPnN0YXR1c19jb2RlKSB8fCBTT1VQX1NU QVRVU19JU19SRURJUkVDVElPTihtc2ctPnN0YXR1c19jb2RlKSkKICAgICAgICAgcmV0dXJuOwog CiAgICAgLy8gV2Ugc3RpbGwgZG9uJ3Qga25vdyBhbnl0aGluZyBhYm91dCBDb250ZW50LVR5cGUs IHNvIHdlIHdpbGwgdHJ5CkBAIC0yMjUsNyArMjI1LDcgQEAgc3RhdGljIHZvaWQgZ290SGVhZGVy c0NhbGxiYWNrKFNvdXBNZXNzYWdlKiBtc2csIGdwb2ludGVyIGRhdGEpCiAKIHN0YXRpYyB2b2lk IGdvdENodW5rQ2FsbGJhY2soU291cE1lc3NhZ2UqIG1zZywgU291cEJ1ZmZlciogY2h1bmssIGdw b2ludGVyIGRhdGEpCiB7Ci0gICAgaWYgKCFTT1VQX1NUQVRVU19JU19TVUNDRVNTRlVMKG1zZy0+ c3RhdHVzX2NvZGUpKQorICAgIGlmIChTT1VQX1NUQVRVU19JU19UUkFOU1BPUlRfRVJST1IobXNn LT5zdGF0dXNfY29kZSkgfHwgU09VUF9TVEFUVVNfSVNfUkVESVJFQ1RJT04obXNnLT5zdGF0dXNf Y29kZSkpCiAgICAgICAgIHJldHVybjsKIAogICAgIFJlc291cmNlSGFuZGxlKiBoYW5kbGUgPSBz dGF0aWNfY2FzdDxSZXNvdXJjZUhhbmRsZSo+KGRhdGEpOwpAQCAtMjc4LDE4ICsyNzgsNiBAQCBz dGF0aWMgdm9pZCBmaW5pc2hlZENhbGxiYWNrKFNvdXBTZXNzaW9uICpzZXNzaW9uLCBTb3VwTWVz c2FnZSogbXNnLCBncG9pbnRlciBkYQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgaWYg KCFTT1VQX1NUQVRVU19JU19TVUNDRVNTRlVMKG1zZy0+c3RhdHVzX2NvZGUpKSB7Ci0gICAgICAg IGZpbGxSZXNwb25zZUZyb21NZXNzYWdlKG1zZywgJmQtPm1fcmVzcG9uc2UpOwotICAgICAgICBj bGllbnQtPmRpZFJlY2VpdmVSZXNwb25zZShoYW5kbGUuZ2V0KCksIGQtPm1fcmVzcG9uc2UpOwot Ci0gICAgICAgIC8vIFdlYkNvcmUgbWlnaHQgaGF2ZSBjYW5jZWxsZWQgdGhlIGpvYiBpbiB0aGUg d2hpbGUKLSAgICAgICAgaWYgKGQtPm1fY2FuY2VsbGVkKQotICAgICAgICAgICAgcmV0dXJuOwot Ci0gICAgICAgIGlmIChtc2ctPnJlc3BvbnNlX2JvZHktPmRhdGEpCi0gICAgICAgICAgICBjbGll bnQtPmRpZFJlY2VpdmVEYXRhKGhhbmRsZS5nZXQoKSwgbXNnLT5yZXNwb25zZV9ib2R5LT5kYXRh LCBtc2ctPnJlc3BvbnNlX2JvZHktPmxlbmd0aCwgdHJ1ZSk7Ci0gICAgfQotCiAgICAgY2xpZW50 LT5kaWRGaW5pc2hMb2FkaW5nKGhhbmRsZS5nZXQoKSk7CiB9CiAKLS0gCjEuNi4yCgo= 28695 2009-03-17 12:33:42 -0700 2009-03-25 00:17:24 -0700 proposed fix 0001-Do-not-special-case-requests-that-have-HTTP-response.patch text/plain 3871 gustavo RnJvbSA5OWVjZTRhMzg1NDQ5M2FhOWRjZWFhMDNkODg2MGY2ZjZkNjg4NDE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBTYXQsIDE0IE1hciAyMDA5IDE4OjEzOjEwIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g RG8gbm90IHNwZWNpYWwgY2FzZSByZXF1ZXN0cyB0aGF0IGhhdmUgSFRUUCByZXNwb25zZXMgPiAy MDAuIFJlZGlyZWN0cwogYXJlIGhhbmRsZWQgYXV0b21hdGljYWxseSBieSBsaWJzb3VwLCBidXQg dGhlIHJlc3Qgb2YgdGhlIHJlc3BvbnNlcwogc2hvdWxkIGJlIHRyZWF0ZWQgbGlrZSBhbnkgb3Ro ZXIuCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxNCArKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNl SGFuZGxlU291cC5jcHAgICB8ICAgMjggKysrKysrKystLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFu Z2VkLCAyNiBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNkNzYwNTIuLjJlNzczYWQg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDMtMTcgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bn bm9tZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRG8gbm90IHNwZWNpYWwgY2FzZSByZXF1ZXN0cyB0aGF0IGhhdmUgSFRUUCByZXNwb25zZXMg Pj0KKyAgICAgICAgNDAwLiBSZWRpcmVjdHMgYXJlIGhhbmRsZWQgYXV0b21hdGljYWxseSBieSBs aWJzb3VwLCBidXQgdGhlIHJlc3QKKyAgICAgICAgb2YgdGhlIHJlc3BvbnNlcyBzaG91bGQgYmUg dHJlYXRlZCBsaWtlIGFueSBvdGhlci4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291 cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6KToKKyAgICAgICAg KFdlYkNvcmU6OmdvdEhlYWRlcnNDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpnb3RDaHVu a0NhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OmZpbmlzaGVkQ2FsbGJhY2spOgorCiAyMDA5 LTAzLTE3ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICAqIGluc3Bl Y3Rvci9Db25zb2xlTWVzc2FnZS5jcHA6CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCBiMmI5ODFiLi44NjczNTE3IDEw MDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv dXAuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxl U291cC5jcHAKQEAgLTIwOCwxMyArMjA4LDIwIEBAIHN0YXRpYyB2b2lkIHJlc3RhcnRlZENhbGxi YWNrKFNvdXBNZXNzYWdlKiBtc2csIGdwb2ludGVyIGRhdGEpCiAKIHN0YXRpYyB2b2lkIGdvdEhl YWRlcnNDYWxsYmFjayhTb3VwTWVzc2FnZSogbXNnLCBncG9pbnRlciBkYXRhKQogewotICAgIGlm ICghU09VUF9TVEFUVVNfSVNfU1VDQ0VTU0ZVTChtc2ctPnN0YXR1c19jb2RlKSkKKyAgICAvLyBU aGUgMzA0IHN0YXR1cyBjb2RlIChTT1VQX1NUQVRVU19OT1RfTU9ESUZJRUQpIG5lZWRzIHRvIGJl IGZlZAorICAgIC8vIGludG8gV2ViQ29yZSwgYXMgb3Bwb3NlZCB0byBvdGhlciBraW5kcyBvZiBy ZWRpcmVjdGlvbnMsIHdoaWNoCisgICAgLy8gYXJlIGhhbmRsZWQgYnkgc291cCBkaXJlY3RseSwg c28gd2Ugc3BlY2lhbC1jYXNlIGl0IGhlcmUgYW5kIGluCisgICAgLy8gZ290Q2h1bmsuCisgICAg aWYgKFNPVVBfU1RBVFVTX0lTX1RSQU5TUE9SVF9FUlJPUihtc2ctPnN0YXR1c19jb2RlKQorICAg ICAgICB8fCAoU09VUF9TVEFUVVNfSVNfUkVESVJFQ1RJT04obXNnLT5zdGF0dXNfY29kZSkgJiYg KG1zZy0+c3RhdHVzX2NvZGUgIT0gU09VUF9TVEFUVVNfTk9UX01PRElGSUVEKSkpCiAgICAgICAg IHJldHVybjsKIAogICAgIC8vIFdlIHN0aWxsIGRvbid0IGtub3cgYW55dGhpbmcgYWJvdXQgQ29u dGVudC1UeXBlLCBzbyB3ZSB3aWxsIHRyeQogICAgIC8vIHNuaWZmaW5nIHRoZSBjb250ZW50cyBv ZiB0aGUgZmlsZSwgYW5kIHRoZW4gcmVwb3J0IHRoYXQgd2UgZ290Ci0gICAgLy8gaGVhZGVycwot ICAgIGlmICghc291cF9tZXNzYWdlX2hlYWRlcnNfZ2V0X2NvbnRlbnRfdHlwZShtc2ctPnJlc3Bv bnNlX2hlYWRlcnMsIE5VTEwpKQorICAgIC8vIGhlYWRlcnM7IHdlIHdpbGwgbm90IGRvIGNvbnRl bnQgc25pZmZpbmcgZm9yIDMwNCByZXNwb25zZXMsCisgICAgLy8gdGhvdWdoLCBzaW5jZSB0aGV5 IGRvIG5vdCBoYXZlIGEgYm9keS4KKyAgICBpZiAoKG1zZy0+c3RhdHVzX2NvZGUgIT0gU09VUF9T VEFUVVNfTk9UX01PRElGSUVEKQorICAgICAgICAmJiFzb3VwX21lc3NhZ2VfaGVhZGVyc19nZXRf Y29udGVudF90eXBlKG1zZy0+cmVzcG9uc2VfaGVhZGVycywgTlVMTCkpCiAgICAgICAgIHJldHVy bjsKIAogICAgIFJlc291cmNlSGFuZGxlKiBoYW5kbGUgPSBzdGF0aWNfY2FzdDxSZXNvdXJjZUhh bmRsZSo+KGRhdGEpOwpAQCAtMjM0LDcgKzI0MSw4IEBAIHN0YXRpYyB2b2lkIGdvdEhlYWRlcnND YWxsYmFjayhTb3VwTWVzc2FnZSogbXNnLCBncG9pbnRlciBkYXRhKQogCiBzdGF0aWMgdm9pZCBn b3RDaHVua0NhbGxiYWNrKFNvdXBNZXNzYWdlKiBtc2csIFNvdXBCdWZmZXIqIGNodW5rLCBncG9p bnRlciBkYXRhKQogewotICAgIGlmICghU09VUF9TVEFUVVNfSVNfU1VDQ0VTU0ZVTChtc2ctPnN0 YXR1c19jb2RlKSkKKyAgICBpZiAoU09VUF9TVEFUVVNfSVNfVFJBTlNQT1JUX0VSUk9SKG1zZy0+ c3RhdHVzX2NvZGUpCisgICAgICAgIHx8IChTT1VQX1NUQVRVU19JU19SRURJUkVDVElPTihtc2ct PnN0YXR1c19jb2RlKSAmJiAobXNnLT5zdGF0dXNfY29kZSAhPSBTT1VQX1NUQVRVU19OT1RfTU9E SUZJRUQpKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSA9 IHN0YXRpY19jYXN0PFJlc291cmNlSGFuZGxlKj4oZGF0YSk7CkBAIC0yODcsMTggKzI5NSw2IEBA IHN0YXRpYyB2b2lkIGZpbmlzaGVkQ2FsbGJhY2soU291cFNlc3Npb24gKnNlc3Npb24sIFNvdXBN ZXNzYWdlKiBtc2csIGdwb2ludGVyIGRhCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBp ZiAoIVNPVVBfU1RBVFVTX0lTX1NVQ0NFU1NGVUwobXNnLT5zdGF0dXNfY29kZSkpIHsKLSAgICAg ICAgZmlsbFJlc3BvbnNlRnJvbU1lc3NhZ2UobXNnLCAmZC0+bV9yZXNwb25zZSk7Ci0gICAgICAg IGNsaWVudC0+ZGlkUmVjZWl2ZVJlc3BvbnNlKGhhbmRsZS5nZXQoKSwgZC0+bV9yZXNwb25zZSk7 Ci0KLSAgICAgICAgLy8gV2ViQ29yZSBtaWdodCBoYXZlIGNhbmNlbGxlZCB0aGUgam9iIGluIHRo ZSB3aGlsZQotICAgICAgICBpZiAoZC0+bV9jYW5jZWxsZWQpCi0gICAgICAgICAgICByZXR1cm47 Ci0KLSAgICAgICAgaWYgKG1zZy0+cmVzcG9uc2VfYm9keS0+ZGF0YSkKLSAgICAgICAgICAgIGNs aWVudC0+ZGlkUmVjZWl2ZURhdGEoaGFuZGxlLmdldCgpLCBtc2ctPnJlc3BvbnNlX2JvZHktPmRh dGEsIG1zZy0+cmVzcG9uc2VfYm9keS0+bGVuZ3RoLCB0cnVlKTsKLSAgICB9Ci0KICAgICBjbGll bnQtPmRpZEZpbmlzaExvYWRpbmcoaGFuZGxlLmdldCgpKTsKIH0KIAotLSAKMS42LjIKCg==