245982 2022-10-03 14:49:37 -0700 [WinCairo] PageUp and PageDown keys don't start the smooth keyboard scrolling 2022-10-05 02:58:18 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii basuke destra don.olmstead ews-watchlist mifenton richard_robinson2 ross.kirsling thorton webkit-bug-importer oldest_to_newest 1902935 0 fujii 2022-10-03 14:49:37 -0700 [WinCairo] PageUp, PageDown, Home and End keys don't start keyboard scroll 255031@main (bug#228159) enabled EventHandlerDrivenSmoothKeyboardScrollingEnabled. It works nicely for Arrow keys, Space key and Shift+Space key, but for PageUp, PageDown, Home and End keys. 1903024 1 fujii 2022-10-03 21:02:49 -0700 241197@main (bug#229733) fixed PageUp and PageDown for the smooth keyboard scrolling. But, 252663@main (bug#242523) removed the code. Mac port is using EditCommand (ScrollPageBackward and ScrollPageForward) for PageUp and PageDown now. 1903034 2 462779 fujii 2022-10-03 21:51:26 -0700 Created attachment 462779 WIP patch 1903332 3 fujii 2022-10-04 22:07:20 -0700 fast/dom/horizontal-scrollbar-in-rtl.html is failing for mac-wk2. I will split apart EditorCommand.cpp part into another patch. 1903334 4 462805 fujii 2022-10-04 22:24:37 -0700 Created attachment 462805 Patch 1903348 5 462805 ross.kirsling 2022-10-05 00:22:58 -0700 Comment on attachment 462805 Patch r=me 1903374 6 ews-feeder 2022-10-05 02:57:00 -0700 Committed 255162@main (c00cdc0f009b): <https://commits.webkit.org/255162@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462805. 1903375 7 webkit-bug-importer 2022-10-05 02:58:18 -0700 <rdar://problem/100801142> 462779 2022-10-03 21:51:26 -0700 2022-10-04 22:24:31 -0700 WIP patch wip.patch text/plain 2395 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yQ29tbWFuZC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvckNvbW1hbmQuY3BwCmluZGV4IGYwY2ZlODc0YzRh ZC4uMjdmODlkYzNiYTYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRv ckNvbW1hbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yQ29tbWFuZC5j cHAKQEAgLTEwMzksMTEgKzEwMzksMTcgQEAgc3RhdGljIGJvb2wgZXhlY3V0ZVNjcm9sbExpbmVE b3duKEZyYW1lJiBmcmFtZSwgRXZlbnQqLCBFZGl0b3JDb21tYW5kU291cmNlLCBjb24KIAogc3Rh dGljIGJvb2wgZXhlY3V0ZVNjcm9sbFRvQmVnaW5uaW5nT2ZEb2N1bWVudChGcmFtZSYgZnJhbWUs IEV2ZW50KiwgRWRpdG9yQ29tbWFuZFNvdXJjZSwgY29uc3QgU3RyaW5nJikKIHsKKyAgICBpZiAo ZnJhbWUuZXZlbnRIYW5kbGVyKCkuc2hvdWxkVXNlU21vb3RoS2V5Ym9hcmRTY3JvbGxpbmdGb3JG b2N1c2VkU2Nyb2xsYWJsZUFyZWEoKSkKKyAgICAgICAgcmV0dXJuIGZyYW1lLmV2ZW50SGFuZGxl cigpLmtleWJvYXJkU2Nyb2xsUmVjdXJzaXZlbHkoU2Nyb2xsRGlyZWN0aW9uOjpTY3JvbGxVcCwg U2Nyb2xsR3JhbnVsYXJpdHk6OkRvY3VtZW50LCBudWxscHRyKTsKKwogICAgIHJldHVybiBmcmFt ZS5ldmVudEhhbmRsZXIoKS5sb2dpY2FsU2Nyb2xsUmVjdXJzaXZlbHkoU2Nyb2xsQmxvY2tEaXJl Y3Rpb25CYWNrd2FyZCwgU2Nyb2xsR3JhbnVsYXJpdHk6OkRvY3VtZW50KTsKIH0KIAogc3RhdGlj IGJvb2wgZXhlY3V0ZVNjcm9sbFRvRW5kT2ZEb2N1bWVudChGcmFtZSYgZnJhbWUsIEV2ZW50Kiwg RWRpdG9yQ29tbWFuZFNvdXJjZSwgY29uc3QgU3RyaW5nJikKIHsKKyAgICBpZiAoZnJhbWUuZXZl bnRIYW5kbGVyKCkuc2hvdWxkVXNlU21vb3RoS2V5Ym9hcmRTY3JvbGxpbmdGb3JGb2N1c2VkU2Ny b2xsYWJsZUFyZWEoKSkKKyAgICAgICAgcmV0dXJuIGZyYW1lLmV2ZW50SGFuZGxlcigpLmtleWJv YXJkU2Nyb2xsUmVjdXJzaXZlbHkoU2Nyb2xsRGlyZWN0aW9uOjpTY3JvbGxEb3duLCBTY3JvbGxH cmFudWxhcml0eTo6RG9jdW1lbnQsIG51bGxwdHIpOworCiAgICAgcmV0dXJuIGZyYW1lLmV2ZW50 SGFuZGxlcigpLmxvZ2ljYWxTY3JvbGxSZWN1cnNpdmVseShTY3JvbGxCbG9ja0RpcmVjdGlvbkZv cndhcmQsIFNjcm9sbEdyYW51bGFyaXR5OjpEb2N1bWVudCk7CiB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3dpbi9XZWJQYWdlV2luLmNwcCBiL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3dpbi9XZWJQYWdlV2luLmNwcAppbmRleCBjNzdm Zjc4Y2QzY2QuLjE1NWQ3NGUyZDY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJQYWdlL3dpbi9XZWJQYWdlV2luLmNwcApAQCAtODcsMTYgKzg3LDE2IEBAIGJvb2wg V2ViUGFnZTo6cGVyZm9ybURlZmF1bHRCZWhhdmlvckZvcktleUV2ZW50KGNvbnN0IFdlYktleWJv YXJkRXZlbnQmIGtleWJvYXJkCiAgICAgICAgIHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNjcm9sbERv d24sIFNjcm9sbEdyYW51bGFyaXR5OjpMaW5lKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBW S19IT01FOgotICAgICAgICBzY3JvbGwobV9wYWdlLmdldCgpLCBTY3JvbGxVcCwgU2Nyb2xsR3Jh bnVsYXJpdHk6OkRvY3VtZW50KTsKKyAgICAgICAgZXhlY3V0ZUVkaXRDb21tYW5kKCJTY3JvbGxU b0JlZ2lubmluZ09mRG9jdW1lbnQiX3MsIHsgfSk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2Ug VktfRU5EOgotICAgICAgICBzY3JvbGwobV9wYWdlLmdldCgpLCBTY3JvbGxEb3duLCBTY3JvbGxH cmFudWxhcml0eTo6RG9jdW1lbnQpOworICAgICAgICBleGVjdXRlRWRpdENvbW1hbmQoIlNjcm9s bFRvRW5kT2ZEb2N1bWVudCJfcywgeyB9KTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBWS19Q UklPUjoKLSAgICAgICAgc2Nyb2xsKG1fcGFnZS5nZXQoKSwgU2Nyb2xsVXAsIFNjcm9sbEdyYW51 bGFyaXR5OjpQYWdlKTsKKyAgICAgICAgZXhlY3V0ZUVkaXRDb21tYW5kKCJTY3JvbGxQYWdlQmFj a3dhcmQiX3MsIHsgfSk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgVktfTkVYVDoKLSAgICAg ICAgc2Nyb2xsKG1fcGFnZS5nZXQoKSwgU2Nyb2xsRG93biwgU2Nyb2xsR3JhbnVsYXJpdHk6OlBh Z2UpOworICAgICAgICBleGVjdXRlRWRpdENvbW1hbmQoIlNjcm9sbFBhZ2VGb3J3YXJkIl9zLCB7 IH0pOwogICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAgICByZXR1cm4gZmFsc2U7 Cg== 462805 2022-10-04 22:24:37 -0700 2022-10-05 02:57:01 -0700 Patch bug-245982-20221005142436.patch text/plain 2456 fujii RnJvbSA3NTlmYzUxNjBjNTEzYTViMWQ0ODZkNDAxMDA1OGI5NmMzOTVkNjRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFdlZCwgNSBPY3QgMjAyMiAxNDowODozNyArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IFtXaW5DYWlyb10gUGFnZVVwIGFuZCBQYWdlRG93biBrZXlzIGRvbid0IHN0YXJ0IHRoZSBzbW9v dGgKIGtleWJvYXJkIHNjcm9sbGluZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjQ1OTgyCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCjI1MjY2M0BtYWluIHJl bW92ZWQgdGhlIGNvZGUgdG8gc3RhcnQgdGhlIHNtb290aCBrZXlib2FyZCBzY3JvbGxpbmcKZm9y IFBhZ2VVcCBhbmQgUGFnZURvd24ga2V5cyBpbiBFdmVudEhhbmRsZXIuIE1hYyBwb3J0IGlzIGV4 ZWN1dGluZwpTY3JvbGxQYWdlQmFja3dhcmQgYW5kIFNjcm9sbFBhZ2VGb3J3YXJkIEVkaXRDb21t YW5kcyBmb3IgdGhlbS4gRG8gdGhlCnNhbWUgZm9yIFdpbkNhaXJvLgoKRm9yIEhvbWUgYW5kIEVu ZCBrZXlzLCBNYWMgcG9ydCBpcyBleGVjdXRpbmcKU2Nyb2xsVG9CZWdpbm5pbmdPZkRvY3VtZW50 IGFuZCBTY3JvbGxUb0VuZE9mRG9jdW1lbnQgRWRpdENvbW1hbmRzLgpUaGlzIGNoYW5nZSBkb2Vz IHNvIGZvciBXaW5DYWlybyB0b28uIEhvd2V2ZXIsIHRoZSBzbW9vdGgga2V5Ym9hcmQKc2Nyb2xs aW5nIHN0aWxsIGRvZXNuJ3Qgd29yayBmb3IgV2luQ2Fpcm8gYmVjYXVzZSAyNTI2NjNAbWFpbiBh ZGRlZAp0aGUgc21vb3RoIGtleWJvYXJkIHNjcm9sbGluZyBjb2RlIG9ubHkgZm9yIFNjcm9sbFBh Z2VCYWNrd2FyZCBhbmQKU2Nyb2xsUGFnZUZvcndhcmQgRWRpdENvbW1hbmRzIGJ1dCBmb3IgU2Ny b2xsVG9CZWdpbm5pbmdPZkRvY3VtZW50IGFuZApTY3JvbGxUb0VuZE9mRG9jdW1lbnQgRWRpdENv bW1hbmRzLiBBIGZvbGxvdy11cCB3aWxsIGZpeCB0aGUgcHJvYmxlbS4KCiogU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwOgooV2ViS2l0OjpXZWJQYWdl OjpwZXJmb3JtRGVmYXVsdEJlaGF2aW9yRm9yS2V5RXZlbnQpOiBFeGVjdXRlCkVkaXRDb21tYW5k cyBmb3IgSG9tZSwgRW5kLCBQYWdlVXAsIFBhZ2VEb3duIGtleXMuCi0tLQogU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwIHwgOCArKysrLS0tLQogMSBm aWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS93aW4vV2ViUGFnZVdpbi5jcHAgYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS93aW4vV2ViUGFnZVdpbi5jcHAKaW5kZXgg Yzc3ZmY3OGNkM2NkLi4xNTVkNzRlMmQ2NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJQYWdlL3dpbi9XZWJQYWdlV2luLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViUGFnZS93aW4vV2ViUGFnZVdpbi5jcHAKQEAgLTg3LDE2ICs4NywxNiBAQCBi b29sIFdlYlBhZ2U6OnBlcmZvcm1EZWZhdWx0QmVoYXZpb3JGb3JLZXlFdmVudChjb25zdCBXZWJL ZXlib2FyZEV2ZW50JiBrZXlib2FyZAogICAgICAgICBzY3JvbGwobV9wYWdlLmdldCgpLCBTY3Jv bGxEb3duLCBTY3JvbGxHcmFudWxhcml0eTo6TGluZSk7CiAgICAgICAgIGJyZWFrOwogICAgIGNh c2UgVktfSE9NRToKLSAgICAgICAgc2Nyb2xsKG1fcGFnZS5nZXQoKSwgU2Nyb2xsVXAsIFNjcm9s bEdyYW51bGFyaXR5OjpEb2N1bWVudCk7CisgICAgICAgIGV4ZWN1dGVFZGl0Q29tbWFuZCgiU2Ny b2xsVG9CZWdpbm5pbmdPZkRvY3VtZW50Il9zLCB7IH0pOwogICAgICAgICBicmVhazsKICAgICBj YXNlIFZLX0VORDoKLSAgICAgICAgc2Nyb2xsKG1fcGFnZS5nZXQoKSwgU2Nyb2xsRG93biwgU2Ny b2xsR3JhbnVsYXJpdHk6OkRvY3VtZW50KTsKKyAgICAgICAgZXhlY3V0ZUVkaXRDb21tYW5kKCJT Y3JvbGxUb0VuZE9mRG9jdW1lbnQiX3MsIHsgfSk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2Ug VktfUFJJT1I6Ci0gICAgICAgIHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNjcm9sbFVwLCBTY3JvbGxH cmFudWxhcml0eTo6UGFnZSk7CisgICAgICAgIGV4ZWN1dGVFZGl0Q29tbWFuZCgiU2Nyb2xsUGFn ZUJhY2t3YXJkIl9zLCB7IH0pOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFZLX05FWFQ6Ci0g ICAgICAgIHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNjcm9sbERvd24sIFNjcm9sbEdyYW51bGFyaXR5 OjpQYWdlKTsKKyAgICAgICAgZXhlY3V0ZUVkaXRDb21tYW5kKCJTY3JvbGxQYWdlRm9yd2FyZCJf cywgeyB9KTsKICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgcmV0dXJuIGZh bHNlOwo=