24594 2009-03-13 18:28:41 -0700 PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload 2009-03-30 17:19:45 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bolsinga darin ddkilzer oldest_to_newest 113747 0 bolsinga 2009-03-13 18:28:41 -0700 FrameLoaderClient::dispatchDecidePolicyForNavigationAction() always called w/ NavigationAction::type() == NavigationTypeOther This causes policy delegates to not be able to determine the action type. It appears that this comes from the code path FrameLoader::loadWithDocumentLoader(), when not scrolling to an anchor. In this code path, the DocumentLoader::triggeringAction().isEmpty is true, and this is where the 'other' comes from. Add the following patch to the MiniBrowser project. You'll see that the WebActionNavigationTypeKey is always 5, which is WebNavigationTypeOther. Index: MyDocument.m =================================================================== --- MyDocument.m (revision 20870) +++ MyDocument.m (working copy) @@ -128,6 +128,7 @@ [webView setFrameLoadDelegate:self]; [webView setUIDelegate:self]; [webView setResourceLoadDelegate:self]; + [webView setPolicyDelegate:self]; // Load a default URL NSURL *URL = URLToLoad != nil ? URLToLoad : [NSURL URLWithString:@"http://www.apple.com"]; @@ -298,7 +299,16 @@ [self updateResourceStatus]; } +- (void)webView:(WebView *)webView decidePolicyForNavigationAction:(NSDictionary *)actionInformation + request:(NSURLRequest *)request + frame:(WebFrame *)frame + decisionListener:(id<WebPolicyDecisionListener>)listener +{ + NSLog(@"%@", actionInformation); + [listener use]; +} + // History Methods - (void)goToHistoryItem:(id)historyItem 113748 1 bolsinga 2009-03-13 18:38:16 -0700 <rdar://problem/6682110> 115937 2 29098 darin 2009-03-30 16:57:31 -0700 Created attachment 29098 patch 115942 3 29098 darin 2009-03-30 17:19:25 -0700 Comment on attachment 29098 patch Sam reviewed this. 115943 4 darin 2009-03-30 17:19:45 -0700 http://trac.webkit.org/changeset/42120 29098 2009-03-30 16:57:31 -0700 2009-03-30 17:19:25 -0700 patch ReloadPatch.txt text/plain 3896 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjExOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDMtMzAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy NDU5NDogUG9saWN5RGVsZWdhdGUgTmF2aWdhdGlvbkFjdGlvbiBpcyBXZWJOYXZpZ2F0aW9uVHlw ZU90aGVyIGluc3RlYWQgb2YgV2ViTmF2aWdhdGlvblR5cGVSZWxvYWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NTk0CisgICAgICAgIHJkYXI6Ly9w cm9ibGVtLzY2ODIxMTAKKworICAgICAgICBUZXN0OiBmYXN0L2xvYWRlci9yZWxvYWQtcG9saWN5 LWRlbGVnYXRlLmh0bWwKKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6bG9hZFdpdGhEb2N1bWVudExvYWRlcik6IFNldCB0 aGUgdHJpZ2dlcmluZyBhY3Rpb24gaGVyZSB3aGVyZSB3ZSBrbm93IGl0J3MKKyAgICAgICAgdGhl IHBvbGljeSBsb2FkZXIgYW5kIGNhbiB1c2UgbV9wb2xpY3lMb2FkVHlwZSByYXRoZXIgdGhhbiBs ZXR0aW5nIGl0IGdldCBzZXQgaW5zaWRlCisgICAgICAgIGNoZWNrTmF2aWdhdGlvblBvbGljeS4K KwogMjAwOS0wMy0zMCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4Mzg4NzE+IENyYXNoVHJhY2VyOiAxNDgzIGNyYXNoZXMg UXVpY2tsb29raW5nCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lvbiA0MjExOCkK KysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM1 NSw2ICsyMzU1LDggQEAgdm9pZCBGcmFtZUxvYWRlcjo6bG9hZFdpdGhEb2N1bWVudExvYWRlcgog CiAgICAgICAgIHN0b3BQb2xpY3lDaGVjaygpOwogICAgICAgICBzZXRQb2xpY3lEb2N1bWVudExv YWRlcihsb2FkZXIpOworICAgICAgICBpZiAobG9hZGVyLT50cmlnZ2VyaW5nQWN0aW9uKCkuaXNF bXB0eSgpKQorICAgICAgICAgICAgbG9hZGVyLT5zZXRUcmlnZ2VyaW5nQWN0aW9uKE5hdmlnYXRp b25BY3Rpb24obmV3VVJMLCBtX3BvbGljeUxvYWRUeXBlLCBpc0Zvcm1TdWJtaXNzaW9uKSk7CiAK ICAgICAgICAgY2hlY2tOYXZpZ2F0aW9uUG9saWN5KGxvYWRlci0+cmVxdWVzdCgpLCBsb2FkZXIs IGZvcm1TdGF0ZSwKICAgICAgICAgICAgIGNhbGxDb250aW51ZUxvYWRBZnRlck5hdmlnYXRpb25Q b2xpY3ksIHRoaXMpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDIxMTgpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wMy0zMCAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnVnIDI0NTk0OiBQb2xpY3lEZWxlZ2F0ZSBOYXZpZ2F0aW9u QWN0aW9uIGlzIFdlYk5hdmlnYXRpb25UeXBlT3RoZXIgaW5zdGVhZCBvZiBXZWJOYXZpZ2F0aW9u VHlwZVJlbG9hZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQ1OTQKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNjY4MjExMAorCisgICAgICAgICogZmFz dC9sb2FkZXIvcmVsb2FkLXBvbGljeS1kZWxlZ2F0ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvbG9hZGVyL3JlbG9hZC1wb2xpY3ktZGVsZWdhdGUuaHRtbDogQWRkZWQuCisK IDIwMDktMDMtMjkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9y ZWxvYWQtcG9saWN5LWRlbGVnYXRlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2xvYWRlci9yZWxvYWQtcG9saWN5LWRlbGVnYXRlLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3JlbG9hZC1wb2xpY3ktZGVsZWdh dGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIgQEAKK1BvbGljeSBkZWxl Z2F0ZTogYXR0ZW1wdCB0byBsb2FkIGZpbGU6Ly8vVm9sdW1lcy9Ib21lL2RhcmluL1NhZmFyaS9P cGVuU291cmNlL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3JlbG9hZC1wb2xpY3ktZGVsZWdhdGUu aHRtbCB3aXRoIG5hdmlnYXRpb24gdHlwZSAncmVsb2FkJworVGVzdCB0byBtYWtlIHN1cmUgdGhh dCByZWxvYWRzIGdldCByZWxvYWQgcG9saWN5LgoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0 VGVzdHMvZmFzdC9sb2FkZXIvcmVsb2FkLXBvbGljeS1kZWxlZ2F0ZS1leHBlY3RlZC50eHQKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpBZGRlZDogc3ZuOmVvbC1zdHlsZQogICArIG5hdGl2ZQoKSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvbG9hZGVyL3JlbG9hZC1wb2xpY3ktZGVsZWdhdGUuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZWxvYWQtcG9saWN5LWRlbGVnYXRlLmh0bWwJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZWxvYWQtcG9saWN5LWRlbGVn YXRlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjAgQEAKKzxodG1sPgorPGhlYWQ+Cis8 c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CitmdW5jdGlvbiBzdGFydFRlc3QoKQorewor ICAgIGlmIChsYXlvdXRUZXN0Q29udHJvbGxlci5sb2FkQ291bnQgPiAwKQorICAgICAgICByZXR1 cm47CisKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5sb2FkQ291bnQgPSAxOworCisgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVy LnNldEN1c3RvbVBvbGljeURlbGVnYXRlKHRydWUsIHRydWUpOworICAgIGxheW91dFRlc3RDb250 cm9sbGVyLnF1ZXVlUmVsb2FkKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9h ZD0ic3RhcnRUZXN0KCkiPgorPHA+VGVzdCB0byBtYWtlIHN1cmUgdGhhdCByZWxvYWRzIGdldCBy ZWxvYWQgcG9saWN5LjwvcD4KKzwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMgb246 IExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3JlbG9hZC1wb2xpY3ktZGVsZWdhdGUuaHRtbApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkFkZGVkOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9odG1sCkFkZGVkOiBzdm46ZW9s LXN0eWxlCiAgICsgbmF0aXZlCgo=