24583 2009-03-13 12:16:58 -0700 Need to change scope of constructor and destructor of V8ObjectEventListener from private to protected so that they could be used in its derived class V8WorkerContextEventListener. 2009-03-13 13:47:07 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 jianli dimich oldest_to_newest 113648 0 jianli 2009-03-13 12:16:58 -0700 We need to change scope of constructor and destructor of V8ObjectEventListener from private to protected so that they could be used in its derived class V8WorkerContextEventListener. 113651 1 28590 jianli 2009-03-13 12:19:21 -0700 Created attachment 28590 Proposed Patch 113675 2 28590 dglazkov 2009-03-13 13:35:47 -0700 Comment on attachment 28590 Proposed Patch Yikes. /me longs for the time when we will no longer be forked and produce these silly errors. 113676 3 levin 2009-03-13 13:39:24 -0700 Assign to levin for landing. 113677 4 dimich 2009-03-13 13:40:55 -0700 reassigning to me for landing. 113681 5 dimich 2009-03-13 13:47:07 -0700 landed in http://trac.webkit.org/changeset/41682 28590 2009-03-13 12:19:21 -0700 2009-03-13 13:35:47 -0700 Proposed Patch 24583 text/plain 1150 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzUwOTNlMy4uOGZlOWEwYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wMy0xMyAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTmVlZCB0byBjaGFuZ2Ugc2NvcGUgb2YgY29uc3RydWN0b3IgYW5kIGRlc3Ry dWN0b3Igb2YgVjhPYmplY3RFdmVudExpc3RlbmVyIGZyb20gcHJpdmF0ZSB0byBwcm90ZWN0ZWQg c28gdGhhdCB0aGV5IGNvdWxkIGJlIHVzZWQgaW4gaXRzIGRlcml2ZWQgY2xhc3MgVjhXb3JrZXJD b250ZXh0RXZlbnRMaXN0ZW5lci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI0NTgzCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOE9iamVjdEV2ZW50 TGlzdGVuZXIuaDoKKwogMjAwOS0wMy0xMyAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9iaW5kaW5ncy92OC9WOE9iamVjdEV2ZW50TGlzdGVuZXIuaCBiL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhPYmplY3RFdmVudExpc3RlbmVyLmgKaW5kZXggNTAxYmRhYy4uNzMwYjk2YyAx MDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE9iamVjdEV2ZW50TGlzdGVuZXIuaAor KysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4T2JqZWN0RXZlbnRMaXN0ZW5lci5oCkBAIC00Nyw3 ICs0Nyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgIHJldHVybiBhZG9wdFJl ZihuZXcgVjhPYmplY3RFdmVudExpc3RlbmVyKGZyYW1lLCBsaXN0ZW5lciwgaXNJbmxpbmUpKTsK ICAgICAgICAgfQogCi0gICAgcHJpdmF0ZToKKyAgICBwcm90ZWN0ZWQ6CiAgICAgICAgIFY4T2Jq ZWN0RXZlbnRMaXN0ZW5lcihGcmFtZSosIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBsaXN0ZW5lciwg Ym9vbCBpc0lubGluZSk7CiAgICAgICAgIHZpcnR1YWwgflY4T2JqZWN0RXZlbnRMaXN0ZW5lcigp OwogICAgIH07Cg==