245723 2022-09-27 03:49:29 -0700 [GTK] Non-unified GTK4 build broken 2022-09-28 04:46:45 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 berto aperez aperez bugs-noreply csaavedra oldest_to_newest 1901448 0 berto 2022-09-27 03:49:29 -0700 /tmp/webkit2gtk-2.38.0/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp: In constructor ‘WebKit::NativeWebMouseEvent::NativeWebMouseEvent(GdkEvent*, int, std::optional<WebCore::FloatSize>)’: /tmp/webkit2gtk-2.38.0/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp:36:21: error: ‘gdk_event_copy’ was not declared in this scope; did you mean ‘gst_event_copy’? 36 | , m_nativeEvent(gdk_event_copy(event)) | ^~~~~~~~~~~~~~ 1901450 1 berto 2022-09-27 04:00:28 -0700 This needs to include GtkVersioning.h --- a/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp +++ b/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp @@ -27,6 +27,7 @@ #include "NativeWebMouseEvent.h" #include "WebEventFactory.h" +#include <Source/WebCore/platform/gtk/GtkVersioning.h> #include <gdk/gdk.h> namespace WebKit { 1901456 2 csaavedra 2022-09-27 04:24:47 -0700 Shouldn't it be #include <WebCore/GtkVersioning.h> ? 1901461 3 berto 2022-09-27 04:57:01 -0700 (In reply to Claudio Saavedra from comment #2) > Shouldn't it be #include <WebCore/GtkVersioning.h> ? yes, sorry, I tested a complete build and it works now #include "WebEventFactory.h" +#include <WebCore/GtkVersioning.h> #include <gdk/gdk.h> 1901738 4 aperez 2022-09-28 04:40:32 -0700 The issue is present in “main” as well, so I have removed the [2.28.0] tag from the summary. I can make sure this gets backported to the release branch 😉️ 1901741 5 aperez 2022-09-28 04:43:24 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4789 1901742 6 ews-feeder 2022-09-28 04:46:43 -0700 Committed 254950@main (8b91cf150e8a): <https://commits.webkit.org/254950@main> Reviewed commits have been landed. Closing PR #4789 and removing active labels.