245672 2022-09-26 07:44:06 -0700 [LFC] Clarify layout box ownership 2022-09-26 09:39:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto koivisto bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1901171 0 koivisto 2022-09-26 07:44:06 -0700 Use unique_ptr for first/next pointers in the tree. 1901172 1 webkit-bug-importer 2022-09-26 07:44:25 -0700 <rdar://problem/100410718> 1901183 2 462626 koivisto 2022-09-26 08:01:13 -0700 Created attachment 462626 Patch 1901211 3 ews-feeder 2022-09-26 09:39:49 -0700 Committed 254866@main (84b5bcb034c3): <https://commits.webkit.org/254866@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462626. 462626 2022-09-26 08:01:13 -0700 2022-09-26 09:39:50 -0700 Patch bug-245672-20220926180112.patch text/plain 6600 koivisto RnJvbSA2ZDJlNDhlODNlNWYyYjFjZThmMjQ0ZjAzZTgxZGI1MDJiZTNmMDhkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnR0aSBLb2l2aXN0byA8YW50dGlAYXBwbGUuY29tPgpEYXRl OiBNb24sIDI2IFNlcCAyMDIyIDE3OjQ1OjIzICswMzAwClN1YmplY3Q6IFtQQVRDSF0gW0xGQ10g Q2xhcmlmeSBsYXlvdXQgYm94IG93bmVyc2hpcAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI0NTY3MiA8cmRhcjovLzEwMDQxMDcxOD4KClJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgoKVXNlIHN0ZDo6dW5pcXVlX3B0ciBmb3IgZmlyc3RDaGlsZC9uZXh0U2libGlu ZyBwb2ludGVycy4gVGhpcyBkb2VzIG5vdCByZWFsbHkgY2hhbmdlCnRoZSBhY3R1YWwgb3duZXJz aGlwIGJ1dCBtYWtlcyBpdCBtb3JlIG9idmlvdXMgaW4gdGhlIGNvZGUgdGhhdCB0aGlzIGlzIGFu IG93bmluZyB0cmVlLgoKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRC b3guY3BwOgooV2ViQ29yZTo6TGF5b3V0OjpCb3g6OnJlbW92ZUZyb21QYXJlbnQpOgooV2ViQ29y ZTo6TGF5b3V0OjpCb3g6OnNldFBhcmVudCk6IERlbGV0ZWQuCihXZWJDb3JlOjpMYXlvdXQ6OkJv eDo6c2V0TmV4dFNpYmxpbmcpOiBEZWxldGVkLgooV2ViQ29yZTo6TGF5b3V0OjpCb3g6OnNldFBy ZXZpb3VzU2libGluZyk6IERlbGV0ZWQuCiogU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRy ZWUvTGF5b3V0Qm94Lmg6CiogU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0 Q29udGFpbmVyQm94LmNwcDoKKFdlYkNvcmU6OkxheW91dDo6Q29udGFpbmVyQm94OjphcHBlbmRD aGlsZCk6CihXZWJDb3JlOjpMYXlvdXQ6OkNvbnRhaW5lckJveDo6ZGVzdHJveUNoaWxkcmVuKToK KiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRDb250YWluZXJCb3guaDoK LS0tCiAuLi4vV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3BwICAgfCAzMiAr KysrKy0tLS0tLS0tLS0tLQogU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0 Qm94LmggIHwgIDkgKystLS0KIC4uLi9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRDb250YWluZXJC b3guY3BwICB8IDM2ICsrKysrKysrLS0tLS0tLS0tLS0KIC4uLi9sYXlvdXQvbGF5b3V0dHJlZS9M YXlvdXRDb250YWluZXJCb3guaCAgICB8ICAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDI3IGluc2Vy dGlvbnMoKyksIDUyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5 b3V0dHJlZS9MYXlvdXRCb3guY3BwCmluZGV4IDhiN2U1MDBhMDlmNi4uODcwZTM1OWZkN2E5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHAKQEAg LTU1LDM2ICs1NSwyMCBAQCBCb3g6On5Cb3goKQogICAgICAgICByZW1vdmVSYXJlRGF0YSgpOwog fQogCi12b2lkIEJveDo6c2V0UGFyZW50KENvbnRhaW5lckJveCogcGFyZW50KQorVW5pcXVlUmVm PEJveD4gQm94OjpyZW1vdmVGcm9tUGFyZW50KCkKIHsKLSAgICBtX3BhcmVudCA9IHBhcmVudDsK LX0KKyAgICBhdXRvJiBuZXh0T3JGaXJzdCA9IG1fcHJldmlvdXNTaWJsaW5nID8gbV9wcmV2aW91 c1NpYmxpbmctPm1fbmV4dFNpYmxpbmcgOiBtX3BhcmVudC0+bV9maXJzdENoaWxkOworICAgIGF1 dG8mIHByZXZpb3VzT3JMYXN0ID0gbV9uZXh0U2libGluZyA/IG1fbmV4dFNpYmxpbmctPm1fcHJl dmlvdXNTaWJsaW5nIDogbV9wYXJlbnQtPm1fbGFzdENoaWxkOwogCi12b2lkIEJveDo6c2V0TmV4 dFNpYmxpbmcoQm94KiBuZXh0U2libGluZykKLXsKLSAgICBtX25leHRTaWJsaW5nID0gbmV4dFNp Ymxpbmc7Ci19CisgICAgQVNTRVJUKG5leHRPckZpcnN0LmdldCgpID09IHRoaXMpOworICAgIEFT U0VSVChwcmV2aW91c09yTGFzdC5nZXQoKSA9PSB0aGlzKTsKIAotdm9pZCBCb3g6OnNldFByZXZp b3VzU2libGluZyhCb3gqIHByZXZpb3VzU2libGluZykKLXsKLSAgICBtX3ByZXZpb3VzU2libGlu ZyA9IHByZXZpb3VzU2libGluZzsKLX0KKyAgICBhdXRvIG93bmVkU2VsZiA9IHN0ZDo6ZXhjaGFu Z2UobmV4dE9yRmlyc3QsIHN0ZDo6ZXhjaGFuZ2UobV9uZXh0U2libGluZywgbnVsbHB0cikpOwog Ci1VbmlxdWVSZWY8Qm94PiBCb3g6OnJlbW92ZUZyb21QYXJlbnQoKQotewotICAgIGlmIChtX3By ZXZpb3VzU2libGluZykKLSAgICAgICAgbV9wcmV2aW91c1NpYmxpbmctPm1fbmV4dFNpYmxpbmcg PSBtX25leHRTaWJsaW5nOwotICAgIGlmIChtX25leHRTaWJsaW5nKQotICAgICAgICBtX25leHRT aWJsaW5nLT5tX3ByZXZpb3VzU2libGluZyA9IG1fcHJldmlvdXNTaWJsaW5nOwotICAgIGlmICht X3BhcmVudC0+bV9maXJzdENoaWxkID09IHRoaXMpCi0gICAgICAgIG1fcGFyZW50LT5tX2ZpcnN0 Q2hpbGQgPSBtX25leHRTaWJsaW5nOwotICAgIGlmIChtX3BhcmVudC0+bV9sYXN0Q2hpbGQgPT0g dGhpcykKLSAgICAgICAgbV9wYXJlbnQtPm1fbGFzdENoaWxkID0gbV9wcmV2aW91c1NpYmxpbmc7 CisgICAgcHJldmlvdXNPckxhc3QgPSBzdGQ6OmV4Y2hhbmdlKG1fcHJldmlvdXNTaWJsaW5nLCBu dWxscHRyKTsKICAgICBtX3BhcmVudCA9IG51bGxwdHI7Ci0gICAgbV9wcmV2aW91c1NpYmxpbmcg PSBudWxscHRyOwotICAgIG1fbmV4dFNpYmxpbmcgPSBudWxscHRyOwogCi0gICAgcmV0dXJuIFVu aXF1ZVJlZjxCb3g+KCp0aGlzKTsKKyAgICByZXR1cm4gbWFrZVVuaXF1ZVJlZkZyb21Ob25OdWxs VW5pcXVlUHRyKFdURk1vdmUob3duZWRTZWxmKSk7CiB9CiAKIHZvaWQgQm94Ojp1cGRhdGVTdHls ZShjb25zdCBSZW5kZXJTdHlsZSYgbmV3U3R5bGUsIHN0ZDo6dW5pcXVlX3B0cjxSZW5kZXJTdHls ZT4mJiBuZXdGaXJzdExpbmVTdHlsZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9sYXlvdXR0cmVlL0xheW91dEJveC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRy ZWUvTGF5b3V0Qm94LmgKaW5kZXggN2Y3OWViNzk2NDU1Li40NDAwODQ1NjdiZTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oCkBAIC0xODQsMTAgKzE4 NCw2IEBAIHByb3RlY3RlZDoKIHByaXZhdGU6CiAgICAgZnJpZW5kIGNsYXNzIENvbnRhaW5lckJv eDsKIAotICAgIHZvaWQgc2V0UGFyZW50KENvbnRhaW5lckJveCopOwotICAgIHZvaWQgc2V0TmV4 dFNpYmxpbmcoQm94Kik7Ci0gICAgdm9pZCBzZXRQcmV2aW91c1NpYmxpbmcoQm94Kik7Ci0KICAg ICBjbGFzcyBCb3hSYXJlRGF0YSB7CiAgICAgICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwog ICAgIHB1YmxpYzoKQEAgLTIxNCw5ICsyMTAsMTAgQEAgcHJpdmF0ZToKICAgICBzdGQ6Om9wdGlv bmFsPEVsZW1lbnRBdHRyaWJ1dGVzPiBtX2VsZW1lbnRBdHRyaWJ1dGVzOwogCiAgICAgQ2hlY2tl ZFB0cjxDb250YWluZXJCb3g+IG1fcGFyZW50OwotICAgIENoZWNrZWRQdHI8Qm94PiBtX3ByZXZp b3VzU2libGluZzsKLSAgICBDaGVja2VkUHRyPEJveD4gbV9uZXh0U2libGluZzsKICAgICAKKyAg ICBzdGQ6OnVuaXF1ZV9wdHI8Qm94PiBtX25leHRTaWJsaW5nOworICAgIENoZWNrZWRQdHI8Qm94 PiBtX3ByZXZpb3VzU2libGluZzsKKwogICAgIC8vIEZpcnN0IExheW91dFN0YXRlIGdldHMgYSBk aXJlY3QgY2FjaGUuCiAgICAgbXV0YWJsZSBXZWFrUHRyPExheW91dFN0YXRlPiBtX2NhY2hlZExh eW91dFN0YXRlOwogICAgIG11dGFibGUgc3RkOjp1bmlxdWVfcHRyPEJveEdlb21ldHJ5PiBtX2Nh Y2hlZEdlb21ldHJ5Rm9yTGF5b3V0U3RhdGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRDb250YWluZXJCb3guY3BwIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Q29udGFpbmVyQm94LmNwcAppbmRleCAxZDI4MTM2OGYw YTguLjJjMzI1MDAyNzRjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91 dHRyZWUvTGF5b3V0Q29udGFpbmVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv bGF5b3V0dHJlZS9MYXlvdXRDb250YWluZXJCb3guY3BwCkBAIC04NywzNyArODcsMzEgQEAgY29u c3QgQm94KiBDb250YWluZXJCb3g6Omxhc3RJbkZsb3dPckZsb2F0aW5nQ2hpbGQoKSBjb25zdAog dm9pZCBDb250YWluZXJCb3g6OmFwcGVuZENoaWxkKFVuaXF1ZVJlZjxCb3g+IGNoaWxkUmVmKQog ewogICAgIGF1dG8gY2hpbGRCb3ggPSBjaGlsZFJlZi5tb3ZlVG9VbmlxdWVQdHIoKTsKKyAgICBB U1NFUlQoIWNoaWxkQm94LT5tX3BhcmVudCk7CisgICAgQVNTRVJUKCFjaGlsZEJveC0+bV9wcmV2 aW91c1NpYmxpbmcpOworICAgIEFTU0VSVCghY2hpbGRCb3gtPm1fbmV4dFNpYmxpbmcpOwogCi0g ICAgY2hpbGRCb3gtPnNldFBhcmVudCh0aGlzKTsKKyAgICBjaGlsZEJveC0+bV9wYXJlbnQgPSB0 aGlzOworICAgIGNoaWxkQm94LT5tX3ByZXZpb3VzU2libGluZyA9IG1fbGFzdENoaWxkOwogCi0g ICAgaWYgKG1fbGFzdENoaWxkKSB7Ci0gICAgICAgIG1fbGFzdENoaWxkLT5zZXROZXh0U2libGlu ZyhjaGlsZEJveC5nZXQoKSk7Ci0gICAgICAgIGNoaWxkQm94LT5zZXRQcmV2aW91c1NpYmxpbmco bV9sYXN0Q2hpbGQuZ2V0KCkpOwotICAgIH0gZWxzZQotICAgICAgICBtX2ZpcnN0Q2hpbGQgPSBj aGlsZEJveC5nZXQoKTsKKyAgICBhdXRvJiBuZXh0T3JGaXJzdCA9IG1fbGFzdENoaWxkID8gbV9s YXN0Q2hpbGQtPm1fbmV4dFNpYmxpbmcgOiBtX2ZpcnN0Q2hpbGQ7CisgICAgQVNTRVJUKCFuZXh0 T3JGaXJzdCk7CiAKLSAgICAvLyBPd25lcnNoaXAgaGFzIGJlZW4gdHJhbnNmZXJyZWQuCi0gICAg bV9sYXN0Q2hpbGQgPSBjaGlsZEJveC5yZWxlYXNlKCk7CisgICAgbV9sYXN0Q2hpbGQgPSBjaGls ZEJveC5nZXQoKTsKKyAgICBuZXh0T3JGaXJzdCA9IFdURk1vdmUoY2hpbGRCb3gpOwogfQogCiB2 b2lkIENvbnRhaW5lckJveDo6ZGVzdHJveUNoaWxkcmVuKCkKIHsKLSAgICBzdGQ6OnVuaXF1ZV9w dHI8Qm94PiBjaGlsZFRvRGVzdHJveSB7IG1fZmlyc3RDaGlsZC5nZXQoKSB9OwotICAgIAotICAg IG1fZmlyc3RDaGlsZCA9IG51bGxwdHI7CiAgICAgbV9sYXN0Q2hpbGQgPSBudWxscHRyOwogCisg ICAgYXV0byBjaGlsZFRvRGVzdHJveSA9IHN0ZDo6ZXhjaGFuZ2UobV9maXJzdENoaWxkLCBudWxs cHRyKTsKICAgICB3aGlsZSAoY2hpbGRUb0Rlc3Ryb3kpIHsKLSAgICAgICAgY2hpbGRUb0Rlc3Ry b3ktPnNldFBhcmVudChudWxscHRyKTsKLQotICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8Qm94PiBu ZXh0U2libGluZyB7IGNoaWxkVG9EZXN0cm95LT5uZXh0U2libGluZygpIH07Ci0KLSAgICAgICAg aWYgKG5leHRTaWJsaW5nKSB7Ci0gICAgICAgICAgICBjaGlsZFRvRGVzdHJveS0+c2V0TmV4dFNp YmxpbmcobnVsbHB0cik7Ci0gICAgICAgICAgICBuZXh0U2libGluZy0+c2V0UHJldmlvdXNTaWJs aW5nKG51bGxwdHIpOwotICAgICAgICB9Ci0KLSAgICAgICAgY2hpbGRUb0Rlc3Ryb3kgPSBXVEZN b3ZlKG5leHRTaWJsaW5nKTsKKyAgICAgICAgY2hpbGRUb0Rlc3Ryb3ktPm1fcGFyZW50ID0gbnVs bHB0cjsKKyAgICAgICAgY2hpbGRUb0Rlc3Ryb3ktPm1fcHJldmlvdXNTaWJsaW5nID0gbnVsbHB0 cjsKKyAgICAgICAgaWYgKGNoaWxkVG9EZXN0cm95LT5tX25leHRTaWJsaW5nKQorICAgICAgICAg ICAgY2hpbGRUb0Rlc3Ryb3ktPm1fbmV4dFNpYmxpbmctPm1fcHJldmlvdXNTaWJsaW5nID0gbnVs bHB0cjsKKyAgICAgICAgY2hpbGRUb0Rlc3Ryb3kgPSBzdGQ6OmV4Y2hhbmdlKGNoaWxkVG9EZXN0 cm95LT5tX25leHRTaWJsaW5nLCBudWxscHRyKTsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dENvbnRhaW5lckJveC5oIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Q29udGFpbmVyQm94LmgKaW5kZXgg NzA1NzlkN2U2OWViLi4yYzkzYzk4MTRlOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9sYXlvdXR0cmVlL0xheW91dENvbnRhaW5lckJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9sYXlvdXR0cmVlL0xheW91dENvbnRhaW5lckJveC5oCkBAIC02NCw3ICs2NCw3IEBA IHB1YmxpYzoKIHByaXZhdGU6CiAgICAgZnJpZW5kIGNsYXNzIEJveDsKICAgICAKLSAgICBDaGVj a2VkUHRyPEJveD4gbV9maXJzdENoaWxkOworICAgIHN0ZDo6dW5pcXVlX3B0cjxCb3g+IG1fZmly c3RDaGlsZDsKICAgICBDaGVja2VkUHRyPEJveD4gbV9sYXN0Q2hpbGQ7CiAKICAgICBzdGQ6Om9w dGlvbmFsPExheW91dFVuaXQ+IG1fYmFzZWxpbmVGb3JJbnRlZ3JhdGlvbjsK