245664 2022-09-26 01:30:17 -0700 [CG] A large PDFDocumentImage may be displayed pixelated 2023-04-18 11:06:59 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=252194 InRadar P2 Normal --- 251641 1 sabouhallawa sabouhallawa sabouhallawa webkit-bug-importer oldest_to_newest 1901125 0 sabouhallawa 2022-09-26 01:30:17 -0700 Drawing a sub-rectangle of PDFDocumentImage can be expensive because the whole image has to be displayed. PDFDocumentImage tries to cache a viewport of the last source displayed rectangle. The viewport is a bigger rectangle which includes the source rectangle. The goal of caching the viewport is to reuse it as many times as possible and not to draw the image itself. The calculations and the transformation to create, draw and reuse the viewport is very complex and fragile. The solution is to clean up this code by introducing a new class called ImageViewport. This class will be responsible of creating a viewport ImageBuffer, drawing the source rectangle of the image to the viewport ImageBuffer and drawing this buffer to the destination GraphicsContext. The calculations can be simplified such that the resolution of the viewport ImageBuffer matches the effective resolution of the destination GraphicsContext. 1901126 1 sabouhallawa 2022-09-26 01:30:44 -0700 rdar://97254192 1901133 2 sabouhallawa 2022-09-26 02:07:40 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4700 1931571 3 ews-feeder 2023-02-06 17:17:55 -0800 Committed 259928@main (8382d4d3c6e3): <https://commits.webkit.org/259928@main> Reviewed commits have been landed. Closing PR #4700 and removing active labels.