24562 2009-03-12 14:27:44 -0700 Add custom V8 binding for Document.getCSSCanvasContext 2009-03-13 15:47:29 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 mbelshe mbelshe oldest_to_newest 113496 0 mbelshe 2009-03-12 14:27:44 -0700 Made this function custom to deal with the difference between DOMObject in the IDL and CanvasRenderingContext2D. 113498 1 28557 mbelshe 2009-03-12 14:36:53 -0700 Created attachment 28557 patch 113509 2 28557 dglazkov 2009-03-12 15:14:53 -0700 Comment on attachment 28557 patch Looks good, aside for helper functions. Also, don't forget to put bug URL in the ChangeLog. I usually do: URL Description. (standard stuff prepareChangelog puts in) > + String contextId = ToWebCoreString(args[0]); toWebCoreString > + String name = ToWebCoreString(args[1]); Ditto. > + int width = ToInt32(args[2]); toInt32 > + int height = ToInt32(args[3]); Ditto. > + CanvasRenderingContext2D* result = imp->getCSSCanvasContext(contextId, name, width, height); > + return V8Proxy::ToV8Object(V8ClassIndex::CANVASRENDERINGCONTEXT2D, result); > +} > + > } // namespace WebCore 113520 3 28563 mbelshe 2009-03-12 15:56:01 -0700 Created attachment 28563 updated patch 113724 4 dglazkov 2009-03-13 15:47:29 -0700 Landed as http://trac.webkit.org/changeset/41691. 28557 2009-03-12 14:36:53 -0700 2009-03-13 15:43:26 -0700 patch bug24562.patch text/plain 1510 mbelshe SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTY1MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDktMDMtMTIgIE1pa2UgQmVsc2hlICA8bWlrZUBiZWxzaGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBBZGQgY3Vz dG9tIGltcGxlbWVudGF0aW9uIGZvciBnZXRDU1NDYW52YXNDb250ZXh0CisKKyAgICAgICAgKiBi aW5kaW5ncy92OC9jdXN0b20vVjhEb2N1bWVudEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEb2N1bWVudEdldENTU0NhbnZhc0NvbnRleHQpOgorCiAyMDA5LTAzLTEyICBHcmVnIEJvbHNp bmdhICA8Ym9sc2luZ2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtv aXZpc3RvLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhEb2N1bWVudEN1c3Rv bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhEb2N1bWVu dEN1c3RvbS5jcHAJKHJldmlzaW9uIDQxNjQ5KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhEb2N1bWVudEN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgzLDQgKzgzLDE3IEBA IENBTExCQUNLX0ZVTkNfREVDTChEb2N1bWVudEV2YWx1YXRlKQogICAgIHJldHVybiBWOFByb3h5 OjpUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6WFBBVEhSRVNVTFQsIHJlc3VsdC5nZXQoKSk7CiB9 CiAKK0NBTExCQUNLX0ZVTkNfREVDTChEb2N1bWVudEdldENTU0NhbnZhc0NvbnRleHQpCit7Cisg ICAgSU5DX1NUQVRTKCJET00uRG9jdW1lbnQuZ2V0Q1NTQ2FudmFzQ29udGV4dCIpOworICAgIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBob2xkZXIgPSBhcmdzLkhvbGRlcigpOworICAgIERvY3VtZW50 KiBpbXAgPSBWOFByb3h5OjpET01XcmFwcGVyVG9Ob2RlPERvY3VtZW50Pihob2xkZXIpOworICAg IFN0cmluZyBjb250ZXh0SWQgPSBUb1dlYkNvcmVTdHJpbmcoYXJnc1swXSk7CisgICAgU3RyaW5n IG5hbWUgPSBUb1dlYkNvcmVTdHJpbmcoYXJnc1sxXSk7CisgICAgaW50IHdpZHRoID0gVG9JbnQz MihhcmdzWzJdKTsKKyAgICBpbnQgaGVpZ2h0ID0gVG9JbnQzMihhcmdzWzNdKTsKKyAgICBDYW52 YXNSZW5kZXJpbmdDb250ZXh0MkQqIHJlc3VsdCA9IGltcC0+Z2V0Q1NTQ2FudmFzQ29udGV4dChj b250ZXh0SWQsIG5hbWUsIHdpZHRoLCBoZWlnaHQpOworICAgIHJldHVybiBWOFByb3h5OjpUb1Y4 T2JqZWN0KFY4Q2xhc3NJbmRleDo6Q0FOVkFTUkVOREVSSU5HQ09OVEVYVDJELCByZXN1bHQpOwor fQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 28563 2009-03-12 15:56:01 -0700 2009-03-13 15:43:38 -0700 updated patch bug24562.patch text/plain 1472 mbelshe SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTY1MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTAgQEAKKzIwMDktMDMtMTIgIE1pa2UgQmVsc2hlICA8bWlrZUBiZWxzaGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBCdWcgMjQ1 NjI6IEFkZCBjdXN0b20gaW1wbGVtZW50YXRpb24gZm9yIGdldENTU0NhbnZhc0NvbnRleHQKKwor ICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOERvY3VtZW50Q3VzdG9tLmNwcDoKKwogMjAw OS0wMy0xMiAgR3JlZyBCb2xzaW5nYSAgPGJvbHNpbmdhQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4RG9jdW1lbnRDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4RG9jdW1lbnRDdXN0b20uY3BwCShyZXZpc2lvbiA0MTY0OSkKKysrIFdlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RG9jdW1lbnRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC04Myw0ICs4MywxNyBAQCBDQUxMQkFDS19GVU5DX0RFQ0woRG9jdW1lbnRFdmFsdWF0ZSkK ICAgICByZXR1cm4gVjhQcm94eTo6VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OlhQQVRIUkVTVUxU LCByZXN1bHQuZ2V0KCkpOwogfQogCitDQUxMQkFDS19GVU5DX0RFQ0woRG9jdW1lbnRHZXRDU1ND YW52YXNDb250ZXh0KQoreworICAgIElOQ19TVEFUUygiRE9NLkRvY3VtZW50LmdldENTU0NhbnZh c0NvbnRleHQiKTsKKyAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gaG9sZGVyID0gYXJncy5Ib2xk ZXIoKTsKKyAgICBEb2N1bWVudCogaW1wID0gVjhQcm94eTo6RE9NV3JhcHBlclRvTm9kZTxEb2N1 bWVudD4oaG9sZGVyKTsKKyAgICBTdHJpbmcgY29udGV4dElkID0gdG9XZWJDb3JlU3RyaW5nKGFy Z3NbMF0pOworICAgIFN0cmluZyBuYW1lID0gdG9XZWJDb3JlU3RyaW5nKGFyZ3NbMV0pOworICAg IGludCB3aWR0aCA9IHRvSW50MzIoYXJnc1syXSk7CisgICAgaW50IGhlaWdodCA9IHRvSW50MzIo YXJnc1szXSk7CisgICAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEKiByZXN1bHQgPSBpbXAtPmdl dENTU0NhbnZhc0NvbnRleHQoY29udGV4dElkLCBuYW1lLCB3aWR0aCwgaGVpZ2h0KTsKKyAgICBy ZXR1cm4gVjhQcm94eTo6VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OkNBTlZBU1JFTkRFUklOR0NP TlRFWFQyRCwgcmVzdWx0KTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=