24559 2009-03-12 14:03:28 -0700 Need to port JSC fix to V8 in order to fix layout test onload-single-line-comment.html 2009-03-13 10:33:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 jianli levin dglazkov oldest_to_newest 113486 0 jianli 2009-03-12 14:03:28 -0700 Need to port JSC fix to V8 in order to fix layout test onload-single-line-comment.html. 113488 1 28555 jianli 2009-03-12 14:06:08 -0700 Created attachment 28555 Proposed Patch 113601 2 28555 dglazkov 2009-03-13 09:36:39 -0700 Comment on attachment 28555 Proposed Patch So this is just to match JSC's behavior? 113602 3 jianli 2009-03-13 10:02:37 -0700 (In reply to comment #2) > (From update of attachment 28555 [review]) > So this is just to match JSC's behavior? > This is to fix layout test failure in chromium. I ported JSC's fix. 113603 4 dglazkov 2009-03-13 10:06:11 -0700 Sounds good, please mention the revision number of the JSC change that you ported in the ChangeLog. 113609 5 28581 jianli 2009-03-13 10:18:27 -0700 Created attachment 28581 Proposed Patch 113612 6 levin 2009-03-13 10:22:59 -0700 Assigned to levin for landing. 113617 7 levin 2009-03-13 10:33:31 -0700 Committed in r41671. 28555 2009-03-12 14:06:08 -0700 2009-03-13 10:18:27 -0700 Proposed Patch FixLayoutTestSingleLineComment text/plain 1882 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTQwYWU3Zi4uZjZhYTUwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wMy0xMiAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTmVlZCB0byBwb3J0IEpTQyBmaXggdG8gVjggaW4gb3JkZXIgdG8gZml4IGxh eW91dCB0ZXN0IG9ubG9hZC1zaW5nbGUtbGluZS1jb21tZW50Lmh0bWwuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDU1OQorCisgICAgICAgICogYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6VjhMYXp5RXZlbnRMaXN0ZW5lcjo6Z2V0TGlzdGVuZXJGdW5jdGlvbik6CisgICAgICAgIChX ZWJDb3JlOjpWOExhenlFdmVudExpc3RlbmVyOjpnZXRXcmFwcGVkTGlzdGVuZXJGdW5jdGlvbik6 CisKIDIwMDktMDMtMTIgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOExhenlFdmVudExpc3RlbmVyLmNwcCBiL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwCmluZGV4IGNkZmU5ZGYuLmIwNGM3 OWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TGF6eUV2ZW50TGlz dGVuZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TGF6eUV2ZW50TGlz dGVuZXIuY3BwCkBAIC05NSw3ICs5NSw3IEBAIHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+IFY4TGF6 eUV2ZW50TGlzdGVuZXI6OmdldExpc3RlbmVyRnVuY3Rpb24oKQogICAgICAgICAvLyBUaGUgRUNN QVNjcmlwdCBzcGVjIHNheXMgKHZlcnkgb2JsaXF1ZWx5KSB0aGF0IHRoZSBwYXJhbWV0ZXIgdG8g YW4gZXZlbnQgaGFuZGxlciBpcyBuYW1lZCAiZXZ0Ii4KICAgICAgICAgU3RyaW5nIGNvZGUgPSAi KGZ1bmN0aW9uIChldnQpIHtcbiI7CiAgICAgICAgIGNvZGUuYXBwZW5kKG1fY29kZSk7Ci0gICAg ICAgIGNvZGUuYXBwZW5kKCJ9KSIpOworICAgICAgICBjb2RlLmFwcGVuZCgiXG59KSIpOwogCiAg ICAgICAgIHY4OjpIYW5kbGU8djg6OlN0cmluZz4gY29kZUV4dGVybmFsU3RyaW5nID0gdjhFeHRl cm5hbFN0cmluZyhjb2RlKTsKICAgICAgICAgdjg6OkhhbmRsZTx2ODo6U2NyaXB0PiBzY3JpcHQg PSBWOFByb3h5OjpDb21waWxlU2NyaXB0KGNvZGVFeHRlcm5hbFN0cmluZywgbV9mcmFtZS0+ZG9j dW1lbnQoKS0+dXJsKCksIG1fbGluZU51bWJlciAtIDEpOwpAQCAtMTY3LDcgKzE2Nyw3IEBAIHY4 OjpMb2NhbDx2ODo6RnVuY3Rpb24+IFY4TGF6eUV2ZW50TGlzdGVuZXI6OmdldFdyYXBwZWRMaXN0 ZW5lckZ1bmN0aW9uKCkKICAgICAgICAgY29kZS5hcHBlbmQoIiAgICAgIHdpdGggKHRoaXMpIHtc biIpOwogICAgICAgICBjb2RlLmFwcGVuZCgiICAgICAgICByZXR1cm4gKGZ1bmN0aW9uKGV2dCl7 Iik7CiAgICAgICAgIGNvZGUuYXBwZW5kKG1fY29kZSk7Ci0gICAgICAgIGNvZGUuYXBwZW5kKCJ9 KS5jYWxsKHRoaXMsIGV2dCk7XG4iKTsKKyAgICAgICAgY29kZS5hcHBlbmQoIlxufSkuY2FsbCh0 aGlzLCBldnQpO1xuIik7CiAgICAgICAgIGNvZGUuYXBwZW5kKCIgICAgICB9XG4iKTsKICAgICAg ICAgY29kZS5hcHBlbmQoIiAgICB9XG4iKTsKICAgICAgICAgY29kZS5hcHBlbmQoIiAgfVxuIik7 Cg== 28581 2009-03-13 10:18:27 -0700 2009-03-13 10:18:27 -0700 Proposed Patch FixLayoutTestSingleLineComment2 text/plain 1891 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTQwYWU3Zi4uYjgzNWExZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wMy0xMiAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTmVlZCB0byBwb3J0IEpTQyBmaXggKHI0MTU2NSkgdG8gVjggaW4gb3JkZXIg dG8gZml4IGxheW91dCB0ZXN0IG9ubG9hZC1zaW5nbGUtbGluZS1jb21tZW50Lmh0bWwuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDU1OQorCisgICAg ICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6VjhMYXp5RXZlbnRMaXN0ZW5lcjo6Z2V0TGlzdGVuZXJGdW5jdGlvbik6Cisg ICAgICAgIChXZWJDb3JlOjpWOExhenlFdmVudExpc3RlbmVyOjpnZXRXcmFwcGVkTGlzdGVuZXJG dW5jdGlvbik6CisKIDIwMDktMDMtMTIgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOExhenlFdmVudExpc3RlbmVyLmNwcCBiL1dlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwCmluZGV4IGNkZmU5 ZGYuLmIwNGM3OWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TGF6 eUV2ZW50TGlzdGVuZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TGF6 eUV2ZW50TGlzdGVuZXIuY3BwCkBAIC05NSw3ICs5NSw3IEBAIHY4OjpMb2NhbDx2ODo6RnVuY3Rp b24+IFY4TGF6eUV2ZW50TGlzdGVuZXI6OmdldExpc3RlbmVyRnVuY3Rpb24oKQogICAgICAgICAv LyBUaGUgRUNNQVNjcmlwdCBzcGVjIHNheXMgKHZlcnkgb2JsaXF1ZWx5KSB0aGF0IHRoZSBwYXJh bWV0ZXIgdG8gYW4gZXZlbnQgaGFuZGxlciBpcyBuYW1lZCAiZXZ0Ii4KICAgICAgICAgU3RyaW5n IGNvZGUgPSAiKGZ1bmN0aW9uIChldnQpIHtcbiI7CiAgICAgICAgIGNvZGUuYXBwZW5kKG1fY29k ZSk7Ci0gICAgICAgIGNvZGUuYXBwZW5kKCJ9KSIpOworICAgICAgICBjb2RlLmFwcGVuZCgiXG59 KSIpOwogCiAgICAgICAgIHY4OjpIYW5kbGU8djg6OlN0cmluZz4gY29kZUV4dGVybmFsU3RyaW5n ID0gdjhFeHRlcm5hbFN0cmluZyhjb2RlKTsKICAgICAgICAgdjg6OkhhbmRsZTx2ODo6U2NyaXB0 PiBzY3JpcHQgPSBWOFByb3h5OjpDb21waWxlU2NyaXB0KGNvZGVFeHRlcm5hbFN0cmluZywgbV9m cmFtZS0+ZG9jdW1lbnQoKS0+dXJsKCksIG1fbGluZU51bWJlciAtIDEpOwpAQCAtMTY3LDcgKzE2 Nyw3IEBAIHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+IFY4TGF6eUV2ZW50TGlzdGVuZXI6OmdldFdy YXBwZWRMaXN0ZW5lckZ1bmN0aW9uKCkKICAgICAgICAgY29kZS5hcHBlbmQoIiAgICAgIHdpdGgg KHRoaXMpIHtcbiIpOwogICAgICAgICBjb2RlLmFwcGVuZCgiICAgICAgICByZXR1cm4gKGZ1bmN0 aW9uKGV2dCl7Iik7CiAgICAgICAgIGNvZGUuYXBwZW5kKG1fY29kZSk7Ci0gICAgICAgIGNvZGUu YXBwZW5kKCJ9KS5jYWxsKHRoaXMsIGV2dCk7XG4iKTsKKyAgICAgICAgY29kZS5hcHBlbmQoIlxu fSkuY2FsbCh0aGlzLCBldnQpO1xuIik7CiAgICAgICAgIGNvZGUuYXBwZW5kKCIgICAgICB9XG4i KTsKICAgICAgICAgY29kZS5hcHBlbmQoIiAgICB9XG4iKTsKICAgICAgICAgY29kZS5hcHBlbmQo IiAgfVxuIik7Cg==