245583 2022-09-23 09:52:26 -0700 WebKit build failure since rebase of libwebrtc 2022-09-24 09:54:15 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy webkit-bug-importer youennf oldest_to_newest 1900663 0 timothy 2022-09-23 09:52:26 -0700 .../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:293:45: Possible misuse of comma operator here .../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:313:43: Possible misuse of comma operator here .../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:320:43: Possible misuse of comma operator here .../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:396:51: Possible misuse of comma operator here .../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:604:50: Possible misuse of comma operator here 1900664 1 youennf 2022-09-23 09:55:19 -0700 I might have missed some ALLOW_COMMA_BEGIN / ALLOW_COMMA_END places. 1900665 2 timothy 2022-09-23 09:56:12 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4632 1900666 3 timothy 2022-09-23 09:57:14 -0700 (In reply to youenn fablet from comment #1) > I might have missed some ALLOW_COMMA_BEGIN / ALLOW_COMMA_END places. Oh! I will do that instead of the fix I just pushed. 1900680 4 timothy 2022-09-23 10:31:08 -0700 I am not seeing the failures now after updating main. 1900886 5 timothy 2022-09-24 09:04:32 -0700 I am seeing this again due to adding new files and UnifiedSources changing. 1900887 6 timothy 2022-09-24 09:08:22 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4666 1900902 7 ews-feeder 2022-09-24 09:53:55 -0700 Committed 254824@main (829b721f8a6c): <https://commits.webkit.org/254824@main> Reviewed commits have been landed. Closing PR #4666 and removing active labels. 1900903 8 webkit-bug-importer 2022-09-24 09:54:15 -0700 <rdar://problem/100363003>