24557 2009-03-12 13:46:59 -0700 Add locker to v8 event listener of worker context. 2009-03-13 10:34:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 jianli levin dglazkov oldest_to_newest 113473 0 jianli 2009-03-12 13:46:59 -0700 Add locker to v8 event listener of worker context. 113474 1 28548 jianli 2009-03-12 13:50:07 -0700 Created attachment 28548 Proposed Patch 113600 2 28548 dglazkov 2009-03-13 09:35:09 -0700 Comment on attachment 28548 Proposed Patch > + Bug 24557: Add locker to v8 event listener of worker context. > + https://bugs.webkit.org/show_bug.cgi?id=24557 This is probably more conventional and less redundant: https://bugs.webkit.org/show_bug.cgi?id=24557 Add locker to v8 event listener of worker context. Also, perhaps we could make the comment a little bit more informative? It sounds more like a description an action rather than the problem it aims to solve. 113606 3 28579 jianli 2009-03-13 10:10:52 -0700 Created attachment 28579 Proposed Patch 113610 4 28579 dglazkov 2009-03-13 10:20:00 -0700 Comment on attachment 28579 Proposed Patch I see you didn't take my first suggestion :). r=me, just try to make ChangeLog entries consistent with others'. Also, the "Add locker to v8 event listener of worker context" probably belongs with + (WebCore::V8WorkerContextEventListener::handleEvent): 113611 5 levin 2009-03-13 10:21:21 -0700 Assigned to levin for landing. 113618 6 levin 2009-03-13 10:34:03 -0700 Committed in r41670. 28548 2009-03-12 13:50:07 -0700 2009-03-13 10:11:04 -0700 Proposed Patch V8LockerForWorkerContextEventListener text/plain 1174 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTQwYWU3Zi4uZjQ5MWUxNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wMy0xMiAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQnVnIDI0NTU3OiBBZGQgbG9ja2VyIHRvIHY4IGV2ZW50IGxpc3RlbmVyIG9m IHdvcmtlciBjb250ZXh0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjQ1NTcKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFdvcmtlckNv bnRleHRFdmVudExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4V29ya2VyQ29udGV4 dEV2ZW50TGlzdGVuZXI6OmhhbmRsZUV2ZW50KToKKwogMjAwOS0wMy0xMiAgRGFyaW4gRmlzaGVy ICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xh emtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4V29ya2VyQ29u dGV4dEV2ZW50TGlzdGVuZXIuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3Jr ZXJDb250ZXh0RXZlbnRMaXN0ZW5lci5jcHAKaW5kZXggMjRkNTAwMi4uYmY1ZWUzYyAxMDA2NDQK LS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0 ZW5lci5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3JrZXJDb250ZXh0 RXZlbnRMaXN0ZW5lci5jcHAKQEAgLTYyLDYgKzYyLDcgQEAgdm9pZCBWOFdvcmtlckNvbnRleHRF dmVudExpc3RlbmVyOjpoYW5kbGVFdmVudChFdmVudCogZXZlbnQsIGJvb2wgaXNXaW5kb3dFdmVu dCkKICAgICAvLyBTZWUgaXNzdWUgODg5ODI5LgogICAgIFJlZlB0cjxWOEFic3RyYWN0RXZlbnRM aXN0ZW5lcj4gcHJvdGVjdCh0aGlzKTsKIAorICAgIHY4OjpMb2NrZXIgbG9ja2VyOwogICAgIHY4 OjpIYW5kbGVTY29wZSBoYW5kbGVTY29wZTsKIAogICAgIHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+ IGNvbnRleHQgPSBtX3Byb3h5LT5HZXRDb250ZXh0KCk7Cg== 28579 2009-03-13 10:10:52 -0700 2009-03-13 10:20:00 -0700 Proposed Patch V8LockerForWorkerContextEventListener2 text/plain 1247 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTQwYWU3Zi4uNjVlZmE0NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wMy0xMiAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGxvY2tlciB0byB2OCBldmVudCBsaXN0ZW5lciBvZiB3b3JrZXIgY29u dGV4dC4gVGhpcyBpcyB0byBzdXBwb3J0IHJ1bm5pbmcgbXVsdGlwbGUgd29ya2VycyBpbiBhIHNp bmdsZSB3b3JrZXIgcHJvY2VzcyBpbiBjaHJvbWl1bS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NTU3CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9j dXN0b20vVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpWOFdvcmtlckNvbnRleHRFdmVudExpc3RlbmVyOjpoYW5kbGVFdmVudCk6CisKIDIwMDktMDMt MTIgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOFdvcmtlckNvbnRleHRFdmVudExpc3RlbmVyLmNwcCBiL1dlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4V29ya2VyQ29udGV4dEV2ZW50TGlzdGVuZXIuY3BwCmluZGV4IDI0ZDUwMDIu LmJmNWVlM2MgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4V29ya2Vy Q29udGV4dEV2ZW50TGlzdGVuZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t L1Y4V29ya2VyQ29udGV4dEV2ZW50TGlzdGVuZXIuY3BwCkBAIC02Miw2ICs2Miw3IEBAIHZvaWQg VjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lcjo6aGFuZGxlRXZlbnQoRXZlbnQqIGV2ZW50LCBi b29sIGlzV2luZG93RXZlbnQpCiAgICAgLy8gU2VlIGlzc3VlIDg4OTgyOS4KICAgICBSZWZQdHI8 VjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI+IHByb3RlY3QodGhpcyk7CiAKKyAgICB2ODo6TG9ja2Vy IGxvY2tlcjsKICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2NvcGU7CiAKICAgICB2ODo6SGFu ZGxlPHY4OjpDb250ZXh0PiBjb250ZXh0ID0gbV9wcm94eS0+R2V0Q29udGV4dCgpOwo=