245513 2022-09-21 21:01:16 -0700 TextureMapperGL: edge distance anti-aliasing should use 2D distance to calculate v_antialias varing variable 2022-09-26 22:46:55 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 245265 P2 Normal --- 1 fujii webkit-unassigned cmarcelo ews-watchlist kondapallykalyan luiz oldest_to_newest 1900300 0 462527 fujii 2022-09-21 21:01:16 -0700 Created attachment 462527 antialiasing-z-positions.html TextureMapperGL: edge distance anti-aliasing should use 2D distance to calculate v_antialias varing variable > float viewportSpaceDistance = distance(centerInViewportCoordinates, controlPointInViewportCoordinates); This code calculates the distance in homogeneous coordinates. z and w are included. 1900301 1 462528 fujii 2022-09-21 21:01:53 -0700 Created attachment 462528 WIP patch 1900302 2 462528 fujii 2022-09-21 21:04:41 -0700 Comment on attachment 462528 WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=462528&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:113 > + float viewportSpaceDistance = distance(centerInViewportCoordinates.xy / centerInViewportCoordinates.w, controlPointInViewportCoordinates.xy / controlPointInViewportCoordinates.w); We should avoid divisions. bug#245265 is going to solve this bug by calculating the denominator separately. 1901411 3 fujii 2022-09-26 22:46:55 -0700 *** This bug has been marked as a duplicate of bug 245265 *** 462527 2022-09-21 21:01:16 -0700 2022-09-21 21:01:16 -0700 antialiasing-z-positions.html antialiasing-z-positions.html text/html 849 fujii PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPHN0eWxlPgogICAgICAuYyB7CgkgIGRpc3BsYXk6 IGlubGluZS1ibG9jazsKCSAgcG9zaXRpb246IHJlbGF0aXZlOwoJICB3aWR0aDogMjAwcHg7Cgkg IGhlaWdodDogMjAwcHg7CiAgICAgICAgICBwZXJzcGVjdGl2ZTogMTAwcHg7CgkgIG1hcmdpbjog MzBweDsKICAgICAgICB9CiAgICAgICAgLmMgPiBkaXYgewogICAgICAgICAgICBwb3NpdGlvbjog YWJzb2x1dGU7CiAgICAgICAgICAgIHdpZHRoOiAyMDBweDsKICAgICAgICAgICAgaGVpZ2h0OiAy MDBweDsKICAgICAgICAgICAgYmFja2dyb3VuZDogZ3JlZW47CiAgICAgICAgICAgIHRyYW5zZm9y bTogcm90YXRlWigxMGRlZyk7CgkgICAgd2lsbC1jaGFuZ2U6IHRyYW5zZm9ybTsKICAgICAgICB9 CgkjeCB7CiAgICAgICAgICAgIHRyYW5zZm9ybTogdHJhbnNsYXRlWig1MHB4KSByb3RhdGVaKDEw ZGVnKSBzY2FsZSgwLjUpOwoJfQoJI3kgewogICAgICAgICAgICB0cmFuc2Zvcm06IHJvdGF0ZVoo MTBkZWcpOwoJfQoJI3ogewogICAgICAgICAgICB0cmFuc2Zvcm06IHRyYW5zbGF0ZVooLTEwMHB4 KSByb3RhdGVaKDEwZGVnKSBzY2FsZSgyKTsKCX0KICAgIDwvc3R5bGU+CiAgICA8cD5UaGVyZSBh cmUgdGhyZWUgYm94ZXMgYXQgNTBweCwgMCwgLTEwMHB4IHogcG9zaXRpb25zLiBUaGV5IHNob3Vs ZCBoYXZlIHNhbWUgYW50aS1hbGlhc2luZyBlZGdlcy48L3A+CiAgICA8ZGl2IGNsYXNzPWM+PGRp diBpZD14PjwvZGl2PjwvZGl2PgogICAgPGRpdiBjbGFzcz1jPjxkaXYgaWQ9eT48L2Rpdj48L2Rp dj4KICAgIDxkaXYgY2xhc3M9Yz48ZGl2IGlkPXo+PC9kaXY+PC9kaXY+CjwvaHRtbD4K 462528 2022-09-21 21:01:53 -0700 2022-09-21 22:07:46 -0700 WIP patch wip.patch text/plain 2197 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0 dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwCmluZGV4IDUyYTMyZjFi MzdhMy4uODE0OTY2ZGExYjM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJv Z3JhbS5jcHAKQEAgLTkxLDcgKzkxLDcgQEAgc3RhdGljIGNvbnN0IGNoYXIqIHZlcnRleFRlbXBs YXRlQ29tbW9uID0KIAogICAgICAgICB2b2lkIG5vb3AoaW5vdXQgdmVjMiBkdW1teVBhcmFtZXRl cikgeyB9CiAKLSAgICAgICAgdmVjNCB0b1ZpZXdwb3J0U3BhY2UodmVjMiBwb3MpIHsgcmV0dXJu IHZlYzQocG9zLCAwLiwgMS4pICogdV9tb2RlbFZpZXdNYXRyaXg7IH0KKyAgICAgICAgdmVjNCB0 b1ZpZXdwb3J0U3BhY2UodmVjMiBwb3MpIHsgcmV0dXJuIHVfbW9kZWxWaWV3TWF0cml4ICogdmVj NChwb3MsIDAuLCAxLik7IH0KIAogICAgICAgICAvLyBUaGlzIGZ1bmN0aW9uIHJlbGllcyBvbiB0 aGUgYXNzdW1wdGlvbiB0aGF0IHdlIGdldCBlZGdlIHRyaWFuZ2xlcyB3aXRoIGNvbnRyb2wgcG9p bnRzLAogICAgICAgICAvLyBhIGNvbnRyb2wgcG9pbnQgYmVpbmcgdGhlIG5lYXJlc3QgcG9pbnQg dG8gdGhlIGNvb3JkaW5hdGUgdGhhdCBpcyBvbiB0aGUgZWRnZS4KQEAgLTEwMCw3ICsxMDAsNyBA QCBzdGF0aWMgY29uc3QgY2hhciogdmVydGV4VGVtcGxhdGVDb21tb24gPQogICAgICAgICAgICAg Ly8gV2UgY291bnQgb24gdGhlIGZhY3QgdGhhdCBxdWFkIHBhc3NlZCBpbiBpcyBhbHdheXMgYSB1 bml0IHJlY3QsCiAgICAgICAgICAgICAvLyBhbmQgdGhlIHRyYW5zZm9ybWF0aW9uIG1hdHJpeCBh cHBsaWVzIHRoZSByZWFsIHJlY3QuCiAgICAgICAgICAgICBjb25zdCB2ZWMyIGNlbnRlciA9IHZl YzIoMC41LCAwLjUpOwotICAgICAgICAgICAgY29uc3QgZmxvYXQgYW50aWFsaWFzSW5mbGF0aW9u RGlzdGFuY2UgPSAxLjsKKyAgICAgICAgICAgIGNvbnN0IGZsb2F0IGFudGlhbGlhc0luZmxhdGlv bkRpc3RhbmNlID0gMS40MTQ7CiAKICAgICAgICAgICAgIC8vIFdlIHBhc3MgdGhlIGNvbnRyb2wg cG9pbnQgYXMgdGhlIHp3IGNvb3JkaW5hdGVzIG9mIHRoZSB2ZXJ0ZXguCiAgICAgICAgICAgICAv LyBUaGUgY29udHJvbCBwb2ludCBpcyB0aGUgcG9pbnQgb24gdGhlIGVkZ2UgY2xvc2VzdCB0byB0 aGUgY3VycmVudCBwb3NpdGlvbi4KQEAgLTExMCw3ICsxMTAsNyBAQCBzdGF0aWMgY29uc3QgY2hh ciogdmVydGV4VGVtcGxhdGVDb21tb24gPQogICAgICAgICAgICAgLy8gRmlyc3Qgd2UgY2FsY3Vs YXRlIHRoZSBkaXN0YW5jZSBpbiB2aWV3cG9ydCBzcGFjZS4KICAgICAgICAgICAgIHZlYzQgY2Vu dGVySW5WaWV3cG9ydENvb3JkaW5hdGVzID0gdG9WaWV3cG9ydFNwYWNlKGNlbnRlcik7CiAgICAg ICAgICAgICB2ZWM0IGNvbnRyb2xQb2ludEluVmlld3BvcnRDb29yZGluYXRlcyA9IHRvVmlld3Bv cnRTcGFjZShjb250cm9sUG9pbnQpOwotICAgICAgICAgICAgZmxvYXQgdmlld3BvcnRTcGFjZURp c3RhbmNlID0gZGlzdGFuY2UoY2VudGVySW5WaWV3cG9ydENvb3JkaW5hdGVzLCBjb250cm9sUG9p bnRJblZpZXdwb3J0Q29vcmRpbmF0ZXMpOworICAgICAgICAgICAgZmxvYXQgdmlld3BvcnRTcGFj ZURpc3RhbmNlID0gZGlzdGFuY2UoY2VudGVySW5WaWV3cG9ydENvb3JkaW5hdGVzLnh5IC8gY2Vu dGVySW5WaWV3cG9ydENvb3JkaW5hdGVzLncsIGNvbnRyb2xQb2ludEluVmlld3BvcnRDb29yZGlu YXRlcy54eSAvIGNvbnRyb2xQb2ludEluVmlld3BvcnRDb29yZGluYXRlcy53KTsKIAogICAgICAg ICAgICAgLy8gV2UgYWRkIHRoZSBpbmZsYXRpb24gZGlzdGFuY2UgdG8gdGhlIGNvbXB1dGVkIGRp c3RhbmNlLCBhbmQgY29tcHV0ZSB0aGUgcmF0aW8uCiAgICAgICAgICAgICBmbG9hdCBpbmZsYXRp b25SYXRpbyA9ICh2aWV3cG9ydFNwYWNlRGlzdGFuY2UgKyBhbnRpYWxpYXNJbmZsYXRpb25EaXN0 YW5jZSkgLyB2aWV3cG9ydFNwYWNlRGlzdGFuY2U7Cg==