24550 2009-03-12 10:32:23 -0700 Compiler warning for XMLTokenizerLibxml2.cpp 2009-03-31 13:24:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 craig.schlenter webkit-unassigned oldest_to_newest 113407 0 craig.schlenter 2009-03-12 10:32:23 -0700 gcc 4.3.3 throws out warnings about the return value of vasprintf being unused. An example of the compilation failure is seen here in chromium where -Werror makes the compilation fail http://code.google.com/p/chromium/issues/detail?id=7742#c23 I'll attach a patch which I unfortunately can't test as I can't get webkit svn to build at the moment. 113409 1 28532 craig.schlenter 2009-03-12 10:34:11 -0700 Created attachment 28532 patch to fix compiler warning untested patch to fix compiler warning 113461 2 28532 darin 2009-03-12 13:06:17 -0700 Comment on attachment 28532 patch to fix compiler warning Is this really the only unused result warning in WebCore? If not, then why are we fixing this one case? 113549 3 craig.schlenter 2009-03-12 21:42:25 -0700 I've asked the original reporter for more feedback in the chromium issue tracker to see if there are other warnings/errors. I had originally assumed that one of the webkit merges introduced this problem but the vasprintf seems to have been there for ages according to svn blame so I need to dig a bit more to see why it's only showing up now as the reporter was compiling successfully before. I unfortunately don't have the same compiler as the reporter btw. but I'll see if I can coax my machine (Fedora 9) into using a newer compiler and investigate this properly. In this particular case btw., if the vasprintf call fails the invalid buffer returned by vasprintf will be freed a couple of lines further on which will probably result in a crash although arguably if that is failing not much else is likely to work either. Thank you. 113649 4 craig.schlenter 2009-03-13 12:17:12 -0700 I think I know why the chromium reporter sees this and I don't even after upgrading my fedora 9 system to gcc 4.4.0 and glibc-2.9.90 ... it seems as if ubuntu 8.10 has some default compiler flag settings that include FORTIFY_SOURCE that is activated at -O2 and higher: https://wiki.ubuntu.com/CompilerFlags I'll fiddle with getting my machine into equivalent shape tomorrow and track down the related errors/warnings .... 113821 5 craig.schlenter 2009-03-15 07:51:42 -0700 After compiling with -D_FORTIFY_SOURCE=2 this seems to be the only warn_unused_result. GCC-4.4.0 has shown up some other issues (a missing include and possibly some strict aliasing issues) but I'll file separate bugs for those. Thank you. 115912 6 28532 dglazkov 2009-03-30 15:24:05 -0700 Comment on attachment 28532 patch to fix compiler warning Sounds good. 116061 7 dimich 2009-03-31 13:24:21 -0700 Landed: http://trac.webkit.org/changeset/42139 Please add the link to the bug into ChangeLog description next time. 28532 2009-03-12 10:34:11 -0700 2009-03-30 15:24:05 -0700 patch to fix compiler warning webkit.diff text/plain 1102 craig.schlenter SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTYzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMTIgIENyYWlnIFNjaGxlbnRlciAgPGNyYWlnLnNjaGxl bnRlckBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2hlY2sgcmV0dXJuIHZhbHVlIG9mIHZhc3ByaW50Zi4gVGhpcyBzaG91bGQga2Vl cCBnY2MgNC4zLjMKKyAgICAgICAgaGFwcHkgcmF0aGVyIHRoYW4gaGF2ZSBpdCBjb21wbGFpbiBh Ym91dCBhdHRyaWJ1dGUgd2Fybl91bnVzZWRfcmVzdWx0LgorCisgICAgICAgICogZG9tL1hNTFRv a2VuaXplckxpYnhtbDIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6WE1MVG9rZW5pemVyOjplcnJv cik6CisKIDIwMDktMDMtMTIgIEFkYW0gVHJlYXQgIDxhZGFtLnRyZWF0QHRvcmNobW9iaWxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KSW5kZXg6IFdlYkNvcmUv ZG9tL1hNTFRva2VuaXplckxpYnhtbDIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1hN TFRva2VuaXplckxpYnhtbDIuY3BwCShyZXZpc2lvbiA0MTYxNikKKysrIFdlYkNvcmUvZG9tL1hN TFRva2VuaXplckxpYnhtbDIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NDUsNyArODQ1LDggQEAg dm9pZCBYTUxUb2tlbml6ZXI6OmVycm9yKEVycm9yVHlwZSB0eXBlLAogICAgIHZzbnByaW50Ziht LCBzaXplb2YobSkgLSAxLCBtZXNzYWdlLCBhcmdzKTsKICNlbHNlCiAgICAgY2hhciogbTsKLSAg ICB2YXNwcmludGYoJm0sIG1lc3NhZ2UsIGFyZ3MpOworICAgIGlmICh2YXNwcmludGYoJm0sIG1l c3NhZ2UsIGFyZ3MpID09IC0xKQorICAgICAgICByZXR1cm47CiAjZW5kaWYKICAgICAKICAgICBp ZiAobV9wYXJzZXJQYXVzZWQpCg==