245468 2022-09-21 01:48:32 -0700 A live node becomes undefined in OSR Exit. 2022-11-12 14:55:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 entryhii d_degazio bfulgham d_degazio ews-feeder mark.lam webkit-bug-importer ysuzuki oldest_to_newest 1900067 0 entryhii 2022-09-21 01:48:32 -0700 function main() { const v75 = {}; v75.__proto__ = Object; Object.defineProperty(Object, 117982949, {}); let v119 = 0; while (v119 < 10) { function v121() { for (let v130 = 0; v130 < 100; v130++) {} const v142 = [2.1, NaN]; print(v142[0]) // wrongly print undefined } v121() v119++; } } noDFG(main); noFTL(main); main(); With the above script as input to JSC, run JSC with the following parameters: ./jsc test.js --useConcurrentJIT=0 --jitPolicyScale=0.001 v142[0] should be 2.1. But after OSRExit, v142[0] becomes undefined. The problem may be in CompileNewArray in DFGSpeculativeJIT. 2.1 is used (operand.use()) and NaN causes bailout. The use count of 2.1 is 0. So OSRExit wrongly thinks 2.1 is dead and put an undefined into the call frame. 1901721 1 webkit-bug-importer 2022-09-28 01:49:18 -0700 <rdar://problem/100497797> 1904647 2 462916 d_degazio 2022-10-10 15:34:33 -0700 Created attachment 462916 Patch 1904651 3 d_degazio 2022-10-10 15:48:34 -0700 Elaborating on the explanation: in SpeculativeJIT::compileNewArray, in specifically the slow path (reached when we have invalidated the isHavingABadTime watchpoint), we explicitly use() each operand after we write it to the buffer: > case ALL_ARRAY_STORAGE_INDEXING_TYPES: { > JSValueOperand operand(this, use, ManualOperandSpeculation); > JSValueRegs operandRegs = operand.jsValueRegs(); > if (hasInt32(node->indexingType())) { > DFG_TYPE_CHECK( > operandRegs, use, SpecInt32Only, > m_jit.branchIfNotInt32(operandRegs)); > } > m_jit.storeValue(operandRegs, buffer + operandIdx); > operand.use(); > break; > } This is an optimization to avoid spilling operands unnecessarily when we call the new-array operation further down, by manually managing the node lifetimes. If a later operand fails the DFG_TYPE_CHECK, however, we may OSRExit. At that point, the exit information will be collected after earlier operands were used, potentially leaving it dead, resulting in the undefined value we see in this bug. This patch resolves the issue by doing two separate passes - first, we traverse the operands and emit the necessary type checks; second, we traverse the operands again and write them to the buffer. In this scheme, we generate the exit information prior to using any of the operands, so they should all remain live during this period. 1904653 4 462916 ysuzuki 2022-10-10 15:54:06 -0700 Comment on attachment 462916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462916&action=review r=me > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:9694 > + for (unsigned operandIdx = 0; operandIdx < node->numChildren(); ++operandIdx) { > + Edge use = m_graph.m_varArgChildren[node->firstChild() + operandIdx]; > + JSValueOperand operand(this, use, ManualOperandSpeculation); > + JSValueRegs operandRegs = operand.jsValueRegs(); > + if (hasInt32(node->indexingType())) { > + DFG_TYPE_CHECK( > + operandRegs, use, SpecInt32Only, > + m_jit.branchIfNotInt32(operandRegs)); > + } > + } Let's put it under `if (hasInt32(node->indexingType()))` And remove inner `if (hasInt32(node->indexingType()))`. 1904656 5 462917 d_degazio 2022-10-10 16:01:16 -0700 Created attachment 462917 Patch 1904690 6 462917 ysuzuki 2022-10-10 18:30:42 -0700 Comment on attachment 462917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462917&action=review > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:9657 > case ALL_DOUBLE_INDEXING_TYPES: { In WebKit coding style, `case` is aligned to `switch`. > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:9684 > case ALL_INT32_INDEXING_TYPES: > case ALL_CONTIGUOUS_INDEXING_TYPES: > case ALL_ARRAY_STORAGE_INDEXING_TYPES: { Ditto. 1904691 7 462917 ysuzuki 2022-10-10 18:31:16 -0700 Comment on attachment 462917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462917&action=review > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:9704 > default: Ditto. 1911918 8 mark.lam 2022-11-11 15:53:04 -0800 d_degazio@apple.com: Pull request: https://github.com/WebKit/WebKit/pull/5211 1911921 9 mark.lam 2022-11-11 16:14:37 -0800 *** Bug 246307 has been marked as a duplicate of this bug. *** 1912003 10 462917 mark.lam 2022-11-12 09:37:50 -0800 Comment on attachment 462917 Patch Let's land this via the github PR. 1912032 11 ews-feeder 2022-11-12 14:55:14 -0800 Committed 256611@main (104b2a1546ed): <https://commits.webkit.org/256611@main> Reviewed commits have been landed. Closing PR #5211 and removing active labels. 462916 2022-10-10 15:34:33 -0700 2022-10-10 16:01:14 -0700 Patch bug-245468-20221010153432.patch text/plain 6309 d_degazio RnJvbSA0OWYyZTQwODcxNTc1MDcwMmVlYjI0NGRkYjVjZDhjN2IwZTIxYmIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBEZWdhemlvIDwzNTE0NjIwMStkZGVnYXppb0B1c2Vy cy5ub3JlcGx5LmdpdGh1Yi5jb20+CkRhdGU6IE1vbiwgMTAgT2N0IDIwMjIgMTU6MTM6NDAgLTA3 MDAKU3ViamVjdDogW1BBVENIXSBBIGxpdmUgbm9kZSBiZWNvbWVzIHVuZGVmaW5lZCBpbiBPU1Ig RXhpdAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NTQ2OCByZGFy Oi8vMTAwNDk3Nzk3CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogSlNUZXN0cy9zdHJl c3MvbmV3LWFycmF5LWtlZXAtcGFyYW1zLWxpdmUtaW4tb3NyZXhpdC1kZmctc2xvdy1wYXRoLmpz OiBBZGRlZC4KKG1haW4udjEyMSk6CihtYWluKToKKiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1NwZWN1bGF0aXZlSklULmNwcDoKLS0tCiAuLi4vSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklULmNwcCAgfCA2NCArKysrKysrKysrKy0tLS0tLS0tCiAuLi5lcC1wYXJhbXMt bGl2ZS1pbi1vc3JleGl0LWRmZy1zbG93LXBhdGguanMgfCAyMSArKysrKysKIDIgZmlsZXMgY2hh bmdlZCwgNTcgaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2 NDQgSlNUZXN0cy9zdHJlc3MvbmV3LWFycmF5LWtlZXAtcGFyYW1zLWxpdmUtaW4tb3NyZXhpdC1k Zmctc2xvdy1wYXRoLmpzCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdTcGVjdWxhdGl2ZUpJVC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1 bGF0aXZlSklULmNwcAppbmRleCAyYmQ5MTc4ZDhkMWIuLjQyOWEwMGU1ZjY0MCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKQEAgLTk2NDks NTMgKzk2NDksNjEgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZU5ld0FycmF5KE5vZGUq IG5vZGUpCiAgICAgc2l6ZV90IHNjcmF0Y2hTaXplID0gc2l6ZW9mKEVuY29kZWRKU1ZhbHVlKSAq IG5vZGUtPm51bUNoaWxkcmVuKCk7CiAgICAgU2NyYXRjaEJ1ZmZlciogc2NyYXRjaEJ1ZmZlciA9 IHZtKCkuc2NyYXRjaEJ1ZmZlckZvclNpemUoc2NyYXRjaFNpemUpOwogICAgIEVuY29kZWRKU1Zh bHVlKiBidWZmZXIgPSBzY3JhdGNoQnVmZmVyID8gc3RhdGljX2Nhc3Q8RW5jb2RlZEpTVmFsdWUq PihzY3JhdGNoQnVmZmVyLT5kYXRhQnVmZmVyKCkpIDogbnVsbHB0cjsKLQotICAgIGZvciAodW5z aWduZWQgb3BlcmFuZElkeCA9IDA7IG9wZXJhbmRJZHggPCBub2RlLT5udW1DaGlsZHJlbigpOyAr K29wZXJhbmRJZHgpIHsKKyAgICBzd2l0Y2ggKG5vZGUtPmluZGV4aW5nVHlwZSgpKSB7CiAgICAg ICAgIC8vIE5lZWQgdG8gcGVyZm9ybSB0aGUgc3BlY3VsYXRpb25zIHRoYXQgdGhpcyBub2RlIHBy b21pc2VzIHRvIHBlcmZvcm0uIElmIHdlJ3JlCiAgICAgICAgIC8vIGVtaXR0aW5nIGNvZGUgaGVy ZSBhbmQgdGhlIGluZGV4aW5nIHR5cGUgaXMgbm90IGFycmF5IHN0b3JhZ2UgdGhlbiB0aGVyZSBp cwogICAgICAgICAvLyBwcm9iYWJseSBzb21ldGhpbmcgaGlsYXJpb3VzIGdvaW5nIG9uIGFuZCB3 ZSdyZSBhbHJlYWR5IGZhaWxpbmcgYXQgYWxsIHRoZQogICAgICAgICAvLyB0aGluZ3MsIGJ1dCBh dCBsZWFzdCB3ZSdyZSBnb2luZyB0byBiZSBzb3VuZC4KLSAgICAgICAgRWRnZSB1c2UgPSBtX2dy YXBoLm1fdmFyQXJnQ2hpbGRyZW5bbm9kZS0+Zmlyc3RDaGlsZCgpICsgb3BlcmFuZElkeF07Ci0g ICAgICAgIHN3aXRjaCAobm9kZS0+aW5kZXhpbmdUeXBlKCkpIHsKLSAgICAgICAgY2FzZSBBTExf QkxBTktfSU5ERVhJTkdfVFlQRVM6Ci0gICAgICAgIGNhc2UgQUxMX1VOREVDSURFRF9JTkRFWElO R19UWVBFUzoKLSAgICAgICAgICAgIENSQVNIKCk7Ci0gICAgICAgICAgICBicmVhazsKICAgICAg ICAgY2FzZSBBTExfRE9VQkxFX0lOREVYSU5HX1RZUEVTOiB7Ci0gICAgICAgICAgICBTcGVjdWxh dGVEb3VibGVPcGVyYW5kIG9wZXJhbmQodGhpcywgdXNlKTsKLSAgICAgICAgICAgIEZQUlJlZyBv cEZQUiA9IG9wZXJhbmQuZnByKCk7Ci0gICAgICAgICAgICBERkdfVFlQRV9DSEVDSygKLSAgICAg ICAgICAgICAgICBKU1ZhbHVlUmVncygpLCB1c2UsIFNwZWNEb3VibGVSZWFsLAotICAgICAgICAg ICAgICAgIG1faml0LmJyYW5jaElmTmFOKG9wRlBSKSk7CisgICAgICAgICAgICBmb3IgKHVuc2ln bmVkIG9wZXJhbmRJZHggPSAwOyBvcGVyYW5kSWR4IDwgbm9kZS0+bnVtQ2hpbGRyZW4oKTsgKytv cGVyYW5kSWR4KSB7CisgICAgICAgICAgICAgICAgRWRnZSB1c2UgPSBtX2dyYXBoLm1fdmFyQXJn Q2hpbGRyZW5bbm9kZS0+Zmlyc3RDaGlsZCgpICsgb3BlcmFuZElkeF07CisgICAgICAgICAgICAg ICAgU3BlY3VsYXRlRG91YmxlT3BlcmFuZCBvcGVyYW5kKHRoaXMsIHVzZSk7CisgICAgICAgICAg ICAgICAgRlBSUmVnIG9wRlBSID0gb3BlcmFuZC5mcHIoKTsKKyAgICAgICAgICAgICAgICBERkdf VFlQRV9DSEVDSygKKyAgICAgICAgICAgICAgICAgICAgSlNWYWx1ZVJlZ3MoKSwgdXNlLCBTcGVj RG91YmxlUmVhbCwKKyAgICAgICAgICAgICAgICAgICAgbV9qaXQuYnJhbmNoSWZOYU4ob3BGUFIp KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGZvciAodW5zaWduZWQgb3BlcmFuZElkeCA9 IDA7IG9wZXJhbmRJZHggPCBub2RlLT5udW1DaGlsZHJlbigpOyArK29wZXJhbmRJZHgpIHsKKyAg ICAgICAgICAgICAgICBFZGdlIHVzZSA9IG1fZ3JhcGgubV92YXJBcmdDaGlsZHJlbltub2RlLT5m aXJzdENoaWxkKCkgKyBvcGVyYW5kSWR4XTsKKyAgICAgICAgICAgICAgICBTcGVjdWxhdGVEb3Vi bGVPcGVyYW5kIG9wZXJhbmQodGhpcywgdXNlKTsKKyAgICAgICAgICAgICAgICBGUFJSZWcgb3BG UFIgPSBvcGVyYW5kLmZwcigpOwogI2lmIFVTRShKU1ZBTFVFNjQpCi0gICAgICAgICAgICBKU1Zh bHVlUmVnc1RlbXBvcmFyeSBzY3JhdGNoKHRoaXMpOwotICAgICAgICAgICAgSlNWYWx1ZVJlZ3Mg c2NyYXRjaFJlZ3MgPSBzY3JhdGNoLnJlZ3MoKTsKLSAgICAgICAgICAgIG1faml0LmJveERvdWJs ZShvcEZQUiwgc2NyYXRjaFJlZ3MpOwotICAgICAgICAgICAgbV9qaXQuc3RvcmVWYWx1ZShzY3Jh dGNoUmVncywgYnVmZmVyICsgb3BlcmFuZElkeCk7CisgICAgICAgICAgICAgICAgSlNWYWx1ZVJl Z3NUZW1wb3Jhcnkgc2NyYXRjaCh0aGlzKTsKKyAgICAgICAgICAgICAgICBKU1ZhbHVlUmVncyBz Y3JhdGNoUmVncyA9IHNjcmF0Y2gucmVncygpOworICAgICAgICAgICAgICAgIG1faml0LmJveERv dWJsZShvcEZQUiwgc2NyYXRjaFJlZ3MpOworICAgICAgICAgICAgICAgIG1faml0LnN0b3JlVmFs dWUoc2NyYXRjaFJlZ3MsIGJ1ZmZlciArIG9wZXJhbmRJZHgpOwogI2Vsc2UKLSAgICAgICAgICAg IG1faml0LnN0b3JlRG91YmxlKG9wRlBSLCBUcnVzdGVkSW1tUHRyKGJ1ZmZlciArIG9wZXJhbmRJ ZHgpKTsKKyAgICAgICAgICAgICAgICBtX2ppdC5zdG9yZURvdWJsZShvcEZQUiwgVHJ1c3RlZElt bVB0cihidWZmZXIgKyBvcGVyYW5kSWR4KSk7CiAjZW5kaWYKLSAgICAgICAgICAgIG9wZXJhbmQu dXNlKCk7CisgICAgICAgICAgICAgICAgb3BlcmFuZC51c2UoKTsKKyAgICAgICAgICAgIH0KICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGNhc2UgQUxMX0lOVDMyX0lOREVY SU5HX1RZUEVTOgogICAgICAgICBjYXNlIEFMTF9DT05USUdVT1VTX0lOREVYSU5HX1RZUEVTOgog ICAgICAgICBjYXNlIEFMTF9BUlJBWV9TVE9SQUdFX0lOREVYSU5HX1RZUEVTOiB7Ci0gICAgICAg ICAgICBKU1ZhbHVlT3BlcmFuZCBvcGVyYW5kKHRoaXMsIHVzZSwgTWFudWFsT3BlcmFuZFNwZWN1 bGF0aW9uKTsKLSAgICAgICAgICAgIEpTVmFsdWVSZWdzIG9wZXJhbmRSZWdzID0gb3BlcmFuZC5q c1ZhbHVlUmVncygpOwotICAgICAgICAgICAgaWYgKGhhc0ludDMyKG5vZGUtPmluZGV4aW5nVHlw ZSgpKSkgewotICAgICAgICAgICAgICAgIERGR19UWVBFX0NIRUNLKAotICAgICAgICAgICAgICAg ICAgICBvcGVyYW5kUmVncywgdXNlLCBTcGVjSW50MzJPbmx5LAotICAgICAgICAgICAgICAgICAg ICBtX2ppdC5icmFuY2hJZk5vdEludDMyKG9wZXJhbmRSZWdzKSk7CisgICAgICAgICAgICBmb3Ig KHVuc2lnbmVkIG9wZXJhbmRJZHggPSAwOyBvcGVyYW5kSWR4IDwgbm9kZS0+bnVtQ2hpbGRyZW4o KTsgKytvcGVyYW5kSWR4KSB7CisgICAgICAgICAgICAgICAgRWRnZSB1c2UgPSBtX2dyYXBoLm1f dmFyQXJnQ2hpbGRyZW5bbm9kZS0+Zmlyc3RDaGlsZCgpICsgb3BlcmFuZElkeF07CisgICAgICAg ICAgICAgICAgSlNWYWx1ZU9wZXJhbmQgb3BlcmFuZCh0aGlzLCB1c2UsIE1hbnVhbE9wZXJhbmRT cGVjdWxhdGlvbik7CisgICAgICAgICAgICAgICAgSlNWYWx1ZVJlZ3Mgb3BlcmFuZFJlZ3MgPSBv cGVyYW5kLmpzVmFsdWVSZWdzKCk7CisgICAgICAgICAgICAgICAgaWYgKGhhc0ludDMyKG5vZGUt PmluZGV4aW5nVHlwZSgpKSkgeworICAgICAgICAgICAgICAgICAgICBERkdfVFlQRV9DSEVDSygK KyAgICAgICAgICAgICAgICAgICAgICAgIG9wZXJhbmRSZWdzLCB1c2UsIFNwZWNJbnQzMk9ubHks CisgICAgICAgICAgICAgICAgICAgICAgICBtX2ppdC5icmFuY2hJZk5vdEludDMyKG9wZXJhbmRS ZWdzKSk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAgICAgICAgZm9y ICh1bnNpZ25lZCBvcGVyYW5kSWR4ID0gMDsgb3BlcmFuZElkeCA8IG5vZGUtPm51bUNoaWxkcmVu KCk7ICsrb3BlcmFuZElkeCkgeworICAgICAgICAgICAgICAgIEVkZ2UgdXNlID0gbV9ncmFwaC5t X3ZhckFyZ0NoaWxkcmVuW25vZGUtPmZpcnN0Q2hpbGQoKSArIG9wZXJhbmRJZHhdOworICAgICAg ICAgICAgICAgIEpTVmFsdWVPcGVyYW5kIG9wZXJhbmQodGhpcywgdXNlLCBNYW51YWxPcGVyYW5k U3BlY3VsYXRpb24pOworICAgICAgICAgICAgICAgIEpTVmFsdWVSZWdzIG9wZXJhbmRSZWdzID0g b3BlcmFuZC5qc1ZhbHVlUmVncygpOworICAgICAgICAgICAgICAgIG1faml0LnN0b3JlVmFsdWUo b3BlcmFuZFJlZ3MsIGJ1ZmZlciArIG9wZXJhbmRJZHgpOworICAgICAgICAgICAgICAgIG9wZXJh bmQudXNlKCk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBtX2ppdC5zdG9yZVZhbHVlKG9w ZXJhbmRSZWdzLCBidWZmZXIgKyBvcGVyYW5kSWR4KTsKLSAgICAgICAgICAgIG9wZXJhbmQudXNl KCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICBkZWZhdWx0OgogICAg ICAgICAgICAgQ1JBU0goKTsKICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9CiAgICAgfQog CiAgICAgZmx1c2hSZWdpc3RlcnMoKTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL25ldy1h cnJheS1rZWVwLXBhcmFtcy1saXZlLWluLW9zcmV4aXQtZGZnLXNsb3ctcGF0aC5qcyBiL0pTVGVz dHMvc3RyZXNzL25ldy1hcnJheS1rZWVwLXBhcmFtcy1saXZlLWluLW9zcmV4aXQtZGZnLXNsb3ct cGF0aC5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLmJhNDI0YWJi MzlmYwotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL25ldy1hcnJheS1rZWVwLXBh cmFtcy1saXZlLWluLW9zcmV4aXQtZGZnLXNsb3ctcGF0aC5qcwpAQCAtMCwwICsxLDIxIEBACisv L0AgcmVxdWlyZU9wdGlvbnMoIi0tdXNlQ29uY3VycmVudEpJVD0wIC0taml0UG9saWN5U2NhbGU9 MC4wMDEiKQorCitmdW5jdGlvbiBtYWluKCkgeworICBjb25zdCB2NzUgPSB7fTsKKyAgdjc1Ll9f cHJvdG9fXyA9IE9iamVjdDsKKyAgT2JqZWN0LmRlZmluZVByb3BlcnR5KE9iamVjdCwgMTE3OTgy OTQ5LCB7fSk7CisgIGxldCB2MTE5ID0gMDsKKyAgd2hpbGUgKHYxMTkgPCAxMCkgeworICAgIGZ1 bmN0aW9uIHYxMjEoKSB7CisgICAgICBmb3IgKGxldCB2MTMwID0gMDsgdjEzMCA8IDEwMDsgdjEz MCsrKSB7fQorICAgICAgY29uc3QgdjE0MiA9IFsyLjEsICBOYU5dOworICAgICAgaWYgKHYxNDJb MF0gPT09IHVuZGVmaW5lZCkKKyAgICAgICAgdGhyb3cgJ0Vycm9yOiB2YWx1ZSBzaG91bGQgbm90 IGJlY29tZSB1bmRlZmluZWQnCisgICAgfQorICAgIHYxMjEoKQorICAgIHYxMTkrKzsKKyAgfQor fQorbm9ERkcobWFpbik7Citub0ZUTChtYWluKTsKK21haW4oKTsK 462917 2022-10-10 16:01:16 -0700 2022-11-12 09:37:50 -0800 Patch bug-245468-20221010160115.patch text/plain 6271 d_degazio RnJvbSA0NDQ0NGVkODMzZGMyZTAzN2Y3ZmFkM2ViYmYxZDc3NDZiODNjMTc4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBEZWdhemlvIDwzNTE0NjIwMStkZGVnYXppb0B1c2Vy cy5ub3JlcGx5LmdpdGh1Yi5jb20+CkRhdGU6IE1vbiwgMTAgT2N0IDIwMjIgMTU6MTM6NDAgLTA3 MDAKU3ViamVjdDogW1BBVENIXSBBIGxpdmUgbm9kZSBiZWNvbWVzIHVuZGVmaW5lZCBpbiBPU1Ig RXhpdAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NTQ2OCByZGFy Oi8vMTAwNDk3Nzk3CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogSlNUZXN0cy9zdHJl c3MvbmV3LWFycmF5LWtlZXAtcGFyYW1zLWxpdmUtaW4tb3NyZXhpdC1kZmctc2xvdy1wYXRoLmpz OiBBZGRlZC4KKG1haW4udjEyMSk6CihtYWluKToKKiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1NwZWN1bGF0aXZlSklULmNwcDoKLS0tCiAuLi4vSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklULmNwcCAgfCA2MiArKysrKysrKysrKy0tLS0tLS0tCiAuLi5lcC1wYXJhbXMt bGl2ZS1pbi1vc3JleGl0LWRmZy1zbG93LXBhdGguanMgfCAyMSArKysrKysrCiAyIGZpbGVzIGNo YW5nZWQsIDU2IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAw NjQ0IEpTVGVzdHMvc3RyZXNzL25ldy1hcnJheS1rZWVwLXBhcmFtcy1saXZlLWluLW9zcmV4aXQt ZGZnLXNsb3ctcGF0aC5qcwoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHU3BlY3VsYXRpdmVKSVQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVC5jcHAKaW5kZXggMmJkOTE3OGQ4ZDFiLi45M2RhNmMxNGJhMGEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCkBAIC05NjQ5 LDUzICs5NjQ5LDYxIEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVOZXdBcnJheShOb2Rl KiBub2RlKQogICAgIHNpemVfdCBzY3JhdGNoU2l6ZSA9IHNpemVvZihFbmNvZGVkSlNWYWx1ZSkg KiBub2RlLT5udW1DaGlsZHJlbigpOwogICAgIFNjcmF0Y2hCdWZmZXIqIHNjcmF0Y2hCdWZmZXIg PSB2bSgpLnNjcmF0Y2hCdWZmZXJGb3JTaXplKHNjcmF0Y2hTaXplKTsKICAgICBFbmNvZGVkSlNW YWx1ZSogYnVmZmVyID0gc2NyYXRjaEJ1ZmZlciA/IHN0YXRpY19jYXN0PEVuY29kZWRKU1ZhbHVl Kj4oc2NyYXRjaEJ1ZmZlci0+ZGF0YUJ1ZmZlcigpKSA6IG51bGxwdHI7Ci0KLSAgICBmb3IgKHVu c2lnbmVkIG9wZXJhbmRJZHggPSAwOyBvcGVyYW5kSWR4IDwgbm9kZS0+bnVtQ2hpbGRyZW4oKTsg KytvcGVyYW5kSWR4KSB7CisgICAgc3dpdGNoIChub2RlLT5pbmRleGluZ1R5cGUoKSkgewogICAg ICAgICAvLyBOZWVkIHRvIHBlcmZvcm0gdGhlIHNwZWN1bGF0aW9ucyB0aGF0IHRoaXMgbm9kZSBw cm9taXNlcyB0byBwZXJmb3JtLiBJZiB3ZSdyZQogICAgICAgICAvLyBlbWl0dGluZyBjb2RlIGhl cmUgYW5kIHRoZSBpbmRleGluZyB0eXBlIGlzIG5vdCBhcnJheSBzdG9yYWdlIHRoZW4gdGhlcmUg aXMKICAgICAgICAgLy8gcHJvYmFibHkgc29tZXRoaW5nIGhpbGFyaW91cyBnb2luZyBvbiBhbmQg d2UncmUgYWxyZWFkeSBmYWlsaW5nIGF0IGFsbCB0aGUKICAgICAgICAgLy8gdGhpbmdzLCBidXQg YXQgbGVhc3Qgd2UncmUgZ29pbmcgdG8gYmUgc291bmQuCi0gICAgICAgIEVkZ2UgdXNlID0gbV9n cmFwaC5tX3ZhckFyZ0NoaWxkcmVuW25vZGUtPmZpcnN0Q2hpbGQoKSArIG9wZXJhbmRJZHhdOwot ICAgICAgICBzd2l0Y2ggKG5vZGUtPmluZGV4aW5nVHlwZSgpKSB7Ci0gICAgICAgIGNhc2UgQUxM X0JMQU5LX0lOREVYSU5HX1RZUEVTOgotICAgICAgICBjYXNlIEFMTF9VTkRFQ0lERURfSU5ERVhJ TkdfVFlQRVM6Ci0gICAgICAgICAgICBDUkFTSCgpOwotICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgIGNhc2UgQUxMX0RPVUJMRV9JTkRFWElOR19UWVBFUzogewotICAgICAgICAgICAgU3BlY3Vs YXRlRG91YmxlT3BlcmFuZCBvcGVyYW5kKHRoaXMsIHVzZSk7Ci0gICAgICAgICAgICBGUFJSZWcg b3BGUFIgPSBvcGVyYW5kLmZwcigpOwotICAgICAgICAgICAgREZHX1RZUEVfQ0hFQ0soCi0gICAg ICAgICAgICAgICAgSlNWYWx1ZVJlZ3MoKSwgdXNlLCBTcGVjRG91YmxlUmVhbCwKLSAgICAgICAg ICAgICAgICBtX2ppdC5icmFuY2hJZk5hTihvcEZQUikpOworICAgICAgICAgICAgZm9yICh1bnNp Z25lZCBvcGVyYW5kSWR4ID0gMDsgb3BlcmFuZElkeCA8IG5vZGUtPm51bUNoaWxkcmVuKCk7ICsr b3BlcmFuZElkeCkgeworICAgICAgICAgICAgICAgIEVkZ2UgdXNlID0gbV9ncmFwaC5tX3ZhckFy Z0NoaWxkcmVuW25vZGUtPmZpcnN0Q2hpbGQoKSArIG9wZXJhbmRJZHhdOworICAgICAgICAgICAg ICAgIFNwZWN1bGF0ZURvdWJsZU9wZXJhbmQgb3BlcmFuZCh0aGlzLCB1c2UpOworICAgICAgICAg ICAgICAgIEZQUlJlZyBvcEZQUiA9IG9wZXJhbmQuZnByKCk7CisgICAgICAgICAgICAgICAgREZH X1RZUEVfQ0hFQ0soCisgICAgICAgICAgICAgICAgICAgIEpTVmFsdWVSZWdzKCksIHVzZSwgU3Bl Y0RvdWJsZVJlYWwsCisgICAgICAgICAgICAgICAgICAgIG1faml0LmJyYW5jaElmTmFOKG9wRlBS KSk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIG9wZXJhbmRJZHgg PSAwOyBvcGVyYW5kSWR4IDwgbm9kZS0+bnVtQ2hpbGRyZW4oKTsgKytvcGVyYW5kSWR4KSB7Cisg ICAgICAgICAgICAgICAgRWRnZSB1c2UgPSBtX2dyYXBoLm1fdmFyQXJnQ2hpbGRyZW5bbm9kZS0+ Zmlyc3RDaGlsZCgpICsgb3BlcmFuZElkeF07CisgICAgICAgICAgICAgICAgU3BlY3VsYXRlRG91 YmxlT3BlcmFuZCBvcGVyYW5kKHRoaXMsIHVzZSk7CisgICAgICAgICAgICAgICAgRlBSUmVnIG9w RlBSID0gb3BlcmFuZC5mcHIoKTsKICNpZiBVU0UoSlNWQUxVRTY0KQotICAgICAgICAgICAgSlNW YWx1ZVJlZ3NUZW1wb3Jhcnkgc2NyYXRjaCh0aGlzKTsKLSAgICAgICAgICAgIEpTVmFsdWVSZWdz IHNjcmF0Y2hSZWdzID0gc2NyYXRjaC5yZWdzKCk7Ci0gICAgICAgICAgICBtX2ppdC5ib3hEb3Vi bGUob3BGUFIsIHNjcmF0Y2hSZWdzKTsKLSAgICAgICAgICAgIG1faml0LnN0b3JlVmFsdWUoc2Ny YXRjaFJlZ3MsIGJ1ZmZlciArIG9wZXJhbmRJZHgpOworICAgICAgICAgICAgICAgIEpTVmFsdWVS ZWdzVGVtcG9yYXJ5IHNjcmF0Y2godGhpcyk7CisgICAgICAgICAgICAgICAgSlNWYWx1ZVJlZ3Mg c2NyYXRjaFJlZ3MgPSBzY3JhdGNoLnJlZ3MoKTsKKyAgICAgICAgICAgICAgICBtX2ppdC5ib3hE b3VibGUob3BGUFIsIHNjcmF0Y2hSZWdzKTsKKyAgICAgICAgICAgICAgICBtX2ppdC5zdG9yZVZh bHVlKHNjcmF0Y2hSZWdzLCBidWZmZXIgKyBvcGVyYW5kSWR4KTsKICNlbHNlCi0gICAgICAgICAg ICBtX2ppdC5zdG9yZURvdWJsZShvcEZQUiwgVHJ1c3RlZEltbVB0cihidWZmZXIgKyBvcGVyYW5k SWR4KSk7CisgICAgICAgICAgICAgICAgbV9qaXQuc3RvcmVEb3VibGUob3BGUFIsIFRydXN0ZWRJ bW1QdHIoYnVmZmVyICsgb3BlcmFuZElkeCkpOwogI2VuZGlmCi0gICAgICAgICAgICBvcGVyYW5k LnVzZSgpOworICAgICAgICAgICAgICAgIG9wZXJhbmQudXNlKCk7CisgICAgICAgICAgICB9CiAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICBjYXNlIEFMTF9JTlQzMl9JTkRF WElOR19UWVBFUzoKICAgICAgICAgY2FzZSBBTExfQ09OVElHVU9VU19JTkRFWElOR19UWVBFUzoK ICAgICAgICAgY2FzZSBBTExfQVJSQVlfU1RPUkFHRV9JTkRFWElOR19UWVBFUzogewotICAgICAg ICAgICAgSlNWYWx1ZU9wZXJhbmQgb3BlcmFuZCh0aGlzLCB1c2UsIE1hbnVhbE9wZXJhbmRTcGVj dWxhdGlvbik7Ci0gICAgICAgICAgICBKU1ZhbHVlUmVncyBvcGVyYW5kUmVncyA9IG9wZXJhbmQu anNWYWx1ZVJlZ3MoKTsKICAgICAgICAgICAgIGlmIChoYXNJbnQzMihub2RlLT5pbmRleGluZ1R5 cGUoKSkpIHsKLSAgICAgICAgICAgICAgICBERkdfVFlQRV9DSEVDSygKLSAgICAgICAgICAgICAg ICAgICAgb3BlcmFuZFJlZ3MsIHVzZSwgU3BlY0ludDMyT25seSwKLSAgICAgICAgICAgICAgICAg ICAgbV9qaXQuYnJhbmNoSWZOb3RJbnQzMihvcGVyYW5kUmVncykpOworICAgICAgICAgICAgICAg IGZvciAodW5zaWduZWQgb3BlcmFuZElkeCA9IDA7IG9wZXJhbmRJZHggPCBub2RlLT5udW1DaGls ZHJlbigpOyArK29wZXJhbmRJZHgpIHsKKyAgICAgICAgICAgICAgICAgICAgRWRnZSB1c2UgPSBt X2dyYXBoLm1fdmFyQXJnQ2hpbGRyZW5bbm9kZS0+Zmlyc3RDaGlsZCgpICsgb3BlcmFuZElkeF07 CisgICAgICAgICAgICAgICAgICAgIEpTVmFsdWVPcGVyYW5kIG9wZXJhbmQodGhpcywgdXNlLCBN YW51YWxPcGVyYW5kU3BlY3VsYXRpb24pOworICAgICAgICAgICAgICAgICAgICBKU1ZhbHVlUmVn cyBvcGVyYW5kUmVncyA9IG9wZXJhbmQuanNWYWx1ZVJlZ3MoKTsKKyAgICAgICAgICAgICAgICAg ICAgREZHX1RZUEVfQ0hFQ0soCisgICAgICAgICAgICAgICAgICAgICAgICBvcGVyYW5kUmVncywg dXNlLCBTcGVjSW50MzJPbmx5LAorICAgICAgICAgICAgICAgICAgICAgICAgbV9qaXQuYnJhbmNo SWZOb3RJbnQzMihvcGVyYW5kUmVncykpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAg IH0KKyAgICAgICAgICAgIGZvciAodW5zaWduZWQgb3BlcmFuZElkeCA9IDA7IG9wZXJhbmRJZHgg PCBub2RlLT5udW1DaGlsZHJlbigpOyArK29wZXJhbmRJZHgpIHsKKyAgICAgICAgICAgICAgICBF ZGdlIHVzZSA9IG1fZ3JhcGgubV92YXJBcmdDaGlsZHJlbltub2RlLT5maXJzdENoaWxkKCkgKyBv cGVyYW5kSWR4XTsKKyAgICAgICAgICAgICAgICBKU1ZhbHVlT3BlcmFuZCBvcGVyYW5kKHRoaXMs IHVzZSwgTWFudWFsT3BlcmFuZFNwZWN1bGF0aW9uKTsKKyAgICAgICAgICAgICAgICBKU1ZhbHVl UmVncyBvcGVyYW5kUmVncyA9IG9wZXJhbmQuanNWYWx1ZVJlZ3MoKTsKKyAgICAgICAgICAgICAg ICBtX2ppdC5zdG9yZVZhbHVlKG9wZXJhbmRSZWdzLCBidWZmZXIgKyBvcGVyYW5kSWR4KTsKKyAg ICAgICAgICAgICAgICBvcGVyYW5kLnVzZSgpOwogICAgICAgICAgICAgfQotICAgICAgICAgICAg bV9qaXQuc3RvcmVWYWx1ZShvcGVyYW5kUmVncywgYnVmZmVyICsgb3BlcmFuZElkeCk7Ci0gICAg ICAgICAgICBvcGVyYW5kLnVzZSgpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAg ICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIENSQVNIKCk7CiAgICAgICAgICAgICBicmVhazsK LSAgICAgICAgfQogICAgIH0KIAogICAgIGZsdXNoUmVnaXN0ZXJzKCk7CmRpZmYgLS1naXQgYS9K U1Rlc3RzL3N0cmVzcy9uZXctYXJyYXkta2VlcC1wYXJhbXMtbGl2ZS1pbi1vc3JleGl0LWRmZy1z bG93LXBhdGguanMgYi9KU1Rlc3RzL3N0cmVzcy9uZXctYXJyYXkta2VlcC1wYXJhbXMtbGl2ZS1p bi1vc3JleGl0LWRmZy1zbG93LXBhdGguanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwLi5iYTQyNGFiYjM5ZmMKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVz cy9uZXctYXJyYXkta2VlcC1wYXJhbXMtbGl2ZS1pbi1vc3JleGl0LWRmZy1zbG93LXBhdGguanMK QEAgLTAsMCArMSwyMSBAQAorLy9AIHJlcXVpcmVPcHRpb25zKCItLXVzZUNvbmN1cnJlbnRKSVQ9 MCAtLWppdFBvbGljeVNjYWxlPTAuMDAxIikKKworZnVuY3Rpb24gbWFpbigpIHsKKyAgY29uc3Qg djc1ID0ge307CisgIHY3NS5fX3Byb3RvX18gPSBPYmplY3Q7CisgIE9iamVjdC5kZWZpbmVQcm9w ZXJ0eShPYmplY3QsIDExNzk4Mjk0OSwge30pOworICBsZXQgdjExOSA9IDA7CisgIHdoaWxlICh2 MTE5IDwgMTApIHsKKyAgICBmdW5jdGlvbiB2MTIxKCkgeworICAgICAgZm9yIChsZXQgdjEzMCA9 IDA7IHYxMzAgPCAxMDA7IHYxMzArKykge30KKyAgICAgIGNvbnN0IHYxNDIgPSBbMi4xLCAgTmFO XTsKKyAgICAgIGlmICh2MTQyWzBdID09PSB1bmRlZmluZWQpCisgICAgICAgIHRocm93ICdFcnJv cjogdmFsdWUgc2hvdWxkIG5vdCBiZWNvbWUgdW5kZWZpbmVkJworICAgIH0KKyAgICB2MTIxKCkK KyAgICB2MTE5Kys7CisgIH0KK30KK25vREZHKG1haW4pOworbm9GVEwobWFpbik7CittYWluKCk7 Cg==