<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>245465</bug_id>
          
          <creation_ts>2022-09-21 00:02:59 -0700</creation_ts>
          <short_desc>recordStrokeLineWithColorAndThickness doesn&apos;t mark the state as having applied changes.</short_desc>
          <delta_ts>2022-11-10 09:33:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Woodrow">mattwoodrow</reporter>
          <assigned_to name="Matt Woodrow">mattwoodrow</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>george.pomas</cc>
    
    <cc>jon</cc>
    
    <cc>jwmerrill</cc>
    
    <cc>paul.neave</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1900044</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2022-09-21 00:02:59 -0700</bug_when>
    <thetext>&lt;rdar://98994290&gt;

The recordStrokeLineWithColorAndThickness optimised path skips serialising the state object, but fails to mark that we&apos;ve applied the necessary changes.

This means that you can then change state back to it&apos;s original value, and we won&apos;t detect that it changed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900045</commentid>
    <comment_count>1</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2022-09-21 00:05:17 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/4560</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900956</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-09-24 16:58:51 -0700</bug_when>
    <thetext>*** Bug 245145 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901366</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-09-26 19:20:05 -0700</bug_when>
    <thetext>Committed 254889@main (aabdfc49a52b): &lt;https://commits.webkit.org/254889@main&gt;

Reviewed commits have been landed. Closing PR #4560 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1906020</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-10-16 18:59:56 -0700</bug_when>
    <thetext>*** Bug 246498 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1906428</commentid>
    <comment_count>5</comment_count>
    <who name="Paul Neave">paul.neave</who>
    <bug_when>2022-10-18 03:27:36 -0700</bug_when>
    <thetext>Does anyone know when this fix will make its way into Safari? Issue is still present in iOS 16.0.3 and Safari TP. Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1908566</commentid>
    <comment_count>6</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-10-26 15:53:12 -0700</bug_when>
    <thetext>Please try it out with iOS 16.2 beta.

Apple does not comment on future releases, so we cannot discuss when it will be in shipping Safari.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1911562</commentid>
    <comment_count>7</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-11-10 09:33:45 -0800</bug_when>
    <thetext>*** Bug 247731 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>