<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24543</bug_id>
          
          <creation_ts>2009-03-12 01:13:51 -0700</creation_ts>
          <short_desc>Rename KURL::isLocalFile() to isFileURL()</short_desc>
          <delta_ts>2023-07-14 15:33:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>257316</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Julien Chaffraix">jchaffraix</reporter>
          <assigned_to name="Julien Chaffraix">jchaffraix</assigned_to>
          <cc>annevk</cc>
    
    <cc>ap</cc>
    
    <cc>darin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>113327</commentid>
    <comment_count>0</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2009-03-12 01:13:51 -0700</bug_when>
    <thetext>This was raised during bug 22475.

To sum up what was said, isLocalFile is not totally right as the resource can be remote but mounted in the local filesystem. isFileURL would be more appropriate and stick to what the method is currently doing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>113334</commentid>
    <comment_count>1</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2009-03-12 01:38:22 -0700</bug_when>
    <thetext>Darin, could you tell us your thoughts about this renaming?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>113397</commentid>
    <comment_count>2</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-03-12 08:53:01 -0700</bug_when>
    <thetext>Seems OK.

I don&apos;t like the idea of repeating the class name, URL, in the function. Maybe it should be protocolIsFile to be a member of the &quot;protocol&quot; family of functions. If so, then it would be good to have a version that works on strings too, just like protocolIs. And have protocolIsJavaScript too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1966816</commentid>
    <comment_count>3</comment_count>
    <who name="Anne van Kesteren">annevk</who>
    <bug_when>2023-07-14 15:33:31 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 257316 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>