<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>245425</bug_id>
          
          <creation_ts>2022-09-20 07:09:13 -0700</creation_ts>
          <short_desc>REGRESSION (Safari 16): Service worker clientId is empty for web worker fetches</short_desc>
          <delta_ts>2023-04-04 20:09:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Service Workers</component>
          <version>Other</version>
          <rep_platform>All</rep_platform>
          <op_sys>iOS 16</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://github.com/web-platform-tests/wpt/pull/36068</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Critical</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>254938</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Ashley Gullen">ashley</reporter>
          <assigned_to name="youenn fablet">youennf</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ahmad.saleem792</cc>
    
    <cc>apple-rth</cc>
    
    <cc>ap</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cdumez</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1899806</commentid>
    <comment_count>0</comment_count>
    <who name="Ashley Gullen">ashley</who>
    <bug_when>2022-09-20 07:09:13 -0700</bug_when>
    <thetext>Safari 16 has a regression where the Service Worker fetch event for a web worker has an empty clientId. It works correctly in Chrome and in Safari 15.

Minimal repro: https://downloads.scirra.com/labs/swworker/

Load the page. Reload it so the SW becomes active. In its fetch event it logs every fetch with its URL and clientId. Open dev tools for the service worker to see these logs.

In Safari 16+ the clientId is empty for the worker fetches. In Safari 15 and Chrome it sets the correct clientId.

This breaks a paid-for feature (Remote Preview) in our commercial web app Construct (www.construct.net). Please fix it ASAP.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1899985</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-09-20 18:29:26 -0700</bug_when>
    <thetext>I only see &quot;Hello world from worker.js&quot; in Safari 15.6.1, so this test case doesn&apos;t confirm that this is a regression. And I&apos;m getting the same output from STP 153.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900083</commentid>
    <comment_count>2</comment_count>
    <who name="Ashley Gullen">ashley</who>
    <bug_when>2022-09-21 04:43:25 -0700</bug_when>
    <thetext>I did check iOS 15.7 and it was working there - don&apos;t forget to open the console for the Service Worker, it&apos;s easy to get mixed up between consoles...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900084</commentid>
    <comment_count>3</comment_count>
    <who name="Ashley Gullen">ashley</who>
    <bug_when>2022-09-21 04:44:22 -0700</bug_when>
    <thetext>(and don&apos;t forget the reload step to make sure the SW is active and actually intercepting fetches)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900951</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-09-24 16:55:48 -0700</bug_when>
    <thetext>Yes, I wasn&apos;t looking at the service worker console, thank you for the clarification.

I could confirm with STP, and it worked correctly with Safari 15.6.1. Didn&apos;t try Safari 16, but it&apos;s known to be broken there per your report.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900952</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-09-24 16:56:00 -0700</bug_when>
    <thetext>&lt;rdar://problem/100368228&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901107</commentid>
    <comment_count>6</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2022-09-26 00:53:01 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/4696</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901112</commentid>
    <comment_count>7</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2022-09-26 01:07:35 -0700</bug_when>
    <thetext>Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/36068</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901699</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-09-28 00:24:06 -0700</bug_when>
    <thetext>Committed 254944@main (6facf7d89d16): &lt;https://commits.webkit.org/254944@main&gt;

Reviewed commits have been landed. Closing PR #4696 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901854</commentid>
    <comment_count>9</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-09-28 13:24:31 -0700</bug_when>
    <thetext>Reverted by https://github.com/WebKit/WebKit/pull/4801</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901855</commentid>
    <comment_count>10</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-09-28 13:24:34 -0700</bug_when>
    <thetext>Re-opening for pull request https://github.com/WebKit/WebKit/pull/4801</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901858</commentid>
    <comment_count>11</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-09-28 13:30:09 -0700</bug_when>
    <thetext>Committed 254966@main (828a55516a7e): &lt;https://commits.webkit.org/254966@main&gt;

Reviewed commits have been landed. Closing PR #4801 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901879</commentid>
    <comment_count>12</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-09-28 15:18:05 -0700</bug_when>
    <thetext>So, reopening.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1925813</commentid>
    <comment_count>13</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2023-01-16 06:49:42 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/8694</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1926272</commentid>
    <comment_count>14</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-18 08:50:28 -0800</bug_when>
    <thetext>Committed 259031@main (599d00ac6774): &lt;https://commits.webkit.org/259031@main&gt;

Reviewed commits have been landed. Closing PR #8694 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>