24541 2009-03-11 19:38:29 -0700 Scrolling with home and end keys not always works 2009-03-12 08:01:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 113305 0 gustavo 2009-03-11 19:38:29 -0700 Pressing the home and end keys not always work, and some times doesn't scroll to the beginning/end of the page. Try opening this page, click the view, click the down arrow, then click home, for instance. 113314 1 28519 gustavo 2009-03-11 20:40:02 -0700 Created attachment 28519 proposed fix 113373 2 gustavo 2009-03-12 06:12:45 -0700 I found that on some sites, such as orkut, pgdown/pgup also do not work at all. I'll add another patch for that here. 113384 3 28528 gustavo 2009-03-12 07:31:10 -0700 Created attachment 28528 also make this work correctly for page up/down If you want to test the problem/fix use the bugzilla review page. The top frame doesn't scroll correctly with pgup/down. 113386 4 28528 alp 2009-03-12 07:52:03 -0700 Comment on attachment 28528 also make this work correctly for page up/down r=me Hope we'll tidy up the keypress/scrolling code soon though. 113387 5 28519 alp 2009-03-12 07:52:30 -0700 Comment on attachment 28519 proposed fix r=me Will do until this code is cleaned up to get the basic functionality. 113388 6 gustavo 2009-03-12 07:54:49 -0700 (In reply to comment #4) > (From update of attachment 28528 [review]) > r=me > > Hope we'll tidy up the keypress/scrolling code soon though. > Yeah, like I said in the spacebar bug, and on IRC, I think we need to review scrolling as a whole for the GTK+ port. I'd like to start that by implementing Scrollview::scroll. Time allowing, I'll do it. 113389 7 gustavo 2009-03-12 08:01:06 -0700 Landed as r41624 and r41625. 28519 2009-03-11 20:40:02 -0700 2009-03-12 07:52:30 -0700 proposed fix homeend.patch text/plain 2067 gustavo RnJvbSA3NWFiMzgyODdjNTg0MjlmYWM2YjIwNzBlOTVkYzE5ZGI2ZTAzNmNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUaHUsIDEyIE1hciAyMDA5IDAwOjM3OjAxIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g MjAwOS0wMy0xMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KCiAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDU0MQogICAgICAgIFNjcm9sbGluZyB3aXRoIGhvbWUg YW5kIGVuZCBrZXlzIG5vdCBhbHdheXMgd29ya3MKCiAgICAgICAgTWFrZSBob21lIGFuZCBlbmQg a2V5cyBiZWhhdmUgbW9yZSBjb25zaXN0ZW50bHkgZm9yIHNjcm9sbGluZyB0aGUKICAgICAgICB2 aWV3LgoKICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKLS0tCiBXZWJLaXQvZ3Rr L0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBXZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAgIDQgKystLQogMiBmaWxlcyBjaGFuZ2VkLCAx NCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsv Q2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggM2JhZGE0Ny4uMWU4Mzk4OCAx MDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wMy0xMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8 Z25zQGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ1NDEKKyAg ICAgICAgU2Nyb2xsaW5nIHdpdGggaG9tZSBhbmQgZW5kIGtleXMgbm90IGFsd2F5cyB3b3Jrcwor CisgICAgICAgIE1ha2UgaG9tZSBhbmQgZW5kIGtleXMgYmVoYXZlIG1vcmUgY29uc2lzdGVudGx5 IGZvciBzY3JvbGxpbmcgdGhlCisgICAgICAgIHZpZXcuCisKKyAgICAgICAgKiB3ZWJraXQvd2Vi a2l0d2Vidmlldy5jcHA6CisKIDIwMDktMDMtMTAgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEhvbGdlciBGcmV5dGhlci4KZGlmZiAtLWdpdCBh L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2Vidmlldy5jcHAKaW5kZXggZDg3NjM1Zi4uMDk2NDFkNyAxMDA2NDQKLS0tIGEvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2Vidmlldy5jcHAKQEAgLTQ1MSwxMCArNDUxLDEwIEBAIHN0YXRpYyBnYm9vbGVhbiB3 ZWJraXRfd2ViX3ZpZXdfa2V5X3ByZXNzX2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVu dEtleSoKICAgICAgICAgdmlldy0+c2Nyb2xsQnkoSW50U2l6ZSgtY1Njcm9sbGJhclBpeGVsc1Bl ckxpbmVTdGVwLCAwKSk7CiAgICAgICAgIHJldHVybiBUUlVFOwogICAgIGNhc2UgR0RLX0hvbWU6 Ci0gICAgICAgIGZyYW1lLT5zZWxlY3Rpb24oKS0+bW9kaWZ5KGFsdGVyYXRpb24sIFNlbGVjdGlv bkNvbnRyb2xsZXI6OkJBQ0tXQVJELCBEb2N1bWVudEJvdW5kYXJ5LCB0cnVlKTsKKyAgICAgICAg dmlldy0+c2Nyb2xsQnkoSW50U2l6ZSgwLCAtdmlldy0+Y29udGVudHNIZWlnaHQoKSkpOwogICAg ICAgICByZXR1cm4gVFJVRTsKICAgICBjYXNlIEdES19FbmQ6Ci0gICAgICAgIGZyYW1lLT5zZWxl Y3Rpb24oKS0+bW9kaWZ5KGFsdGVyYXRpb24sIFNlbGVjdGlvbkNvbnRyb2xsZXI6OkZPUldBUkQs IERvY3VtZW50Qm91bmRhcnksIHRydWUpOworICAgICAgICB2aWV3LT5zY3JvbGxCeShJbnRTaXpl KDAsIHZpZXctPmNvbnRlbnRzSGVpZ2h0KCkpKTsKICAgICAgICAgcmV0dXJuIFRSVUU7CiAgICAg fQogCi0tIAoxLjYuMgoK 28528 2009-03-12 07:31:10 -0700 2009-03-12 07:52:03 -0700 also make this work correctly for page up/down pgupdown.patch text/plain 2402 gustavo RnJvbSAzYjgzOGExMTdhNDUyMGJjNTI4YzIxMDVhMTRlOGI2ZjljYmI2Y2ZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUaHUsIDEyIE1hciAyMDA5IDExOjI2OjQwIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g MjAwOS0wMy0xMiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KCiAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDU0MQogICAgICAgIFNjcm9sbGluZyB3aXRoIGhvbWUg YW5kIGVuZCBrZXlzIG5vdCBhbHdheXMgd29ya3MKCiAgICAgICAgQWxzbyBtYWtlIHBhZ2UgdXAg YW5kIHBhZ2UgZG93biBrZXlzIGJlIGhhbmRsZWQgYnkgdGhlIHdlYnZpZXcga2V5CiAgICAgICAg ZXZlbnQgY29kZSwgc28gdGhhdCB0aGV5IGFsc28gd29yayBpbiBjYXNlcyB3aGVyZSB0aGUgR1RL KwogICAgICAgIHNjcm9sbGJhcnMgZG9uJ3QgaGFuZGxlIHRoZW0gZGlyZWN0bHksIGxpa2UgaW4g dGhlIGJ1Z3ppbGwncyBwYXRjaAogICAgICAgIHJldmlldyBwYWdlLgoKICAgICAgICAqIHdlYmtp dC93ZWJraXR3ZWJ2aWV3LmNwcDoKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwIHwgICAgNiArKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwg MCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktp dC9ndGsvQ2hhbmdlTG9nCmluZGV4IDg3Y2MzZjcuLjdjODMyYzQgMTAwNjQ0Ci0tLSBhL1dlYktp dC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC01LDYgKzUsMjAg QEAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NTQx CiAgICAgICAgIFNjcm9sbGluZyB3aXRoIGhvbWUgYW5kIGVuZCBrZXlzIG5vdCBhbHdheXMgd29y a3MKIAorICAgICAgICBBbHNvIG1ha2UgcGFnZSB1cCBhbmQgcGFnZSBkb3duIGtleXMgYmUgaGFu ZGxlZCBieSB0aGUgd2VidmlldyBrZXkKKyAgICAgICAgZXZlbnQgY29kZSwgc28gdGhhdCB0aGV5 IGFsc28gd29yayBpbiBjYXNlcyB3aGVyZSB0aGUgR1RLKworICAgICAgICBzY3JvbGxiYXJzIGRv bid0IGhhbmRsZSB0aGVtIGRpcmVjdGx5LCBsaWtlIGluIHRoZSBidWd6aWxsJ3MgcGF0Y2gKKyAg ICAgICAgcmV2aWV3IHBhZ2UuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6 CisKKzIwMDktMDMtMTIgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NTQxCisgICAgICAgIFNjcm9sbGluZyB3 aXRoIGhvbWUgYW5kIGVuZCBrZXlzIG5vdCBhbHdheXMgd29ya3MKKwogICAgICAgICBNYWtlIGhv bWUgYW5kIGVuZCBrZXlzIGJlaGF2ZSBtb3JlIGNvbnNpc3RlbnRseSBmb3Igc2Nyb2xsaW5nIHRo ZQogICAgICAgICB2aWV3LgogCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDRj YzYwOGIuLmJlZDQ1ZDUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC00NTYs NiArNDU2LDEyIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfa2V5X3ByZXNzX2V2 ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEtleSoKICAgICAgICAgZWxzZQogICAgICAg ICAgICAgdmlldy0+c2Nyb2xsQnkoSW50U2l6ZSgwLCB2aWV3LT52aXNpYmxlSGVpZ2h0KCkpKTsK ICAgICAgICAgcmV0dXJuIFRSVUU7CisgICAgY2FzZSBHREtfUGFnZV9VcDoKKyAgICAgICAgdmll dy0+c2Nyb2xsQnkoSW50U2l6ZSgwLCAtdmlldy0+dmlzaWJsZUhlaWdodCgpKSk7CisgICAgICAg IHJldHVybiBUUlVFOworICAgIGNhc2UgR0RLX1BhZ2VfRG93bjoKKyAgICAgICAgdmlldy0+c2Ny b2xsQnkoSW50U2l6ZSgwLCB2aWV3LT52aXNpYmxlSGVpZ2h0KCkpKTsKKyAgICAgICAgcmV0dXJu IFRSVUU7CiAgICAgY2FzZSBHREtfSG9tZToKICAgICAgICAgdmlldy0+c2Nyb2xsQnkoSW50U2l6 ZSgwLCAtdmlldy0+Y29udGVudHNIZWlnaHQoKSkpOwogICAgICAgICByZXR1cm4gVFJVRTsKLS0g CjEuNi4yCgo=