24536 2009-03-11 19:17:16 -0700 Cannot resolve include file 2009-07-13 11:35:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED P2 Normal --- 27065 1 norbert.leser webkit-unassigned hausmann laszlo.gombos mrowe oldest_to_newest 113291 0 norbert.leser 2009-03-11 19:17:16 -0700 Symbian compilers cannot resolve certain missing include files in first compile pass. The specific header files missing can only indirectly be resolved. The proposed fix is to explicitly declare the header files in the respective files where they are required. I propose to add these unconditionally, since it is unambiguous for any other compilers as well. See attached patch. 113292 1 28512 norbert.leser 2009-03-11 19:18:03 -0700 Created attachment 28512 Proposed fix for bug 24536 113298 2 mrowe 2009-03-11 19:30:30 -0700 Why are these extra includes necessary? RefPtr.h has no dependency on the contents of PassRefPtr.h, so I'm not sure why your patch adds that include. The change to ProfileGenerator.cpp also appears to be bogus, as it already includes Profile.h. 113303 3 mrowe 2009-03-11 19:36:33 -0700 Your changelog should also have a name rather than Nokia User. 113614 4 28582 norbert.leser 2009-03-13 10:25:54 -0700 Created attachment 28582 Cleaned-up patch for 24536 According to review comments: - I removed the change for RefPtr.h (we will resolve this with a compiler fix rather than webkit code change). - I removed the second include Profile.h. This was omitted in the initial patch. The intention was to change the order of header includes, and not to add a second Profile.h. Without this changed order, our compiler cannot resolve WTF::PassRefPtr<JSC::Profile>, as referenced in ProfileGenerator.h. 113632 5 28582 mrowe 2009-03-13 11:41:02 -0700 Comment on attachment 28582 Cleaned-up patch for 24536 In a .cpp file named Foo our policy is to include config.h first, followed by Foo.h, followed by any remaining headers that the file needs. It seems to me that if your compiler is choking on this code for some reason, it is buggy and should be fixed. 113650 6 darin 2009-03-13 12:18:41 -0700 Actually, looking at ProfileGenerator, I don’t understand why this line of code compiles: PassRefPtr<Profile> profile() const { return m_profile; } Without a definition of the class Profile, this should fail. I have no idea why this is working with other compilers. The correct fix for this is to change ProfileGenerator.h to include Profile.h, though, not to reorder includes ProfileGenerator.cpp. 113657 7 norbert.leser 2009-03-13 12:32:38 -0700 (In reply to comment #6) > Actually, looking at ProfileGenerator, I don’t understand why this line of code > compiles: > > PassRefPtr<Profile> profile() const { return m_profile; } > > Without a definition of the class Profile, this should fail. I have no idea why > this is working with other compilers. The correct fix for this is to change > ProfileGenerator.h to include Profile.h, though, not to reorder includes > ProfileGenerator.cpp. > That is fine with me. That would have been my alternate suggestion as well, if you want to keep the order in the implementation file. I believe, the class Profile forward declaration will be redundant then and can be removed. 120476 8 30144 norbert.leser 2009-05-08 15:34:56 -0700 Created attachment 30144 Updated patch for bug 24536 Updated patch according to Darin's suggestion of adding Profile.h to ProfileGenerator.h instead of ProfileGenerator.cpp 120675 9 zecke 2009-05-11 09:23:25 -0700 In the future please add the bug number to the changelog. Landed in r43495. 28512 2009-03-11 19:18:03 -0700 2009-03-13 10:25:54 -0700 Proposed fix for bug 24536 patch_fix04.txt text/plain 1299 norbert.leser SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQxNjAxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMTEgIE5va2lhIFVz ZXIgIDxub3JiZXJ0Lmxlc2VyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTeW1iaWFuIGNvbXBpbGVycyBjYW5ub3QgcmVzb2x2ZSBt aXNzaW5nIGluY2x1ZGUgcGF0aHMgaW4gZmlyc3QgY29tcGlsZSBwYXNzCisgICAgICAgIGR1ZSB0 byBpbmRpcmVjdG5lc3MuCisKKyAgICAgICAgKiBwcm9maWxlci9Qcm9maWxlR2VuZXJhdG9yLmNw cDoKKyAgICAgICAgKiB3dGYvUmVmUHRyLmg6CisKIDIwMDktMDMtMTEgIEFkYW0gUm9iZW4gIDxh cm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZSB0aGUgV2luZG93cyBpbXBsZW1lbnRh dGlvbiBvZiBUaHJlYWRTcGVjaWZpYyB0byB1c2UgZnVuY3Rpb25zCkluZGV4OiBKYXZhU2NyaXB0 Q29yZS9wcm9maWxlci9Qcm9maWxlR2VuZXJhdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2Ny aXB0Q29yZS9wcm9maWxlci9Qcm9maWxlR2VuZXJhdG9yLmNwcAkocmV2aXNpb24gNDE2MDEpCisr KyBKYXZhU2NyaXB0Q29yZS9wcm9maWxlci9Qcm9maWxlR2VuZXJhdG9yLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjQsNiArMjQsNyBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNs dWRlICJQcm9maWxlLmgiCiAjaW5jbHVkZSAiUHJvZmlsZUdlbmVyYXRvci5oIgogCiAjaW5jbHVk ZSAiQ2FsbEZyYW1lLmgiCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvUmVmUHRyLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1JlZlB0ci5oCShyZXZpc2lvbiA0MTYwMSkKKysr IEphdmFTY3JpcHRDb3JlL3d0Zi9SZWZQdHIuaAkod29ya2luZyBjb3B5KQpAQCAtMjMsNiArMjMs NyBAQAogCiAjaW5jbHVkZSA8YWxnb3JpdGhtPgogI2luY2x1ZGUgIkFsd2F5c0lubGluZS5oIgor I2luY2x1ZGUgIlBhc3NSZWZQdHIuaCIKIAogbmFtZXNwYWNlIFdURiB7CiAK 28582 2009-03-13 10:25:54 -0700 2009-05-08 15:34:56 -0700 Cleaned-up patch for 24536 patch_update1_24536.txt text/plain 1167 norbert.leser SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNDE2NjcpDQorKysgSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpDQpAQCAtMSwzICsxLDEzIEBADQorMjAwOS0wMy0xMyAgTm9y YmVydCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN5bWJpYW4gY29tcGlsZXJzIGNhbm5vdCBy ZXNvbHZlIFdURjo6UGFzc1JlZlB0cjxKU0M6OlByb2ZpbGU+CisgICAgICAgIHVubGVzcyBQcm9m aWxlLmggaXMgaW5jbHVkZWQgYmVmb3JlIFByb2ZpbGVHZW5lcmF0b3IuaAorICAgICAgICAoTW92 ZWQsIHRvIGNoYW5nZSBvcmRlciBvZiBpbmNsdWRlcykuCisgICAgICAgIAorICAgICAgICAqIHBy b2ZpbGVyL1Byb2ZpbGVHZW5lcmF0b3IuY3BwOgorCiAyMDA5LTAzLTEyICBNYXJrIFJvd2UgIDxt cm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4 OiBKYXZhU2NyaXB0Q29yZS9wcm9maWxlci9Qcm9maWxlR2VuZXJhdG9yLmNwcA0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQ0KLS0tIEphdmFTY3JpcHRDb3JlL3Byb2ZpbGVyL1Byb2ZpbGVHZW5lcmF0b3IuY3BwCShyZXZp c2lvbiA0MTY2NCkNCisrKyBKYXZhU2NyaXB0Q29yZS9wcm9maWxlci9Qcm9maWxlR2VuZXJhdG9y LmNwcAkod29ya2luZyBjb3B5KQ0KQEAgLTI0LDYgKzI0LDcgQEANCiAgKi8KIAogI2luY2x1ZGUg ImNvbmZpZy5oIgorI2luY2x1ZGUgIlByb2ZpbGUuaCIKICNpbmNsdWRlICJQcm9maWxlR2VuZXJh dG9yLmgiCiAKICNpbmNsdWRlICJDYWxsRnJhbWUuaCIKQEAgLTMxLDcgKzMyLDYgQEANCiAjaW5j bHVkZSAiSlNTdHJpbmdSZWYuaCIKICNpbmNsdWRlICJKU0Z1bmN0aW9uLmgiCiAjaW5jbHVkZSAi SW50ZXJwcmV0ZXIuaCIKLSNpbmNsdWRlICJQcm9maWxlLmgiCiAjaW5jbHVkZSAiUHJvZmlsZXIu aCIKICNpbmNsdWRlICJUcmFjaW5nLmgiCiAK 30144 2009-05-08 15:34:56 -0700 2009-05-08 15:45:16 -0700 Updated patch for bug 24536 24536_patch.txt text/plain 963 norbert.leser SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQzNDEyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDUtMDggIE5vcmJlcnQg TGVzZXIgIDxub3JiZXJ0Lmxlc2VyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFN5bWJpYW4gY29tcGlsZXJzIGNhbm5v dCByZXNvbHZlIFdURjo6UGFzc1JlZlB0cjxKU0M6OlByb2ZpbGU+CisgICAgICAgIHVubGVzcyBQ cm9maWxlLmggaXMgaW5jbHVkZWQuCisKKyAgICAgICAgKiBwcm9maWxlci9Qcm9maWxlR2VuZXJh dG9yLmg6CisKIDIwMDktMDUtMDggIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4K IAogICAgICAgICBOb3QgcmV2aWV3ZWQuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9wcm9maWxlci9Q cm9maWxlR2VuZXJhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcHJvZmlsZXIv UHJvZmlsZUdlbmVyYXRvci5oCShyZXZpc2lvbiA0MzI3MCkKKysrIEphdmFTY3JpcHRDb3JlL3By b2ZpbGVyL1Byb2ZpbGVHZW5lcmF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYsNyBA QAogI2lmbmRlZiBQcm9maWxlR2VuZXJhdG9yX2gKICNkZWZpbmUgUHJvZmlsZUdlbmVyYXRvcl9o CiAKKyNpbmNsdWRlICJQcm9maWxlLmgiCiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNp bmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4K