24531 2009-03-11 17:29:08 -0700 Crash clicking around on animation-rich site 2009-03-11 17:52:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser cmarrin darin oldest_to_newest 113268 0 simon.fraser 2009-03-11 17:29:08 -0700 I got a crash in RenderLayer::currentTransform() when clicking around on an animation-heavy site (Apple internal). 113269 1 simon.fraser 2009-03-11 17:29:34 -0700 The problem is that getAnimatedStyleForRenderer() can return a null style, and is not expected to. 113270 2 28504 simon.fraser 2009-03-11 17:33:05 -0700 Created attachment 28504 Patch, changelog A testcase is hard, because it requires fast clicking. 113271 3 28504 darin 2009-03-11 17:35:58 -0700 Comment on attachment 28504 Patch, changelog Seems to me we could have just done this in AnimationControllerPrivate::getAnimatedStyleForRenderer and avoided passing that renderer down all those levels. Would that be better? 113274 4 simon.fraser 2009-03-11 17:42:32 -0700 Darin: I did it this way to avoid another RefPtr<RenderStyle> in getAnimatedStyleForRenderer(). But I can do it that way if you like. 113277 5 28506 simon.fraser 2009-03-11 17:46:07 -0700 Created attachment 28506 Revised patch 113280 6 28506 darin 2009-03-11 17:48:24 -0700 Comment on attachment 28506 Revised patch Seems way better. Don't forget to fix the change log to only mention the one file you changed. r=me 113281 7 simon.fraser 2009-03-11 17:52:24 -0700 Fixed changelog. http://trac.webkit.org/changeset/41603 28504 2009-03-11 17:33:05 -0700 2009-03-11 17:46:07 -0700 Patch, changelog 24531_patch.txt text/plain 4141 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGI1ZWFhMC4uZjY1NTMzYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAwOS0wMy0xMSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQ1MzEKKyAgICAgICAgCisgICAgICAgIE1ha2Ugc3VyZSB0aGF0IEFuaW1hdGlvbkNvbnRy b2xsZXJQcml2YXRlOjpnZXRBbmltYXRlZFN0eWxlRm9yUmVuZGVyZXIoKSBuZXZlcgorICAgICAg ICByZXR1cm5zIGEgbnVsbCBzdHlsZSBpZiBpdCBoYXMgYSB2YWxpZCByZW5kZXJlciwgd2hpY2gg Y291bGQgaGFwcGVuIGlmIGEKKyAgICAgICAgQ29tcG9zaXRlQW5pbWF0aW9uIGV4aXN0ZWQsIGJ1 dCB3YXNuJ3QgcnVubmluZyBhbnkgYW5pbWF0aW9ucyBvciB0cmFuc2l0aW9ucy4KKworICAgICAg ICAqIHBhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6QW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGU6OmdldEFuaW1hdGVkU3R5bGVGb3JSZW5k ZXJlcik6CisgICAgICAgICogcGFnZS9hbmltYXRpb24vQ29tcG9zaXRlQW5pbWF0aW9uLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2l0ZUFuaW1hdGlvblByaXZhdGU6OmdldEFuaW1hdGVk U3R5bGUpOgorICAgICAgICAoV2ViQ29yZTo6Q29tcG9zaXRlQW5pbWF0aW9uOjpnZXRBbmltYXRl ZFN0eWxlKToKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9Db21wb3NpdGVBbmltYXRpb24uaDoK KworMjAwOS0wMy0xMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwog ICAgICAgICBGaXggU2NvbnMgYnVpbGQuIFBhdGNoIGZyb20gQWxleGFuZGVyIEd1eS4KIAogICAg ICAgICAqIFdlYkNvcmUuc2NvbnM6CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9u L0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRp b25Db250cm9sbGVyLmNwcAppbmRleCBiZWFlNjMzLi5lMTk5ZmFlIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUv cGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQ29udHJvbGxlci5jcHAKQEAgLTI4Myw3ICsyODMsNyBA QCBQYXNzUmVmUHRyPFJlbmRlclN0eWxlPiBBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZTo6Z2V0 QW5pbWF0ZWRTdHlsZUZvclJlbmRlcmVyKAogICAgIC8vIE1ha2Ugc3VyZSBhbmltYXRpb25VcGRh dGVUaW1lIGlzIHVwZGF0ZWQsIHNvIHRoYXQgaXQgaXMgY3VycmVudCBldmVuIGlmIG5vCiAgICAg Ly8gc3R5bGVDaGFuZ2UgaGFzIGhhcHBlbmVkIChlLmcuIGFjY2VsZXJhdGVkIGFuaW1hdGlvbnMp LgogICAgIHNldEJlZ2luQW5pbWF0aW9uVXBkYXRlVGltZShjQmVnaW5BbmltYXRpb25VcGRhdGVU aW1lTm90U2V0KTsKLSAgICByZXR1cm4gcmVuZGVyZXJBbmltYXRpb25zLT5nZXRBbmltYXRlZFN0 eWxlKCk7CisgICAgcmV0dXJuIHJlbmRlcmVyQW5pbWF0aW9ucy0+Z2V0QW5pbWF0ZWRTdHlsZShy ZW5kZXJlcik7CiB9CiAKIHVuc2lnbmVkIEFuaW1hdGlvbkNvbnRyb2xsZXJQcml2YXRlOjpudW1i ZXJPZkFjdGl2ZUFuaW1hdGlvbnMoKSBjb25zdApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2Fu aW1hdGlvbi9Db21wb3NpdGVBbmltYXRpb24uY3BwIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9D b21wb3NpdGVBbmltYXRpb24uY3BwCmluZGV4IGQzODZmMWIuLjBiZTQ5MmYgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQ29tcG9zaXRlQW5pbWF0aW9uLmNwcAorKysgYi9XZWJD b3JlL3BhZ2UvYW5pbWF0aW9uL0NvbXBvc2l0ZUFuaW1hdGlvbi5jcHAKQEAgLTUzLDcgKzUzLDcg QEAgcHVibGljOgogICAgIHZvaWQgY2xlYXJSZW5kZXJlcigpOwogCiAgICAgUGFzc1JlZlB0cjxS ZW5kZXJTdHlsZT4gYW5pbWF0ZShSZW5kZXJPYmplY3QqLCBSZW5kZXJTdHlsZSogY3VycmVudFN0 eWxlLCBSZW5kZXJTdHlsZSogdGFyZ2V0U3R5bGUpOwotICAgIFBhc3NSZWZQdHI8UmVuZGVyU3R5 bGU+IGdldEFuaW1hdGVkU3R5bGUoKTsKKyAgICBQYXNzUmVmUHRyPFJlbmRlclN0eWxlPiBnZXRB bmltYXRlZFN0eWxlKFJlbmRlck9iamVjdCopOwogCiAgICAgQW5pbWF0aW9uQ29udHJvbGxlclBy aXZhdGUqIGFuaW1hdGlvbkNvbnRyb2xsZXJQcml2KCkgY29uc3QgeyByZXR1cm4gbV9hbmltYXRp b25Db250cm9sbGVyOyB9CiAKQEAgLTMxMCw3ICszMTAsNyBAQCBQYXNzUmVmUHRyPFJlbmRlclN0 eWxlPiBDb21wb3NpdGVBbmltYXRpb25Qcml2YXRlOjphbmltYXRlKFJlbmRlck9iamVjdCogcmVu ZGVyZQogICAgIHJldHVybiByZXN1bHRTdHlsZSA/IHJlc3VsdFN0eWxlLnJlbGVhc2UoKSA6IHRh cmdldFN0eWxlOwogfQogCi1QYXNzUmVmUHRyPFJlbmRlclN0eWxlPiBDb21wb3NpdGVBbmltYXRp b25Qcml2YXRlOjpnZXRBbmltYXRlZFN0eWxlKCkKK1Bhc3NSZWZQdHI8UmVuZGVyU3R5bGU+IENv bXBvc2l0ZUFuaW1hdGlvblByaXZhdGU6OmdldEFuaW1hdGVkU3R5bGUoUmVuZGVyT2JqZWN0KiBy ZW5kZXJlcikKIHsKICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+IHJlc3VsdFN0eWxlOwogICAgIENT U1Byb3BlcnR5VHJhbnNpdGlvbnNNYXA6OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IG1fdHJhbnNpdGlv bnMuZW5kKCk7CkBAIC0zMjUsNiArMzI1LDggQEAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gQ29t cG9zaXRlQW5pbWF0aW9uUHJpdmF0ZTo6Z2V0QW5pbWF0ZWRTdHlsZSgpCiAgICAgICAgICAgICBr ZXlmcmFtZUFuaW1hdGlvbi0+Z2V0QW5pbWF0ZWRTdHlsZShyZXN1bHRTdHlsZSk7CiAgICAgfQog ICAgIAorICAgIGlmICghcmVzdWx0U3R5bGUpCisgICAgICAgIHJlc3VsdFN0eWxlID0gcmVuZGVy ZXItPnN0eWxlKCk7CiAgICAgcmV0dXJuIHJlc3VsdFN0eWxlOwogfQogCkBAIC02NDIsOSArNjQ0 LDkgQEAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gQ29tcG9zaXRlQW5pbWF0aW9uOjphbmltYXRl KFJlbmRlck9iamVjdCogcmVuZGVyZXIsIFJlbmQKICAgICByZXR1cm4gbV9kYXRhLT5hbmltYXRl KHJlbmRlcmVyLCBjdXJyZW50U3R5bGUsIHRhcmdldFN0eWxlKTsKIH0KIAotUGFzc1JlZlB0cjxS ZW5kZXJTdHlsZT4gQ29tcG9zaXRlQW5pbWF0aW9uOjpnZXRBbmltYXRlZFN0eWxlKCkKK1Bhc3NS ZWZQdHI8UmVuZGVyU3R5bGU+IENvbXBvc2l0ZUFuaW1hdGlvbjo6Z2V0QW5pbWF0ZWRTdHlsZShS ZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogewotICAgIHJldHVybiBtX2RhdGEtPmdldEFuaW1hdGVk U3R5bGUoKTsKKyAgICByZXR1cm4gbV9kYXRhLT5nZXRBbmltYXRlZFN0eWxlKHJlbmRlcmVyKTsK IH0KIAogZG91YmxlIENvbXBvc2l0ZUFuaW1hdGlvbjo6d2lsbE5lZWRTZXJ2aWNlKCkgY29uc3QK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQ29tcG9zaXRlQW5pbWF0aW9uLmgg Yi9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0NvbXBvc2l0ZUFuaW1hdGlvbi5oCmluZGV4IGI1ODU3 YWEuLjBiNmVmZWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQ29tcG9zaXRl QW5pbWF0aW9uLmgKKysrIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9Db21wb3NpdGVBbmltYXRp b24uaApAQCAtNTgsNyArNTgsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBjbGVhclJlbmRlcmVyKCk7 CiAKICAgICBQYXNzUmVmUHRyPFJlbmRlclN0eWxlPiBhbmltYXRlKFJlbmRlck9iamVjdCosIFJl bmRlclN0eWxlKiBjdXJyZW50U3R5bGUsIFJlbmRlclN0eWxlKiB0YXJnZXRTdHlsZSk7Ci0gICAg UGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gZ2V0QW5pbWF0ZWRTdHlsZSgpOworICAgIFBhc3NSZWZQ dHI8UmVuZGVyU3R5bGU+IGdldEFuaW1hdGVkU3R5bGUoUmVuZGVyT2JqZWN0Kik7CiAKICAgICBk b3VibGUgd2lsbE5lZWRTZXJ2aWNlKCkgY29uc3Q7CiAgICAgCg== 28506 2009-03-11 17:46:07 -0700 2009-03-11 17:48:24 -0700 Revised patch 24531_patch.txt text/plain 1934 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGI1ZWFhMC4uZjY1NTMzYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAwOS0wMy0xMSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQ1MzEKKyAgICAgICAgCisgICAgICAgIE1ha2Ugc3VyZSB0aGF0IEFuaW1hdGlvbkNvbnRy b2xsZXJQcml2YXRlOjpnZXRBbmltYXRlZFN0eWxlRm9yUmVuZGVyZXIoKSBuZXZlcgorICAgICAg ICByZXR1cm5zIGEgbnVsbCBzdHlsZSBpZiBpdCBoYXMgYSB2YWxpZCByZW5kZXJlciwgd2hpY2gg Y291bGQgaGFwcGVuIGlmIGEKKyAgICAgICAgQ29tcG9zaXRlQW5pbWF0aW9uIGV4aXN0ZWQsIGJ1 dCB3YXNuJ3QgcnVubmluZyBhbnkgYW5pbWF0aW9ucyBvciB0cmFuc2l0aW9ucy4KKworICAgICAg ICAqIHBhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6QW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGU6OmdldEFuaW1hdGVkU3R5bGVGb3JSZW5k ZXJlcik6CisgICAgICAgICogcGFnZS9hbmltYXRpb24vQ29tcG9zaXRlQW5pbWF0aW9uLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2l0ZUFuaW1hdGlvblByaXZhdGU6OmdldEFuaW1hdGVk U3R5bGUpOgorICAgICAgICAoV2ViQ29yZTo6Q29tcG9zaXRlQW5pbWF0aW9uOjpnZXRBbmltYXRl ZFN0eWxlKToKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9Db21wb3NpdGVBbmltYXRpb24uaDoK KworMjAwOS0wMy0xMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwog ICAgICAgICBGaXggU2NvbnMgYnVpbGQuIFBhdGNoIGZyb20gQWxleGFuZGVyIEd1eS4KIAogICAg ICAgICAqIFdlYkNvcmUuc2NvbnM6CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9u L0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRp b25Db250cm9sbGVyLmNwcAppbmRleCBiZWFlNjMzLi4yMWYwMTQyIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUv cGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQ29udHJvbGxlci5jcHAKQEAgLTI4Myw3ICsyODMsMTEg QEAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gQW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGU6Omdl dEFuaW1hdGVkU3R5bGVGb3JSZW5kZXJlcigKICAgICAvLyBNYWtlIHN1cmUgYW5pbWF0aW9uVXBk YXRlVGltZSBpcyB1cGRhdGVkLCBzbyB0aGF0IGl0IGlzIGN1cnJlbnQgZXZlbiBpZiBubwogICAg IC8vIHN0eWxlQ2hhbmdlIGhhcyBoYXBwZW5lZCAoZS5nLiBhY2NlbGVyYXRlZCBhbmltYXRpb25z KS4KICAgICBzZXRCZWdpbkFuaW1hdGlvblVwZGF0ZVRpbWUoY0JlZ2luQW5pbWF0aW9uVXBkYXRl VGltZU5vdFNldCk7Ci0gICAgcmV0dXJuIHJlbmRlcmVyQW5pbWF0aW9ucy0+Z2V0QW5pbWF0ZWRT dHlsZSgpOworICAgIFJlZlB0cjxSZW5kZXJTdHlsZT4gYW5pbWF0aW5nU3R5bGUgPSByZW5kZXJl ckFuaW1hdGlvbnMtPmdldEFuaW1hdGVkU3R5bGUoKTsKKyAgICBpZiAoIWFuaW1hdGluZ1N0eWxl KQorICAgICAgICBhbmltYXRpbmdTdHlsZSA9IHJlbmRlcmVyLT5zdHlsZSgpOworICAgIAorICAg IHJldHVybiBhbmltYXRpbmdTdHlsZS5yZWxlYXNlKCk7CiB9CiAKIHVuc2lnbmVkIEFuaW1hdGlv bkNvbnRyb2xsZXJQcml2YXRlOjpudW1iZXJPZkFjdGl2ZUFuaW1hdGlvbnMoKSBjb25zdAo=