<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>245230</bug_id>
          
          <creation_ts>2022-09-15 10:01:03 -0700</creation_ts>
          <short_desc>[Filters] Limit the memory cost of FilterResults to 100MB</short_desc>
          <delta_ts>2023-06-01 14:47:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>242219</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Said Abou-Hallawa">sabouhallawa</reporter>
          <assigned_to name="Said Abou-Hallawa">sabouhallawa</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1898738</commentid>
    <comment_count>0</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2022-09-15 10:01:03 -0700</bug_when>
    <thetext>Allowing to cache many large FilterImages can cause a memory jetsam. We tried to solve this problem by not applying the filter if the number of filter effects exceeds a certain maximum (currently it is 100).

Instead we should look at the estimated total memory size if we cache all the results. But even if we decide to no cache the result because their memory will exceed a certain maximum (say 100 MB), we should still apply the SVGFilter without caching the results. This may be very inefficient especially with cases where a result FilterImage is used multiple times. Caching it saves time, but we have to regenerate it every time we need it. Of course this is better than not displaying anything for the filtered image.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898743</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-09-15 10:18:10 -0700</bug_when>
    <thetext>&lt;rdar://problem/99975678&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898745</commentid>
    <comment_count>2</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2022-09-15 10:24:30 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/4390</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1959422</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-06-01 14:47:42 -0700</bug_when>
    <thetext>Committed 264807@main (93ee37d30632): &lt;https://commits.webkit.org/264807@main&gt;

Reviewed commits have been landed. Closing PR #4390 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>