24523 2009-03-11 15:03:58 -0700 Add test to check that an invalid second argument of window.postMessage is ignored 2009-03-12 15:02:07 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pam pam ap oldest_to_newest 113235 0 pam 2009-03-11 15:03:58 -0700 Make sure that the second argument of window.postMessage is ignored if it's not a message port. 113236 1 28495 pam 2009-03-11 15:05:04 -0700 Created attachment 28495 New test + result 113325 2 ap 2009-03-12 01:09:25 -0700 Is this correct behavior, or an implementation quirk? I doubt that I fully investigated this case when writing the code - but HTML5 seems to imply that an exception should be raised. What does Firefox do? I don't think that using the test framework here helps much, as we don't have a long series of tests, and this isn't a fast/js test. As mentioned in another bug, such usage of successfullyParsed won't work in most interesting cases. 113418 3 28534 pam 2009-03-12 11:02:35 -0700 Created attachment 28534 Patch addressing Alexey's comments (In reply to comment #2) > Is this correct behavior, or an implementation quirk? I doubt that I fully > investigated this case when writing the code - but HTML5 seems to imply that an > exception should be raised. What does Firefox do? Firefox (Mac 3.0.7) raises an exception. The HTML4 spec doesn't say what to do. HTML5 does imply that an exception should be raised. I'd suggest adding this test as it is for now, to catch unintentional changes, and updating it when there's a deliberate switchover to HTML5 behavior. > I don't think that using the test framework here helps much, as we don't have a > long series of tests, and this isn't a fast/js test. As mentioned in another > bug, such usage of successfullyParsed won't work in most interesting cases. Yes, notice that successfullyParsed is not used in the normal way here, just inserted to make the output look like what people expect to see. In any case, I've pulled out the test framework in this patch, since as you say it's not adding much. 113424 4 28534 ap 2009-03-12 11:11:27 -0700 Comment on attachment 28534 Patch addressing Alexey's comments r=me - at least this tests that we don't crash! Please add a comment saying that the results are likely incorrect, so that the test doesn't scare away the person fixing the behavior. 113504 5 pam 2009-03-12 15:02:07 -0700 Comment added. Landed in r41651. 28495 2009-03-11 15:05:04 -0700 2009-03-12 11:02:35 -0700 New test + result 24523a.txt text/plain 3031 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQxNjAx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDMt MTEgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHRlc3QgdG8gY2hlY2sgdGhhdCBh biBpbnZhbGlkIHNlY29uZCBhcmd1bWVudCBvZgorICAgICAgICB3aW5kb3cucG9zdE1lc3NhZ2Ug aXMgaWdub3JlZC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjQ1MjMKKworICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3Nh Z2UtYXJncy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy93 aW5kb3ctcG9zdG1lc3NhZ2UtYXJncy5odG1sOiBBZGRlZC4KKwogMjAwOS0wMy0xMSAgUGFtZWxh IEdyZWVuZSAgPHBhbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5 IFByb3NrdXJ5YWtvdi4KSW5kZXg6IGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2Ut YXJncy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZmFzdC9kb20vV2luZG93L3dpbmRvdy1w b3N0bWVzc2FnZS1hcmdzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIGZhc3QvZG9tL1dp bmRvdy93aW5kb3ctcG9zdG1lc3NhZ2UtYXJncy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMTAgQEAKK0NoZWNrIHRoYXQgdGhlIHNlY29uZCBhcmd1bWVudCBvZiB3aW5kb3cu cG9zdE1lc3NhZ2UgaXMgaWdub3JlZCBpZiBpdCBpcyBub3QgYSBtZXNzYWdlIHBvcnQuCisKK09u IHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxv d2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIG1lc3NhZ2VDb3VudCBpcyA3CitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogZmFz dC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdzLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g ZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdzLmh0bWwJKHJldmlzaW9uIDAp CisrKyBmYXN0L2RvbS9XaW5kb3cvd2luZG93LXBvc3RtZXNzYWdlLWFyZ3MuaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw2MCBAQAorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVz aGVldCIgaHJlZj0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3Jp cHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9o ZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUi PjwvZGl2PgorCis8c2NyaXB0PgorZGVzY3JpcHRpb24oJ0NoZWNrIHRoYXQgdGhlIHNlY29uZCBh cmd1bWVudCBvZiB3aW5kb3cucG9zdE1lc3NhZ2UgaXMgaWdub3JlZCBpZiBpdCBpcyBub3QgYSBt ZXNzYWdlIHBvcnQuJyk7CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorCit2YXIgbWVzc2FnZUNvdW50ID0gMDsKK3ZhciBz dWNjZXNzZnVsbHlQYXJzZWQ7CisKK2Z1bmN0aW9uIG9ubWVzc2FnZShldnQpIHsKKyAgICBtZXNz YWdlQ291bnQrKzsKKworICAgIGlmIChldnQuZGF0YSA9PSAnZG9uZScpIHsKKyAgICAgICAgc2hv dWxkQmUoIm1lc3NhZ2VDb3VudCIsICI3Iik7CisKKyAgICAgICAgLy8gU2hvdyB0aGUgZXBpbG9n dWUgaHVtYW5zIGFyZSB1c2VkIHRvIHNlZWluZy4KKyAgICAgICAgc3VjY2Vzc2Z1bGx5UGFyc2Vk ID0gdHJ1ZTsKKyAgICAgICAgc2hvdWxkQmVUcnVlKCJzdWNjZXNzZnVsbHlQYXJzZWQiKTsKKyAg ICAgICAgZGVidWcoJzxiciAvPjxzcGFuIGNsYXNzPSJwYXNzIj5URVNUIENPTVBMRVRFPC9zcGFu PicpOworCisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfQorfQorCit3aW5k b3cuYWRkRXZlbnRMaXN0ZW5lcignbWVzc2FnZScsIG9ubWVzc2FnZSwgZmFsc2UpOworCitmdW5j dGlvbiB0cnlQb3N0TWVzc2FnZShmaXJzdCwgc2Vjb25kLCB0aGlyZCkgeworICAgIHRyeSB7Cisg ICAgICAgIGlmICghdGhpcmQpCisgICAgICAgICAgICB3aW5kb3cucG9zdE1lc3NhZ2UoZmlyc3Qs IHNlY29uZCk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHdpbmRvdy5wb3N0TWVzc2FnZShm aXJzdCwgc2Vjb25kLCB0aGlyZCk7CisgICAgfSBjYXRjaCAoZSkgeworICAgICAgICB0ZXN0RmFp bGVkKCJQb3N0aW5nIG1lc3NhZ2UgKCIgKyBmaXJzdCArICIsICIgKyBzZWNvbmQgKyAiKTogdGhy ZXcgZXhjZXB0aW9uICIgKyBlKTsKKyAgICB9Cit9CisKK3RyeVBvc3RNZXNzYWdlKCcxJywgMSwg JyonKTsKK3RyeVBvc3RNZXNzYWdlKCcyJywgIiIsICcqJyk7Cit0cnlQb3N0TWVzc2FnZSgnMycs IHdpbmRvdywgJyonKTsKK3RyeVBvc3RNZXNzYWdlKCc0JywgeyB4OiAxIH0sICcqJyk7Cit0cnlQ b3N0TWVzc2FnZSgnNScsIG51bGwsICcqJyk7Cit0cnlQb3N0TWVzc2FnZSgnNicsIHZvaWQgMCwg JyonKTsKK3RyeVBvc3RNZXNzYWdlKCdkb25lJywgJyonKTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+ Cis8L2h0bWw+Cg== 28534 2009-03-12 11:02:35 -0700 2009-03-12 11:11:27 -0700 Patch addressing Alexey's comments 24523b.txt text/plain 2257 pam SW5kZXg6IGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2UtYXJncy1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdz LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9z dG1lc3NhZ2UtYXJncy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAgQEAK K1Rlc3QgdGhhdCB0aGUgc2Vjb25kIGFyZ3VtZW50IG9mIHdpbmRvdy5wb3N0TWVzc2FnZSBpcyBp Z25vcmVkIGlmIGl0IGlzIG5vdCBhIG1lc3NhZ2UgcG9ydC4gWW91IHNob3VsZCBzZWUgbWVzc2Fn ZXMgJzEnIHRocm91Z2ggJzYnLCBmb2xsb3dlZCBieSAnZG9uZScsIHJlY2VpdmVkIGJlbG93Lgor CitSZWNlaXZlZCBtZXNzYWdlICcxJworUmVjZWl2ZWQgbWVzc2FnZSAnMicKK1JlY2VpdmVkIG1l c3NhZ2UgJzMnCitSZWNlaXZlZCBtZXNzYWdlICc0JworUmVjZWl2ZWQgbWVzc2FnZSAnNScKK1Jl Y2VpdmVkIG1lc3NhZ2UgJzYnCitSZWNlaXZlZCBtZXNzYWdlICdkb25lJworCkluZGV4OiBmYXN0 L2RvbS9XaW5kb3cvd2luZG93LXBvc3RtZXNzYWdlLWFyZ3MuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBm YXN0L2RvbS9XaW5kb3cvd2luZG93LXBvc3RtZXNzYWdlLWFyZ3MuaHRtbAkocmV2aXNpb24gMCkK KysrIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2UtYXJncy5odG1sCShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDQ1IEBACis8aHRtbD4KKzxoZWFkPjwvaGVhZD4KKzxib2R5PgorPGRp diBpZD0iZGVzY3JpcHRpb24iPjwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2Ny aXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50 aWxEb25lKCk7Cit9CisKK3ZhciBjb25zb2xlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNv bnNvbGUiKTsKKworZnVuY3Rpb24gb25tZXNzYWdlKGV2dCkgeworICAgIGNvbnNvbGUuaW5uZXJI VE1MICs9ICJSZWNlaXZlZCBtZXNzYWdlICciICsgZXZ0LmRhdGEgKyAiJzxicj4iOworCisgICAg aWYgKGV2dC5kYXRhID09ICdkb25lJyAmJiB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKword2luZG93LmFk ZEV2ZW50TGlzdGVuZXIoJ21lc3NhZ2UnLCBvbm1lc3NhZ2UsIGZhbHNlKTsKKworZnVuY3Rpb24g dHJ5UG9zdE1lc3NhZ2UoZmlyc3QsIHNlY29uZCwgdGhpcmQpIHsKKyAgICB0cnkgeworICAgICAg ICBpZiAoIXRoaXJkKQorICAgICAgICAgICAgd2luZG93LnBvc3RNZXNzYWdlKGZpcnN0LCBzZWNv bmQpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB3aW5kb3cucG9zdE1lc3NhZ2UoZmlyc3Qs IHNlY29uZCwgdGhpcmQpOworICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgIGNvbnNvbGUuaW5u ZXJIVE1MICs9ICJGQUlMOiBQb3N0aW5nIG1lc3NhZ2UgKCIgKyBmaXJzdCArICIsICIgKyBzZWNv bmQgKyAiKTogdGhyZXcgZXhjZXB0aW9uICIgKyBlICsgIjxicj4iOworICAgIH0KK30KKworZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRlc2NyaXB0aW9uIikuaW5uZXJIVE1MID0gIlRlc3QgdGhh dCB0aGUgc2Vjb25kIGFyZ3VtZW50IG9mIHdpbmRvdy5wb3N0TWVzc2FnZSBpcyBpZ25vcmVkIGlm IGl0IGlzIG5vdCBhIG1lc3NhZ2UgcG9ydC4gWW91IHNob3VsZCBzZWUgbWVzc2FnZXMgJzEnIHRo cm91Z2ggJzYnLCBmb2xsb3dlZCBieSAnZG9uZScsIHJlY2VpdmVkIGJlbG93Ljxicj48YnI+IjsK KwordHJ5UG9zdE1lc3NhZ2UoJzEnLCAxLCAnKicpOwordHJ5UG9zdE1lc3NhZ2UoJzInLCAiIiwg JyonKTsKK3RyeVBvc3RNZXNzYWdlKCczJywgd2luZG93LCAnKicpOwordHJ5UG9zdE1lc3NhZ2Uo JzQnLCB7IHg6IDEgfSwgJyonKTsKK3RyeVBvc3RNZXNzYWdlKCc1JywgbnVsbCwgJyonKTsKK3Ry eVBvc3RNZXNzYWdlKCc2Jywgdm9pZCAwLCAnKicpOwordHJ5UG9zdE1lc3NhZ2UoJ2RvbmUnLCAn KicpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==