<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>245222</bug_id>
          
          <creation_ts>2022-09-15 07:30:58 -0700</creation_ts>
          <short_desc>REGRESSION(250548@main): Early WebProcess exit on 32-bit platforms since memory limit is zero</short_desc>
          <delta_ts>2022-09-16 00:32:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=241012</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Olivier Blin">olivier.blin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>darin</cc>
    
    <cc>loic.yhuel</cc>
    
    <cc>mafm</cc>
    
    <cc>magomez</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>nham</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zdobersek</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1898696</commentid>
    <comment_count>0</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2022-09-15 07:30:58 -0700</bug_when>
    <thetext>In 250548@main, the memory limit in MemoryPressureHandler is set to a least 7 GB for active process.
This value is stored in a size_t variable, but this is limited to 4 GB on 32-bit platforms.

The memory limit is truncated down to 0, which triggers a WebProcess exit after the first MemoryPressure check.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898698</commentid>
    <comment_count>1</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2022-09-15 07:32:34 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/4381</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898712</commentid>
    <comment_count>2</comment_count>
    <who name="Miguel Gomez">magomez</who>
    <bug_when>2022-09-15 08:56:21 -0700</bug_when>
    <thetext>Folks, this is already being handled in https://bugs.webkit.org/show_bug.cgi?id=241012.

The PR for this addresses the value overflow, but what should be done is that WebKitGTK and WPE shouldn&apos;t use those values at all.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898713</commentid>
    <comment_count>3</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-09-15 08:58:40 -0700</bug_when>
    <thetext>(In reply to Miguel Gomez from comment #2)
&gt; Folks, this is already being handled in
&gt; https://bugs.webkit.org/show_bug.cgi?id=241012.
&gt; 
&gt; The PR for this addresses the value overflow, but what should be done is
&gt; that WebKitGTK and WPE shouldn&apos;t use those values at all.

I think https://github.com/WebKit/WebKit/pull/4381 is valuable no matter what. 

If you want to disable this handling for WebKitGTK and WPE and fine but that&apos;s a separate issue from the overflow handling on 32bit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898821</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-09-15 15:13:50 -0700</bug_when>
    <thetext>Committed 254533@main (b0895ea02d48): &lt;https://commits.webkit.org/254533@main&gt;

Reviewed commits have been landed. Closing PR #4381 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898822</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-09-15 15:14:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/99989909&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898920</commentid>
    <comment_count>6</comment_count>
    <who name="Miguel Gomez">magomez</who>
    <bug_when>2022-09-16 00:32:51 -0700</bug_when>
    <thetext>*** Bug 241012 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>