245179 2022-09-14 07:48:35 -0700 getKeyframes() returns equal "from" and "to" values for a "width" transition 2022-09-23 10:10:26 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=23775 InRadar P2 Normal --- 1 graouts graouts dino graouts koivisto webkit-bug-importer oldest_to_newest 1898460 0 graouts 2022-09-14 07:48:35 -0700 Starting a "width" transition for a simple <div> will return the same values for "from" and "to" when getKeyframes() is called. This cannot be correct since a transition cannot have the same from and to values. Digging into this, this is about this code in ComputedStyleExtractor::valueForPropertyInStyle(): case CSSPropertyWidth: if (renderer && !renderer->isRenderOrLegacyRenderSVGModelObject()) { // According to http://www.w3.org/TR/CSS2/visudet.html#the-width-property, // the "width" property does not apply for non-replaced inline elements. if (!isNonReplacedInline(*renderer)) return zoomAdjustedPixelValue(sizingBox(*renderer).width(), style); } return zoomAdjustedPixelValueForLength(style.width(), style); In this case we end up calling zoomAdjustedPixelValue(sizingBox(*renderer).width(), style) which simply does not use the values provided in the RenderStyle for the keyframe. 1898461 1 462334 graouts 2022-09-14 07:50:13 -0700 Created attachment 462334 testcase 1898478 2 graouts 2022-09-14 09:09:25 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4350 1900135 3 webkit-bug-importer 2022-09-21 07:49:18 -0700 <rdar://problem/100223910> 1900585 4 graouts 2022-09-23 03:13:01 -0700 I believe this got fixed along with bug 23924. Will add a new test though. 1900672 5 ews-feeder 2022-09-23 10:10:24 -0700 Committed 254793@main (1ed5a302e8a0): <https://commits.webkit.org/254793@main> Reviewed commits have been landed. Closing PR #4350 and removing active labels. 462334 2022-09-14 07:50:13 -0700 2022-09-14 07:50:13 -0700 testcase bug-245179.html text/html 815 graouts PGh0bWw+CjxoZWFkPgoJPHRpdGxlPlRlc3QgZm9yIGJ1ZyAyNDUxNzk8L3RpdGxlPgoJPHN0eWxl PgoJCQpkaXYgewoJcG9zaXRpb246IGFic29sdXRlOwoJdG9wOiAxMDBweDsKCWxlZnQ6IDEwMHB4 OwoJd2lkdGg6IDEwMHB4OwoJaGVpZ2h0OiAxMDBweDsKCgliYWNrZ3JvdW5kLWNvbG9yOiBibGFj azsKICAgIHRyYW5zaXRpb246IHdpZHRoIDFzIGxpbmVhcjsKfQoKZGl2LnJldGFyZ2V0ZWQgewoJ d2lkdGggOiAyMDBweDsKfQoKCTwvc3R5bGU+ICAKPC9oZWFkPgoKPGJvZHk+CjxkaXY+PC9kaXY+ CjxzY3JpcHQ+Cgpjb25zdCB0YXJnZXQgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJkaXYiKTsK CnRhcmdldC5hZGRFdmVudExpc3RlbmVyKCJ0cmFuc2l0aW9uc3RhcnQiLCBldmVudCA9PiB7CiAg ICBjb25zdCBwcm9wZXJ0eSA9IGV2ZW50LnByb3BlcnR5TmFtZTsKICAgIGNvbnN0IGVmZmVjdCA9 IHRhcmdldC5nZXRBbmltYXRpb25zKClbMF0uZWZmZWN0OwogICAgY29uc3Qga2V5ZnJhbWVzID0g ZWZmZWN0LmdldEtleWZyYW1lcygpOwogICAgY29uc29sZS5sb2coYFRyYW5zaXRpb25pbmcgJHtw cm9wZXJ0eX0gZnJvbSAke2tleWZyYW1lc1swXVtwcm9wZXJ0eV19IHRvICR7a2V5ZnJhbWVzWzFd W3Byb3BlcnR5XX0gZm9yICR7KGVmZmVjdC5nZXRDb21wdXRlZFRpbWluZygpLmR1cmF0aW9uIC8g MTAwMCkudG9GaXhlZCgxKX1zYCk7Cn0sIHsgb25jZTogdHJ1ZSB9KTsKCnNldFRpbWVvdXQoKCkg PT4gdGFyZ2V0LmNsYXNzTGlzdC50b2dnbGUoInJldGFyZ2V0ZWQiKSk7CiAgICAKPC9zY3JpcHQ+ CjwvYm9keT4KPC9odG1sPgo=