245135 2022-09-13 05:46:23 -0700 Holepunch missing after video source change 2022-09-16 01:30:45 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olivier.blin magomez aperez bugs-noreply cgarcia fujii loic.yhuel magomez zdobersek oldest_to_newest 1898199 0 462314 olivier.blin 2022-09-13 05:46:23 -0700 Created attachment 462314 Test case to reproduce the missing holepunch after changing video source Since r295749 (251754@main), the holepunch feature is broken (missing) after changing the video source. See https://bugs.webkit.org/show_bug.cgi?id=240283 for the crash fix which causes this regression. This bug can be seen with YouTube TV, just after skipping an ad. The holepunch contents layer is reset to NULL after changing the source, which causes the holepunch buffer not to be rendered anymore. The new content layer from the new MediaPlayer is set from TextureMapperPlatformLayerProxyGL::activateOnCompositingThread(), but after that, TextureMapperPlatformLayerProxyGL::invalidate() is called to invalidate the old content layer from the old MediaPlayer. This sets the content layer to NULL in the target layer, and this disables the new content layer. This can be reproduced on a WPE build with USE_GSTREAMER_HOLEPUNCH=ON and the attached test page. 1898659 1 462353 magomez 2022-09-15 01:59:47 -0700 Created attachment 462353 tentative fix The issue is quite complicated to reproduce in my system. I was able to see it only once in tens of executions. This is because it has to happen that the old player is destroyed and the new one created before there's a layerFlush, so the CoordinatedGraphicsScene can be in the situation where a layer's proxy is replaced with a new one. Most of the times there's a layerFlush between the destruction of the old player and the creation of the new one, so the problem doesn't reproduce. Anyway, I think the fix is as simple as doing the invalidation of the old proxies before activating the new ones. Olivier, as you seem to be able to reproduce the issue reliably, could you give a test to this patch and check whether it fixes the problem? 1898673 2 olivier.blin 2022-09-15 04:29:27 -0700 Miguel: thank you, this fixes the issue for me. I could reproduce the issue on my laptop, but it has been first detected on set-top boxes with less powerful CPUs. 1898681 3 magomez 2022-09-15 06:22:26 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4379 1898930 4 ews-feeder 2022-09-16 01:30:42 -0700 Committed 254548@main (f994a1b3e3dc): <https://commits.webkit.org/254548@main> Reviewed commits have been landed. Closing PR #4379 and removing active labels. 462314 2022-09-13 05:46:23 -0700 2022-09-13 05:46:23 -0700 Test case to reproduce the missing holepunch after changing video source video-src-change-holepunch.html text/html 936 olivier.blin PGh0bWw+CiAgICA8aGVhZD4KICAgICAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgogICAgICAg ICAgICBib2R5IHsKICAgICAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMjU1LCAy NTUsIDI1NSwgMC44KTsKICAgICAgICAgICAgfQogICAgICAgICAgICAuYm94IHsKICAgICAgICAg ICAgICAgIHdpZHRoOiA2NDBweDsKICAgICAgICAgICAgICAgIGhlaWdodDogNDgwcHg7CiAgICAg ICAgICAgIH0KICAgICAgICA8L3N0eWxlPgogICAgICAgIDxzY3JpcHQ+CiAgICAgICAgICAgIHZh ciB2aWRlbyA9IG51bGw7CiAgICAgICAgICAgIHZhciBwcmVmaXggPSAiTGF5b3V0VGVzdHMvbWVk aWEvY29udGVudC8iOwogICAgICAgICAgICB2YXIgc3JjMSA9IHByZWZpeCArICJ0ZXN0Lm1wNCI7 CiAgICAgICAgICAgIHZhciBzcmMyID0gcHJlZml4ICsgInRlc3QubXA0IjsKICAgICAgICAKICAg ICAgICAgICAgZnVuY3Rpb24gc2V0dXAoKQogICAgICAgICAgICB7CiAgICAgICAgICAgICAgICB2 aWRlbyA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd2aWRlbycpWzBdOwogICAgICAg ICAgICAgICAgdmlkZW8uc3JjID0gc3JjMTsKICAgICAgICAgICAgICAgIHZpZGVvLnBsYXkoKTsK ICAgICAgICAgICAgICAgIHNldFRpbWVvdXQobmV4dFNyYywgMjAwMCk7CiAgICAgICAgICAgIH0K CiAgICAgICAgICAgIGZ1bmN0aW9uIG5leHRTcmMoKQogICAgICAgICAgICB7CiAgICAgICAgICAg ICAgICB2aWRlby5zcmMgPSBzcmMyOwogICAgICAgICAgICAgICAgdmlkZW8ucGxheSgpOwogICAg ICAgICAgICB9CiAgICAgICAgPC9zY3JpcHQ+CiAgICA8L2hlYWQ+Cgo8Ym9keSBvbmxvYWQ9InNl dHVwKCkiPgogICAgPGRpdiBjbGFzcz0iYm94Ij4KICAgICAgICA8dmlkZW8+PC92aWRlbz4KICAg IDwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 462353 2022-09-15 01:59:47 -0700 2022-09-15 01:59:47 -0700 tentative fix invalidate-before-activate.patch text/plain 1510 magomez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29v cmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5h dGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcAppbmRleCAyYjg0ODQ0MGQ4 NDguLmM3OGVhMzg0OGM0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRp bmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5l LmNwcApAQCAtMzk3LDYgKzM5NywxNCBAQCB2b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZTo6 dXBkYXRlU2NlbmVTdGF0ZSgpCiAgICAgICAgIGxheWVyc0J5QmFja2luZy5iYWNraW5nU3RvcmUg PSB7IH07CiAgICAgfQogCisgICAgLy8gSW52YWxpZGF0ZSB0aGUgcHJveGllcyB0aGF0IGFyZSBu b3QgdXNlZCBhbnltb3JlIGJlZm9yZSBhY3RpdmF0aW5nIHRoZSBuZXcgb25lczoKKyAgICAvLyBh IGxheWVyJ3MgcHJveHkgY2FuIGJlIHJlcGxhY2VkIHdpdGggYSBuZXcgb25lLiBJZiB3ZSBkb24n dCBpbnZhbGlkYXRlIHRoZSBvbGQgcHJveHkKKyAgICAvLyBiZWZvcmUgYWN0aXZhdGluZyB0aGUg bmV3IG9uZSwgdGhlIGNvbnRlbnRMYXllciBzZXQgdG8gdGhlIGxheWVyIGJ5IHRoZSBhY3RpdmF0 aW9uIG9mCisgICAgLy8gdGhlIG5ldyBwcm94eSB3aWxsIGJlIHJlbW92ZWQgYnkgdGhlIGludmFs aWRhdGlvbiBvZiB0aGUgb2xkIG9uZS4KKyAgICBmb3IgKGF1dG8mIHByb3h5IDogcmVwbGFjZWRQ cm94aWVzVG9JbnZhbGlkYXRlKQorICAgICAgICBwcm94eS0+aW52YWxpZGF0ZSgpOworICAgIHJl cGxhY2VkUHJveGllc1RvSW52YWxpZGF0ZSA9IHsgfTsKKwogICAgIHsKICAgICAgICAgZm9yIChh dXRvJiBlbnRyeSA6IGxheWVyc0J5QmFja2luZy5jb250ZW50TGF5ZXIpIHsKICAgICAgICAgICAg IGF1dG8mIHByb3h5ID0gZW50cnkucHJveHkuZ2V0KCk7CkBAIC00MzIsMTAgKzQ0MCw2IEBAIHZv aWQgQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lOjp1cGRhdGVTY2VuZVN0YXRlKCkKICAgICBmb3Ig KGF1dG8mIHByb3h5IDogcHJveGllc0ZvclN3YXBwaW5nKQogICAgICAgICBwcm94eS0+c3dhcEJ1 ZmZlcigpOwogCi0gICAgZm9yIChhdXRvJiBwcm94eSA6IHJlcGxhY2VkUHJveGllc1RvSW52YWxp ZGF0ZSkKLSAgICAgICAgcHJveHktPmludmFsaWRhdGUoKTsKLSAgICByZXBsYWNlZFByb3hpZXNU b0ludmFsaWRhdGUgPSB7IH07Ci0KICAgICAvLyBFamVjdCBhbnkgYmFja2luZyBzdG9yZSBjb250 YWluZXIgd2hvc2Ugb25seSByZWZlcmVuY2UgaXMgaGVsZCBpbiB0aGlzIHNjZW5lJ3MgSGFzaFNl dCBjYWNoZS4KICAgICBtX2ltYWdlQmFja2luZ1N0b3JlQ29udGFpbmVycy5yZW1vdmVJZigKICAg ICAgICAgW10oYXV0byYgY29udGFpbmVyKSB7Cg==