24509 2009-03-10 21:53:02 -0700 Div for cancel button in search fields is too short 2009-03-12 10:32:33 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 NEW P2 Normal --- 1 simon.fraser webkit-unassigned adele oldest_to_newest 113118 0 simon.fraser 2009-03-10 21:53:02 -0700 The repaint test that I'm about to commit for bug 23093 shows that the cancel button's renderer is 13x11px, which is too short. This causes incomplete redraws. It also makes the bottom 2px of the cancel button onclickable. The cancel button size is hard-coded in RenderThemeMac to be 13x11px at normal font sizes. It draws correctly because when drawing, we call [NSSearchFieldCell cancelButtonRectForBounds:], which returns a rect that is 19x19px. Note that just changing the cancelButtonSizes constants causes the search field to layout incorrectly. 113120 1 28463 simon.fraser 2009-03-10 21:55:28 -0700 Created attachment 28463 Repaint test result showing short rect 113408 2 simon.fraser 2009-03-12 10:32:33 -0700 When fixing this, should also fix the cancel button with zooming. 28463 2009-03-10 21:55:28 -0700 2009-03-10 21:55:28 -0700 Repaint test result showing short rect Picture 1.png image/png 4250 simon.fraser iVBORw0KGgoAAAANSUhEUgAAAdkAAABdCAIAAABmc4svAAAEi2lDQ1BJQ0MgUHJvZmlsZQAAeAHt 3Wl0E1UYBuAvLYUCSrUsBUQdtSogKdm6CWjLFCkSSm1LQWQxTcc0SpNhEtqEoqAguO8LuKJWQUAB KQoii4KKKyAIAesKtQiuIFVRD947k7U5luNfeaenM9+9szTvk2/mT85piNzpxJaEPKJql1cpGT5U GHf1eKFDgBKpO6WxXb1tdo+cX1xsZTUVjS4axrexS8tu0vGZnXqxplRu8HdNsh5fvWhXQ+O4dTuS m2KPjRt1rpQ8diLXLLan3i4rXiJdMqvzar0yrwtZ3U1hL4rVE3jt0GqZ1xVaPUc9pqxEZMfMZ3UX h1Yv5nWFVq/hdY3dwa+5lSgxtUwsZnW7RiJnvVfysZpIdMt+xemo8gomgyFTEN1T3Eq50+N0u4QR LnuG0LdU9ldKiknyyYrk8QimDJPe3I+Im/HziY4sVS10KQMic3XsdeUnMeXJkbmxGUTLfERpfSJz 6RJR6lyitSvt05Qa7XqkSzATnWys5QqekcjeDB07L7FdUvsOyR07dT7t9C5nnJnatVv3Hmk9e/U+ q8/Z55wrCOedf0H6hRdd3Ldf/0sG6DMGGoxGk9mSmZWdk3vpoEGDh1x2eV7+UFEsGHbF8MIRV44c aR1VNLr4qpKS0rIx5WPZSx5/zYSJkyZfa7NV2Cul6xxVTuf1N0ypdrnlqVMVj3daTa3PP3163Ywb b5o56+ZbZs+5de68ebfdfsedd919z7333f/Agw89/Mij8xc89vgTTz719MJnnn2u/vkXFi1+ccnS ZS+9vHzFyldWNax+9bU1r697Y/2GjZvefGvzlnfe3fre+x98+NHH23d8snPXp7sDe/d91vj5l199 /c3+pm+bD353+Psffvz5lyNHf2357fc//vzr7xOMIAYgJU4gDiCUnwGE8ofiW4PxW6dXw/P0ofBK OHwwezD8f8rOoq8NZ9/ydij7tmD2PQGe/Qse/oAa/hBL/5Oa/hiPf7zt/OEWUAGiW8AQaYEogrDB KK0FuIHaArwDeAvEIvAWUBHUFmAK4RZgPaAxRHogugn+rQvCFJs1Ct4F27bzLtgT2Ks1wf4DTc0H Dx3mLXD0WAtrAP7+a/e3ek8ksHV77e6oa6bZ+xZqtfbUCtZtbJIXsJsj22jQ5+TkmswGfabFYszO bnVCStSYPw353+Rb9ckYtY/P89/oRR17agWLaB1YVSuYRfVhG30Eqw2GrCxLrjGn1TSGEIAABCAA AQhAAAIQgAAEIAABCEAAAhCAAAQgAAEIQCBeIMFspor0AFWyXeWDV51gCz+Ir7Uq/hTMQOAUEmj9 Gd4pFB1RIQABCEAAAhCAAAQgAAEIQAACEIAABCAAAQhAAAIQgAAEIAABCEAAAhCAAAQgAAEIQAAC EIAABCAAAQhAAAIQgAAEIAABCEAAAhCAAAQgAAEIQAACEIAABCAAAQhAAAIQgAAEIACB/4uA9t1v appeotMlVduEwgIh9kvWQll7kkhOcpFE1WQjgQqpgK1LSSY/+9eFEilkYmsfGyts62E/dNJrhq7d 1vYfqy/6hRS815gAAAAJcEhZcwAACxMAAAsTAQCanBgAAAu1SURBVHgB7Z1biI3fG8f/43waxmCU MzkVORXlkAtyCLkQ4kIiwkhSQi6EcuFwo5AkLkQROZSUw41CKSEu5FSOF+M0zowZfv59/31H+zX7 t9+913731P/j4u2713rWs9Z83u1pvc+71tpF5eXl/+EfBCAAAQgUlECDgvZO5xCAAAQg8F8CxGK+ BxCAAAQKT4BYXPh7wAggAAEIEIv5DkAAAhAoPAFiceHvASOAAAQgQCzmOwABCECg8ASIxYW/B4wA AhCAALGY7wAEIACBwhMgFhf+HjACCEAAAsRivgMQgAAECk+AWFz4e8AIIAABCBCL+Q5AAAIQKDyB RtkN4cuXL2pYUVEhUVlZKfH161eJmpoaiQYNiPgiwRUCEEiawM+fP9Vlw4YNJZo3by5RUlIiUVZW JtGiRQuJ5K9EyeSZ0yMEIACBVALE4lQifIYABCCQPIF4OYrHjx9riK9evZIoLi6WKC0tlWjSpImE nwj0kSsEIACBAhJw1rSqqkrD+PTpk8SdO3ckOnToINGrVy+JxK7MixNDTUcQgAAE6iRALK4TDRUQ gAAEEiOQLkfx/ft3jePBgwcSXhHRs2dPlfiNZKNG/3Nlm6KiItlY6CNXCEAAAokR+PXrl/qy8MqK tm3bqsqrv16/fq2Su3fvSvTp00eiadOmEnm6Mi/OE1jcQgACEIhBgFgcAxamEIAABPJEIF2O4uHD h+q1WbNmEn7J6BIvlnBqwgONpiZ27drlWgQEIACBghBwjqK6uloDcI7i7du3Krl586aEo9aAAQPy OlrmxXnFi3MIQAACGREgFmeECSMIQAACeSXwlxzFkydP1KV3bXTs2FEl0dRENBERLfEfEM1juAoB AQhAIGsCHz9+VNs3b95IvH//XsKH5/isidatW6vKO9S8Z61x48aqGj58uITDoANj9+7dVRX2yrw4 LE+8QQACEMiGALE4G2q0gQAEIBCWQG2Owm8SPbfv1q2bOkuTmkiTkQg7ULxBAAIQSCHgg3GeP3+u KsexFMvfHz9//qxCC5/026VLF1U5a9GuXTuVePHY06dPVeIuvNNN5TlemRfnCJDmEIAABAIQIBYH gIgLCEAAAjkSqM1ReJGz92iTmsgRbsDm3kpfT5JCXi3P2piAdxlXGRLwWZeZpCbS+PQSC/vxoRNe dOEw6MDoUNm5c+c0zuNWMS+OSwx7CEAAAuEJEIvDM8UjBCAAgbgEanMUfjnoqbiPwfRzsUXcbrDP jsCgQYPU8PTp0xI+rTQ7hzm2evbsmTxMmDBB4t69ezn6pDkE4hLwyZZOMjg0jRo1St78XbXo2rWr qiyuXr2qEkc/5x9atWqlKodBZy3evXunqrBX5sVheeINAhCAQDYEiMXZUKMNBCAAgbAEanMUfjPu BcwJvCI/cOCA/p7jx49LeP6/Y8cOlYwePVri27dvEhs2bJC4ePGihK/l5eXSixYtcqHEunXrJAYP HizhB//bt2+rxJ5btmypks2bN0v4UI6DBw+qpKysTMIPOGvWrFHJjRs3JMaMGSPhqvbt26skzXXn zp2qffTokcS8efMkpkyZIrF+/XqJy5cvp5Q4y7R06VJVTZ06VcLr1efPn6+SQ4cOSXi5+61bt1Sy d+/eFLF69WqVeG++kxUrV65U1bRp0yS4QiBPBLwfzakJdxTNSLjKqQnbuMoi6tlh0IHRR164VRDB vDgIRpxAAAIQyIkAsTgnfDSGAAQgEIRAbY7CU3H/VIc7iD4IuCo74V81Xbt2rTzcv39fws/Xzpm4 i7Nnz0r7LeqVK1dU4rXfkyZNUomFH0wqKipUtW/fPonDhw9LvHz5UmLcuHESmzZtkrh27ZqEn8HP nTunEj/mnzlzRiXew+73s37MP3bsmGycRdHHv17d1549e2TgTILXUXj3h43Pnz8vYydYRowYoZKJ EydK+IyRhQsXqmTBggUSJ06ckFixYoWEszH6+Pu6detWaSdhLly44FoEBJIh4OUT0e6i+QdHAFdZ RJs73xgNeg6MDpXR5rmUMC/OhR5tIQABCIQhQCwOwxEvEIAABHIhUJuj8JLmXNxl2NabvsePH68m s2fPlti2bZvE0KFDU7ydOnVKJbNmzZLwm00Lpyac0PBaAnvzQ32nTp1U6IcOD2zVqlW2l/Bh/j6m zwYnT56U9mpwpzhevHihKudVMslR2HMa4dUOHz58kJkTGm5VU1Mj7R9SdNbCCzOcThk5cqSMzad3 7952hYBA/SHg/2g+/dJjc0bCwhkJl9jYy4qckXAksU1U5ClUMi+OoqYEAhCAQNIEiMVJE6c/CEAA AlECtTkK/+ieH2xdEm0WquTIkSNy5WUGc+bMUcmWLVskZs6cKeHFEs4kqPzPq6v8PvTPWmk/j0Sr nKyIVqUp8YF7c+fOlZk3xbuVf8HQJTkKp0r8Q4rTp09P8emSHj16pFT5o9e0GK9TN7ZBQKBeEWjT po3GkyZH4dSEhf8EJyuiVfZsY4t8B0bmxUaNgAAEIFAwAsTigqGnYwhAAAImUJuj8PH1VVVVqvbz vrcVpHm6t8dMxI8fP2TmDR1OTbgvH7PgHMWMGTPU6tKlSxLewuAxe+tBdJ9CJgPLzsZnRFy/fl0e lixZIpHjK1f/7qEzEt7rMWzYMHXhDInvzpAhQ/71D/HmkZKSEhkb3eTJk1UycOBACac4nA/xlnyn OPxt+deuMYBAjgS8qcrH1zgn6XVB0S6ckbCwjZdP+LgYByILBxmHSjcPIpgXB8GIEwhAAAI5ESAW 54SPxhCAAASCEKjNUfgce0/7faxBdqsL0ozPR0P4cbhfv36y907z7du3p3jwqgDvrfCJlH6E956R vn37pjTP30dvjvAOkf79+6s7pwucCti/f3/mI1m2bJmMvWPFJYsXL1bV0aNHJZzMce9OIGzcuFE2 frjzMHy8htfPe7uN94M4fVFaWio/PovDd9DbW8aOHSsbrhDIE4Hi4mJ5jq6IcLIik66dmvCBsQ6D Tp9a+Mxen5mTSReZ2zAvzpwVlhCAAATyRYBYnC+y+IUABCCQOYGi6PEI/vU97/VwssJv6i0y7+m3 5e7du+uyr6ysVJWf5euy/LPcRzH4Jb7Fn2bJa2da/BLWDLMbjB364L7oX+q+nGXyw1R29yuTofoW +OEueEYrk2Fg8/9AYPny5fn+M/2fyMLbSbz6y5m6sINhXhyWJ94gAAEIZEOAWJwNNdpAAAIQCEug dh2F/XoG7vX8fi6OLnIO9fAbKzXhoXrrgUvqifCahFDjycSh74XvYKje0/ipt7cgzZipgkAKAWck LLxqwls8vAYppW2oj8yLQ5HEDwQgAIHsCRCLs2dHSwhAAAKhCPxlHYVdV1dXS/tduXMUfokffWnu J2X7QUAAAhCoPwSciPCQvKHD26Oco3AWLsezZdxXXYJ5cV1kKIcABCCQHAFicXKs6QkCEIBAXQT+ so7Cpp6T+728f/rB65/9cxU2JmthgAgIQKDgBNJkJJyG9WIJhy8HvcTGz7w4MdR0BAEIQKBOAsTi OtFQAQEIQCAxAulyFNFB+MwBb8228GtHPxGwoCIKkBIIQKBQBKKhyRkJH57pQ3iSHyTz4uSZ0yME IACBVALE4lQifIYABCCQPIF4OQqPzzN5C1chIAABCEAgLgHmxXGJYQ8BCEAgPAFicXimeIQABCAQ lwCxOC4x7CEAAQiEJ0AsDs8UjxCAAATiEiAWxyWGPQQgAIHwBIjF4ZniEQIQgEBcAsTiuMSwhwAE IBCeALE4PFM8QgACEIhLgFgclxj2EIAABMITIBaHZ4pHCEAAAnEJEIvjEsMeAhCAQHgCxOLwTPEI AQhAIC4BYnFcYthDAAIQCE+AWByeKR4hAAEIxCVALI5LDHsIQAAC4QkQi8MzxSMEIACBuASIxXGJ YQ8BCEAgPAFicXimeIQABCAQlwCxOC4x7CEAAQiEJ0AsDs8UjxCAAATiEiAWxyWGPQQgAIHwBIjF 4ZniEQIQgEBcAv8A8rfep0XDTiIAAAAASUVORK5CYII=