24508 2009-03-10 21:03:19 -0700 REGRESSION: Setting value of search field programatically does not replace the placeholder text 2009-03-12 13:12:25 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 simon.fraser simon.fraser adele bengummer oldest_to_newest 113115 0 simon.fraser 2009-03-10 21:03:19 -0700 Setting foo.value on a search field does not cause it to redraw if it has placeholder text. 113116 1 28461 simon.fraser 2009-03-10 21:05:37 -0700 Created attachment 28461 Testcase (put in LayoutTests/fast/repaint) 113152 2 mrowe 2009-03-11 03:27:39 -0700 <rdar://problem/6618802> 113265 3 adele 2009-03-11 17:23:12 -0700 weird, setValue never gets called on the input element 113266 4 adele 2009-03-11 17:24:10 -0700 <rdar://problem/6618802> 113267 5 adele 2009-03-11 17:24:24 -0700 oops, mark already did that. 113414 6 ap 2009-03-12 10:40:37 -0700 *** Bug 24140 has been marked as a duplicate of this bug. *** 113462 7 28544 simon.fraser 2009-03-12 13:08:34 -0700 Created attachment 28544 Patch, changelog, testcase 113463 8 simon.fraser 2009-03-12 13:12:25 -0700 http://trac.webkit.org/changeset/41644 28461 2009-03-10 21:05:37 -0700 2009-03-10 21:05:37 -0700 Testcase (put in LayoutTests/fast/repaint) search-field-placeholder.html text/html 651 simon.fraser PGh0bWw+CjxoZWFkPgogIDx0aXRsZT5TZWFyY2ggZmllbGQgcmVkcmF3PC90aXRsZT4KICA8c3R5 bGUgdHlwZT0idGV4dC9jc3MiPgoKICA8L3N0eWxlPgogIDxzY3JpcHQgc3JjPSJyZXBhaW50Lmpz IiB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij48L3NjcmlwdD4KICA8c2Ny aXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPgogICAgZnVuY3Rpb24g cmVwYWludFRlc3QoKQogICAgewogICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc2VhcmNo ZmllbGQnKS52YWx1ZSA9ICdzb21lIHRleHQnOwogICAgfQogIDwvc2NyaXB0Pgo8L2hlYWQ+Cjxi b2R5IG9ubG9hZD0icnVuUmVwYWludFRlc3QoKSI+CiAgPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NTA4Ij5odHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ1MDg8L2E+LiBTZWFyY2ggZmllbGQgZG9lcyBu b3QgcmVkcmF3IGlmIHZhbHVlIHNldCwgd2hlbiBpdCBoYXMgcGxhY2Vob2xkZXIgdGV4dC48L3A+ CiAgPGlucHV0IGlkPSJzZWFyY2hmaWVsZCIgdHlwZT0ic2VhcmNoIiBwbGFjZWhvbGRlcj0iU2Vh cmNoIG1lIj4KPC9ib2R5Pgo8L2h0bWw+ 28544 2009-03-12 13:08:34 -0700 2009-03-12 13:10:08 -0700 Patch, changelog, testcase 24508_patch.txt text/plain 5811 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMGEzYzJjLi5kMDJiYzA1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMDktMDMt MTIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ1MDgKKyAgICAgICAgCisgICAgICAgIFRlc3Qg Zm9yIHNldHRpbmcgdGhlIHZhbHVlIG9uIGEgdGV4dCBpbnB1dCB3aXRoIHBsYWNlaG9sZGVyIHRl eHQuCisgICAgICAgIAorICAgICAgICAqIGZhc3QvZm9ybXMvcGxhY2Vob2xkZXItc2V0LXZhbHVl Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL3BsYWNlaG9s ZGVyLXNldC12YWx1ZS1leHBlY3RlZC5jaGVja3N1bTogQWRkZWQuCisgICAgICAgICogcGxhdGZv cm0vbWFjL2Zhc3QvZm9ybXMvcGxhY2Vob2xkZXItc2V0LXZhbHVlLWV4cGVjdGVkLnBuZzogQWRk ZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvcGxhY2Vob2xkZXItc2V0LXZh bHVlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKKzIwMDktMDMtMTIgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dAog ICAgICAgICAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI0NTUyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3BsYWNlaG9sZGVyLXNl dC12YWx1ZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9wbGFjZWhvbGRlci1zZXQtdmFs dWUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42MTVhNjYwCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9wbGFjZWhvbGRlci1zZXQtdmFs dWUuaHRtbApAQCAtMCwwICsxLDE1IEBACis8aHRtbD4KKzxoZWFkPgorICA8c2NyaXB0IHR5cGU9 InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPgorICAgIGZ1bmN0aW9uIHJ1blRlc3Qo KQorICAgIHsKKyAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzZWFyY2hmaWVsZCcpLnZh bHVlID0gJ05ldyB0ZXh0JzsKKyAgICB9CisgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25s b2FkPSJydW5UZXN0KCkiPgorICA8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ1MDgiPmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNDUwODwvYT4uIFNlYXJjaCBmaWVsZCBkb2VzIG5vdCByZWRyYXcgaWYg dmFsdWUgc2V0LCB3aGVuIGl0IGhhcyBwbGFjZWhvbGRlciB0ZXh0LjwvcD4KKworICA8aW5wdXQg aWQ9InNlYXJjaGZpZWxkIiB0eXBlPSJzZWFyY2giIHBsYWNlaG9sZGVyPSJQbGFjZWhvbGRlciB0 ZXh0Ij4KKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9mb3Jtcy9wbGFjZWhvbGRlci1z ZXQtdmFsdWUtZXhwZWN0ZWQuY2hlY2tzdW0gYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFz dC9mb3Jtcy9wbGFjZWhvbGRlci1zZXQtdmFsdWUtZXhwZWN0ZWQuY2hlY2tzdW0KbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYWY1YjEwMwotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL3BsYWNlaG9sZGVyLXNldC12YWx1ZS1l eHBlY3RlZC5jaGVja3N1bQpAQCAtMCwwICsxIEBACitjMmE2MTBhYmE2NWM1MGZkOWJhMDQ4Njcw NWExZWE5ZApcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL3BsYWNlaG9sZGVyLXNldC12YWx1ZS1leHBlY3Rl ZC5wbmcgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9mb3Jtcy9wbGFjZWhvbGRlci1z ZXQtdmFsdWUtZXhwZWN0ZWQucG5nCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LjJmODBiYzgKQmluYXJ5IGZpbGVzIC9kZXYvbnVsbCBhbmQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZmFzdC9mb3Jtcy9wbGFjZWhvbGRlci1zZXQtdmFsdWUtZXhwZWN0ZWQucG5nIGRpZmZl cgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvcGxhY2Vo b2xkZXItc2V0LXZhbHVlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9m YXN0L2Zvcm1zL3BsYWNlaG9sZGVyLXNldC12YWx1ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMTliNzJkNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL3BsYWNlaG9sZGVyLXNldC12YWx1ZS1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSwyNSBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisg IFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgw MHg2MDAKKyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAorICAgIFJl bmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNpemUgNzg0eDU4NAorICAgICAgUmVuZGVyQmxvY2sg e1B9IGF0ICgwLDApIHNpemUgNzg0eDM2CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAo MCwwKSBzaXplIDUzeDE4CisgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNTM6ICJU ZXN0IGZvciAiCisgICAgICAgIFJlbmRlcklubGluZSB7QX0gYXQgKDAsMCkgc2l6ZSAzMDV4MTgg W2NvbG9yPSMwMDAwRUVdCisgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICg1MywwKSBz aXplIDMwNXgxOAorICAgICAgICAgICAgdGV4dCBydW4gYXQgKDUzLDApIHdpZHRoIDMwNTogImh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDUwOCIKKyAgICAgICAgUmVu ZGVyVGV4dCB7I3RleHR9IGF0ICgzNTgsMCkgc2l6ZSA3NzV4MzYKKyAgICAgICAgICB0ZXh0IHJ1 biBhdCAoMzU4LDApIHdpZHRoIDQxNzogIi4gU2VhcmNoIGZpZWxkIGRvZXMgbm90IHJlZHJhdyBp ZiB2YWx1ZSBzZXQsIHdoZW4gaXQgaGFzIHBsYWNlaG9sZGVyIgorICAgICAgICAgIHRleHQgcnVu IGF0ICgwLDE4KSB3aWR0aCAyNzogInRleHQuIgorICAgICAgUmVuZGVyQmxvY2sgKGFub255bW91 cykgYXQgKDAsNTIpIHNpemUgNzg0eDIzCisgICAgICAgIFJlbmRlclRleHRDb250cm9sIHtJTlBV VH0gYXQgKDIsMikgc2l6ZSAxNDh4MTkgW2JnY29sb3I9I0ZGRkZGRl0gW2JvcmRlcjogKDJweCBp bnNldCAjMDAwMDAwKV0KKyAgICAgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMywzKSBzaXpl IDE0MngxMworICAgICAgICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMCkgc2l6ZSA4eDEx CisgICAgICAgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMTI5LDApIHNpemUgMTN4MTEKKyAg ICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCisgICAgICAgIFJlbmRl clRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MAorbGF5ZXIgYXQgKDIxLDY1KSBzaXplIDEy MXgxMworICBSZW5kZXJCbG9jayB7RElWfSBhdCAoOCwwKSBzaXplIDEyMXgxMworICAgIFJlbmRl clRleHQgeyN0ZXh0fSBhdCAoMSwwKSBzaXplIDQ4eDEzCisgICAgICB0ZXh0IHJ1biBhdCAoMSww KSB3aWR0aCA0ODogIk5ldyB0ZXh0IgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzODRmMjk3Li41MzZlZThiIDEwMDY0NAotLS0gYS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAy MDA5LTAzLTEyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NTA4CisgICAgICAgIAorICAgICAg ICBGaXggdXBkYXRpbmcgb2YgdGV4dCBmaWVsZCB3aXRoIHBsYWNlaG9sZGVyIHRleHQgd2hlbiB2 YWx1ZSBpcyBzZXQKKyAgICAgICAgYnkgZW5zdXJpbmcgdGhhdCB1cGRhdGVQbGFjZWhvbGRlclZp c2liaWxpdHkoKSBpcyBjYWxsZWQgYWZ0ZXIKKyAgICAgICAgdGhlIHZhbHVlIGhhcyBiZWVuIHVw ZGF0ZWQsIG5vdCBiZWZvcmUuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9wbGFjZWhvbGRl ci1zZXQtdmFsdWUuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlKToKKworMjAwOS0w My0xMiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBS ZXZpZXdlZCBieSBEYXZlIEh5YXR0CiAgICAgICAgIAogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ1NTIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9I VE1MSW5wdXRFbGVtZW50LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApp bmRleCAzOTUwOWEzLi5kZWIxZTEwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0 RWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC05 MzMsMTcgKzkzMywxNyBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlKGNvbnN0IFN0 cmluZyYgdmFsdWUpCiAgICAgaWYgKGlucHV0VHlwZSgpID09IEZJTEUgJiYgIXZhbHVlLmlzRW1w dHkoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKGlzVGV4dEZpZWxkKCkpCi0gICAgICAg IElucHV0RWxlbWVudDo6dXBkYXRlUGxhY2Vob2xkZXJWaXNpYmlsaXR5KG1fZGF0YSwgZG9jdW1l bnQoKSk7Ci0KICAgICBzZXRWYWx1ZU1hdGNoZXNSZW5kZXJlcihmYWxzZSk7CiAgICAgaWYgKHN0 b3Jlc1ZhbHVlU2VwYXJhdGVGcm9tQXR0cmlidXRlKCkpIHsKICAgICAgICAgaWYgKGlucHV0VHlw ZSgpID09IEZJTEUpCiAgICAgICAgICAgICBtX2ZpbGVMaXN0LT5jbGVhcigpOwogICAgICAgICBl bHNlIHsKICAgICAgICAgICAgIG1fZGF0YS5zZXRWYWx1ZShjb25zdHJhaW5WYWx1ZSh2YWx1ZSkp OwotICAgICAgICAgICAgaWYgKGlzVGV4dEZpZWxkKCkgJiYgaW5Eb2N1bWVudCgpKQotICAgICAg ICAgICAgICAgIGRvY3VtZW50KCktPnVwZGF0ZVJlbmRlcmluZygpOworICAgICAgICAgICAgaWYg KGlzVGV4dEZpZWxkKCkpIHsKKyAgICAgICAgICAgICAgICBJbnB1dEVsZW1lbnQ6OnVwZGF0ZVBs YWNlaG9sZGVyVmlzaWJpbGl0eShtX2RhdGEsIGRvY3VtZW50KCkpOworICAgICAgICAgICAgICAg IGlmIChpbkRvY3VtZW50KCkpCisgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50KCktPnVwZGF0 ZVJlbmRlcmluZygpOworICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgICAgIGlmIChyZW5k ZXJlcigpKQogICAgICAgICAgICAgcmVuZGVyZXIoKS0+dXBkYXRlRnJvbUVsZW1lbnQoKTsK