<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>244982</bug_id>
          
          <creation_ts>2022-09-09 08:23:51 -0700</creation_ts>
          <short_desc>css-pseudo: ::placeholder should not support &apos;writing-mode&apos;, &apos;direction&apos;, and &apos;text-orientation&apos;</short_desc>
          <delta_ts>2022-09-16 23:12:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BrowserCompat, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Ahmad Saleem">ahmad.saleem792</assigned_to>
          <cc>ap</cc>
    
    <cc>bfulgham</cc>
    
    <cc>karlcow</cc>
    
    <cc>koivisto</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1897248</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-09-09 08:23:51 -0700</bug_when>
    <thetext>It is to align Webkit with Web-Spec:

https://drafts.csswg.org/css-pseudo-4/#placeholder-pseudo
&gt; All properties that apply to the ::first-line pseudo-element also apply to the ::placeholder pseudo-element.

and
https://drafts.csswg.org/css-pseudo-4/#first-line-styling
&gt; User agents may apply other properties as well except for the following excluded properties:
&gt; * writing-mode
&gt; * direction
&gt; * text-orientation

Current Safari Technology Preview 153 behavior is not aligned with Blink / Chromium, Gecko / Firefox and Web-Spec.

Chrome Commit to Merge - https://chromium.googlesource.com/chromium/src.git/+/68c32d4e9fe24e25e672095253e0f0b2e709ecf4%5E%21/

Where to merge - https://github.com/WebKit/WebKit/blob/main/Source/WebCore/css/html.css#L762

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1897520</commentid>
    <comment_count>1</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-09-10 06:38:47 -0700</bug_when>
    <thetext>It seems that it does not fix WPT test but since it is to align with web-spec, I think it is still good to merge this change. So I pushed it without change request and let&apos;s see. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1897521</commentid>
    <comment_count>2</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-09-10 06:39:12 -0700</bug_when>
    <thetext>https://github.com/WebKit/WebKit/pull/4172</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898078</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-09-12 17:42:41 -0700</bug_when>
    <thetext>Committed 254416@main (b79ce718736d): &lt;https://commits.webkit.org/254416@main&gt;

Reviewed commits have been landed. Closing PR #4172 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898079</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-09-12 17:43:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/99846286&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1899115</commentid>
    <comment_count>5</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2022-09-16 16:12:00 -0700</bug_when>
    <thetext>Ahmad do you remember which WPT test is you were alluding to?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1899155</commentid>
    <comment_count>6</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-09-16 23:12:22 -0700</bug_when>
    <thetext>(In reply to Karl Dubost from comment #5)
&gt; Ahmad do you remember which WPT test is you were alluding to?

https://wpt.fyi/results/css/css-pseudo/placeholder-excluded-properties.html?label=master&amp;label=experimental&amp;aligned&amp;view=subtest&amp;q=placeholder-excluded-properties</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>