24487 2009-03-10 03:32:44 -0700 [Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled 2009-04-05 01:27:09 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo webkit-unassigned christian zecke oldest_to_newest 112970 0 jmalonzo 2009-03-10 03:32:44 -0700 Enable private browsing adding a 'enable-private-browsing' setting in WebKitWebSettings and enabling it in DRT. Doing this passes http/tests/security/cross-frame-access-private-browsing.html. 112973 1 28433 jmalonzo 2009-03-10 03:44:09 -0700 Created attachment 28433 Implement private browsing in DRT and add option in WebKit/Gtk 113140 2 28433 zecke 2009-03-11 02:03:56 -0700 Comment on attachment 28433 Implement private browsing in DRT and add option in WebKit/Gtk > + resetWebViewToConsistentStateBeforeTesting(); > + you might want to copy more there... e.g. the loading of about:blank (which we should kill at some point) ate after certain tests. > webkit_web_view_open(webView, "about:blank"); > > - gLayoutTestController->setJavaScriptProfilingEnabled(false); NO! The g_object_set in resetWebView... is no good replacement! setJSProfilingEnabled will disable both Developer Extras and JS profiling. Is there a reason you want to keep Developer Extras enabled? 113145 3 jmalonzo 2009-03-11 02:24:03 -0700 (In reply to comment #2) > (From update of attachment 28433 [review]) > > > + resetWebViewToConsistentStateBeforeTesting(); > > + > > you might want to copy more there... e.g. the loading of about:blank (which we > should kill at some point) I'll do that in a different patch. > > > ate after certain tests. > > webkit_web_view_open(webView, "about:blank"); > > > > - gLayoutTestController->setJavaScriptProfilingEnabled(false); > > NO! The g_object_set in resetWebView... is no good replacement! > setJSProfilingEnabled will disable both Developer Extras and JS profiling. Is > there a reason you want to keep Developer Extras enabled? Why not? Why is the resetWebView... not a good replacement? developer extras is also disabled in resetWebView... Thanks 113150 4 zecke 2009-03-11 03:25:45 -0700 (In reply to comment #3) > > Why not? Why is the resetWebView... not a good replacement? developer extras is > also disabled in resetWebView... right, didn't see it/looked for it in the g_object_set. Please describe this change in the ChangeLog and why it is semantically equivalent. 113172 5 jmalonzo 2009-03-11 05:28:02 -0700 Landed in r41583. Thanks a lot dude. 113823 6 christian 2009-03-15 08:19:20 -0700 (In reply to comment #5) > Landed in r41583. Thanks a lot dude. This new setting badly needs documentation, neither Xan, Gustavo or me could grasp what it does without digging inside WebCore. So I'm listing behaviour which may be affected, and we need to verify and unit test those points. - "Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript attempts when in private browsing mode (only an issue if Log JavaScript Exceptions is turned on)" - No page navigation ends up in history? - Does it affect cookie storage? - Cache is not used? - Form completion is discarded? The last two probably don't apply simply because we don't have these features. 113903 7 28433 gustavo 2009-03-16 12:06:37 -0700 Comment on attachment 28433 Implement private browsing in DRT and add option in WebKit/Gtk Clearing review flag so that it stops showing up in the pending commit queue. 114637 8 28820 jmalonzo 2009-03-21 03:03:14 -0700 Created attachment 28820 updated documentation 114638 9 jmalonzo 2009-03-21 03:07:16 -0700 I uploaded a new patch to fix these. I appreciate any feedback if any. I tagged that feature as experimental for WebKitGtk since some features like on-disk caching are, i think, not yet implemented for Gtk. (In reply to comment #6) > grasp what it does without digging inside WebCore. So I'm listing behaviour > which may be affected, and we need to verify and unit test those points. > > - "Follow up to <rdar://problem/5394877> Safari should not log unsafe > JavaScript attempts when in private browsing mode (only an issue if Log > JavaScript Exceptions is turned on)" > - No page navigation ends up in history? > - Does it affect cookie storage? > - Cache is not used? > - Form completion is discarded? > > The last two probably don't apply simply because we don't have these features. That's right. I think the only thing to test here is the cookie storage. Is there a way to test that? 115801 10 zecke 2009-03-30 06:12:35 -0700 Cookies are added by WebCore to the session, caching data to secondary storage is something that soup would do, so there might be a need to synchronize this flag with the soup session... 116405 11 28820 zecke 2009-04-02 23:42:44 -0700 Comment on attachment 28820 updated documentation > + * This is currently experimental for WebKitGtk. Okay, change that to WebKitGTK+ (as this seems to be our name now) :) 116569 12 jmalonzo 2009-04-05 01:27:09 -0700 Landed in r42231. Thanks! 28433 2009-03-10 03:44:09 -0700 2009-03-16 12:06:37 -0700 Implement private browsing in DRT and add option in WebKit/Gtk webkitgtk-privatebrowsing.patch text/plain 10826 jmalonzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzZGJiYTExLi44MjQ0YTNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDMt MTAgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3RrXSBJbXBsZW1lbnQgTGF5 b3V0VGVzdENvbnRyb2xsZXJHdGs6OnNldFByaXZhdGVCcm93c2luZ0VuYWJsZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NDg3CisKKyAgICAgICAg RW5hYmxlIGh0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNzLXByaXZhdGUtYnJv d3NpbmcuaHRtbCB0ZXN0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6CisKIDIw MDktMDMtMDkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCA2 M2UxOGMzLi4yY2M5MzczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tp cHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtMjI2NCw3ICsy MjY0LDYgQEAgaHR0cC90ZXN0cy91cmkvY3NzLWhyZWYucGhwCiAKICMgRklYTUU6IFNlY3VyaXR5 IHRlc3RzIHRoYXQgYXJlIGZhaWxpbmcKIGh0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUt YWNjZXNzLWdldC5odG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1w cml2YXRlLWJyb3dzaW5nLmh0bWwKIGh0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNj ZXNzLXB1dC5odG1sCiBodHRwL3Rlc3RzL3NlY3VyaXR5L2RhdGFUcmFuc2Zlci1zZXQtZGF0YS1m aWxlLXVybC5odG1sCiBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZlZWQtdXJscy1mcm9tLXJlbW90ZS5o dG1sCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdl TG9nCmluZGV4IGYzNDM2NGQuLjI0OWY5N2UgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMDMt MTAgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3RrXSBJbXBsZW1lbnQgTGF5 b3V0VGVzdENvbnRyb2xsZXJHdGs6OnNldFByaXZhdGVCcm93c2luZ0VuYWJsZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NDg3CisKKyAgICAgICAg QWRkIHByaXZhdGUgYnJvd3Npbmcgb3B0aW9uICJlbmFibGUtcHJpdmF0ZS1icm93c2luZyIgdG8g V2ViS2l0V2ViU2V0dGluZ3MuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vic2V0dGluZ3Mu Y3BwOgorICAgICAgICAoX1dlYktpdFdlYlNldHRpbmdzUHJpdmF0ZTo6KToKKyAgICAgICAgKF9X ZWJLaXRXZWJTZXR0aW5nc1ByaXZhdGU6OndlYmtpdF93ZWJfc2V0dGluZ3NfY2xhc3NfaW5pdCk6 CisgICAgICAgIChfV2ViS2l0V2ViU2V0dGluZ3NQcml2YXRlOjp3ZWJraXRfd2ViX3NldHRpbmdz X3NldF9wcm9wZXJ0eSk6CisgICAgICAgIChfV2ViS2l0V2ViU2V0dGluZ3NQcml2YXRlOjp3ZWJr aXRfd2ViX3NldHRpbmdzX2dldF9wcm9wZXJ0eSk6CisgICAgICAgIChfV2ViS2l0V2ViU2V0dGlu Z3NQcml2YXRlOjp3ZWJraXRfd2ViX3NldHRpbmdzX2NvcHkpOgorICAgICAgICAqIHdlYmtpdC93 ZWJraXR3ZWJ2aWV3LmNwcDoKKwogMjAwOS0wMy0wOCAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRo ZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2Uu CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAgYi9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAKaW5kZXggYWEzOGM2Yy4uZDMx ZWMyZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3Bw CisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcApAQCAtNzQsNiAr NzQsNyBAQCBzdHJ1Y3QgX1dlYktpdFdlYlNldHRpbmdzUHJpdmF0ZSB7CiAgICAgZ2NoYXIqIHVz ZXJfc3R5bGVzaGVldF91cmk7CiAgICAgZ2Zsb2F0IHpvb21fc3RlcDsKICAgICBnYm9vbGVhbiBl bmFibGVfZGV2ZWxvcGVyX2V4dHJhczsKKyAgICBnYm9vbGVhbiBlbmFibGVfcHJpdmF0ZV9icm93 c2luZzsKIH07CiAKICNkZWZpbmUgV0VCS0lUX1dFQl9TRVRUSU5HU19HRVRfUFJJVkFURShvYmop IChHX1RZUEVfSU5TVEFOQ0VfR0VUX1BSSVZBVEUoKG9iaiksIFdFQktJVF9UWVBFX1dFQl9TRVRU SU5HUywgV2ViS2l0V2ViU2V0dGluZ3NQcml2YXRlKSkKQEAgLTEwMSw3ICsxMDIsOCBAQCBlbnVt IHsKICAgICBQUk9QX1JFU0laQUJMRV9URVhUX0FSRUFTLAogICAgIFBST1BfVVNFUl9TVFlMRVNI RUVUX1VSSSwKICAgICBQUk9QX1pPT01fU1RFUCwKLSAgICBQUk9QX0VOQUJMRV9ERVZFTE9QRVJf RVhUUkFTCisgICAgUFJPUF9FTkFCTEVfREVWRUxPUEVSX0VYVFJBUywKKyAgICBQUk9QX0VOQUJM RV9QUklWQVRFX0JST1dTSU5HCiB9OwogCiBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdz X2ZpbmFsaXplKEdPYmplY3QqIG9iamVjdCk7CkBAIC0zMzUsNiArMzM3LDIyIEBAIHN0YXRpYyB2 b2lkIHdlYmtpdF93ZWJfc2V0dGluZ3NfY2xhc3NfaW5pdChXZWJLaXRXZWJTZXR0aW5nc0NsYXNz KiBrbGFzcykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZBTFNFLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxhZ3MpKTsKIAorICAgIC8qKgorICAg ICogV2ViS2l0V2ViU2V0dGluZ3M6ZW5hYmxlLXByaXZhdGUtYnJvd3Npbmc6CisgICAgKgorICAg ICogV2hldGhlciB0byBlbmFibGUgcHJpdmF0ZSBicm93c2luZyBtb2RlLgorICAgICoKKyAgICAq IFNpbmNlIDEuMS4yCisgICAgKi8KKyAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5 KGdvYmplY3RfY2xhc3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQUk9Q X0VOQUJMRV9QUklWQVRFX0JST1dTSU5HLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZ19wYXJhbV9zcGVjX2Jvb2xlYW4oCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiZW5hYmxlLXByaXZhdGUtYnJvd3NpbmciLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIkVuYWJsZSBQcml2YXRlIEJyb3dzaW5nIiwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJFbmFibGVzIHByaXZhdGUgYnJvd3NpbmcgbW9kZSIsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBGQUxTRSwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZsYWdzKSk7CisKICAgICBnX3R5cGVfY2xhc3NfYWRkX3By aXZhdGUoa2xhc3MsIHNpemVvZihXZWJLaXRXZWJTZXR0aW5nc1ByaXZhdGUpKTsKIH0KIApAQCAt NDM3LDYgKzQ1NSw5IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfc2V0dGluZ3Nfc2V0X3Byb3Bl cnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwgY29uCiAgICAgY2FzZSBQUk9QX0VO QUJMRV9ERVZFTE9QRVJfRVhUUkFTOgogICAgICAgICBwcml2LT5lbmFibGVfZGV2ZWxvcGVyX2V4 dHJhcyA9IGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpOwogICAgICAgICBicmVhazsKKyAgICBj YXNlIFBST1BfRU5BQkxFX1BSSVZBVEVfQlJPV1NJTkc6CisgICAgICAgIHByaXYtPmVuYWJsZV9w cml2YXRlX2Jyb3dzaW5nID0gZ192YWx1ZV9nZXRfYm9vbGVhbih2YWx1ZSk7CisgICAgICAgIGJy ZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIEdfT0JKRUNUX1dBUk5fSU5WQUxJRF9QUk9QRVJU WV9JRChvYmplY3QsIHByb3BfaWQsIHBzcGVjKTsKICAgICAgICAgYnJlYWs7CkBAIC01MTIsNiAr NTMzLDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zZXR0aW5nc19nZXRfcHJvcGVydHkoR09i amVjdCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBHVmEKICAgICBjYXNlIFBST1BfRU5BQkxFX0RF VkVMT1BFUl9FWFRSQVM6CiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xlYW4odmFsdWUsIHByaXYt PmVuYWJsZV9kZXZlbG9wZXJfZXh0cmFzKTsKICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBQUk9Q X0VOQUJMRV9QUklWQVRFX0JST1dTSU5HOgorICAgICAgICBnX3ZhbHVlX3NldF9ib29sZWFuKHZh bHVlLCBwcml2LT5lbmFibGVfcHJpdmF0ZV9icm93c2luZyk7CisgICAgICAgIGJyZWFrOwogICAg IGRlZmF1bHQ6CiAgICAgICAgIEdfT0JKRUNUX1dBUk5fSU5WQUxJRF9QUk9QRVJUWV9JRChvYmpl Y3QsIHByb3BfaWQsIHBzcGVjKTsKICAgICAgICAgYnJlYWs7CkBAIC01NjMsNiArNTg3LDcgQEAg V2ViS2l0V2ViU2V0dGluZ3MqIHdlYmtpdF93ZWJfc2V0dGluZ3NfY29weShXZWJLaXRXZWJTZXR0 aW5ncyogd2ViX3NldHRpbmdzKQogICAgICAgICAgICAgICAgICAidXNlci1zdHlsZXNoZWV0LXVy aSIsIHByaXYtPnVzZXJfc3R5bGVzaGVldF91cmksCiAgICAgICAgICAgICAgICAgICJ6b29tLXN0 ZXAiLCBwcml2LT56b29tX3N0ZXAsCiAgICAgICAgICAgICAgICAgICJlbmFibGUtZGV2ZWxvcGVy LWV4dHJhcyIsIHByaXYtPmVuYWJsZV9kZXZlbG9wZXJfZXh0cmFzLAorICAgICAgICAgICAgICAg ICAiZW5hYmxlLXByaXZhdGUtYnJvd3NpbmciLCBwcml2LT5lbmFibGVfcHJpdmF0ZV9icm93c2lu ZywKICAgICAgICAgICAgICAgICAgTlVMTCkpOwogCiAgICAgcmV0dXJuIGNvcHk7CmRpZmYgLS1n aXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Vi a2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IGNlYWRmYTkuLmQ4NzYzNWYgMTAwNjQ0Ci0tLSBh L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Vi a2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC0xNzA5LDcgKzE3MDksOSBAQCBzdGF0aWMgdm9pZCB3 ZWJraXRfd2ViX3ZpZXdfdXBkYXRlX3NldHRpbmdzKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiAg ICAgU2V0dGluZ3MqIHNldHRpbmdzID0gY29yZSh3ZWJWaWV3KS0+c2V0dGluZ3MoKTsKIAogICAg IGdjaGFyKiBkZWZhdWx0RW5jb2RpbmcsICpjdXJzaXZlRm9udEZhbWlseSwgKmRlZmF1bHRGb250 RmFtaWx5LCAqZmFudGFzeUZvbnRGYW1pbHksICptb25vc3BhY2VGb250RmFtaWx5LCAqc2Fuc1Nl cmlmRm9udEZhbWlseSwgKnNlcmlmRm9udEZhbWlseSwgKnVzZXJTdHlsZXNoZWV0VXJpOwotICAg IGdib29sZWFuIGF1dG9Mb2FkSW1hZ2VzLCBhdXRvU2hyaW5rSW1hZ2VzLCBwcmludEJhY2tncm91 bmRzLCBlbmFibGVTY3JpcHRzLCBlbmFibGVQbHVnaW5zLCBlbmFibGVEZXZlbG9wZXJFeHRyYXMs IHJlc2l6YWJsZVRleHRBcmVhczsKKyAgICBnYm9vbGVhbiBhdXRvTG9hZEltYWdlcywgYXV0b1No cmlua0ltYWdlcywgcHJpbnRCYWNrZ3JvdW5kcywKKyAgICAgICAgZW5hYmxlU2NyaXB0cywgZW5h YmxlUGx1Z2lucywgZW5hYmxlRGV2ZWxvcGVyRXh0cmFzLCByZXNpemFibGVUZXh0QXJlYXMsCisg ICAgICAgIGVuYWJsZVByaXZhdGVCcm93c2luZzsKIAogICAgIGdfb2JqZWN0X2dldCh3ZWJTZXR0 aW5ncywKICAgICAgICAgICAgICAgICAgImRlZmF1bHQtZW5jb2RpbmciLCAmZGVmYXVsdEVuY29k aW5nLApAQCAtMTcyNyw2ICsxNzI5LDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3Vw ZGF0ZV9zZXR0aW5ncyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogICAgICAgICAgICAgICAgICAi cmVzaXphYmxlLXRleHQtYXJlYXMiLCAmcmVzaXphYmxlVGV4dEFyZWFzLAogICAgICAgICAgICAg ICAgICAidXNlci1zdHlsZXNoZWV0LXVyaSIsICZ1c2VyU3R5bGVzaGVldFVyaSwKICAgICAgICAg ICAgICAgICAgImVuYWJsZS1kZXZlbG9wZXItZXh0cmFzIiwgJmVuYWJsZURldmVsb3BlckV4dHJh cywKKyAgICAgICAgICAgICAgICAgImVuYWJsZS1wcml2YXRlLWJyb3dzaW5nIiwgJmVuYWJsZVBy aXZhdGVCcm93c2luZywKICAgICAgICAgICAgICAgICAgTlVMTCk7CiAKICAgICBzZXR0aW5ncy0+ c2V0RGVmYXVsdFRleHRFbmNvZGluZ05hbWUoZGVmYXVsdEVuY29kaW5nKTsKQEAgLTE3NDQsNiAr MTc0Nyw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld191cGRhdGVfc2V0dGluZ3MoV2Vi S2l0V2ViVmlldyogd2ViVmlldykKICAgICBzZXR0aW5ncy0+c2V0VGV4dEFyZWFzQXJlUmVzaXph YmxlKHJlc2l6YWJsZVRleHRBcmVhcyk7CiAgICAgc2V0dGluZ3MtPnNldFVzZXJTdHlsZVNoZWV0 TG9jYXRpb24oS1VSTChLVVJMKCksIHVzZXJTdHlsZXNoZWV0VXJpKSk7CiAgICAgc2V0dGluZ3Mt PnNldERldmVsb3BlckV4dHJhc0VuYWJsZWQoZW5hYmxlRGV2ZWxvcGVyRXh0cmFzKTsKKyAgICBz ZXR0aW5ncy0+c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZChlbmFibGVQcml2YXRlQnJvd3Npbmcp OwogCiAgICAgZ19mcmVlKGRlZmF1bHRFbmNvZGluZyk7CiAgICAgZ19mcmVlKGN1cnNpdmVGb250 RmFtaWx5KTsKQEAgLTE4MTIsNiArMTgxNiw4IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmll d19zZXR0aW5nc19ub3RpZnkoV2ViS2l0V2ViU2V0dGluZ3MqIHdlYlNldHRpbmdzLCBHUGFyCiAg ICAgICAgIHNldHRpbmdzLT5zZXRVc2VyU3R5bGVTaGVldExvY2F0aW9uKEtVUkwoS1VSTCgpLCBn X3ZhbHVlX2dldF9zdHJpbmcoJnZhbHVlKSkpOwogICAgIGVsc2UgaWYgKG5hbWUgPT0gZ19pbnRl cm5fc3RyaW5nKCJlbmFibGUtZGV2ZWxvcGVyLWV4dHJhcyIpKQogICAgICAgICBzZXR0aW5ncy0+ c2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChnX3ZhbHVlX2dldF9ib29sZWFuKCZ2YWx1ZSkpOwor ICAgIGVsc2UgaWYgKG5hbWUgPT0gZ19pbnRlcm5fc3RyaW5nKCJlbmFibGUtcHJpdmF0ZS1icm93 c2luZyIpKQorICAgICAgICBzZXR0aW5ncy0+c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZChnX3Zh bHVlX2dldF9ib29sZWFuKCZ2YWx1ZSkpOwogICAgIGVsc2UgaWYgKCFnX29iamVjdF9jbGFzc19m aW5kX3Byb3BlcnR5KEdfT0JKRUNUX0dFVF9DTEFTUyh3ZWJTZXR0aW5ncyksIG5hbWUpKQogICAg ICAgICBnX3dhcm5pbmcoIlVuZXhwZWN0ZWQgc2V0dGluZyAnJXMnIiwgbmFtZSk7CiAgICAgZ192 YWx1ZV91bnNldCgmdmFsdWUpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDg2MTcxYTguLjQ4ZjI0ZTIgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAwOS0wMy0xMCAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBHdGtdIEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxlckd0azo6c2V0UHJpdmF0ZUJyb3dz aW5nRW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQ0ODcKKworICAgICAgICBJbXBsZW1lbnQgTGF5b3V0VGVzdENvbnRyb2xsZXJHdGs6OnNl dFByaXZhdGVCcm93c2luZ0VuYWJsZWQuIEFsc28KKyAgICAgICAgcmVzZXQgdGhlIG9wdGlvbnMg ZXZlcnl0aW1lIHdlIHJ1biB0aGUgdGVzdHMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9n dGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAocmVzZXRXZWJWaWV3VG9Db25zaXN0ZW50 U3RhdGVCZWZvcmVUZXN0aW5nKToKKyAgICAgICAgKHJ1blRlc3QpOgorICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHA6CisgICAgICAgIChMYXlv dXRUZXN0Q29udHJvbGxlcjo6c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCk6CisKIDIwMDktMDMt MDggIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8emVja2VAc2VsZmlzaC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggYWM4NjU3OS4uODA2OTUzOSAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNw cAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3Bw CkBAIC0yMjAsNiArMjIwLDE4IEBAIHN0YXRpYyB2b2lkIGludmFsaWRhdGVBbnlQcmV2aW91c1dh aXRUb0R1bXBXYXRjaGRvZygpCiAgICAgfQogfQogCitzdGF0aWMgdm9pZCByZXNldFdlYlZpZXdU b0NvbnNpc3RlbnRTdGF0ZUJlZm9yZVRlc3RpbmcoKQoreworICAgIFdlYktpdFdlYlNldHRpbmdz KiBzZXR0aW5ncyA9IHdlYmtpdF93ZWJfdmlld19nZXRfc2V0dGluZ3Mod2ViVmlldyk7CisgICAg Z19vYmplY3Rfc2V0KEdfT0JKRUNUKHNldHRpbmdzKSwKKyAgICAgICAgICAgICAgICAgImVuYWJs ZS1wcml2YXRlLWJyb3dzaW5nIiwgRkFMU0UsCisgICAgICAgICAgICAgICAgICJlbmFibGUtZGV2 ZWxvcGVyLWV4dHJhcyIsIEZBTFNFLAorICAgICAgICAgICAgICAgICBOVUxMKTsKKworICAgIFdl YktpdFdlYkluc3BlY3RvciogaW5zcGVjdG9yID0gd2Via2l0X3dlYl92aWV3X2dldF9pbnNwZWN0 b3Iod2ViVmlldyk7CisgICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKGluc3BlY3RvciksICJqYXZh c2NyaXB0LXByb2ZpbGluZy1lbmFibGVkIiwgRkFMU0UsIE5VTEwpOworfQorCiB2b2lkIGR1bXAo KQogewogICAgIGludmFsaWRhdGVBbnlQcmV2aW91c1dhaXRUb0R1bXBXYXRjaGRvZygpOwpAQCAt MzIxLDYgKzMzMyw4IEBAIHN0YXRpYyB2b2lkIHJ1blRlc3QoY29uc3Qgc3RyaW5nJiB0ZXN0UGF0 aE9yVVJMKQogICAgIGdjaGFyKiB1cmwgPSBhdXRvY29ycmVjdFVSTChwYXRoT3JVUkwuY19zdHIo KSk7CiAgICAgY29uc3Qgc3RyaW5nIHRlc3RVUkwodXJsKTsKIAorICAgIHJlc2V0V2ViVmlld1Rv Q29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGluZygpOworCiAgICAgZ0xheW91dFRlc3RDb250cm9s bGVyID0gbmV3IExheW91dFRlc3RDb250cm9sbGVyKHRlc3RVUkwsIGV4cGVjdGVkUGl4ZWxIYXNo KTsKICAgICB0b3BMb2FkaW5nRnJhbWUgPSAwOwogICAgIGRvbmUgPSBmYWxzZTsKQEAgLTM1OCw3 ICszNzIsNiBAQCBzdGF0aWMgdm9pZCBydW5UZXN0KGNvbnN0IHN0cmluZyYgdGVzdFBhdGhPclVS TCkKICAgICAvLyBBIGJsYW5rIGxvYWQgc2VlbXMgdG8gYmUgbmVjZXNzYXJ5IHRvIHJlc2V0IHN0 YXRlIGFmdGVyIGNlcnRhaW4gdGVzdHMuCiAgICAgd2Via2l0X3dlYl92aWV3X29wZW4od2ViVmll dywgImFib3V0OmJsYW5rIik7CiAKLSAgICBnTGF5b3V0VGVzdENvbnRyb2xsZXItPnNldEphdmFT Y3JpcHRQcm9maWxpbmdFbmFibGVkKGZhbHNlKTsKICAgICBnTGF5b3V0VGVzdENvbnRyb2xsZXIt PmRlcmVmKCk7CiAgICAgZ0xheW91dFRlc3RDb250cm9sbGVyID0gMDsKIH0KZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5j cHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJH dGsuY3BwCmluZGV4IDRkZjdlOTguLmNhM2JjMzYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAKKysrIGIvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNwcApAQCAt MjI1LDkgKzIyNSwxMyBAQCBpbnQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OndpbmRvd0NvdW50KCkK ICAgICByZXR1cm4gMTsKIH0KIAotdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0UHJpdmF0 ZUJyb3dzaW5nRW5hYmxlZChib29sIHByaXZhdGVCcm93c2luZ0VuYWJsZWQpCit2b2lkIExheW91 dFRlc3RDb250cm9sbGVyOjpzZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkKGJvb2wgZmxhZykKIHsK LSAgICAvLyBGSVhNRTogaW1wbGVtZW50CisgICAgV2ViS2l0V2ViVmlldyogdmlldyA9IHdlYmtp dF93ZWJfZnJhbWVfZ2V0X3dlYl92aWV3KG1haW5GcmFtZSk7CisgICAgQVNTRVJUKHZpZXcpOwor CisgICAgV2ViS2l0V2ViU2V0dGluZ3MqIHNldHRpbmdzID0gd2Via2l0X3dlYl92aWV3X2dldF9z ZXR0aW5ncyh2aWV3KTsKKyAgICBnX29iamVjdF9zZXQoR19PQkpFQ1Qoc2V0dGluZ3MpLCAiZW5h YmxlLXByaXZhdGUtYnJvd3NpbmciLCBmbGFnLCBOVUxMKTsKIH0KIAogdm9pZCBMYXlvdXRUZXN0 Q29udHJvbGxlcjo6c2V0QXV0aG9yQW5kVXNlclN0eWxlc0VuYWJsZWQoYm9vbCBmbGFnKQo= 28820 2009-03-21 03:03:14 -0700 2009-04-02 23:42:44 -0700 updated documentation privbrowsing-doc.patch text/plain 1419 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNzlhNzM0ZS4uZmQ4OGQ4MCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wMy0yMSAg SmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVkIGRvY3VtZW50YXRpb24g YW5kIHB1dCBtb3JlIGluZm9ybWF0aW9uIGFib3V0IHRoZQorICAgICAgICBwcml2YXRlLWJyb3dz aW5nIHNldHRpbmcgZm9yIFdlYktpdEd0ay4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJz ZXR0aW5ncy5jcHA6CisgICAgICAgIChfV2ViS2l0V2ViU2V0dGluZ3NQcml2YXRlOjp3ZWJraXRf d2ViX3NldHRpbmdzX2NsYXNzX2luaXQpOgorCiAyMDA5LTAzLTIwICBKYW4gTWljaGFlbCBBbG9u em8gIDxqbWFsb256b0BnbWFpbC5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLiBGaXggc3R5 bGUgaXNzdWVzIHdpdGggbXkgcHJldmlvdXMgY29tbWl0IChyNDE4NjYpIGFzCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAgYi9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAKaW5kZXggZDMxZWMyZi4uMzFlODdkMiAxMDA2NDQK LS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCisrKyBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcApAQCAtMzQwLDcgKzM0MCwxMiBAQCBz dGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX2NsYXNzX2luaXQoV2ViS2l0V2ViU2V0dGlu Z3NDbGFzcyoga2xhc3MpCiAgICAgLyoqCiAgICAgKiBXZWJLaXRXZWJTZXR0aW5nczplbmFibGUt cHJpdmF0ZS1icm93c2luZzoKICAgICAqCi0gICAgKiBXaGV0aGVyIHRvIGVuYWJsZSBwcml2YXRl IGJyb3dzaW5nIG1vZGUuCisgICAgKiBXaGV0aGVyIHRvIGVuYWJsZSBwcml2YXRlIGJyb3dzaW5n IG1vZGUuIFByaXZhdGUgYnJvd3NpbmcgbW9kZSBwcmV2ZW50cworICAgICogV2ViS2l0IGZyb20g dXBkYXRpbmcgdGhlIGdsb2JhbCBoaXN0b3J5IGFuZCBzdG9yaW5nIGFueSBzZXNzaW9uCisgICAg KiBpbmZvcm1hdGlvbiBlLmcuLCBvbi1kaXNrIGNhY2hlLCBhcyB3ZWxsIGFzIHN1cHByZXNzaW5n IGFueSBtZXNzYWdlcworICAgICogZnJvbSBiZWluZyBwcmludGVkIGludG8gdGhlIChqYXZhc2Ny aXB0KSBjb25zb2xlLgorICAgICoKKyAgICAqIFRoaXMgaXMgY3VycmVudGx5IGV4cGVyaW1lbnRh bCBmb3IgV2ViS2l0R3RrLgogICAgICoKICAgICAqIFNpbmNlIDEuMS4yCiAgICAgKi8K