244822 2022-09-05 19:34:41 -0700 merge Element::attributeChanged and Element::parseAttribute and avoid base class calls when an attribute is handled 2023-07-25 06:50:29 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 255258 InRadar P2 Normal --- 1 heycam heycam annevk webkit-bug-importer oldest_to_newest 1896409 0 heycam 2022-09-05 19:34:41 -0700 I can't see a good reason to have separate Element::attributeChanged and Element::parseAttribute member functions. The patch in this bug will do two things: 1. Merge parseAttribute into attributeChanged, to avoid one virtual function call. 2. Tweak the contents of attributeChanged functions to consistently avoid calling the base class attributeChanged if an attribute is handled in the derived class. As well as reducing the amount of work done when an attribute is changed, very slightly, this sets the stage for a subsequent patch to use an enum value to represent known attribute names instead of checking for QualifiedName equality. 1896411 1 heycam 2022-09-05 19:40:15 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4040 1898097 2 webkit-bug-importer 2022-09-12 19:35:17 -0700 <rdar://problem/99850653> 1968017 3 annevk 2023-07-25 06:50:29 -0700 *** This bug has been marked as a duplicate of bug 255258 ***