244796 2022-09-05 01:41:37 -0700 WebNotificationManager: fix build if SERVICE_WORKER=OFF 2022-09-05 07:24:16 -0700 1 1 1 Unclassified WebKit WebKit Process Model WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thomas.devoogdt webkit-unassigned webkit-bug-importer oldest_to_newest 1896285 0 thomas.devoogdt 2022-09-05 01:41:37 -0700 Similar to https://bugs.webkit.org/show_bug.cgi?id=231968, I was not able to compile Webkit with ENABLE_SERVICE_WORKER=OFF. SWContextManager is only compiled if ENABLE_SERVICE_WORKER=ON. 1896286 1 462138 thomas.devoogdt 2022-09-05 01:43:28 -0700 Created attachment 462138 SWContextManager is not compiled if SERVICE_WORKER=OFF. 1896339 2 ews-feeder 2022-09-05 07:23:14 -0700 Committed 254163@main (a91ffd1fa487): <https://commits.webkit.org/254163@main> Reviewed commits have been landed. Closing PR #4026 and removing active labels. 1896340 3 webkit-bug-importer 2022-09-05 07:24:16 -0700 <rdar://problem/99569417> 462138 2022-09-05 01:43:28 -0700 2022-09-05 01:43:28 -0700 SWContextManager is not compiled if SERVICE_WORKER=OFF. file_244796.txt text/plain 1927 thomas.devoogdt RnJvbSA4YjEzYTUwMGZiMGQyODBjOTkxMWJmY2FkMTVhODFlZWU4NTgwZTZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogVGhvbWFzIERldm9vZ2R0IDx0aG9tYXMuZGV2b29nZHRAYmFy Y28uY29tPg0KRGF0ZTogTW9uLCA1IFNlcCAyMDIyIDA5OjA0OjQ1ICswMjAwDQpTdWJqZWN0OiBb UEFUQ0hdIFdlYk5vdGlmaWNhdGlvbk1hbmFnZXI6IGZpeCBidWlsZCBpZiBTRVJWSUNFX1dPUktF Uj1PRkYNCk1JTUUtVmVyc2lvbjogMS4wDQpDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJz ZXQ9VVRGLTgNCkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQNCg0KUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuDQoNCi9ob21lL3Rob21hcy9Eb2N1bWVudHMvbmRfZmFsY29uL2J1aWxk cm9vdC9vdXRwdXQvYnVpbGQvd2Via2l0Z3RrLTIuMzcuMS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5hZ2VyLmNwcDoxMzk6MzM6IGVycm9y OiDigJhTV0NvbnRleHRNYW5hZ2Vy4oCZIGhhcyBub3QgYmVlbiBkZWNsYXJlZA0KICAgICBlbHNl IGlmIChhdXRvKiBjb25uZWN0aW9uID0gU1dDb250ZXh0TWFuYWdlcjo6c2luZ2xldG9uKCkuY29u bmVjdGlvbigpKSB7DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+ fn5+fn5+DQoNClNpZ25lZC1vZmYtYnk6IFRob21hcyBEZXZvb2dkdCA8dGhvbWFzLmRldm9vZ2R0 QGJhcmNvLmNvbT4NCi0tLQ0KIC4uLi9XZWJLaXQvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL1dl Yk5vdGlmaWNhdGlvbk1hbmFnZXIuY3BwICB8IDIgKysNCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspDQoNCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTm90aWZp Y2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9Ob3RpZmljYXRpb25zL1dlYk5vdGlmaWNhdGlvbk1hbmFnZXIuY3BwDQppbmRleCBiNTRj MDFhZmYyYTMuLjBjNDFhOTQ3NGQzNSAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9Ob3RpZmljYXRpb25zL1dlYk5vdGlmaWNhdGlvbk1hbmFnZXIuY3BwDQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5hZ2Vy LmNwcA0KQEAgLTEzNiwxMSArMTM2LDEzIEBAIHN0YXRpYyBib29sIHNlbmRNZXNzYWdlKE5vdGlm aWNhdGlvbiYgbm90aWZpY2F0aW9uLCBXZWJQYWdlKiBwYWdlLCBjb25zdCBGdW5jdGlvDQogICAg IHN0ZDo6b3B0aW9uYWw8V2ViQ29yZTo6UGFnZUlkZW50aWZpZXI+IHBhZ2VJZGVudGlmaWVyOw0K ICAgICBpZiAocGFnZSkNCiAgICAgICAgIHBhZ2VJZGVudGlmaWVyID0gcGFnZS0+aWRlbnRpZmll cigpOw0KKyNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpDQogICAgIGVsc2UgaWYgKGF1dG8qIGNv bm5lY3Rpb24gPSBTV0NvbnRleHRNYW5hZ2VyOjpzaW5nbGV0b24oKS5jb25uZWN0aW9uKCkpIHsN CiAgICAgICAgIC8vIFBhZ2VsZXNzIG5vdGlmaWNhdGlvbiBtZXNzYWdlcyBhcmUsIGJ5IGRlZmF1 bHQsIG9uIGJlaGFsZiBvZiBhIHNlcnZpY2Ugd29ya2VyLg0KICAgICAgICAgLy8gU28gdXNlIHRo ZSBzZXJ2aWNlIHdvcmtlciBjb25uZWN0aW9uJ3MgcGFnZSBpZGVudGlmaWVyLg0KICAgICAgICAg cGFnZUlkZW50aWZpZXIgPSBjb25uZWN0aW9uLT5wYWdlSWRlbnRpZmllcigpOw0KICAgICB9DQor I2VuZGlmDQogDQogICAgIEFTU0VSVChwYWdlSWRlbnRpZmllcik7DQogICAgIHJldHVybiBzZW5k TWVzc2FnZSgqV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24o KSwgcGFnZUlkZW50aWZpZXItPnRvVUludDY0KCkpOw0KLS0gDQoyLjM3LjINCg==