24477 2009-03-09 20:00:16 -0700 REGRESSION (r41467): Page Down key scrolls two pages 2009-03-20 02:17:01 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, Regression P1 Major --- 1 a4list darin adele alice.barraclough ap dharris+webkit jwalden+bwo nickptar rajiv tony zwarich oldest_to_newest 112939 0 a4list 2009-03-09 20:00:16 -0700 hitting "Page Down" keyboard button broken (scrolls more than one "page", i.e. more than one screen distance) problem observed in r41521, not sure if that is first appearance of problem, but this bug appeared very recently. 113001 1 ap 2009-03-10 09:02:40 -0700 Are you seeing this on all sites? I cannot reproduce the problem with r41550 (although I have a notebook, so it's Fn+Down, not PgDown for me). 113020 2 a4list 2009-03-10 10:57:30 -0700 Yes, every website. The "Page Down" key is located on keyboard among Home/End/Delete/Page Up/Page Down/Insert buttons. (btw, "Page Up" scrolls the wrong distance, also.) Problem continues in r41545. 113028 3 ap 2009-03-10 11:39:29 -0700 Weird, it suddenly started to happen to me. Maybe I was testing an old version previously. Logging editing commands, I see that doCommandBySelector:"scrollPageDown:" is invoked twice for each PageDown. 113109 4 rajiv 2009-03-10 20:38:08 -0700 i'm seeing this in WebKit r41545 with safari 4 public beta installed: Version 4 Public Beta (5528.16, r41545), on a mac with an "extended keyboard" with actual page up/page down keys. the problem is not just with page down but also with page up. 113354 5 ap 2009-03-12 02:41:59 -0700 <rdar://problem/6674184> 113552 6 rajiv 2009-03-12 23:02:15 -0700 this was broken in Changeset 41467 for trunk/WebKit/mac/WebView/WebHTMLView.mm in order to fix bug #24079. see http://trac.webkit.org/changeset/41467 building webkit r41660 with that change reversed fixes the problems described in this bug. 113557 7 28572 rajiv 2009-03-12 23:30:29 -0700 Created attachment 28572 patch to fix double page down/page up bug since the selector is passed to super, consider the event handled. code originally introduced in http://trac.webkit.org/changeset/39549 113558 8 28572 adele 2009-03-12 23:35:01 -0700 Comment on attachment 28572 patch to fix double page down/page up bug This will cause https://bugs.webkit.org/show_bug.cgi?id=23060 to show up again. To reproduce that bug, try running Mail.app with your patched WebKit. Focus a message in the preview pane, and you'll see that Home, End, Page Up, and Page Down don't work. 113597 9 adele 2009-03-13 09:07:26 -0700 Here's an experiment we should try. If we added the selectors for Page Up/Down and Home/End to the Editor command table in WebCore, would we still need eventHandled to be false here to get the Mail testcase to work? 114127 10 darin 2009-03-17 16:23:52 -0700 I値l take this one. 114140 11 darin 2009-03-17 17:06:41 -0700 http://trac.webkit.org/changeset/41793 114144 12 mrowe 2009-03-17 17:24:52 -0700 *** Bug 24660 has been marked as a duplicate of this bug. *** 114302 13 a4list 2009-03-19 05:11:19 -0700 This problem is not fixed. Some recent versions seemed OK. r41760 again scrolls too far. It seems to be not quite a full page extra, but it is scrolling the wrong distance. 114308 14 darin 2009-03-19 07:39:38 -0700 The difference in distance scrolled is probably due to the fact that we now use WebCore's scrolling code instead of WebFrameView's. The old bug was absolutely critical, the new bug simply makes the Mac version match the Windows version. While I want to fix the new bug, it's *not* the same thing, so reopening this bug report isn't quite right. 114310 15 dharris+webkit 2009-03-19 08:01:02 -0700 (In reply to comment #13) > This problem is not fixed. > > Some recent versions seemed OK. > > r41760 again scrolls too far. According to comment #12, this was committed in r41793 -- which is after r41760. There has been no new nightly build since r41760 (I don't know why). 114325 16 darin 2009-03-19 10:03:02 -0700 Please try again with a version newer than r41793. 114428 17 a4list 2009-03-19 18:57:44 -0700 seems to be OK in r41844. Thanks! 114469 18 zwarich 2009-03-20 02:17:01 -0700 *** Bug 24698 has been marked as a duplicate of this bug. *** 28572 2009-03-12 23:30:29 -0700 2009-03-12 23:35:01 -0700 patch to fix double page down/page up bug WebKitBug24477.patch text/plain 1554 rajiv SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA0MTY2MikKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDMtMTIgIFJhaml2IEFhcm9uIE1hbmdsYW5p ICA8cmFqaXZAYWx1bS5taXQuZWR1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorICAgICAgICAKKyAgICAgICAgRml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjQ0NzcKKyAgICAgICAgUkVHUkVTU0lPTjogSGl0dGluZyAiUGFnZSBE b3duIiBrZXlib2FyZCBidXR0b24gYnJva2VuIChzY3JvbGxzIG1vcmUgdGhhbiBvbmUgInBhZ2Ui LCBpLmUuIG1vcmUgdGhhbiBvbmUgc2NyZWVuIGRpc3RhbmNlKQorICAgICAgICA8cmRhcjovL3By b2JsZW0vNjY3NDE4ND4KKworICAgICAgICAqIFdlYlZpZXcvV2ViSFRNTFZpZXcubW06CisgICAg ICAgICgtW1dlYkhUTUxWaWV3IGRvQ29tbWFuZEJ5U2VsZWN0b3I6XSk6CisKIDIwMDktMDMtMTIg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBNaWtlIFRob2xlIGFuZCBNYXJrIFJvd2UuCkluZGV4OiBXZWJLaXQvbWFjL1dlYlZpZXcv V2ViSFRNTFZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxW aWV3Lm1tCShyZXZpc2lvbiA0MTY2MCkKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmll dy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTM5NCwxMCArNTM5NCw2IEBAIHN0YXRpYyB2b2lkIGV4 dHJhY3RVbmRlcmxpbmVzKE5TQXR0cmlidXQKICAgICAgICAgICAgICAgICAvLyBJZiBXZWJLaXQg ZG9lcyBub3Qgc3VwcG9ydCB0aGlzIGNvbW1hbmQsIHdlIG5lZWQgdG8gcGFzcyB0aGUgc2VsZWN0 b3IgdG8gc3VwZXIuCiAgICAgICAgICAgICAgICAgW3N1cGVyIGRvQ29tbWFuZEJ5U2VsZWN0b3I6 c2VsZWN0b3JdOwogICAgICAgICAgICAgICAgIF9wcml2YXRlLT5zZWxlY3RvckZvckRvQ29tbWFu ZEJ5U2VsZWN0b3IgPSAwOwotICAgICAgICAgICAgICAgIC8vIEluIHRoZW9yeSwgW3N1cGVyIGRv Q29tbWFuZEJ5U2VsZWN0b3I6XSBjYW4gZG8gc29tZSBhY3Rpb24gdGhhdCB3b3VsZCBjYXVzZSBX ZWJLaXQgCi0gICAgICAgICAgICAgICAgLy8gdG8gbmVlZCB0byBjb25zaWRlciB0aGUgZXZlbnQg aGFuZGxlZC4gIEJ1dCBpbiBwcmFjdGljZSwgSSd2ZSBmb3VuZCBubwotICAgICAgICAgICAgICAg IC8vIGV4YW1wbGUgb2YgdGhhdCBoYXBwZW5pbmcgYW5kIGNhdXNpbmcgYnJva2VuIGJlaGF2aW9y LgotICAgICAgICAgICAgICAgIGV2ZW50V2FzSGFuZGxlZCA9IGZhbHNlOwogICAgICAgICAgICAg fQogICAgICAgICB9CiAK