24474 2009-03-09 17:32:59 -0700 AX: in multi-body tables, asking for a cell at a specific coordinate can return nil 2009-03-13 15:21:19 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach webkit-unassigned oldest_to_newest 112923 0 cfleizach 2009-03-09 17:32:59 -0700 In a table with more than one tbody, asking for certain cells can return nil instead of the cell 112925 1 cfleizach 2009-03-09 17:37:43 -0700 the problem is that the row being passed in is being compared against the wrong value 112926 2 28422 cfleizach 2009-03-09 17:39:31 -0700 Created attachment 28422 patch to fix logic error in retrieving cells in an AXTable 113712 3 cfleizach 2009-03-13 15:21:19 -0700 http://trac.webkit.org/changeset/41687 28422 2009-03-09 17:39:31 -0700 2009-03-13 14:23:14 -0700 patch to fix logic error in retrieving cells in an AXTable patch.txt text/plain 6171 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTU0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDMtMDkgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWcgMjQ0NzQ6IEFYOiBpbiBtdWx0aS1ib2R5IHRhYmxlcywgYXNraW5nIGZvciBhIGNlbGwg YXQgYSBzcGVjaWZpYyBjb29yZGluYXRlIGNhbiByZXR1cm4gbmlsCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDQ3NAorCisgICAgICAgIFRlc3Q6IHBs YXRmb3JtL21hYy1zbm93bGVvcGFyZC9hY2Nlc3NpYmlsaXR5L3RhYmxlLW11bHRpLWJvZGllcy5o dG1sCisKKyAgICAgICAgKiBwYWdlL0FjY2Vzc2liaWxpdHlUYWJsZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpBY2Nlc3NpYmlsaXR5VGFibGU6OmNlbGxGb3JDb2x1bW5BbmRSb3cpOgorCiAyMDA5 LTAzLTA5ICBLaW0gQ2hyaXN0ZW5zZW4gIDxraW13b3JraW5nQGdtYWlsLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJDb3JlL3BhZ2UvQWNjZXNzaWJp bGl0eVRhYmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQWNjZXNzaWJpbGl0eVRh YmxlLmNwcAkocmV2aXNpb24gNDE1MzEpCisrKyBXZWJDb3JlL3BhZ2UvQWNjZXNzaWJpbGl0eVRh YmxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzg2LDExICszODYsMTMgQEAgQWNjZXNzaWJpbGl0 eVRhYmxlQ2VsbCogQWNjZXNzaWJpbGl0eVRhYgogICAgIHVuc2lnbmVkIHJvd09mZnNldCA9IDA7 CiAgICAgd2hpbGUgKHRhYmxlU2VjdGlvbikgewogICAgICAgICAKLSAgICAgICAgcm93Q291bnQg Kz0gdGFibGVTZWN0aW9uLT5udW1Sb3dzKCk7CisgICAgICAgIHVuc2lnbmVkIG51bVJvd3MgPSB0 YWJsZVNlY3Rpb24tPm51bVJvd3MoKTsKICAgICAgICAgdW5zaWduZWQgbnVtQ29scyA9IHRhYmxl U2VjdGlvbi0+bnVtQ29sdW1ucygpOwogICAgICAgICAKLSAgICAgICAgaWYgKHJvdyA8IHJvd0Nv dW50ICYmIGNvbHVtbiA8IG51bUNvbHMpIHsKLSAgICAgICAgICAgIGludCBzZWN0aW9uU3BlY2lm aWNSb3cgPSByb3cgLSByb3dPZmZzZXQ7CisgICAgICAgIHJvd0NvdW50ICs9IG51bVJvd3M7Cisg ICAgICAgIAorICAgICAgICB1bnNpZ25lZCBzZWN0aW9uU3BlY2lmaWNSb3cgPSByb3cgLSByb3dP ZmZzZXQ7ICAgICAgICAgICAgCisgICAgICAgIGlmIChyb3cgPCByb3dDb3VudCAmJiBjb2x1bW4g PCBudW1Db2xzICYmIHNlY3Rpb25TcGVjaWZpY1JvdyA8IG51bVJvd3MpIHsKICAgICAgICAgICAg IGNlbGwgPSB0YWJsZVNlY3Rpb24tPmNlbGxBdChzZWN0aW9uU3BlY2lmaWNSb3csIGNvbHVtbiku Y2VsbDsKICAgICAgICAgICAgIAogICAgICAgICAgICAgLy8gd2UgZGlkbid0IGZpbmQgdGhlIGNl bGwsIHdoaWNoIG1lYW5zIHRoZXJlJ3Mgc3Bhbm5pbmcgaGFwcGVuaW5nCkBAIC00MjIsOSArNDI0 LDkgQEAgQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbCogQWNjZXNzaWJpbGl0eVRhYgogICAgICAgICBp ZiAoY2VsbCkKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAKLSAgICAgICAgcm93T2Zmc2V0 ICs9IHJvd0NvdW50OworICAgICAgICByb3dPZmZzZXQgKz0gbnVtUm93czsKICAgICAgICAgLy8g d2UgZGlkbid0IGZpbmQgYW55dGhpbmcgYmV0d2VlbiB0aGUgcm93cyB3ZSBzaG91bGQgaGF2ZQot ICAgICAgICBpZiAocm93IDwgcm93T2Zmc2V0KQorICAgICAgICBpZiAocm93IDwgcm93Q291bnQp CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgdGFibGVTZWN0aW9uID0gdGFibGUtPnNlY3Rp b25CZWxvdyh0YWJsZVNlY3Rpb24sIHRydWUpOyAgICAgICAgCiAgICAgfQpJbmRleDogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2 aXNpb24gNDE1NDIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxMyBAQAorMjAwOS0wMy0wOSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBw bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEJ1ZyAyNDQ3NDogQVg6IGluIG11bHRpLWJvZHkgdGFibGVzLCBhc2tpbmcgZm9yIGEgY2VsbCBh dCBhIHNwZWNpZmljIGNvb3JkaW5hdGUgY2FuIHJldHVybiBuaWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NDc0CisKKyAgICAgICAgKiBwbGF0Zm9y bS9tYWMtc25vd2xlb3BhcmQvYWNjZXNzaWJpbGl0eS90YWJsZS1tdWx0aS1ib2RpZXMtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQvYWNjZXNz aWJpbGl0eS90YWJsZS1tdWx0aS1ib2RpZXMuaHRtbDogQWRkZWQuCisKIDIwMDktMDMtMDkgIFNh bSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSb2xsIG91dCByNDEzOTMuICBJ dCBoYXMgYmVlbiBjYXVzaW5nIGZhaWx1cmVzIG9uIHRoZSBib3RzIGZvciBhYm91dCBhIHdlZWsu CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQvYWNjZXNzaWJpbGl0 eS90YWJsZS1tdWx0aS1ib2RpZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL3BsYXRmb3JtL21hYy1zbm93bGVvcGFyZC9hY2Nlc3NpYmlsaXR5L3RhYmxlLW11bHRpLWJv ZGllcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMtc25vd2xlb3BhcmQvYWNjZXNzaWJpbGl0eS90YWJsZS1tdWx0aS1ib2RpZXMtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDkgQEAKK8KgCUZvcnVtCUxhc3QgUG9zdAlUaHJl YWRzCVBvc3RzCitFbmdsaXNoIEZvcnVtcworwqAJTWFpbiBEaXNjdXNzaW9uCisJIFdhbnQgdG8g Y29tbXVuaWNhdGUgd2l0aCBvdGhlciBsb2NhbCBmYW5zPyBEbyBpdCBoZXJlLCB0b28hCSBUb2Rh eSAwMzo1MnBtCTM4MQkyMyw0MzcKKworCisKKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorUGFz cwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL2FjY2Vzc2liaWxp dHkvdGFibGUtbXVsdGktYm9kaWVzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLXNub3dsZW9wYXJkL2FjY2Vzc2liaWxpdHkvdGFibGUtbXVsdGktYm9kaWVzLmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQv YWNjZXNzaWJpbGl0eS90YWJsZS1tdWx0aS1ib2RpZXMuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw4NCBAQAorPGh0bWw+CisKKzxoZWFkPgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNU ZXh0KCk7Cis8L3NjcmlwdD4KKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKworZnVu Y3Rpb24gcmVtb3ZlVGFibGUoKQoreworICAgIHZhciB0YWJsZSA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCd0YWJsZTEnKTsKKyAgICB2YXIgY29udGFpbmVyID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3RhYmxlY29udGFpbmVyJyk7CisgCisgICAgY29udGFpbmVyLnJlbW92ZUNoaWxkKHRh YmxlKTsgIAorfQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgaWQ9ImJvZHkiPgorCis8 dGFibGUgY2xhc3M9InRib3JkZXIiIGNlbGxwYWRkaW5nPSI2IiBjZWxsc3BhY2luZz0iMSIgYm9y ZGVyPSIwIiB3aWR0aD0iMTAwJSIgYWxpZ249ImNlbnRlciI+Cis8dGhlYWQ+CisJPHRyIGFsaWdu PSJjZW50ZXIiPgorCSAgPHRkIGNsYXNzPSJ0aGVhZCI+Jm5ic3A7PC90ZD4KKwkgIDx0ZCBjbGFz cz0idGhlYWQiIHdpZHRoPSIxMDAlIiBhbGlnbj0ibGVmdCI+Rm9ydW08L3RkPgorCSAgPHRkIGNs YXNzPSJ0aGVhZCI+TGFzdCBQb3N0PC90ZD4KKwkgIDx0ZCBjbGFzcz0idGhlYWQiPlRocmVhZHM8 L3RkPgorCSAgPHRkIGNsYXNzPSJ0aGVhZCI+UG9zdHM8L3RkPgorCTwvdHI+Cis8L3RoZWFkPgor PHRib2R5PgorICAgPHRyPgorICAgIDx0ZCBjbGFzcz0idGNhdCIgY29sc3Bhbj0iNSI+PGEgc3R5 bGU9ImZsb2F0OnJpZ2h0IiBocmVmPSIjdG9wIiBvbmNsaWNrPSJyZXR1cm4gdG9nZ2xlX2NvbGxh cHNlKCdmb3J1bWJpdF83MScpIj48aW1nIGlkPSJjb2xsYXBzZWltZ19mb3J1bWJpdF83MSIgc3Jj PSJpbWFnZXMvYnV0dG9ucy9jb2xsYXBzZV90Y2F0LmdpZiIgYWx0PSIiIGJvcmRlcj0iMCIgLz48 L2E+CisgICAgIDxhIGhyZWY9ImZvcnVtZGlzcGxheS5waHA/Zj03MSI+RW5nbGlzaCBGb3J1bXM8 L2E+CisgICAgPC90ZD4KKyAgIDwvdHI+Cis8L3Rib2R5PgorPHRib2R5IGlkPSJjb2xsYXBzZW9i al9mb3J1bWJpdF83MSIgc3R5bGU9IiI+Cis8dHI+CisgIDx0ZCBjbGFzcz0idGNhdCI+PHNwYW4g Y2xhc3M9InNtYWxsZm9udCI+Jm5ic3A7PC9zcGFuPjwvdGQ+CisgIDx0ZCBjbGFzcz0idGNhdCIg Y29sc3Bhbj0iNCI+CisgICAgPGEgaHJlZj0iZm9ydW1kaXNwbGF5LnBocD9mPTMwIj5NYWluIERp c2N1c3Npb248L2E+CisgIDwvdGQ+Cis8L3RyPgorPHRyIGFsaWduPSJjZW50ZXIiPgorICA8dGQg Y2xhc3M9ImFsdDIiPjxpbWcgc3JjPSJpbWFnZXMvc3RhdHVzaWNvbi9mb3J1bV9uZXcuZ2lmIiBh bHQ9IiIgYm9yZGVyPSIwIiBpZD0iZm9ydW1fc3RhdHVzaWNvbl8yMyIgLz48L3RkPgorICA8dGQg Y2xhc3M9ImFsdDFBY3RpdmUiIGFsaWduPSJsZWZ0IiBpZD0iZjIzIj4KKyAgIFdhbnQgdG8gY29t bXVuaWNhdGUgd2l0aCBvdGhlciBsb2NhbCBmYW5zPyBEbyBpdCBoZXJlLCB0b28hCisgIDwvdGQ+ Cis8dGQgY2xhc3M9ImFsdDIiIG5vd3JhcD0ibm93cmFwIj4KK1RvZGF5IDxzcGFuIGNsYXNzPSJ0 aW1lIj4wMzo1MnBtPC9zcGFuPgorPC90ZD4KKzx0ZCBjbGFzcz0iYWx0MSI+MzgxPC90ZD4KKzx0 ZCBjbGFzcz0iYWx0MiI+MjMsNDM3PC90ZD4JCis8L3RyPgorPC90YWJsZT4KKzxCUj48QlI+PEJS PgorPGRpdiBpZD0icmVzdWx0Ij4KKzwvZGl2PgorCis8c2NyaXB0PgorICAgICAgICBpZiAod2lu ZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisKKyAgICAgICAgICAgIHZhciBib2R5ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJvZHkiKTsKKyAgICAgICAgICAgIGJvZHkuZm9jdXMo KTsKKyAgICAgICAgICAgIHZhciB0YWJsZSA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3Vz ZWRFbGVtZW50LmNoaWxkQXRJbmRleCgwKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgcmVz dWx0LmlubmVyVGV4dCArPSAiLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tXG4iOworICAgICAgICAg ICAgdmFyIGF4Q2VsbEtleSA9ICJBWENlbGwiOworICAgICAgICAgCisgICAgICAgICAgICB2YXIg dGFibGVDZWxsMSA9IHRhYmxlLmNlbGxGb3JDb2x1bW5BbmRSb3coMiwwKTsKKyAgICAgICAgICAg IGlmICh0YWJsZUNlbGwxLmFsbEF0dHJpYnV0ZXMoKS5pbmRleE9mKGF4Q2VsbEtleSkgIT0gLTEp IHsKKyAgICAgICAgICAgICAgICByZXN1bHQuaW5uZXJUZXh0ICs9ICJQYXNzIjsKKyAgICAgICAg ICAgIH0gCisgICAgICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgICAgICByZXN1bHQuaW5uZXJU ZXh0ICs9ICJGYWlsIjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorPC9zY3JpcHQ+CisKKzwv Ym9keT4KKzwvaHRtbD4K